From patchwork Sat Nov 2 20:16:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Qiang Liu X-Patchwork-Id: 13870183 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61AC9D12D5C for ; Mon, 11 Nov 2024 02:19:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D55856B0089; Sun, 10 Nov 2024 21:19:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D054F6B008A; Sun, 10 Nov 2024 21:19:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF4636B008C; Sun, 10 Nov 2024 21:19:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A0E086B0089 for ; Sun, 10 Nov 2024 21:19:45 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 27A2DC1738 for ; Mon, 11 Nov 2024 02:19:45 +0000 (UTC) X-FDA: 82772206272.13.D1CF250 Received: from chinatelecom.cn (smtpnm6-07.21cn.com [182.42.151.156]) by imf29.hostedemail.com (Postfix) with ESMTP id 4BEC012000F for ; Mon, 11 Nov 2024 02:18:46 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of liuq131@chinatelecom.cn designates 182.42.151.156 as permitted sender) smtp.mailfrom=liuq131@chinatelecom.cn; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731291411; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=43fB6o7xFeb5XxS+QsqYwxGlYhg44sHnBfGO7NjZ8rg=; b=WYWfIbYTBGLVk3vY4nTrr9urVfg/DjyLDxDUJrwTPNFL6j2seWTofPje5768entqRpwe3k VC1a4nVE7NDFkUJSvZBJLyuWLiA2JRICbBh5uH0VxFwfp9pjjKg/p6Byx3G4EvZGAb5ANw OLat8p2lAjOXZHRbGItwPfSyk06Em7U= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of liuq131@chinatelecom.cn designates 182.42.151.156 as permitted sender) smtp.mailfrom=liuq131@chinatelecom.cn; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731291411; a=rsa-sha256; cv=none; b=cDcg793lZSRwprKj/haFNU70+LjPS5oWiWmtm2jzSvl6Ysp9jDZsM4sycHsgAnS/5y81Ln xS0QDkEN8kGVPeR6/P6dGv8kl8Fm9EiNReSauX8rQI3AmT5Y+DztmkWIpFbx3Or7JWAxJn Lpl/qFyqlrcjX8EjlnrxJPHvPCjmJkM= HMM_SOURCE_IP: 192.168.139.44:0.888087250 HMM_ATTACHE_NUM: 0000 HMM_SOURCE_TYPE: SMTP Received: from clientip-36.111.64.85 (unknown [192.168.139.44]) by chinatelecom.cn (HERMES) with SMTP id 124659F5D4; Mon, 11 Nov 2024 10:19:33 +0800 (CST) X-189-SAVE-TO-SEND: +liuq131@chinatelecom.cn Received: from ([36.111.64.85]) by gateway-ssl-dep-6977f57994-mvlbg with ESMTP id 2ea6ac7329234ca1b6bed43548054357 for akpm@linux-foundation.org; Mon, 11 Nov 2024 10:19:37 CST X-Transaction-ID: 2ea6ac7329234ca1b6bed43548054357 X-Real-From: liuq131@chinatelecom.cn X-Receive-IP: 36.111.64.85 X-MEDUSA-Status: 0 From: Qiang Liu To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Qiang Liu Subject: [PATCH] mm/compaction: fix the total_isolated in strict mode Date: Sat, 2 Nov 2024 20:16:21 +0000 Message-Id: <20241102201621.95291-1-liuq131@chinatelecom.cn> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 4BEC012000F X-Stat-Signature: h39wgsfqmo994ixydfsr6omddy1u6gkx X-Rspam-User: X-HE-Tag: 1731291526-531424 X-HE-Meta: U2FsdGVkX18FrVL0UUmBYDcgcVSJu44rStWMAToDk6HuHAv16tWlpyKbboZZZIfjWJ7HtEwUtr+hNrBIJd4l7/o/0wybftHMAThA5VHyZNtcQ1hBgzCvFF7FqY5KSV3G0fJlOWVOUbXCrlWrlj3Rjp3U+mL4eS1B0BVyaLRbrSQ4SBuW/VXV1lL7mr4o0YuGUFI6yOxAA4QKAONwgpcazwu/FZEl+OrLAWkFQIDpQMp5JI3+ms4IWpxwB5EU1gYCESyAA0U8+CWm3houB7KfFwBsgM5Vm1Eqk4FJfMF07pwoZ57SMikEcTfMfzKrB+YaQ61nf8fxR4inj7X/i0bmNbqBrfR++MouBbFmjWDvg3lYoM/yK15M0PjQHJPhK4ZiaiKRhvhBbgUlG8sH9uIbfpLnCYlAL+mQRXXBqWvlwUBn5TD4H27AQAHMUeWTOwdhqFhTVKCaBKbkPHm0r58WocPaMT6//CvNAz5zyOnN9tgY6UQBC7IgTONzx5sLtZT9ZPix72oUT7jhvUn27Car6aWxAPwHtHaS2s39kah5M6BlZnXfWCPFFjt9OFsdgjjWvcsPUqQZPi0zoUzJg0K+norLjTdwC8BtV+fDWryWfCzLfF7ElsVUXoxf4AQmhtMhWqrHG79tDQVsnMigCxGzJ9aQqpIgx/bVGg+kc2UU10bzSazhwEtL4eHwoEXWz4X6GE8KtoXG9ylVBtLJGB+1XUFrmKdsC2ViGHlcdAdK9LzBiqgp39fhOicJQ+pl3X3AdBVb0BNgndaYsNsB6XWNzPNEp/wxRKAARrDsctlqXLNGDPzg3VnwokvYCyp9r4UAMuBSRNyNWnDjcxxCH2g2T3Fh+CmDkbhs5lXPMBroGHGJrHVaEXxNewfasBfbyjArAav5TSw1UMm4IXxWUjAYMxyvWmkehUbvmwEEuYvmL5lbMn6FCNpY2FV0e9HMm0G7/th/3xz7gF6YNSTNvlw D6I5ru+r mxAUWnDdfd7mPQZVFN7DsXYdnzqUH5TL4S58q/Zjvsj1LyC+IKVWraIACXQ5Bz0Xagep32IrHOjooMspM3laQhAPBzEcrFrO8N9pV6SX6VR9v2+JIT8AzvR3WeI8naifLOm5su8P5wZcTUJv3Fh6p6j9Tj89haZAS9mUZx/1pWjmUV9gW+IeFhjW4i6OGMCmuSq7/gJblfVvnwLnmEUKfVmv7+Ghyzi3RBFhuqnCkz/ZUOlRMEbKWCfNM8w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.445476, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: If the last cycle reads bogus compound_order() and blockpfn > end_pfn occurs, it is possible that total_isolated will be less than nr_scanned. In this case, strict mode should return 0, but the “if (strict && blockpfn < end_pfn)” statement cannot recognize this situation Signed-off-by: Qiang Liu --- mm/compaction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/compaction.c b/mm/compaction.c index a2b16b08cbbf..6009f5d1021a 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -699,7 +699,7 @@ static unsigned long isolate_freepages_block(struct compact_control *cc, * pages requested were isolated. If there were any failures, 0 is * returned and CMA will fail. */ - if (strict && blockpfn < end_pfn) + if (strict && (blockpfn < end_pfn || total_isolated != nr_scanned)) total_isolated = 0; cc->total_free_scanned += nr_scanned;