From patchwork Sun Nov 3 03:20:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kanchana P Sridhar X-Patchwork-Id: 13860286 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62E1CE67819 for ; Sun, 3 Nov 2024 03:21:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9FFFC6B007B; Sat, 2 Nov 2024 23:21:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D5BF6B0085; Sat, 2 Nov 2024 23:21:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 89EAC6B0088; Sat, 2 Nov 2024 23:21:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 587806B007B for ; Sat, 2 Nov 2024 23:21:18 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E9BBC1A09AD for ; Sun, 3 Nov 2024 03:21:17 +0000 (UTC) X-FDA: 82743332070.10.D17BC08 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by imf18.hostedemail.com (Postfix) with ESMTP id 721431C0002 for ; Sun, 3 Nov 2024 03:21:02 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=W2DdAxRZ; spf=pass (imf18.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 192.198.163.14 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730604029; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eAOM1k5eBgatCXxcKi5hWs7e/Nc/Gb2n04WWWLD5dIE=; b=QfEvu0OuKqI0fc2f2jgyFmIHULCGOFJnQexHlhHArm96wf1pbXV6OCXvUs1WQhdFJ85a3O xVHJiRSbdyZMXCLWJw/hFptqdZHlDfhIWIVb2+Qh4UeMz6/odASJ+TriFbmiJ82JOrMhcx 7Tjpm4LtSPoqGIXrPw7xpg81Wip60+U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730604029; a=rsa-sha256; cv=none; b=jKR6b0318a17itEGDq6jF0JAD1DinJuCJ0XJtc7orLVdEfwpN1VDq8JMMDHrnx9ci1IPVd GKOxx6d0Jl99o6GiGPTE5GKP3Iyb2bbfkFZZomXl8eRTPOSjsXsMlV4V8YQ86a5DrXor8R /7HQWEZ7WpMFCwjzv3My/PsZ7c0crjE= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=W2DdAxRZ; spf=pass (imf18.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 192.198.163.14 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1730604075; x=1762140075; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=8jyV13JKHn0vIl+wBpuhM8EZ+NN4RHEftxJMCaIna00=; b=W2DdAxRZWCYB2LtrLAqHou9u3uhJgSVSzesKcDWLgUPG9kwpATda2ZJH YAgSlmvPNoMdi/IUVJU7Sd8JEFTlqivqVAOf90nnQRnvDkb2RDYErcOxV jpKNL3HpFqwxXJD39yuI2tAy9snNmUbkErvfCvu9l7fW/TrWZiQPid0Oj Fe8+zY9J+hVOu6mhOkuMQ/Eo4qXqaU+92iqrwFVJDT3RW/RXLnQ3pVGoX j0O0Ir7DogCISBNCrErK9X/xCrcfAlMJP9zEk82hV8yB2dpc3oCNX6Y7G fiEfWri7RqCakxGq2+nxsuUr2Ehx08OanV2ef+S8gfShlnbfITnQhzW6X Q==; X-CSE-ConnectionGUID: V5DP5g7mRK2Y5L3exyL9zg== X-CSE-MsgGUID: O4rKYjBWSsGOLmdsdZusPg== X-IronPort-AV: E=McAfee;i="6700,10204,11244"; a="30548220" X-IronPort-AV: E=Sophos;i="6.11,254,1725346800"; d="scan'208";a="30548220" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2024 20:21:12 -0700 X-CSE-ConnectionGUID: 3SSZ6/PoSPeJNuzxqB1iwA== X-CSE-MsgGUID: xv6vpDvIR3Ssdv3gkPqx7g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,254,1725346800"; d="scan'208";a="83451868" Received: from unknown (HELO JF5300-B11A338T.jf.intel.com) ([10.242.51.115]) by orviesa006.jf.intel.com with ESMTP; 02 Nov 2024 20:21:13 -0700 From: Kanchana P Sridhar To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, yosryahmed@google.com, nphamcs@gmail.com, chengming.zhou@linux.dev, usamaarif642@gmail.com, ryan.roberts@arm.com, ying.huang@intel.com, 21cnbao@gmail.com, akpm@linux-foundation.org, linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au, davem@davemloft.net, clabbe@baylibre.com, ardb@kernel.org, ebiggers@google.com, surenb@google.com, kristen.c.accardi@intel.com, zanussi@kernel.org Cc: wajdi.k.feghali@intel.com, vinodh.gopal@intel.com, kanchana.p.sridhar@intel.com Subject: [PATCH v2 01/13] crypto: acomp - Define two new interfaces for compress/decompress batching. Date: Sat, 2 Nov 2024 20:20:59 -0700 Message-Id: <20241103032111.333282-2-kanchana.p.sridhar@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20241103032111.333282-1-kanchana.p.sridhar@intel.com> References: <20241103032111.333282-1-kanchana.p.sridhar@intel.com> MIME-Version: 1.0 X-Stat-Signature: mtcwaptynkgg71efr149nqh1iwqcpcwx X-Rspam-User: X-Rspamd-Queue-Id: 721431C0002 X-Rspamd-Server: rspam02 X-HE-Tag: 1730604062-874492 X-HE-Meta: U2FsdGVkX189wBsX0hSpSWGc9KSmFVi9Bwo2rjQDpJMid5Kg8qiEGsO/VsH0D3+BSjYBDiaktLLFJhAspPhodx3LlhdseNPCgabI9DKzrtepPywfoHTxQhmGaW29OIXLZFzbOvCI0xtfq1e2uZs74rhnPziqiCDemysGIbdvZugbbhdnTKE5REPNKzCHxFpZyf35uImF6hRxgmX5wSK/2+Ds+0fkDWwOIkpe1s6S8S6SNS7hrFiN5SJxRhaDhpj32iCq3iatOu0o2Q+Y1HSV/+mFZUsdmm0Z7O14sRTw/jIU47JCG27VBomfMlbacKlxuxdRnyJVWsmc3UYsiAhxdl38x1wTHVUlveA8EuPpr/N96rRbc68DbT7zentLeSqr5nkF3JQXii0VYTrkFO9C3FB3ADo+Akz6ZA8wgOI5AiPwFZ3DG3oDTU+oUAAdLKD5SEkupIQnoZHbwTxNt8yFc7IH0kbIjkfK3uNeH8UMOR1WGfxRHeeftPosIg4lAi1sdTdovMziUu/rhGTipZvGcK9hggDAxhkBqr/A6TfgLlBY6xptW5ER0Uk+uLeD4XIOFa556ijIHKyFSnCiW5UuH7/HrcBThpprDbGnZSNvPhSMR5wbXfVcp+VWdiZf2T9UTdU8CNAjaCg2HV02Cej/+XlBXXsyL9NP520BUP+ENOXXdOsttFmJStdWCBAw4LTYDkogFuQr+fGjs8L2QImC9bwM+3We754xkAV25QcxsHJGgnyTvnmCKZIhZ319TkMraowhL1WlAkiAHm7yRyp/vJVVcOOuuGEBNgtRZTdAId+7Ia4Ec+8TsCcDZ6+hZpuI8qVP0xI/TV41DADVypbZS1XFsvtP+3D7889GIGCV0oO2bOjxOepsROKWl8HT/kvhy1stFmnbTwVw55D4eIqTb3TsY2N3bQjCvDtB/9AiiCJO21SU7Maf1wrQnV8W3xnVg58SeHZmahH3cx0iuFj 4+G3TNES n5FzSfLSkKa92mod3sPdY9dDKKh+PkBpSqzU3QWmrigCNp69y0Z3VjQSPWt/xMkQGpDKETNNWvJzD0MsoV1VHB/pmc2eGODcNKkkjBb6gNjd4M8mT1fS2C6Ff+GxoZ53pE6aivnPYvqEFjVToUEw198lUf5z3rFfxZqBE0CJmL1itwFrh78JMkIezUQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This commit adds batch_compress() and batch_decompress() interfaces to: struct acomp_alg struct crypto_acomp This allows the iaa_crypto Intel IAA driver to register implementation for batch_compress() and batch_decompress() API, that can subsequently be invoked from the kernel zswap/zram swap modules to compress/decompress up to CRYPTO_BATCH_SIZE (i.e. 8) pages in parallel in the IAA hardware accelerator to improve swapout/swapin performance. Signed-off-by: Kanchana P Sridhar --- crypto/acompress.c | 2 + include/crypto/acompress.h | 82 +++++++++++++++++++++++++++++ include/crypto/internal/acompress.h | 16 ++++++ 3 files changed, 100 insertions(+) diff --git a/crypto/acompress.c b/crypto/acompress.c index 6fdf0ff9f3c0..a506db499a37 100644 --- a/crypto/acompress.c +++ b/crypto/acompress.c @@ -71,6 +71,8 @@ static int crypto_acomp_init_tfm(struct crypto_tfm *tfm) acomp->compress = alg->compress; acomp->decompress = alg->decompress; + acomp->batch_compress = alg->batch_compress; + acomp->batch_decompress = alg->batch_decompress; acomp->dst_free = alg->dst_free; acomp->reqsize = alg->reqsize; diff --git a/include/crypto/acompress.h b/include/crypto/acompress.h index 54937b615239..ab0d9987bde1 100644 --- a/include/crypto/acompress.h +++ b/include/crypto/acompress.h @@ -37,12 +37,20 @@ struct acomp_req { void *__ctx[] CRYPTO_MINALIGN_ATTR; }; +/* + * The max compress/decompress batch size, for crypto algorithms + * that support batch_compress and batch_decompress API. + */ +#define CRYPTO_BATCH_SIZE 8UL + /** * struct crypto_acomp - user-instantiated objects which encapsulate * algorithms and core processing logic * * @compress: Function performs a compress operation * @decompress: Function performs a de-compress operation + * @batch_compress: Function performs a batch compress operation + * @batch_decompress: Function performs a batch decompress operation * @dst_free: Frees destination buffer if allocated inside the * algorithm * @reqsize: Context size for (de)compression requests @@ -51,6 +59,20 @@ struct acomp_req { struct crypto_acomp { int (*compress)(struct acomp_req *req); int (*decompress)(struct acomp_req *req); + void (*batch_compress)(struct acomp_req *reqs[], + struct crypto_wait *wait, + struct page *pages[], + u8 *dsts[], + unsigned int dlens[], + int errors[], + int nr_pages); + void (*batch_decompress)(struct acomp_req *reqs[], + struct crypto_wait *wait, + u8 *srcs[], + struct page *pages[], + unsigned int slens[], + int errors[], + int nr_pages); void (*dst_free)(struct scatterlist *dst); unsigned int reqsize; struct crypto_tfm base; @@ -265,4 +287,64 @@ static inline int crypto_acomp_decompress(struct acomp_req *req) return crypto_acomp_reqtfm(req)->decompress(req); } +/** + * crypto_acomp_batch_compress() -- compress a batch of requests + * + * Function invokes the batch compress operation + * + * @reqs: @nr_pages asynchronous compress requests. + * @wait: crypto_wait for synchronous acomp batch compress. If NULL, the + * driver must provide a way to process completions asynchronously. + * @pages: Pages to be compressed. + * @dsts: Pre-allocated destination buffers to store results of compression. + * @dlens: Will contain the compressed lengths. + * @errors: zero on successful compression of the corresponding + * req, or error code in case of error. + * @nr_pages: The number of pages, up to CRYPTO_BATCH_SIZE, + * to be compressed. + */ +static inline void crypto_acomp_batch_compress(struct acomp_req *reqs[], + struct crypto_wait *wait, + struct page *pages[], + u8 *dsts[], + unsigned int dlens[], + int errors[], + int nr_pages) +{ + struct crypto_acomp *tfm = crypto_acomp_reqtfm(reqs[0]); + + return tfm->batch_compress(reqs, wait, pages, dsts, + dlens, errors, nr_pages); +} + +/** + * crypto_acomp_batch_decompress() -- decompress a batch of requests + * + * Function invokes the batch decompress operation + * + * @reqs: @nr_pages asynchronous decompress requests. + * @wait: crypto_wait for synchronous acomp batch decompress. If NULL, the + * driver must provide a way to process completions asynchronously. + * @srcs: The src buffers to be decompressed. + * @pages: The pages to store the decompressed buffers. + * @slens: Compressed lengths of @srcs. + * @errors: zero on successful compression of the corresponding + * req, or error code in case of error. + * @nr_pages: The number of pages, up to CRYPTO_BATCH_SIZE, + * to be decompressed. + */ +static inline void crypto_acomp_batch_decompress(struct acomp_req *reqs[], + struct crypto_wait *wait, + u8 *srcs[], + struct page *pages[], + unsigned int slens[], + int errors[], + int nr_pages) +{ + struct crypto_acomp *tfm = crypto_acomp_reqtfm(reqs[0]); + + return tfm->batch_decompress(reqs, wait, srcs, pages, + slens, errors, nr_pages); +} + #endif diff --git a/include/crypto/internal/acompress.h b/include/crypto/internal/acompress.h index 8831edaafc05..acfe2d9d5a83 100644 --- a/include/crypto/internal/acompress.h +++ b/include/crypto/internal/acompress.h @@ -17,6 +17,8 @@ * * @compress: Function performs a compress operation * @decompress: Function performs a de-compress operation + * @batch_compress: Function performs a batch compress operation + * @batch_decompress: Function performs a batch decompress operation * @dst_free: Frees destination buffer if allocated inside the algorithm * @init: Initialize the cryptographic transformation object. * This function is used to initialize the cryptographic @@ -37,6 +39,20 @@ struct acomp_alg { int (*compress)(struct acomp_req *req); int (*decompress)(struct acomp_req *req); + void (*batch_compress)(struct acomp_req *reqs[], + struct crypto_wait *wait, + struct page *pages[], + u8 *dsts[], + unsigned int dlens[], + int errors[], + int nr_pages); + void (*batch_decompress)(struct acomp_req *reqs[], + struct crypto_wait *wait, + u8 *srcs[], + struct page *pages[], + unsigned int slens[], + int errors[], + int nr_pages); void (*dst_free)(struct scatterlist *dst); int (*init)(struct crypto_acomp *tfm); void (*exit)(struct crypto_acomp *tfm);