From patchwork Mon Nov 4 22:27:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Keren Sun X-Patchwork-Id: 13862183 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE329D1CA05 for ; Mon, 4 Nov 2024 22:28:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A9886B00A3; Mon, 4 Nov 2024 17:28:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 332176B00A4; Mon, 4 Nov 2024 17:28:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FB996B00A5; Mon, 4 Nov 2024 17:28:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 00F726B00A3 for ; Mon, 4 Nov 2024 17:28:18 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9570FC0BD2 for ; Mon, 4 Nov 2024 22:28:18 +0000 (UTC) X-FDA: 82749850848.19.99FF467 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) by imf06.hostedemail.com (Postfix) with ESMTP id BD1E318000F for ; Mon, 4 Nov 2024 22:27:53 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=I6qLUhg+; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of 3f0opZwgKCPgpjwjsxzslttlqj.htrqnsz2-rrp0fhp.twl@flex--kerensun.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3f0opZwgKCPgpjwjsxzslttlqj.htrqnsz2-rrp0fhp.twl@flex--kerensun.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730759213; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y1YSqDn0sbFO9SXEJcmAUmq+AuYyNB6VQvHAGKw4UO8=; b=WxtiIO+PF/6tZbUJG0vN4smNro1iFaKGFPKj0g84iGf59JOvwJ7Si2NPLAoCE+AAZsTkb7 0cp5ITcox5WwAXt9tZy8iV/P20C36GKUEdMBFwSXRd3vQ0cOzwh/yajDqJ8zUh1dHZv9PL SpXPseAaK68rTat0327VLCrXo2E7gJ4= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=I6qLUhg+; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of 3f0opZwgKCPgpjwjsxzslttlqj.htrqnsz2-rrp0fhp.twl@flex--kerensun.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3f0opZwgKCPgpjwjsxzslttlqj.htrqnsz2-rrp0fhp.twl@flex--kerensun.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730759213; a=rsa-sha256; cv=none; b=cefC0QS9bXktYz0l4j1/rV3M251/Yav6qtjg/FF3Q3Yki/3lHajabiLrHh63gPerEc9dJR Ox6iZ77sHhMFHyFIRBA4Pkuxmr0HdX25S+SIZqXJtZyJnyw3imlAaSiR+bBuDi431x8MSf 0a+FIdR5Ycc6cpgHFRF2+/3uXUSixDs= Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-6ea7c5805ccso42508927b3.0 for ; Mon, 04 Nov 2024 14:28:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1730759296; x=1731364096; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Y1YSqDn0sbFO9SXEJcmAUmq+AuYyNB6VQvHAGKw4UO8=; b=I6qLUhg+3xaCC8C+ZrOC06VUV06toJwLoGgwfn7PYj+JBcEtKVhpxs/NR/7FeloDOF PLU7xwOTMqx7r/28jhh0BWuYXevFI2p6jdECmt0mv12eNk7gQJTu/FAKVLtgoMVSnsIg 3e75JS106nvDUXq2M9sXc4vLt313rsico4GO4AxPTRKH0oCXmGh/0mTJxbTGu4OebNKR 24nG4pYdRfnlGZNcRE6XcbiPoQZy9pC0m83kUNPJoOuGPcQQ7R4dQybG648ZegwOXzP+ z1Rnih0EDXJ90pzKuxLGCRdSYEgPo5FET9oyIpXzqAMQlFGsy+OZK3P73DhjLIJUo66v lO5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730759296; x=1731364096; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Y1YSqDn0sbFO9SXEJcmAUmq+AuYyNB6VQvHAGKw4UO8=; b=OUF06oqF/NcJMA8wY5b7txmCdjC/A4bhwskpSJO7Kqm/f7b+JTh/I/2/S6KXzj8Ut7 UZnI56Rm57i6LP21I9/ZX+tpvkMVcs1UVzUfxL1aChVqaq6ul6Q4dd1160LEBgFBKMQU oiXhA35VnFuh3zOWHwyeUgaWZSBr3J7KbC9zFn5rXkgBYg8d/nhAlkPEQWcP2+S6Y0To uYBkAYwUaxGuPoR8snaQ0WX6/1eI9plt4Hr1s0E+nAEciFeJHaz34EAeIG12UKGF94d0 kl8oscaWS1Cv1InUVTSSB99ceq6AZgAD9Ct0YFQXbk+YHvCoc2OlFJmBFFuPSZ5S2FdR 8OMw== X-Forwarded-Encrypted: i=1; AJvYcCXMOMMkWRUW8tI62H+m54FhCu1CH8oNa0glvuLuH0Y+iE0adnEE3XWQlabPtuuihiEIwMJWErHZCg==@kvack.org X-Gm-Message-State: AOJu0Yyyydrieb9kOeJa4CUH1RUSqnXjxAvXZ1xXQ9PDjVIrOQN7nCu1 DURkWeDab9lhLqAuC5w51TMHSCO09WiEEAt+e5G2ZZmGmEIGgKCaWyoWsoMNA4m1/D/uJfpceAC Z2UaO59CA8g== X-Google-Smtp-Source: AGHT+IEwJ6XoH9jYvE9XepfbYW66gSHe6pDYBUEJ6j7mRhsOIIUs4LZTeXXSxAJhVRpRqXv6MfH+lzcIHJo1EQ== X-Received: from kerensun.svl.corp.google.com ([2620:15c:2c5:11:2520:b863:90ba:85bc]) (user=kerensun job=sendgmr) by 2002:a05:690c:802:b0:6ea:1f5b:1f5e with SMTP id 00721157ae682-6ea52518ac3mr273147b3.4.1730759295937; Mon, 04 Nov 2024 14:28:15 -0800 (PST) Date: Mon, 4 Nov 2024 14:27:37 -0800 In-Reply-To: <20241104222737.298130-1-kerensun@google.com> Mime-Version: 1.0 References: <20241104222737.298130-1-kerensun@google.com> X-Mailer: git-send-email 2.47.0.199.ga7371fff76-goog Message-ID: <20241104222737.298130-5-kerensun@google.com> Subject: [PATCH 4/4] mm: Replace simple_strtoul() with kstrtoul() From: Keren Sun To: akpm@linux-foundation.org Cc: roman.gushchin@linux.dev, hannes@cmpxchg.org, mhocko@kernel.org, shakeel.butt@linux.dev, muchun.song@linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Keren Sun X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: BD1E318000F X-Stat-Signature: fibu6dzk4t44ttqp67zjx853gyj6xpzm X-HE-Tag: 1730759273-723339 X-HE-Meta: U2FsdGVkX1/XQGtVpZv76nPt1bux60W+iTX55iqm2mDQ5WzfmXQILjXY50+k5Mhonhm/hNk58wIhRPWmRHvmhYPTDLofI8GtOR24vzpb9yMUHsrTcBLOclnZ2fEDh5OvFkNhHO33x4KqjbcSO+JP9D8vINORpx4u7tem93TFjKrTvlNk6hznkbZODDgmVw594ezPFSyin/LlU7wTlNQkLDvserStnEVR80qMTPBORReG2wvti0Vdm6xcQjSJr/fiClrVmcrAnR+GmFrqw5Vo4mPU/EaGvxwVlaK5IBA74wqXBp+4ck4u4RBu+Xp/o4j9e1yrKSlwUSNTqEUtI1Anwih0xvAVGlIMLU5ilr+A/MfGXEh0IiqzSOY6p5KG6YXiUh8t6SmGxLgf8Gi6ZBVRHmcIYMNsH+/wIvbPk06OXopPvRqELTvlsKDrIcbej6BleZjeSNsHWlGEmYVLPHztyZIIh93nzqr4gJHZe+bfZC9saPe7kDArSveUpQoqgTyHOk73hBymN+wPqCMuLVPxCrLvrNQAkJYE6u01hyubz8HJTdV/kMiVD7lvu7nrWU7BbY0DzkeRZBc6NbYuQtBh2+81NbjM6HGZUxr1fe4ElkOfFMZIQGLvy+ijQh9tj3cS6F3YGoJGg+XjSVezqRsG8V+fUMbfHt+xy20S2qeApnOIOtLky7IEYKLpeWaSyhtCRyauI3EhKAXXE9QWE5lVMJNYtBySaFWHbachVcVQs1nclAQw1tbp6XOCgkuMLgqc5eJ5zYYY4orYJ4AuwCki3wUL8w8ZtSLn4xJ1dEEUTWSlN50VnQRpl6m8QSBSSACSn81txhpgAjoxoJPag0kI2CYYzhAA8Z7pilp295XsIbvDDbDhaykCvyEY2s5ZrrC0tSPWpg4QTHFsqyhEiE4oZ+p76emhqrgSo3Miu49DVxPFFoVEV6r64bqJF7VzyA8JYLaRNXH8Y9kkUwoS8dm 84Miv+cx Jnrxpme9prZrCFDO6Q3Bs1FhXx2ThkVHMPTqM/S45ROS0sedNs72TnLt0Ba23sxpKrN46YGQqbtLNGkmiUO6mynYeHZ4bo9U91miA0T8K/ehmjgMJ5NuuabD0eKH4JhZTa9P/5Ajrn8DURkVEySVyTSRzRgefAMUs0Q9jjO6Hx7NdgJzwVNQb+Qemn1RK+8T4Dr2tnorHlB76EvdyH/MZjRzIZ2D4toWcvJMXfCY13C3WHbBD3IfhYMJ6x+t+myvn0pOh31GYv0XPerKl+GYCucmsny8HOgXFvTo/6mOTygpPuNb37oDLRDe6rf+nyhymi6yiot7KQaff/34s35Cg1zhwQck8xoizlQcMyehNYJZ76t0enYrsidICzQSgcVZ1tjc5VJchjPe6nyIv9RDtAQO5mKT5QKAG4VOFCS94X/JbBMY9L1L9YBJ0Ibbr7W5FBQSZdkqZj80dIXc5lVsn2Bu6smyklU5eOyVp3JjrtZg9a+CzCCiwgGLES0aIk8RrOq6LxQJPy8mk9IWcqZuIo5oxjXHA4+o8hv/DFb16Lg8Y3P5DnGNsB1l/SoVpuXoYjbomEmjgMP8OU5esF7DPcaZv7VKvnKVInWuC2a6+rNNjSVQGWZwe42UrlstEsJfirBQs0OedmM01a84= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000013, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: simple_strtoul() has caveat and is obsolete, use kstrtoul() instead in mmcg. Signed-off-by: Keren Sun --- mm/memcontrol-v1.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/mm/memcontrol-v1.c b/mm/memcontrol-v1.c index 5e1854623824..260b356cea5a 100644 --- a/mm/memcontrol-v1.c +++ b/mm/memcontrol-v1.c @@ -1,5 +1,6 @@ // SPDX-License-Identifier: GPL-2.0-or-later +#include "linux/kstrtox.h" #include #include #include @@ -1922,17 +1923,15 @@ static ssize_t memcg_write_event_control(struct kernfs_open_file *of, buf = strstrip(buf); - efd = simple_strtoul(buf, &endp, 10); - if (*endp != ' ') + kstrtoul(buf, 10, efd); + if (*buf != ' ') return -EINVAL; - buf = endp + 1; + buf++; - cfd = simple_strtoul(buf, &endp, 10); - if (*endp == '\0') - buf = endp; - else if (*endp == ' ') - buf = endp + 1; - else + kstrtoul(buf, 10, cfd); + if (*buf == ' ') + buf++; + else if (*buf != '\0') return -EINVAL; event = kzalloc(sizeof(*event), GFP_KERNEL);