From patchwork Fri Nov 22 18:04:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shiju Jose X-Patchwork-Id: 13883507 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F9C2E69185 for ; Fri, 22 Nov 2024 18:05:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 487BB6B0083; Fri, 22 Nov 2024 13:05:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 410616B00A0; Fri, 22 Nov 2024 13:05:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B3C56B00A1; Fri, 22 Nov 2024 13:05:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0A17A6B0083 for ; Fri, 22 Nov 2024 13:05:02 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B156581530 for ; Fri, 22 Nov 2024 18:05:01 +0000 (UTC) X-FDA: 82814505522.10.0F0F408 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf02.hostedemail.com (Postfix) with ESMTP id E42B08001C for ; Fri, 22 Nov 2024 18:03:16 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732298451; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LsVF5cSj0kKqXm3UCMW7iQTGowtyqnQvzvPuCvoCk88=; b=AV9eFdKG2szsEcJzT9rdT80uNoNWkIvvqhepyGaR/AsDsCEYmGgRVsqI6ZjnyChXBvXg2P HR5Nyd8DZTAFuAyCWrkLSL1OHIvPvReK2o8BXAOyi8wyw/r7rK2BD9l9Osfp3i+67WLgoK ztaQzAuClHiqZddeLDP5rCog/HziWAI= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732298451; a=rsa-sha256; cv=none; b=BRllWiHz1ZUYcTQnZ6mCSKq1ZLWd8axMXdgST7BQkgPyfchVBsBFLW+KpXPcBWeE7l4EtE /YbMS1BCN/cYsuItouJEvh0bfOnRqwTKjuL4ZHQ6GyfE91NLnyvvL+pwx5ky5gzxJB2i2/ DxsscNtQxLfeKbjj7BmL98PwiU3E8oY= Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Xw2wH3TxQz6K6lq; Sat, 23 Nov 2024 02:01:19 +0800 (CST) Received: from frapeml500007.china.huawei.com (unknown [7.182.85.172]) by mail.maildlp.com (Postfix) with ESMTPS id E0F1B14010C; Sat, 23 Nov 2024 02:04:57 +0800 (CST) Received: from P_UKIT01-A7bmah.china.huawei.com (10.126.171.16) by frapeml500007.china.huawei.com (7.182.85.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 22 Nov 2024 19:04:55 +0100 From: To: , , , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH v17 08/18] cxl/mbox: Add SET_FEATURE mailbox command Date: Fri, 22 Nov 2024 18:04:05 +0000 Message-ID: <20241122180416.1932-9-shiju.jose@huawei.com> X-Mailer: git-send-email 2.43.0.windows.1 In-Reply-To: <20241122180416.1932-1-shiju.jose@huawei.com> References: <20241122180416.1932-1-shiju.jose@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.126.171.16] X-ClientProxiedBy: lhrpeml500002.china.huawei.com (7.191.160.78) To frapeml500007.china.huawei.com (7.182.85.172) X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E42B08001C X-Stat-Signature: 3d3d4rimoryifs3s96tphrmgzbb6yea6 X-Rspam-User: X-HE-Tag: 1732298596-500331 X-HE-Meta: U2FsdGVkX19Nip8pBavUVa/7ujQQ33RhkAatmZQFUn7qiNR+kZ7DotHK6J6aF7+T3hw0G1wJvJgyGeBi6/sMKTY4bL/FqBXN8QRuPBVRmRuLK5/FjNyRCJ1QlUsV259UbKiFx9aoLGiWR8LQm0Q4FNhkslBlsibCpwtYq4w/+cj2bwKjaBisgY0kMQxpYZBJIgbSSreBJA3p/cnKCmRFOqsr5NQ9RsST4EOq5tSQFb4UMkAv35MdqDkvx24e+vQvyijDvg7oEtTOhmtOJRrO71iGhJfRgxlSLoHiPYN8oHMw1S4T4CaYVWGxc5BIpxZIiQJXaNhZlzLuRWHyj52tzwj5ma+0DWBO4jhUBektyv4YpWsyphl52Vy53J+yOdhNmkUovbH/pKO7N7pJOpoGKRSokEapbCu9dNVSB+y1B3/juHM7/kW8+JkLxZ1C1xN7S+D6L5vRIEvL7xUxVKmZ2p5m284Dfr/Lq+m/YqFnQR+vRaFz7lVNz4vg0Q+fZ//9S5Xr+CY1n83fyT1qKrNaM8RAEqYU0oB+1ogOaKsX25aNr6BJ7e3cXfqj4mTg3efLwGI9PlOkpz0EXP5dMlEU5BKxOcCeNLYoQBpCz3mmV7npbctE4OoE358xS0zzQa70AboOwBbXE2yzm/eneuMaGyQOjMmqxIAENpUSfGDVIC+HdLbhgFM+sVUToYR3XPaFIinyzDZlQP9RxMEIG8NS9nZ4MJ+iD77c56MHpLBcKuG4TnajWtl/O94l+w4AoISWyixzlDPhRXthKhfqRDQH15Zcwn/CW74jK+vLZTsI2I7YlIfMyFcjxsn+QzFAHxUgg8h9/800QoQKxlx6bTbxgMjnJ6p33Mc76n1924QpLbx5z6RHlJ/+d6cfle7xcTiF0BTY9QFi4m13RT/SqvJiKeoTk57+R/oTu4fOuVCBGOZXX2D6mhwltqqcuRxmVSgQVPwPnbCJDm058pNBa25 MxFbS7Yc JbQbNw0ZAyzj8OHcH6872PIhDI2FDUrIcrfkdRQYMlBCgnqzwyKzULfUeghb68TWcaZK22BPHEAPUMlAJcsLkJPE7+XV8x0uFt25S335b2QzmsPDvHeTlJQYEs6+ZxEFmzu68ptjFmHBfMGB22CBvmrnRYxAKPi4+dd89k6v616kMYre9wC24GY8AEfHvAxKwDp222I+3sIkzAELAWsf1qRAdnM8zmo4gRlnwbU2hxhI0xE7FQAGBxLSbG9NWLd+YeLz7s9CtyyJqF/nlA6OO/R4gJy8MmSIjQKOs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Shiju Jose Add support for SET_FEATURE mailbox command. CXL spec 3.1 section 8.2.9.6 describes optional device specific features. CXL devices support features with changeable attributes. The settings of a feature can be optionally modified using Set Feature command. CXL spec 3.1 section 8.2.9.6.3 describes Set Feature command. Reviewed-by: Jonathan Cameron Reviewed-by: Dave Jiang Signed-off-by: Dave Jiang Signed-off-by: Shiju Jose --- drivers/cxl/core/mbox.c | 73 +++++++++++++++++++++++++++++++++++++++++ drivers/cxl/cxlmem.h | 34 +++++++++++++++++++ 2 files changed, 107 insertions(+) diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c index 37764d3d470d..c29bf0e1f12c 100644 --- a/drivers/cxl/core/mbox.c +++ b/drivers/cxl/core/mbox.c @@ -1011,6 +1011,79 @@ size_t cxl_get_feature(struct cxl_dev_state *cxlds, const uuid_t feat_uuid, } EXPORT_SYMBOL_NS_GPL(cxl_get_feature, CXL); +/* + * FEAT_DATA_MIN_PAYLOAD_SIZE - min extra number of bytes should be + * available in the mailbox for storing the actual feature data so that + * the feature data transfer would work as expected. + */ +#define FEAT_DATA_MIN_PAYLOAD_SIZE 10 +int cxl_set_feature(struct cxl_dev_state *cxlds, + const uuid_t feat_uuid, u8 feat_version, + void *feat_data, size_t feat_data_size, + u8 feat_flag) +{ + struct cxl_mailbox *cxl_mbox = &cxlds->cxl_mbox; + struct cxl_memdev_set_feat_pi { + struct cxl_mbox_set_feat_hdr hdr; + u8 feat_data[]; + } __packed; + size_t data_in_size, data_sent_size = 0; + struct cxl_mbox_cmd mbox_cmd; + size_t hdr_size; + int rc = 0; + + struct cxl_memdev_set_feat_pi *pi __free(kfree) = + kmalloc(cxl_mbox->payload_size, GFP_KERNEL); + pi->hdr.uuid = feat_uuid; + pi->hdr.version = feat_version; + feat_flag &= ~CXL_SET_FEAT_FLAG_DATA_TRANSFER_MASK; + feat_flag |= CXL_SET_FEAT_FLAG_DATA_SAVED_ACROSS_RESET; + hdr_size = sizeof(pi->hdr); + /* + * Check minimum mbox payload size is available for + * the feature data transfer. + */ + if (hdr_size + FEAT_DATA_MIN_PAYLOAD_SIZE > cxl_mbox->payload_size) + return -ENOMEM; + + if ((hdr_size + feat_data_size) <= cxl_mbox->payload_size) { + pi->hdr.flags = cpu_to_le32(feat_flag | + CXL_SET_FEAT_FLAG_FULL_DATA_TRANSFER); + data_in_size = feat_data_size; + } else { + pi->hdr.flags = cpu_to_le32(feat_flag | + CXL_SET_FEAT_FLAG_INITIATE_DATA_TRANSFER); + data_in_size = cxl_mbox->payload_size - hdr_size; + } + + do { + pi->hdr.offset = cpu_to_le16(data_sent_size); + memcpy(pi->feat_data, feat_data + data_sent_size, data_in_size); + mbox_cmd = (struct cxl_mbox_cmd) { + .opcode = CXL_MBOX_OP_SET_FEATURE, + .size_in = hdr_size + data_in_size, + .payload_in = pi, + }; + rc = cxl_internal_send_cmd(cxl_mbox, &mbox_cmd); + if (rc < 0) + return rc; + + data_sent_size += data_in_size; + if (data_sent_size >= feat_data_size) + return 0; + + if ((feat_data_size - data_sent_size) <= (cxl_mbox->payload_size - hdr_size)) { + data_in_size = feat_data_size - data_sent_size; + pi->hdr.flags = cpu_to_le32(feat_flag | + CXL_SET_FEAT_FLAG_FINISH_DATA_TRANSFER); + } else { + pi->hdr.flags = cpu_to_le32(feat_flag | + CXL_SET_FEAT_FLAG_CONTINUE_DATA_TRANSFER); + } + } while (true); +} +EXPORT_SYMBOL_NS_GPL(cxl_set_feature, CXL); + /** * cxl_enumerate_cmds() - Enumerate commands for a device. * @mds: The driver data for the operation diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h index b915e0037c12..d85e0048bce2 100644 --- a/drivers/cxl/cxlmem.h +++ b/drivers/cxl/cxlmem.h @@ -492,6 +492,7 @@ enum cxl_opcode { CXL_MBOX_OP_GET_SUP_LOG_SUBLIST = 0x0405, CXL_MBOX_OP_GET_SUPPORTED_FEATURES = 0x0500, CXL_MBOX_OP_GET_FEATURE = 0x0501, + CXL_MBOX_OP_SET_FEATURE = 0x0502, CXL_MBOX_OP_IDENTIFY = 0x4000, CXL_MBOX_OP_GET_PARTITION_INFO = 0x4100, CXL_MBOX_OP_SET_PARTITION_INFO = 0x4101, @@ -836,6 +837,35 @@ struct cxl_mbox_get_feat_in { u8 selection; } __packed; +/* + * Set Feature CXL 3.1 Spec 8.2.9.6.3 + */ + +/* + * Set Feature input payload + * CXL rev 3.1 section 8.2.9.6.3 Table 8-101 + */ +/* Set Feature : Payload in flags */ +#define CXL_SET_FEAT_FLAG_DATA_TRANSFER_MASK GENMASK(2, 0) +enum cxl_set_feat_flag_data_transfer { + CXL_SET_FEAT_FLAG_FULL_DATA_TRANSFER, + CXL_SET_FEAT_FLAG_INITIATE_DATA_TRANSFER, + CXL_SET_FEAT_FLAG_CONTINUE_DATA_TRANSFER, + CXL_SET_FEAT_FLAG_FINISH_DATA_TRANSFER, + CXL_SET_FEAT_FLAG_ABORT_DATA_TRANSFER, + CXL_SET_FEAT_FLAG_DATA_TRANSFER_MAX +}; + +#define CXL_SET_FEAT_FLAG_DATA_SAVED_ACROSS_RESET BIT(3) + +struct cxl_mbox_set_feat_hdr { + uuid_t uuid; + __le32 flags; + __le16 offset; + u8 version; + u8 rsvd[9]; +} __packed; + int cxl_internal_send_cmd(struct cxl_mailbox *cxl_mbox, struct cxl_mbox_cmd *cmd); int cxl_dev_state_identify(struct cxl_memdev_state *mds); @@ -902,4 +932,8 @@ int cxl_get_supported_feature_entry(struct cxl_dev_state *cxlds, const uuid_t *f size_t cxl_get_feature(struct cxl_dev_state *cxlds, const uuid_t feat_uuid, enum cxl_get_feat_selection selection, void *feat_out, size_t feat_out_size); +int cxl_set_feature(struct cxl_dev_state *cxlds, + const uuid_t feat_uuid, u8 feat_version, + void *feat_data, size_t feat_data_size, + u8 feat_flag); #endif /* __CXL_MEM_H__ */