| Message ID | 20241127-lru-stop-comment-v1-1-f54a7cba9429@google.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mm/zswap: add LRU_STOP to comment about dropping the lru lock | expand |
On Wed, Nov 27, 2024 at 01:53:29PM +0000, Alice Ryhl wrote: > This function has been able to return LRU_STOP since commit b49547ade38a > ("mm/zswap: stop lru list shrinking when encounter warm region"). To > reduce confusion, update the comment to also list LRU_STOP as an option. > > Signed-off-by: Alice Ryhl <aliceryhl@google.com> Acked-by: Johannes Weiner <hannes@cmpxchg.org>
On 2024/11/27 21:53, Alice Ryhl wrote: > This function has been able to return LRU_STOP since commit b49547ade38a > ("mm/zswap: stop lru list shrinking when encounter warm region"). To > reduce confusion, update the comment to also list LRU_STOP as an option. > > Signed-off-by: Alice Ryhl <aliceryhl@google.com> Reviewed-by: Chengming Zhou <chengming.zhou@linux.dev> Thanks! > --- > mm/zswap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index f6316b66fb23..9718c33f8192 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -1156,7 +1156,7 @@ static enum lru_status shrink_memcg_cb(struct list_head *item, struct list_lru_o > > /* > * It's safe to drop the lock here because we return either > - * LRU_REMOVED_RETRY or LRU_RETRY. > + * LRU_REMOVED_RETRY, LRU_RETRY or LRU_STOP. > */ > spin_unlock(&l->lock); > > > --- > base-commit: aaf20f870da056752f6386693cc0d8e25421ef35 > change-id: 20241127-lru-stop-comment-09dab2427b6e > > Best regards,
diff --git a/mm/zswap.c b/mm/zswap.c index f6316b66fb23..9718c33f8192 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -1156,7 +1156,7 @@ static enum lru_status shrink_memcg_cb(struct list_head *item, struct list_lru_o /* * It's safe to drop the lock here because we return either - * LRU_REMOVED_RETRY or LRU_RETRY. + * LRU_REMOVED_RETRY, LRU_RETRY or LRU_STOP. */ spin_unlock(&l->lock);
This function has been able to return LRU_STOP since commit b49547ade38a ("mm/zswap: stop lru list shrinking when encounter warm region"). To reduce confusion, update the comment to also list LRU_STOP as an option. Signed-off-by: Alice Ryhl <aliceryhl@google.com> --- mm/zswap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: aaf20f870da056752f6386693cc0d8e25421ef35 change-id: 20241127-lru-stop-comment-09dab2427b6e Best regards,