From patchwork Mon Dec 2 12:58:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Hildenbrand X-Patchwork-Id: 13895583 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5BE9E77170 for ; Thu, 5 Dec 2024 15:32:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 538A86B0127; Thu, 5 Dec 2024 10:19:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D45376B013A; Thu, 5 Dec 2024 10:19:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 249986B00F3; Thu, 5 Dec 2024 10:19:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4194B6B0082 for ; Mon, 2 Dec 2024 07:58:33 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E6AD31C8346 for ; Mon, 2 Dec 2024 12:58:32 +0000 (UTC) X-FDA: 82850022318.19.A55536A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id F184E40012 for ; Mon, 2 Dec 2024 12:58:17 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GZYZ7OU5; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733144300; a=rsa-sha256; cv=none; b=7jgg7Cn6ouN8TGXt7+XXf5ZHQ7d4QWL5+BaxAzsa2Od5sq/2ECqLMt1g3PM00gHdLOPDtg ydQv0c6yj7rMi2tegwuhZl/tbcJ+01PKoNlXpR3Su0hsDVrjC0xx48YYSCckOQseTp2nUf a9yid1AeaejTVB85VaczVafZ53XeBB4= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GZYZ7OU5; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733144300; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KtMsmFE9pgvd9dqP+bKnl486+ttvAdvq1JTdJU/oyis=; b=3NNzqes5ZEkWBxxYcOdIaGbXScybLVpxT8Kg/cYbBiJyIoRTsaqJXukhRszcKZ9otBHiC/ 5TU0rg8HuTUi6VPSZxtLabgW5gOipZfwSYUlzA7hfMT/McjB1qUBZrUIYpeuyjP8YEyS7H oFnQkAcLjYAazaV3kdcY0v+A6Y2CBrQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733144310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KtMsmFE9pgvd9dqP+bKnl486+ttvAdvq1JTdJU/oyis=; b=GZYZ7OU5XdNUaz/ZJPCWQ3tbukmUGZtK3B4NaNP4KoWE77UcFNNPwOD2k3aDKBiK7TmfDp chqNjf1md2LjuXoNRdsSKVai5oXlbQdF9x9/pKfHgQolWP7E9xruNApuYDDS5KFOeY3aL4 vm/spPiI/oW3J1CIDng70LIkVsSPBj0= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-215-W0vdIfGOP66mWzIFy1nl9w-1; Mon, 02 Dec 2024 07:58:27 -0500 X-MC-Unique: W0vdIfGOP66mWzIFy1nl9w-1 X-Mimecast-MFC-AGG-ID: W0vdIfGOP66mWzIFy1nl9w Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 32501195FCDD; Mon, 2 Dec 2024 12:58:24 +0000 (UTC) Received: from t14s.cit.tum.de (unknown [10.39.194.150]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id BF7E1195605A; Mon, 2 Dec 2024 12:58:19 +0000 (UTC) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, David Hildenbrand , Andrew Morton , Oscar Salvador , Zi Yan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan Subject: [PATCH v1 1/6] mm/page_isolation: don't pass gfp flags to isolate_single_pageblock() Date: Mon, 2 Dec 2024 13:58:07 +0100 Message-ID: <20241202125812.561028-2-david@redhat.com> In-Reply-To: <20241202125812.561028-1-david@redhat.com> References: <20241202125812.561028-1-david@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Stat-Signature: 9isw5tigbg5mmzprczycwtjzjm598egt X-Rspam-User: X-Rspamd-Queue-Id: F184E40012 X-Rspamd-Server: rspam08 X-HE-Tag: 1733144297-914958 X-HE-Meta: U2FsdGVkX1+xd5Nv2yrna9WUajDlCV0ASf20nzCInSvIr0NKa7jArHZeA9hsickXt59bAC9G/r+xYI9VPnZi5P/Lx+JwL7oadbomuO1GJxjbtiAFY0W+5fvW8NdGmaXRhu/B01FSBim2ThOGhDRVr+fRIBgdgm2vcNTjD7KPaoMOdzAzgNQZCxd1rj8bB7igqZRPx4GM0DfrHZuHTrRp8N8mPi8I1vcJ6TKxoiqzZYiCSYjLzIFRt5e9ATcyMQazK51NuaQaLMNnHwDNKtpt82dfS/uhLphGtEMXIkgTTDzrEls9rCLe++SMBhgsuE9twqQnmCvh2+ya8Tv/s0M+Y2vVjQP0JAnqob/WPhsQcoNyNcm5FM2fAMUoA3ujSepGp502aeJozBSFI4VXqJvW/j8g90yUY2IRxRykICvZ9K/BH3klzOI4L7EPcZ2+LgM71av4UC0LHgdfBRdXP+PWMP8z+GC9rDUzoBfkgcQSUijZHsDB8RDbjhc4CwxTGvOpckLudb2mwxHcp/57MKkmTn7Y996rE/Jh1PLaCXPNBWrvW3fxfmcmvTstr8gMz9DjwJnwDFqsgTUDmPgd1yHUx4ha6xMNKEr5slydPF6WEhP6uXVZVjL56/vlw5huMPjpXXFKWm5oLxjkT1AJAPKVm1zIUfdA53C1BBngxJTGxWVdCxFooSiCrf25/cb3rXYcqwctmvvFtohhwOTH4tCNDgOaUcUgOy8uUeJbGkXJVpNF6CaHxIDyDMRJ44PHMi1EXZd8kinnyni1HrZhn+FUqmN4tR3y6yhW6G95xL/3yQcY/yj7/vk8sCzKqMWnSMP+/Ys0TIPBNe8QUk/V3C9oyolISp73ySljZgEcE25qFavXFhV/MkQXEaE2qJuVA3l5bJT8c5S8BOB/H6D9AI5Su4TjvX9lcs0D9bZlwXcIqbTYwoNf5UXgixCnKdJ8z9CmwNqqGbpR/F90IKO8I+R PgJrEdfk XmkbDC+GwzqGCYVCmns0tr6stpyS01ZW24gp9ET/uVq1aih1s7n8L+RLetvnFNd1Nyl3SORystjbI6K1BFHSKb8iqDxdMw8cPJPVFsrZo91Gb9cB6DXU7Xh9o+8OW2UBVdbyvvQZELYDh4rPTUdfALYZDp9X2YRTPAPeQiRPUReAxRKhECs0D+Txju6fnTQGiJWHdcWZCqAlT0UxaZWE1Y8GROqBLZAe6nee8Fj7jR1oiCwBjh39jt+TNcLBE5G50WX2uMs+7whw3VwkxfPCrHVxnZoFGIxBBQPhv/UIC0jkkLlHG4zBtpTWxEYj/3EE7k5w4EaKiSJ/BBEemsnVfdvgo+KXUn/X3zOHnWu6LJ8q3oJp6H9hZbbc8GgQOoEpHwk0KVDQ1M4GkXTbIoV8ricgQNw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The flags are no longer used, we can stop passing them to isolate_single_pageblock(). Signed-off-by: David Hildenbrand --- mm/page_isolation.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/mm/page_isolation.c b/mm/page_isolation.c index 7e04047977cf..e680d40d96de 100644 --- a/mm/page_isolation.c +++ b/mm/page_isolation.c @@ -286,7 +286,6 @@ __first_valid_page(unsigned long pfn, unsigned long nr_pages) * within a free or in-use page. * @boundary_pfn: pageblock-aligned pfn that a page might cross * @flags: isolation flags - * @gfp_flags: GFP flags used for migrating pages * @isolate_before: isolate the pageblock before the boundary_pfn * @skip_isolation: the flag to skip the pageblock isolation in second * isolate_single_pageblock() @@ -306,8 +305,7 @@ __first_valid_page(unsigned long pfn, unsigned long nr_pages) * the in-use page then splitting the free page. */ static int isolate_single_pageblock(unsigned long boundary_pfn, int flags, - gfp_t gfp_flags, bool isolate_before, bool skip_isolation, - int migratetype) + bool isolate_before, bool skip_isolation, int migratetype) { unsigned long start_pfn; unsigned long isolate_pageblock; @@ -489,7 +487,7 @@ int start_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn, bool skip_isolation = false; /* isolate [isolate_start, isolate_start + pageblock_nr_pages) pageblock */ - ret = isolate_single_pageblock(isolate_start, flags, gfp_flags, false, + ret = isolate_single_pageblock(isolate_start, flags, false, skip_isolation, migratetype); if (ret) return ret; @@ -498,7 +496,7 @@ int start_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn, skip_isolation = true; /* isolate [isolate_end - pageblock_nr_pages, isolate_end) pageblock */ - ret = isolate_single_pageblock(isolate_end, flags, gfp_flags, true, + ret = isolate_single_pageblock(isolate_end, flags, true, skip_isolation, migratetype); if (ret) { unset_migratetype_isolate(pfn_to_page(isolate_start), migratetype);