From patchwork Tue Dec 3 09:30:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Celeste Liu X-Patchwork-Id: 13892033 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23A46D49797 for ; Tue, 3 Dec 2024 09:31:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 975286B0089; Tue, 3 Dec 2024 04:31:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8FD656B008A; Tue, 3 Dec 2024 04:31:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 750186B008C; Tue, 3 Dec 2024 04:31:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4FBC46B0089 for ; Tue, 3 Dec 2024 04:31:12 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CB32F1C699F for ; Tue, 3 Dec 2024 09:31:11 +0000 (UTC) X-FDA: 82853128638.06.862A0CB Received: from flow-b2-smtp.messagingengine.com (flow-b2-smtp.messagingengine.com [202.12.124.137]) by imf01.hostedemail.com (Postfix) with ESMTP id CD57040007 for ; Tue, 3 Dec 2024 09:30:59 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=coelacanthus.name header.s=fm2 header.b=xzlU2rr4; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="z jkgOXn"; spf=pass (imf01.hostedemail.com: domain of uwu@coelacanthus.name designates 202.12.124.137 as permitted sender) smtp.mailfrom=uwu@coelacanthus.name; dmarc=pass (policy=quarantine) header.from=coelacanthus.name ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733218263; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TH5iUDtcVd8w2RV5/BeTBVj9JapPNqfFOxuzY/m1AcE=; b=NzgUa0LyBSHN35F0xIRveW/yT1ilauTKbkS6VNTq5ou8buvo+QyECO9h6qwriGXJFWm7f0 lX+kh7r+U/m7nzkpz7X/l0EanYTmGK7i5tYttVnFMS1oSvVQyyWH5DbHzwwiWrcz/KcRyy oTVEGTaNWEx/jZcl6jidNRWJp9/7gy4= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=coelacanthus.name header.s=fm2 header.b=xzlU2rr4; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="z jkgOXn"; spf=pass (imf01.hostedemail.com: domain of uwu@coelacanthus.name designates 202.12.124.137 as permitted sender) smtp.mailfrom=uwu@coelacanthus.name; dmarc=pass (policy=quarantine) header.from=coelacanthus.name ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733218263; a=rsa-sha256; cv=none; b=dlW3tZBDV24w4Scib4GKQpqjoGA3byO9bY6R+odNv+KXh0XhGCSVDqOFd7CpcRoA/lEzvQ FGfrlTpfxrajmTNy8gSpW7AJaexrHfzw8gJIqjNgG0yNT3ufv1C6t+ddIMtuxPGLprXNNV nkIOPn19MadEhDtntB1D+1IDqTqmawA= Received: from phl-compute-04.internal (phl-compute-04.phl.internal [10.202.2.44]) by mailflow.stl.internal (Postfix) with ESMTP id 3AFBB1D40996; Tue, 3 Dec 2024 04:31:08 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-04.internal (MEProxy); Tue, 03 Dec 2024 04:31:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= coelacanthus.name; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1733218268; x=1733221868; bh=TH5iUDtcVd 8w2RV5/BeTBVj9JapPNqfFOxuzY/m1AcE=; b=xzlU2rr4ohSa6VQcSxOxkMbISJ VqUnzWbMC2LFTIzpVR0w2szczBLATRHV5rCCJazN9RIFuYBcDRASVWcq4xeN3/Pc Ilong4t7YBu5KMLah/22yGCXn5EzpNWc6wDuyl8Xom+ploCaOcNo8xccpfGSynBr pPQRXvdhprvngNIPgq3b/oufCEcjERNwFHVdOoldJCA1BqpSanWWtjWT7vuM2/Rf fl3Eyijrnyc6bLS0EC1Mte2DLG7Yt/RKLGJ28BIMwJpUxSjcGMiwr/9SIwJceanK LR0kxxI6AWLwKF3/owfuagxLcABmE/dFKAMdUX4qs17tq5l1Mse5yFgUFzPg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1733218268; x= 1733221868; bh=TH5iUDtcVd8w2RV5/BeTBVj9JapPNqfFOxuzY/m1AcE=; b=z jkgOXnpDfYS+02R02SbuT0WWLpWVlRqUFduyqhIALXWk5meNkCdBpbV0/QE9fOiV nZQJszso81VuWM9c04ZnuseMb44mevydzWFNPtJqikkZ9SP0w76jVS0RCM5/1Zz+ DE/V+VBhO9WOQP0GofMo6mIGJxR4Asa8KkBE+oARPadljojA4vEiDoKkfMJCMlm9 P/hFel/DtHpk6HcDfZDyvh1FCdWcBEO0I17d1RMFnLjESsRpl5qhnhQrsKThOQqj 6oe21Hddj/utXn2kK+qTGjHmSemKTWnYMclt+YxT7FM7GFeQLrMVdDhgycTlDYzH yrRGN2uE9IdQ4N0j98iGA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddriedvgddthecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefhfffugggtgffkfhgjvfevofesthejredtredtjeen ucfhrhhomhepvegvlhgvshhtvgcunfhiuhcuoehufihusegtohgvlhgrtggrnhhthhhush drnhgrmhgvqeenucggtffrrghtthgvrhhnpeeiteejtdevjeffgfehkeegfeelkeekvdeh tdegleevhfetheejheejiedtjeegteenucevlhhushhtvghrufhiiigvpedtnecurfgrrh grmhepmhgrihhlfhhrohhmpehufihusegtohgvlhgrtggrnhhthhhushdrnhgrmhgvpdhn sggprhgtphhtthhopedvjedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepuhifuh estghovghlrggtrghnthhhuhhsrdhnrghmvgdprhgtphhtthhopehsthgrsghlvgesvhhg vghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopehshhhurghhsehkvghrnhgvlhdroh hrghdprhgtphhtthhopehprghulhdrfigrlhhmshhlvgihsehsihhfihhvvgdrtghomhdp rhgtphhtthhopehguhhorhgvnheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepkhgvvg hssehkvghrnhgvlhdrohhrghdprhgtphhtthhopeiiihihrghoseguihhsrhhoohhtrdho rhhgpdhrtghpthhtoheplhhinhhugidqkhhsvghlfhhtvghsthesvhhgvghrrdhkvghrnh gvlhdrohhrghdprhgtphhtthhopehlughvsehsthhrrggtvgdrihho X-ME-Proxy: Feedback-ID: i95c648bc:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 3 Dec 2024 04:31:05 -0500 (EST) From: Celeste Liu Date: Tue, 03 Dec 2024 17:30:05 +0800 Subject: [PATCH v2 2/2] riscv: selftests: Add a ptrace test to verify syscall parameter modification MIME-Version: 1.0 Message-Id: <20241203-riscv-new-regset-v2-2-d37da8c0cba6@coelacanthus.name> References: <20241203-riscv-new-regset-v2-0-d37da8c0cba6@coelacanthus.name> In-Reply-To: <20241203-riscv-new-regset-v2-0-d37da8c0cba6@coelacanthus.name> To: Oleg Nesterov , Paul Walmsley , Palmer Dabbelt , Albert Ou , Eric Biederman , Kees Cook , Shuah Khan Cc: Alexandre Ghiti , "Dmitry V. Levin" , Andrea Bolognani , =?utf-8?b?QmrDtnJuIFTDtnBlbA==?= , Thomas Gleixner , Ron Economos , Charlie Jenkins , Quan Zhou , Felix Yan , Ruizhe Pan , Shiqi Zhang , Guo Ren , Yao Zi , Han Gao , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org, linux-kselftest@vger.kernel.org, Celeste Liu X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=5295; i=uwu@coelacanthus.name; h=from:subject:message-id; bh=RyjBj4yqY/cnYg3J7doc5uv1ZKvB6VdgX8fYxV3Chig=; b=owJ4nJvAy8zAJeafov85RWVtBeNptSSGdL/zJ9qO8P6x3TXF5oxE8YH8p38CcwSX8i+8s9py0 fsfT7r3XYnvKGVhEONikBVTZMkrYfnJeels996O7V0wc1iZQIYwcHEKwESO9zH8z768W5XxtXWQ Vd3MvL6tb6X6EhZWSzZ/OSGQZm/0+n7LI4Z/umbeB/ZzX/4WulioQH3HUSZFxvjP+l+UCuMusYl khdnxAQC3SUvH X-Developer-Key: i=uwu@coelacanthus.name; a=openpgp; fpr=892EBC7DC392DFF9C9C03F1D15F4180E73787863 X-Rspamd-Queue-Id: CD57040007 X-Stat-Signature: jswp9te3tcf3yzdy9wdd13shk688f7ua X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1733218259-158839 X-HE-Meta: U2FsdGVkX19FXG+PEidVuRsq3li+zY1QXBNAmu5UbnaMSTThwupSm23t9oQm7OjxAaUAtmr+ylnA0+CFQzkXcqWuLKMMhOwwpCFJ3UKy+ouVTyoHSyNHyIIAd9AugHPf7Q7fxvc9WRzxlzWScTOwEgBJiJfPZIRQn9Vnqf/mjOVpJ93YaZJD52LcMGpV1lHX5w5m0u7IkSnrxs8Xmh7v/nft/6lpevPXR2JsL008+8uP3CPxlfxQSHp3FYgdtRjjmbQPocbPtNvSpOKmtKxNjFHU/E6TcbJ4qOzdFXxTv/9ZFUapmPWjLSoyUP4lP80LxAoDY/KHTyt7M0GJ6hp3rw44qUGEYSg/ENKAitmvidY5ixdTpGAJ/U8yhPLjfxF7Is6ZVGjK46h6BM6YQM3kdgfhyjgzcvP0ohMHIMdvohB6UjHyDirU5MVjn8qSn4HiVZFNZXN8WrcMk86gt+20YBBWCAgGvv4YAzH9hjA+LVfJiN1BH4QyEaduCMhiweNW9BJyrDdLFjSkmcjAV4yfBMJOX2Ru/h9qrvZni9uxTtkhrqRpJxEJnjvudVrKR9NBsMSSBXAfABxWJtvCvlTcrsEbQtNKa1V8aBQg0RwE9g6+juf8VG1mesGEVO8okqVd/TlpmHnmCJx1UiHLrBO8K5fSxxCrQNP9WrXEIKjKxzRQbDdiZJ2HxMpiZxRF/Bd1c/ZkeDwnpn//z+/G57+UKjr9cEHvIbTYAARMgfx92mVDKFGNB3hve/g6Yo0BIVFDL22BOVUOTENvMYBXvJBMidRI4nVButM/8bUmNSJzWxJn5wSKPMZC5+ixyW6PUZm3dPIi7ifTXqEPf7C4ERW+su1JQ44JYwflLKgSULZZbBQa1MX6paK44CXr62YvvZafuDaVcjgmpW+JO8PV0F6w1Pf6ydqqivczNictAsPmm/XWfplz1iCubmPYx2heMUhRVWGqKpViiYl5a/JjqDp htLdvKAF YFmFuAupGbk+bss4rdW/0s3QFy4RUU1u6Ac9m8Utw7Rh6iIwxtJHyv71rsmCRv8yJgvcpXosI81ZzKGsYJqK5SctsnUnHqweWBSeBrY9ZXNqbSW1ARELVICcNGZ8DHzq75APxN1rfl04XQEBp4LRpB1aUCGvPL5DIwV+ARIOQ+62M8T+5L1Jtm+atpzzF8kbSSbIlA92HelVucN8zWuHw5WwiQO8FAEeS80FAj0c31fiPcKkLWfgW3dlV3gjaLbrZN4AsZ9j7dIlscdIiFo7sVkcwQq4noDCOviRBFQs8d32xy1qh1bxfzbaEtPJ+0FefTgSMKNuYUSxUuzJzwQlVr69fM90VevI7kpwPtdCJVHCr3kbfMxxoZ4HpM8EN/EVE7y/ldhH7BRa3l1Umi5m83CUg/CD3bu6Lq2LvXeUMazuJJwZ3mxZSJ4dRwlxqDTuPuOZMHmu7G1zaXazZmwybcc7Ram3sP2lFtjgZkmhjIgfUrqKLNeHsbWtrrAm4ugOdUm0CQv2kBSJKJhOu2faY1v6wDw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Charlie Jenkins This test checks that orig_a0 allows a syscall argument to be modified, and that changing a0 does not change the syscall argument. Cc: stable@vger.kernel.org Co-developed-by: Quan Zhou Signed-off-by: Quan Zhou Co-developed-by: Celeste Liu Signed-off-by: Celeste Liu Signed-off-by: Charlie Jenkins Reviewed-by: Björn Töpel --- tools/testing/selftests/riscv/abi/.gitignore | 1 + tools/testing/selftests/riscv/abi/Makefile | 5 +- tools/testing/selftests/riscv/abi/ptrace.c | 134 +++++++++++++++++++++++++++ 3 files changed, 139 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/riscv/abi/.gitignore b/tools/testing/selftests/riscv/abi/.gitignore index b38358f91c4d2240ae64892871d9ca98bda1ae58..378c605919a3b3d58eec2701eb7af430cfe315d6 100644 --- a/tools/testing/selftests/riscv/abi/.gitignore +++ b/tools/testing/selftests/riscv/abi/.gitignore @@ -1 +1,2 @@ pointer_masking +ptrace diff --git a/tools/testing/selftests/riscv/abi/Makefile b/tools/testing/selftests/riscv/abi/Makefile index ed82ff9c664e7eb3f760cbab81fb957ff72579c5..3f74d059dfdcbce4d45d8ff618781ccea1419061 100644 --- a/tools/testing/selftests/riscv/abi/Makefile +++ b/tools/testing/selftests/riscv/abi/Makefile @@ -2,9 +2,12 @@ CFLAGS += -I$(top_srcdir)/tools/include -TEST_GEN_PROGS := pointer_masking +TEST_GEN_PROGS := pointer_masking ptrace include ../../lib.mk $(OUTPUT)/pointer_masking: pointer_masking.c $(CC) -static -o$@ $(CFLAGS) $(LDFLAGS) $^ + +$(OUTPUT)/ptrace: ptrace.c + $(CC) -static -o$@ $(CFLAGS) $(LDFLAGS) $^ diff --git a/tools/testing/selftests/riscv/abi/ptrace.c b/tools/testing/selftests/riscv/abi/ptrace.c new file mode 100644 index 0000000000000000000000000000000000000000..d192764b428d1f1c442f3957c6fedeb01a48d556 --- /dev/null +++ b/tools/testing/selftests/riscv/abi/ptrace.c @@ -0,0 +1,134 @@ +// SPDX-License-Identifier: GPL-2.0-only +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "../../kselftest_harness.h" + +#define ORIG_A0_MODIFY 0x01 +#define A0_MODIFY 0x02 +#define A0_OLD 0x03 +#define A0_NEW 0x04 + +#define perr_and_exit(fmt, ...) \ + ({ \ + char buf[256]; \ + snprintf(buf, sizeof(buf), "%s:%d:" fmt ": %m\n", \ + __func__, __LINE__, ##__VA_ARGS__); \ + perror(buf); \ + exit(-1); \ + }) + +static inline void resume_and_wait_tracee(pid_t pid, int flag) +{ + int status; + + if (ptrace(flag, pid, 0, 0)) + perr_and_exit("failed to resume the tracee %d\n", pid); + + if (waitpid(pid, &status, 0) != pid) + perr_and_exit("failed to wait for the tracee %d\n", pid); +} + +static void ptrace_test(int opt, int *result) +{ + int status; + pid_t pid; + struct user_regs_struct regs; + struct iovec iov = { + .iov_base = ®s, + .iov_len = sizeof(regs), + }; + + unsigned long orig_a0; + struct iovec a0_iov = { + .iov_base = &orig_a0, + .iov_len = sizeof(orig_a0), + }; + + pid = fork(); + if (pid == 0) { + /* Mark oneself being traced */ + long val = ptrace(PTRACE_TRACEME, 0, 0, 0); + + if (val) + perr_and_exit("failed to request for tracer to trace me: %ld\n", val); + + kill(getpid(), SIGSTOP); + + /* Perform exit syscall that will be intercepted */ + exit(A0_OLD); + } + + if (pid < 0) + exit(1); + + if (waitpid(pid, &status, 0) != pid) + perr_and_exit("failed to wait for the tracee %d\n", pid); + + /* Stop at the entry point of the syscall */ + resume_and_wait_tracee(pid, PTRACE_SYSCALL); + + /* Check tracee regs before the syscall */ + if (ptrace(PTRACE_GETREGSET, pid, NT_PRSTATUS, &iov)) + perr_and_exit("failed to get tracee registers\n"); + if (ptrace(PTRACE_GETREGSET, pid, NT_RISCV_ORIG_A0, &a0_iov)) + perr_and_exit("failed to get tracee registers\n"); + if (orig_a0 != A0_OLD) + perr_and_exit("unexpected orig_a0: 0x%lx\n", orig_a0); + + /* Modify a0/orig_a0 for the syscall */ + switch (opt) { + case A0_MODIFY: + regs.a0 = A0_NEW; + break; + case ORIG_A0_MODIFY: + orig_a0 = A0_NEW; + break; + } + + if (ptrace(PTRACE_SETREGSET, pid, NT_RISCV_ORIG_A0, &a0_iov)) + perr_and_exit("failed to set tracee registers\n"); + + /* Resume the tracee */ + ptrace(PTRACE_CONT, pid, 0, 0); + if (waitpid(pid, &status, 0) != pid) + perr_and_exit("failed to wait for the tracee\n"); + + *result = WEXITSTATUS(status); +} + +TEST(ptrace_modify_a0) +{ + int result; + + ptrace_test(A0_MODIFY, &result); + + /* The modification of a0 cannot affect the first argument of the syscall */ + EXPECT_EQ(A0_OLD, result); +} + +TEST(ptrace_modify_orig_a0) +{ + int result; + + ptrace_test(ORIG_A0_MODIFY, &result); + + /* Only modify orig_a0 to change the first argument of the syscall */ + EXPECT_EQ(A0_NEW, result); +} + +TEST_HARNESS_MAIN