From patchwork Tue Dec 3 08:37:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Hildenbrand X-Patchwork-Id: 13895578 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53FAAE7716C for ; Thu, 5 Dec 2024 15:30:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86DA36B00CC; Thu, 5 Dec 2024 10:19:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7038B6B011C; Thu, 5 Dec 2024 10:19:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 866C06B0125; Thu, 5 Dec 2024 10:19:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9F5026B007B for ; Tue, 3 Dec 2024 03:38:16 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5177B1205EF for ; Tue, 3 Dec 2024 08:38:16 +0000 (UTC) X-FDA: 82852995288.25.2908FFE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 24CABA0005 for ; Tue, 3 Dec 2024 08:38:04 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="ORN/g3Qo"; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733215082; a=rsa-sha256; cv=none; b=gzBKT20357UD2vtUL/cDcgFemK+14FI4Q2kt37DSFjo7p9ej4xRToOX37jte+XcdUUcweY tqI+RpKwsRAtMOrewA8MkZMGpibSHncunoCOJ9RDqRwNKXkCvnIuPJ4uMy2J8sulvTP/XB DOID90BEQk+X5rjWavRb+DQN10HzP3E= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="ORN/g3Qo"; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733215082; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=adHjUEuwXA+ANkdOzZ/yc4IEWn5pdw/yGiEpqds38YQ=; b=Iyg8YPVV8EuVHaUAFyJmKunCNkcGAH5YfonnJxi2G7nAYH4EAMx2whD90ZHJJTcQDZnMad 4rUdbUD+a7razA+JEz2/88k3PxrESZahlIhw7ofhtzFryTeDmEFulD2L5YTsELHdVE+k7L uHSyyoYwAkkmyksOlRe6w1fembnblDk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733215093; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=adHjUEuwXA+ANkdOzZ/yc4IEWn5pdw/yGiEpqds38YQ=; b=ORN/g3Qoa4oR6d/bXC+IuJ+qGBSzncqddxfYxxlpObCMQTZgcCXVWWCym26eINSG8xs2Ae /8VjKK67mGqGr2lkINHabD4QIrmCWZSlzH6nEgg/+ZC64HOgqr7/kgmEL0vf9R/69pnOqn IxVG4BtTql0DVvC7ZY9ZrH+Dxil1cNY= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-266-XLLS1IlrMmade3IZ0UMyDg-1; Tue, 03 Dec 2024 03:38:10 -0500 X-MC-Unique: XLLS1IlrMmade3IZ0UMyDg-1 X-Mimecast-MFC-AGG-ID: XLLS1IlrMmade3IZ0UMyDg Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2ED881944DC4; Tue, 3 Dec 2024 08:38:08 +0000 (UTC) Received: from t14s.fritz.box (unknown [10.22.88.109]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 870B530000DF; Tue, 3 Dec 2024 08:38:03 +0000 (UTC) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, David Hildenbrand , Andrew Morton , Oscar Salvador , Zi Yan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan Subject: [PATCH v2 1/6] mm/page_isolation: don't pass gfp flags to isolate_single_pageblock() Date: Tue, 3 Dec 2024 09:37:51 +0100 Message-ID: <20241203083756.112975-2-david@redhat.com> In-Reply-To: <20241203083756.112975-1-david@redhat.com> References: <20241203083756.112975-1-david@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Rspamd-Queue-Id: 24CABA0005 X-Stat-Signature: o34mq6por8tm9ktp575tc5hapxqm6z8i X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1733215084-27154 X-HE-Meta: U2FsdGVkX1+OC9map5wfWA15vobjb6665sle+bNQr9Vgf0ajPCm67F5gdl4AdCSz3mU7G5PFeEpjOd4pq2QLCgocXYiBw3XEj7YlneSean0SW4mOHcnAH9HoKkb0uoPVa5X1CU8PBZbMeXuCMNSnG1CSh0yCM7os7ysrZVrq1QZQD0XfVeq8L0w9pOaN2mof0zIV5OseJRqg/SNIVelndH6Gz1qJyJDCbNqvZmhKLM3+DHw5s7lCbC67QWo3SE+KOnu4zT1pkC9e4v5rV+90ngejOrZqcMzF0Ew7VkbyILpZPpdVQ3rEY8hsHf/WfZCgR866wot3tjSylCmiCIW6gBhUouM8u4bq23xETdjPdFHSGdo7StzdicYhkWw5xOEttesLwePwHjOEd1tCYmu9jeArC8hKEsuuyXxOE4AZmDTT+1E6/5/TD5jvnXkILecXbgMVKdXnQWNdvL3gZx68zT9D6yabE711m39pffxjuXyO4DFZIbwaAQAzQ0rRVPynoJk6Sw4vx8OqbtjmwbraFSETNVNJEj76i9EQMcAyLGSihl2o2wv8PiKnm2v+NZ30q/JFduqrQYHxk+ch2I1yqPx5WHO9n8xjtsH1+ri+1n+woIIm2OqJNrcAaxASx2LoyNLDciBaT3eaQa/QQEKIt07R3yhfOHlztQvIP59HCrUJVFqbkAn4oyi6CY+u7n/w378EmuTtR3EdkRvMZtBkNnarqPOXLj882q6mDfUPh0HuJ2HHf9CW0jCI4f32UWsh+9GFAsyK7JmhGfl5oWLQoIu79b2MNAWZzZY7fC2eoUQ4yGVyYJP92uN7IFZIt0jdqE510E4FhaKmHnmk8EAekmYZm276oeO2ELCD1fgFujUvLUXzE7Ta1GXj4DUQV8E0bAw7Km8qtloO9/H33p6yjAdulUB/WTX4IyI0dBnU0gTFLMUerrwgZJ6D38MoPZEpFKRoumaSAK1KNZxhw0J tshmrSuq K2sG5ebyW6lYjHoDOLP14sKaWF4CPJaj9zhXh3JFw1o97YWtL4w+fmltqpFzmgnBLH2ufiz5tTo+TeaZP0AFKFtxufZm5M87Cgn+1NQFMCv76RN+fnmWxOtnvY/8bYuybCpNyLSRyxP84AoVvcjG8SeLgExdNu2FKiEU53XhNUvaTBJQwxHIiaMo5KNUaiE2DmllC8iW7ZWwdd860+FgNjzqoCmVvLdaqLGOGbluwaZFblzRKKOmJPXn7eDr2M0Yw7qoqV/erUxmTrnMdQ/+Uu5BCpZiWO531Q36/8irLyUJg/0h9In712jGCY6ipnoFMeOravpP97xTRZkdWVHEP6AHF3VKs7itB1rwcnVrSW1dKua7jSYKh0tLxjqQHPPZH4OXo2MIvSYmj1ru7ZaNlXe+zxMEp7WNkSXos02+HK4H/a1o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The flags are no longer used, we can stop passing them to isolate_single_pageblock(). Reviewed-by: Zi Yan Signed-off-by: David Hildenbrand --- mm/page_isolation.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/mm/page_isolation.c b/mm/page_isolation.c index 7e04047977cf..e680d40d96de 100644 --- a/mm/page_isolation.c +++ b/mm/page_isolation.c @@ -286,7 +286,6 @@ __first_valid_page(unsigned long pfn, unsigned long nr_pages) * within a free or in-use page. * @boundary_pfn: pageblock-aligned pfn that a page might cross * @flags: isolation flags - * @gfp_flags: GFP flags used for migrating pages * @isolate_before: isolate the pageblock before the boundary_pfn * @skip_isolation: the flag to skip the pageblock isolation in second * isolate_single_pageblock() @@ -306,8 +305,7 @@ __first_valid_page(unsigned long pfn, unsigned long nr_pages) * the in-use page then splitting the free page. */ static int isolate_single_pageblock(unsigned long boundary_pfn, int flags, - gfp_t gfp_flags, bool isolate_before, bool skip_isolation, - int migratetype) + bool isolate_before, bool skip_isolation, int migratetype) { unsigned long start_pfn; unsigned long isolate_pageblock; @@ -489,7 +487,7 @@ int start_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn, bool skip_isolation = false; /* isolate [isolate_start, isolate_start + pageblock_nr_pages) pageblock */ - ret = isolate_single_pageblock(isolate_start, flags, gfp_flags, false, + ret = isolate_single_pageblock(isolate_start, flags, false, skip_isolation, migratetype); if (ret) return ret; @@ -498,7 +496,7 @@ int start_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn, skip_isolation = true; /* isolate [isolate_end - pageblock_nr_pages, isolate_end) pageblock */ - ret = isolate_single_pageblock(isolate_end, flags, gfp_flags, true, + ret = isolate_single_pageblock(isolate_end, flags, true, skip_isolation, migratetype); if (ret) { unset_migratetype_isolate(pfn_to_page(isolate_start), migratetype);