From patchwork Tue Dec 3 09:47:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Hildenbrand X-Patchwork-Id: 13892059 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF890D7833F for ; Tue, 3 Dec 2024 09:47:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C8FE6B0083; Tue, 3 Dec 2024 04:47:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 474426B0088; Tue, 3 Dec 2024 04:47:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2ED4F6B0089; Tue, 3 Dec 2024 04:47:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 071446B0083 for ; Tue, 3 Dec 2024 04:47:45 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B4D281C5478 for ; Tue, 3 Dec 2024 09:47:44 +0000 (UTC) X-FDA: 82853170260.19.61DA640 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 9FAC04000E for ; Tue, 3 Dec 2024 09:47:32 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XUNmqTrs; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733219256; a=rsa-sha256; cv=none; b=mZBjtSqflyFg/6+IPh5J0jJRRg3HQrPpTqO8RrprzsvDAGCD255Z94w9N1jpVJhZzXmJ0+ 67WPuhduCGdAp74QhMdjANgOSZRwJ+CD9EVEa8o1OBPWdOFCIF6+hIEj3p2vmxbJpWR9Em GXc8Q2A2Ni4CCTHPPHeGVsyoVm59hNw= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XUNmqTrs; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733219256; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=adHjUEuwXA+ANkdOzZ/yc4IEWn5pdw/yGiEpqds38YQ=; b=F0A37gy9uJ9J1enne/7DY5IQdLA5SOipWJtpX2DMwj6gNUoL7A31TYFS7YjL0Qs6rpSrGc zsIkTr7BMccIsWOGiy3/iau2bQ82TzbfBVwdZ7lQjKuMJtIYfQu0/Pta6gO8bdOH3DW0a2 ru0KQaX1YUxgfqq/GwGrJc6UwuYww00= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733219261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=adHjUEuwXA+ANkdOzZ/yc4IEWn5pdw/yGiEpqds38YQ=; b=XUNmqTrsi6ukvMK57jg6ANDctacaG9P9v6y7jj/FRpHdcx9D7LPspUV/J/J+Vul5LHodNN rNLBf1xlCJuPaZAL6eWDKnER6sbXPBwPRakiEcxCjqhRFibWf+SQw/9kAyUygBDBqFEiFH 4R20B7epFFWAhnwHhi4r0i1eTu1hkX8= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-232-jyiZkeuBM1mNXeze5puC1w-1; Tue, 03 Dec 2024 04:47:40 -0500 X-MC-Unique: jyiZkeuBM1mNXeze5puC1w-1 X-Mimecast-MFC-AGG-ID: jyiZkeuBM1mNXeze5puC1w Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43499c1342aso37401125e9.1 for ; Tue, 03 Dec 2024 01:47:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733219259; x=1733824059; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=adHjUEuwXA+ANkdOzZ/yc4IEWn5pdw/yGiEpqds38YQ=; b=jJ5JYgDsUGR6K5jZxgsAT1tM/LzU5PyzNVFS7tXixwpbRjHjmHUCVXuvVlNt3R8mV+ 5WsTtybFnHac4Ma4W3IIRFNb04xKsAhkRXMkwS1YvUX+YlLJFMlnsIVPTyBEQxUHLKgJ Slsm6GQYhZ42sWBoN4mZKcjhLL/eYPB1QLdD6yZtR6e2t2NaacUuXsPLYWZeSTAH1jZD i7dZviDYbEcl+TxaqLHYmToxpG1pyCX6hS0xiBpgSBaAhebQ+QcdIEStQNdNqyIpTSgc 8/n4cStcHivdVtgYgnGBlrF6oDuscn9jezo9RsVqUuMdlpVE32b1nrO8oCvbhivu/fNU cIrA== X-Gm-Message-State: AOJu0YxcCV1AaJlaRr1Hy6KhjFhzgA3ONn5Mkk8e1m2+funenUgG1baN JtJK4sfBSqzozG3Y+9cWXuxIMrYRpJnwbTJtBnKHia7gvk8t4OK5IeOYbLIb3233k/TK2UW8p7r hhUL8v0flcaq0dIgzMah2EI7bPOp2ZCwwVXP+cjn+Gx+f5xE5 X-Gm-Gg: ASbGncuwRn2tl7jfejXZcnVsyYtN1K/Afva66AKgqwt0NSU4KwZLsm+9B++yTyHwF7w S6c57B1jYN4Gy0aczOEuJ33suGg9abcm2xrbmo9btbMtBi2ebQkzP/O5nrmYMoyOfLzvyzfwQ6I nvhuACneZORDR05oJEfBYOMlwrvUoedaK6OMMxOUWujYwzbKoW5V9CXP4ve1Hgh07Tzcaqb96b6 RTWskenSmnqmcHapg6othyDDwwVJ1JKUohqm/4FOP52GqfZCVaGUXZMl/KBtJ9okyrQniXqOgLY NlnBsKbESIQ1Ek76ysZCPrToGX78UFZNEDU= X-Received: by 2002:a05:600c:19d2:b0:434:9dfe:20e6 with SMTP id 5b1f17b1804b1-434d0a03be0mr13411265e9.23.1733219259536; Tue, 03 Dec 2024 01:47:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IGwdCbQ2+x4fQDn4t4+UDQwQ2YQY46+IOELCndGNvUKUKqg7eAlnbIgz+QXoKcPKq7fDw8IyQ== X-Received: by 2002:a05:600c:19d2:b0:434:9dfe:20e6 with SMTP id 5b1f17b1804b1-434d0a03be0mr13411005e9.23.1733219259183; Tue, 03 Dec 2024 01:47:39 -0800 (PST) Received: from localhost (p200300cbc7461b00fd9ec26cc5521de7.dip0.t-ipconnect.de. [2003:cb:c746:1b00:fd9e:c26c:c552:1de7]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-434aa763aaesm213653525e9.14.2024.12.03.01.47.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Dec 2024 01:47:37 -0800 (PST) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, David Hildenbrand , Andrew Morton , Oscar Salvador , Zi Yan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan Subject: [PATCH RESEND v2 1/6] mm/page_isolation: don't pass gfp flags to isolate_single_pageblock() Date: Tue, 3 Dec 2024 10:47:27 +0100 Message-ID: <20241203094732.200195-2-david@redhat.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241203094732.200195-1-david@redhat.com> References: <20241203094732.200195-1-david@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 3-YlmKNT28F_CycQGd67HOL1TQ7ZwsqGwVTLqi9W6mU_1733219259 X-Mimecast-Originator: redhat.com content-type: text/plain; charset="US-ASCII"; x-default=true X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 9FAC04000E X-Stat-Signature: z4cuspjztrq9wftdwzxrbn8d4oe4z3kw X-HE-Tag: 1733219252-624827 X-HE-Meta: U2FsdGVkX1/dAisfeD1UZdPnlmBrEkIelkXuyA4O776YthgjC43iRc1/VeObfaElR66NyhZblEDk/lFRbDL04Rycp3oeVp31XOil/QrhFuMv4PAavyqxBts+3z8fTFL9EO08d2XWm2vboNdhHYOD0cCwoaHPTFmyEu+MJMJrYEaDlR558rjV65v8o9/tYKbrUqAg3wIxA7N8Am6jDC2nhcX7Z8Z7I6eUkOmlRrKId/AxL6q5o38dZKGxUskgcCP7r0YyJfouZid5tfEc6374AMYOnBk4R4u/pPoLamYq58/pqI29D20fG2fFgq+XQOuuNOK8ZNtKDBohItetMaOGYozypdVVXN6nvWVOWHmQUg+bIHAkel45aw/PzY/NDAepDeQlhpjOsa4U5ZljO0fZduavvv3qRreMrBSTmOcY1kfRLXPomR2yvPPTM/zP3EocrEUSVpoedcMuTMGAvwsJAL/kwwy4eEvAVw9Pn46LCXm54fIPqkuj2/WX777sz/S5q3YK28c9lu6DrH0MVsyLtwW+FzTakCpRIIsCP0DtSZuazsdcPU6JW9NBgfIqXjCJJ4dzqshTwJWSOCEvBuL0Y6+HSZRrPgq9LIMTVNgiVkOy98COZzWTZ4QWqqqB/cIOWfFRa3/bcsPu5ymEjsjMe3CnNMlNtcHgdeheYTVENvJM4nFfRd92//uUvoF94QTmVQZlRisQEvshrSA3fYgOtrn+c6AvEysgfb1bS2G0SRxcDhHs3lvWL5pSv0m/kMBnhE+IWuhIUn6i9oRDqMWQY1NDUeAi/dh2fZ66R1vphlQtTFnn47APX9B4IzeN4hTEXzHSrAJmb1v3AoAfZE1vHRTeqdkIVfocoD4eOU07wh68R42P2Yt0b5sricDRfHM+wl+iq9wLq/cS7z7YQSs38wCuoNd4YhG41LAAyBrKllHvM/VB3pucrJPlTbWf74rQGUv3k+s7N9fwdRt9kJC TV8mNXQ5 Kc71L7sKIVHgdpDdzFUKm+ygDmeZ1l7zaUVGCjuJeBGkC2IyAsYr8KX9gX8Qh4Jgi/dHAf+9bhRTdRQlfNf5T8lmx+Xi8b7axcbRW5Oz4lhtkA67iuR3hUR4bVPW7/gmpGSRXNg6UyxekcjpL8LepL7D0ct5sh7Gud0EHrEKXUBhBt8bAaFLfSXT7X2WPSmYwK1rl9WPLszfRGf9dj6uQeij0h/VaFRMwsWygOvojp9u1RQPKpHl46TQFIQY2zppGMi2lIKjsrF00vE3uajJwYdlozlwvu3dXWrBZbHoLlME2NkUl4WlT1v9IvwkkwQcAWzCWCTG9l/DNbB65ZLzHdDzZKaM8rL6CPLV6LeR5fzvpjtZTOTNNwq4/C8am+Z42fZGe96v9L2IPZ8AxQgqyhMEFJjadpqH7SbFvAkk9FI5nFv/wMcJy5TM9GaxF3nLX+DVs2TkERGIiFzOCvHef+woLEHCXPxMXPuL6/j/sf0dVQyzjYqM+cgxpmSZu4nD8gfSx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The flags are no longer used, we can stop passing them to isolate_single_pageblock(). Reviewed-by: Zi Yan Signed-off-by: David Hildenbrand Reviewed-by: Vlastimil Babka Reviewed-by: Oscar Salvador Reviewed-by: Vishal Moola (Oracle) --- mm/page_isolation.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/mm/page_isolation.c b/mm/page_isolation.c index 7e04047977cf..e680d40d96de 100644 --- a/mm/page_isolation.c +++ b/mm/page_isolation.c @@ -286,7 +286,6 @@ __first_valid_page(unsigned long pfn, unsigned long nr_pages) * within a free or in-use page. * @boundary_pfn: pageblock-aligned pfn that a page might cross * @flags: isolation flags - * @gfp_flags: GFP flags used for migrating pages * @isolate_before: isolate the pageblock before the boundary_pfn * @skip_isolation: the flag to skip the pageblock isolation in second * isolate_single_pageblock() @@ -306,8 +305,7 @@ __first_valid_page(unsigned long pfn, unsigned long nr_pages) * the in-use page then splitting the free page. */ static int isolate_single_pageblock(unsigned long boundary_pfn, int flags, - gfp_t gfp_flags, bool isolate_before, bool skip_isolation, - int migratetype) + bool isolate_before, bool skip_isolation, int migratetype) { unsigned long start_pfn; unsigned long isolate_pageblock; @@ -489,7 +487,7 @@ int start_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn, bool skip_isolation = false; /* isolate [isolate_start, isolate_start + pageblock_nr_pages) pageblock */ - ret = isolate_single_pageblock(isolate_start, flags, gfp_flags, false, + ret = isolate_single_pageblock(isolate_start, flags, false, skip_isolation, migratetype); if (ret) return ret; @@ -498,7 +496,7 @@ int start_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn, skip_isolation = true; /* isolate [isolate_end - pageblock_nr_pages, isolate_end) pageblock */ - ret = isolate_single_pageblock(isolate_end, flags, gfp_flags, true, + ret = isolate_single_pageblock(isolate_end, flags, true, skip_isolation, migratetype); if (ret) { unset_migratetype_isolate(pfn_to_page(isolate_start), migratetype);