From patchwork Wed Dec 4 04:01:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen Ridong X-Patchwork-Id: 13893197 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6C2FE7716D for ; Wed, 4 Dec 2024 04:11:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C6D2C6B0089; Tue, 3 Dec 2024 23:11:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BF59B6B0082; Tue, 3 Dec 2024 23:11:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A6D026B0088; Tue, 3 Dec 2024 23:11:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 858406B0082 for ; Tue, 3 Dec 2024 23:11:45 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2B9A11A0DB4 for ; Wed, 4 Dec 2024 04:11:45 +0000 (UTC) X-FDA: 82855952508.21.4F8EEB7 Received: from dggsgout12.his.huawei.com (dggsgout12.his.huawei.com [45.249.212.56]) by imf14.hostedemail.com (Postfix) with ESMTP id 4ADB4100006 for ; Wed, 4 Dec 2024 04:11:24 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of chenridong@huaweicloud.com designates 45.249.212.56 as permitted sender) smtp.mailfrom=chenridong@huaweicloud.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733285488; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ojpckztn+9G/aqX6Q6yDKdiZaMbLAGJ/vUemSTZYfhA=; b=Urtic2gKEXJx5KXk/cwZLP+ASbuC23LXWZkSE2bWj0NniCeNx7QpNvMjHocQncmv93fk/8 1IeD7Vv8KlRgzQvOM01aZKSxqIL0yv4PAX0djqyaIoDddJEOaKTnd6kOoIQJIFstzA+P+l /Oyn6SOCmzAvWTN8mPsWkMv7vnRFxKE= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of chenridong@huaweicloud.com designates 45.249.212.56 as permitted sender) smtp.mailfrom=chenridong@huaweicloud.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733285488; a=rsa-sha256; cv=none; b=OgdzV4aOLuIeKsRKF7C4r5CMjGZBmgt1CHrCcE+76khLIYOFk0myzOgYLy4gIu5lhF50jg QsQMULKCmdV2nWQZ6s/b6EZ8WmcV1G8QsdX6Rg7arvYNnF3GmjgEbd3Yz+Rqh+Frr/TwrN QjZn0QGCdQeC2aj66xXmAu7PNaDnFlA= Received: from mail.maildlp.com (unknown [172.19.163.216]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4Y33x01Twrz4f3jXK for ; Wed, 4 Dec 2024 12:11:16 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.252]) by mail.maildlp.com (Postfix) with ESMTP id 347E31A0197 for ; Wed, 4 Dec 2024 12:11:35 +0800 (CST) Received: from hulk-vt.huawei.com (unknown [10.67.174.121]) by APP3 (Coremail) with SMTP id _Ch0CgBnQ8Bt1k9nusICDg--.38617S3; Wed, 04 Dec 2024 12:11:35 +0800 (CST) From: Chen Ridong To: akpm@linux-foundation.org, mhocko@suse.com, hannes@cmpxchg.org, yosryahmed@google.com, yuzhao@google.com, david@redhat.com, willy@infradead.org, ryan.roberts@arm.com, baohua@kernel.org, 21cnbao@gmail.com, wangkefeng.wang@huawei.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, chenridong@huawei.com, wangweiyang2@huawei.com, xieym_ict@hotmail.com Subject: [RFC PATCH v3 1/2] mm: vmascan: add find_folios_written_back() helper Date: Wed, 4 Dec 2024 04:01:57 +0000 Message-Id: <20241204040158.2768519-2-chenridong@huaweicloud.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241204040158.2768519-1-chenridong@huaweicloud.com> References: <20241204040158.2768519-1-chenridong@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: _Ch0CgBnQ8Bt1k9nusICDg--.38617S3 X-Coremail-Antispam: 1UD129KBjvJXoWxJw48JF4ruFyfWr4rAF18Xwb_yoWrJryUpF Z3KrnFyFW8ZryagrsxXF15ur1YkF95Xr4UJFW2kr4xCF15Cw4UKrW7Kw1UJFW3GrWkZF1S qw1UWFy0g3WUJFDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUPYb4IE77IF4wAFF20E14v26rWj6s0DM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28IrcIa0xkI8VA2jI8067AKxVWUGw A2048vs2IY020Ec7CjxVAFwI0_Gr0_Xr1l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxS w2x7M28EF7xvwVC0I7IYx2IY67AKxVW5JVW7JwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxV WxJVW8Jr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_ GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx 0E2Ix0cI8IcVAFwI0_Jrv_JF1lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWU JVW8JwACjcxG0xvY0x0EwIxGrwACI402YVCY1x02628vn2kIc2xKxwCY1x0262kKe7AKxV WUtVW8ZwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E 14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_GFv_WrylIx kGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAF wI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r 4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07j0xRhU UUUU= X-CM-SenderInfo: hfkh02xlgr0w46kxt4xhlfz01xgou0bp/ X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 4ADB4100006 X-Rspam-User: X-Stat-Signature: iygwxbdu8w8nbn6eu6sw1k76zm89sida X-HE-Tag: 1733285484-489014 X-HE-Meta: U2FsdGVkX1+x8RmM8ljxMMZQCYCkSBMi7WVZaQsxcyY0BPKX4WNEl4986JLInhURg9QuwGXe7P3geNwbpYAT81v1rkipB9fZM6CjGONBNnO9asqKSxpwVrDWVHeICqUvpTHi5rcyO2K14/r+IQmos8TrcukoJAKTnrjvBKabnG3TFHi4dPK7Zy30HyK+hhMGaEVJY2AuKXrOMjtaUQit9U98WS9kfYGKAN35BeRhVqfNmNEGBcoloPnh2L5h+4ptem93PKn3wT5gmYfwxNoSAtJNyc1hmSw/1SG5C3KtSYCF1/Ny8nDqbboStv2/teMJ54fhfvLkYD0t0CHw/NzbLXfGJeJozTEFy5t5q31hMVLu3J5LdUeL92hHnTBW8aIeC3Xy5X/bZPiFTL1nzWtmMQSNccq/M+MfKnrhs1rMtvcazAlgiHu0aZO47s7wM5giXWeaIadEP2gwwrGgLsF5q+t/AVIaQwdc38k6wBh+dFT3WeRQ/4zidtdeZGQaGHrOW4cxfupDEm/Qf8jBXkhFFeXGxmPYkdr6/VvYfX3nXVNuQd9HAzqIu9q1B+1uX4dEi2cVhJg0Lyn2zN0au5GNQBkT7olLWA/B5JA3GycUG4lisGXL740/MrvOmS0JV2yUJQVJCb7j1Yz1Lns5argdAvi92M/TpuSjZ6smlNZ+FUtRlFndA7BGA/MGBx4jSeoaGa+lP+grQpuSnnM/BKN1egeuZGmtAgP2m1MFG9xC2FbpujNWa22Wv1vk0/CvJKmGFLjFWyA3f7rvSG8A/QW5W6pz58BGlXCIkUMr0ywn9Iu5XVwoigkQdL9te3KVo+E5Y096uraD0E9HjHtJE8oV96Bzzbrg1DCHPD9UdZw3BMty3Sy9Q4jUydVkeAQ2UpVE0bFiji0fbQXmRfb9I8CeKb8li37Vi5ZCC01yDbBgzHfcv/VdYjRjlptkWH8J0cx1lub9r2AdMMS8g5Obe5z yCde09ob Citl8fL5Q084wdasJsXrdJTSHjXaZ5BC5DJ5i7ZRQUYCpixG9YQaGi0V5nMbWzrjxL5p15RFW4rVsjxzFUDaayIRQk77xuw3O7ztG0gCGWNyUacnjBx096FVYcdXweCldELZMSq0Owf8rmMYVTYUXS9h0UlF4q/i68chJooVV9G0zgBdW5pa9ZsVpnA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Chen Ridong Add find_folios_written_back() helper, which will be called in the shrink_inactive_list function in subsequent patch. Signed-off-by: Chen Ridong --- mm/vmscan.c | 73 +++++++++++++++++++++++++++++++---------------------- 1 file changed, 43 insertions(+), 30 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 76378bc257e3..af1ff76f83e7 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -283,6 +283,48 @@ static void set_task_reclaim_state(struct task_struct *task, task->reclaim_state = rs; } +/** + * find_folios_written_back - Find and move the written back folios to a new list. + * @list: filios list + * @clean: the written back folios list + * @skip: whether skip to move the written back folios to clean list. + */ +static inline void find_folios_written_back(struct list_head *list, + struct list_head *clean, bool skip) +{ + struct folio *folio; + struct folio *next; + + list_for_each_entry_safe_reverse(folio, next, list, lru) { + if (!folio_evictable(folio)) { + list_del(&folio->lru); + folio_putback_lru(folio); + continue; + } + + if (folio_test_reclaim(folio) && + (folio_test_dirty(folio) || folio_test_writeback(folio))) { + /* restore LRU_REFS_FLAGS cleared by isolate_folio() */ + if (lru_gen_enabled() && folio_test_workingset(folio)) + folio_set_referenced(folio); + continue; + } + + if (skip || folio_test_active(folio) || folio_test_referenced(folio) || + folio_mapped(folio) || folio_test_locked(folio) || + folio_test_dirty(folio) || folio_test_writeback(folio)) { + /* don't add rejected folios to the oldest generation */ + if (lru_gen_enabled()) + set_mask_bits(&folio->flags, LRU_REFS_MASK | LRU_REFS_FLAGS, + BIT(PG_active)); + continue; + } + + /* retry folios that may have missed folio_rotate_reclaimable() */ + list_move(&folio->lru, clean); + } +} + /* * flush_reclaim_state(): add pages reclaimed outside of LRU-based reclaim to * scan_control->nr_reclaimed. @@ -4567,8 +4609,6 @@ static int evict_folios(struct lruvec *lruvec, struct scan_control *sc, int swap int reclaimed; LIST_HEAD(list); LIST_HEAD(clean); - struct folio *folio; - struct folio *next; enum vm_event_item item; struct reclaim_stat stat; struct lru_gen_mm_walk *walk; @@ -4597,34 +4637,7 @@ static int evict_folios(struct lruvec *lruvec, struct scan_control *sc, int swap scanned, reclaimed, &stat, sc->priority, type ? LRU_INACTIVE_FILE : LRU_INACTIVE_ANON); - list_for_each_entry_safe_reverse(folio, next, &list, lru) { - if (!folio_evictable(folio)) { - list_del(&folio->lru); - folio_putback_lru(folio); - continue; - } - - if (folio_test_reclaim(folio) && - (folio_test_dirty(folio) || folio_test_writeback(folio))) { - /* restore LRU_REFS_FLAGS cleared by isolate_folio() */ - if (folio_test_workingset(folio)) - folio_set_referenced(folio); - continue; - } - - if (skip_retry || folio_test_active(folio) || folio_test_referenced(folio) || - folio_mapped(folio) || folio_test_locked(folio) || - folio_test_dirty(folio) || folio_test_writeback(folio)) { - /* don't add rejected folios to the oldest generation */ - set_mask_bits(&folio->flags, LRU_REFS_MASK | LRU_REFS_FLAGS, - BIT(PG_active)); - continue; - } - - /* retry folios that may have missed folio_rotate_reclaimable() */ - list_move(&folio->lru, &clean); - } - + find_folios_written_back(&list, &clean, skip_retry); spin_lock_irq(&lruvec->lru_lock); move_folios_to_lru(lruvec, &list);