diff mbox series

[2/2] mm/damon/core: fix ignored quota goals and filters of newly committed schemes

Message ID 20241222231222.85060-3-sj@kernel.org (mailing list archive)
State New
Headers show
Series mm/damon/core: fix memory leaks and ignored inputs from damon_commit_ctx() | expand

Commit Message

SeongJae Park Dec. 22, 2024, 11:12 p.m. UTC 
damon_commit_schemes() ignores quota goals and filters of the newly
committed schemes.  This makes users confused about the behaviors.
Correctly handle those inputs.

Fixes: 9cb3d0b9dfce ("mm/damon/core: implement DAMON context commit function")
Cc: <stable@vger.kernel.org>
Signed-off-by: SeongJae Park <sj@kernel.org>
---
 mm/damon/core.c | 5 +++++
 1 file changed, 5 insertions(+)
diff mbox series

Patch

diff --git a/mm/damon/core.c b/mm/damon/core.c
index 931e8e4b1333..5192ee29f6cf 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -868,6 +868,11 @@  static int damon_commit_schemes(struct damon_ctx *dst, struct damon_ctx *src)
 				NUMA_NO_NODE);
 		if (!new_scheme)
 			return -ENOMEM;
+		err = damos_commit(new_scheme, src_scheme);
+		if (err) {
+			damon_destroy_scheme(new_scheme);
+			return err;
+		}
 		damon_add_scheme(dst, new_scheme);
 	}
 	return 0;