From patchwork Tue Jan 7 15:14:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Patchwork-Id: 13929148 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87897E77199 for ; Tue, 7 Jan 2025 15:15:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D2CBC6B00AA; Tue, 7 Jan 2025 10:14:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CC3DB6B00B3; Tue, 7 Jan 2025 10:14:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1B466B00AE; Tue, 7 Jan 2025 10:14:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6BDB86B00A8 for ; Tue, 7 Jan 2025 10:14:59 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id BEE691A0A2A for ; Tue, 7 Jan 2025 15:14:58 +0000 (UTC) X-FDA: 82981003476.25.0E5BE5C Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf16.hostedemail.com (Postfix) with ESMTP id D660B180002 for ; Tue, 7 Jan 2025 15:14:56 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=xEDYdNyQ; dkim=pass header.d=linutronix.de header.s=2020e header.b=gvC+B3rW; spf=pass (imf16.hostedemail.com: domain of t-8ch@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=t-8ch@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736262897; a=rsa-sha256; cv=none; b=8bfbtQV1EsMA3VW3KtBssUPQMGo8axzDNRbwuhqDbXiNZDZIs7HKMtmktC3P4ZtWmP80fw 5fbyNvZnx+tyHO017MT6kwr8nQ27u9Dzd+5aGULkurs/zTJmV0e/XwcgLei0m0QjKPw/US +ee000aUWwmVuPEYGSDof4hPrc7lH30= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=xEDYdNyQ; dkim=pass header.d=linutronix.de header.s=2020e header.b=gvC+B3rW; spf=pass (imf16.hostedemail.com: domain of t-8ch@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=t-8ch@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736262897; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8MKnoaEM2eqbdSEIwek8NUSxcpZg/joWFCsMXcOwV8g=; b=2sHc57b6APEEzHJ8McHv9VcNHrfqiNsSVR0sw+Lrh/QoxQ+/aLBKGWTOHSQYe0WHBmBINX DA2z3kJX9ilvb822VjPAedQWl3i4rYk1v65q2PKK4DIgnqIvhrjD/GrS617ntvw5eSWXzQ xwLEGdYkQNFv4s2A1Z8DR87bobuWEGs= From: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1736262894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8MKnoaEM2eqbdSEIwek8NUSxcpZg/joWFCsMXcOwV8g=; b=xEDYdNyQFc4yS3PKefVEYJImsRrGchl4NLvK5u9X9qhOqvFW0G8VLPI78Rjead8YUOib7I Cp8hXOE3hKfi3pGrlSwNvoMarO0cVNB/hlBoNDcidAlhPn8zfBVPZMEumYRVKnJG6v7r69 /sbhJ9/tTdWWjHy1D9E9Z67acXtbk0Vkpa6xtZwN35JQF/OTHRjXiLsszzHJrESKwQFzPA q+diYTEMhS26YnqaIgw+K0ZgP+4dbsJ68AuO0J5YuIfuwT7Qw6M6ifzRdko4FroLMVxl0n vGVrRQt5L8ZAA1neAL/nD3gHTMdNEWDFagGE5zt1sgYCSdOluSJtGwYEODQd4g== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1736262894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8MKnoaEM2eqbdSEIwek8NUSxcpZg/joWFCsMXcOwV8g=; b=gvC+B3rWXyc/qxMwaqaSZObNNe1xvWwv3/CKHVVFYl2ybnP1xfbZCjm2f7hlL4ynU0ItoI bCMQv5vsaVEyHVBw== Date: Tue, 07 Jan 2025 16:14:45 +0100 Subject: [PATCH 1/3] selftests/mm: virtual_address_range: Fix error when CommitLimit < 1GiB MIME-Version: 1.0 Message-Id: <20250107-virtual_address_range-tests-v1-1-3834a2fb47fe@linutronix.de> References: <20250107-virtual_address_range-tests-v1-0-3834a2fb47fe@linutronix.de> In-Reply-To: <20250107-virtual_address_range-tests-v1-0-3834a2fb47fe@linutronix.de> To: Andrew Morton , Shuah Khan , Dev Jain , Thomas Gleixner Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?Thomas_Wei=C3=9Fschuh?= , stable@vger.kernel.org X-Developer-Signature: v=1; a=ed25519-sha256; t=1736262892; l=1691; i=thomas.weissschuh@linutronix.de; s=20240209; h=from:subject:message-id; bh=pkeSpzoPWHY8BsliSFSfbcQRoHvGqOoQKWjNi/5v8ic=; b=Q7U4tGUxDzcEKeBChx8jtgkcq7Wge8kBvCoqMUZT2oi/Qti7jPY0onQ2kqHsunfb2jqdfU1hz sAu/mvAzojZDkvqBTlCrLkZo2WWSwciE2YoG/u+CTP/BwDRiXqX58/F X-Developer-Key: i=thomas.weissschuh@linutronix.de; a=ed25519; pk=pfvxvpFUDJV2h2nY0FidLUml22uGLSjByFbM6aqQQws= X-Rspamd-Queue-Id: D660B180002 X-Stat-Signature: fwuj7ga6mmgf3w98ic4hx5ha54k31yni X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1736262896-564669 X-HE-Meta: U2FsdGVkX1+l0lND5Hv72/ZQfHJZqwSquIhILHvCOkI6gBW6IX2jozlYZH6BEO+OWRDs1ab6780J5OpfCneRQej2u3EN6MrzqErvAkve2snF2cyq67Sf+/xrRFItOixx9IZtK9+2BHFcRC1Hz0kNQr8xaXWXiBXBdaRCmny9nYzu8a1aK5Rw3EGNGi4z02NtdRB/pQfs/a0WmvJGhtxEkOECwyqs3wsO1gevPeUtNswJ47cQfTOEAMifMgTrvSHRvithy9ioquJQENiSHyqv/Ce7JL7jtb0aXxo32bp0CSOxMnIVE4dNV4VdQ/0DjiZpjAPo0ZvLlnBCB/p3cHzsQ9R7wOewel07vRiptA+klLvjcj63ap4jOwvZ2eutVqAbuJCQ0mBnGMSoH8GXd3UlrcCTpvMB/TizF68iOse86scd3ZkmClEBjTOMPhw175ll8x2yPWw2e9ZaZJVu4AKtHp7FRS61wIN72dYaXi5A+aO10NZsyeN0AxyDv5JP7yzkTx3j1bEPCzfD9z/DLlZwhejGScphQGDLPkif70HV1CUF3O9p0zkdiKRQCeaCEE3/3SHzeS9fV8ZWT/WOQ7tDTOvXp1hbOttYcBGp+XOELT2MQFSyW8ZX6BABPkhH9EJRscRXYPF/b4qwK/167/2uILx+bfu05VQahIQTOC/pV470FPCJUGLOTgjIeisAvu5431n4jakYCjKF3kIiOKFP93+AyM7mQjcVDKUl50cqWTrTf55iiBpOm0u9sJjn8T2Tr0rpHnFIdw95/QKc9rKEi0tpcqiss3ugCr1QMkfcjiR91/nZcOldHkEyhzWJkB0LUvfTzu9H5Nenx1RRCOhvvNlbEUHwc7nMyUTJCvIGBGRabX3FASf6q77/84OXg4cfH1zQK/Xizvhi4xFVvc0aK5/Z+KofbCRG9pof8RE6ikgv1hkQDS9YnPLAZzSKM6RFj0ZRuqLmb/WMCH25pbR TQZ/svNy 4hhBbzUm05XGtYCC6jS9JlhrVtMB2+DEQanHzXzIE31BjX5zVeRhOnu0C5dHRpr0qE5ife7BFS+OUdeqxOTexUbkitEkBa4p8c8kQo+lGDO3xcsfoy/v2+ml2my9PQ2ZHvAs/wBEeFT1C8zhP+hUmNhe6HYbOY/N/A6ngN6ufnYe+sJnU1iG/WLbnHoM+wCX1bjL3AcRV/oBTAq7oHZ2N9rzau+95jWyqImdikd45bNK91VGEtoA5eUSc6TyUgufuHjYNAOCZqfXoIyX45dX2erwMqCSN9SaIOUWx5UIXCPQ8zXnWreDR02fI5OHfF+f6zZojoiXNhve9TnoBQa8yeUu/qbfrq4mYDWoWuNX68GKKjzovmWeIStNhHWuUgvCiNxJGcPXcCHLt42ZhQAR+88flp4M49kXJ7cy3J3p8LbZWCiZz78bMn/H9CY7IfsNTZa00W+Yc+W5h7D4WYKAsvdO186k+pm4O5U9S X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: If not enough physical memory is available the kernel may fail mmap(); see __vm_enough_memory() and vm_commit_limit(). In that case the logic in validate_complete_va_space() does not make sense and will even incorrectly fail. Instead skip the test if no mmap() succeeded. Fixes: 010409649885 ("selftests/mm: confirm VA exhaustion without reliance on correctness of mmap()") Cc: stable@vger.kernel.org Signed-off-by: Thomas Weißschuh --- The logic in __vm_enough_memory() seems weird. It describes itself as "Check that a process has enough memory to allocate a new virtual mapping", however it never checks the current memory usage of the process. So it only disallows large mappings. But many small mappings taking the same amount of memory are allowed; and then even automatically merged into one big mapping. --- tools/testing/selftests/mm/virtual_address_range.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tools/testing/selftests/mm/virtual_address_range.c b/tools/testing/selftests/mm/virtual_address_range.c index 2a2b69e91950a37999f606847c9c8328d79890c2..d7bf8094d8bcd4bc96e2db4dc3fcb41968def859 100644 --- a/tools/testing/selftests/mm/virtual_address_range.c +++ b/tools/testing/selftests/mm/virtual_address_range.c @@ -178,6 +178,12 @@ int main(int argc, char *argv[]) validate_addr(ptr[i], 0); } lchunks = i; + + if (!lchunks) { + ksft_test_result_skip("Not enough memory for a single chunk\n"); + ksft_finished(); + } + hptr = (char **) calloc(NR_CHUNKS_HIGH, sizeof(char *)); if (hptr == NULL) { ksft_test_result_skip("Memory constraint not fulfilled\n");