| Message ID | 20250109152245.1591914-1-willy@infradead.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mm: Remove PageTransTail() | expand |
On 09.01.25 16:22, Matthew Wilcox (Oracle) wrote: > The last caller was removed in October. Also remove the FALSE definition > of PageTransCompoundMap(); the normal definition was removed a few > years ago. > > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> > --- > include/linux/page-flags.h | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > index 691506bdf2c5..330929b6e062 100644 > --- a/include/linux/page-flags.h > +++ b/include/linux/page-flags.h > @@ -894,21 +894,9 @@ static inline int PageTransCompound(const struct page *page) > { > return PageCompound(page); > } > - > -/* > - * PageTransTail returns true for both transparent huge pages > - * and hugetlbfs pages, so it should only be called when it's known > - * that hugetlbfs pages aren't involved. > - */ > -static inline int PageTransTail(const struct page *page) > -{ > - return PageTail(page); > -} > #else > TESTPAGEFLAG_FALSE(TransHuge, transhuge) > TESTPAGEFLAG_FALSE(TransCompound, transcompound) > -TESTPAGEFLAG_FALSE(TransCompoundMap, transcompoundmap) > -TESTPAGEFLAG_FALSE(TransTail, transtail) > #endif > > #if defined(CONFIG_MEMORY_FAILURE) && defined(CONFIG_TRANSPARENT_HUGEPAGE) Acked-by: David Hildenbrand <david@redhat.com>
On 9 Jan 2025, at 10:22, Matthew Wilcox (Oracle) wrote: > The last caller was removed in October. Also remove the FALSE definition > of PageTransCompoundMap(); the normal definition was removed a few > years ago. > > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> > --- > include/linux/page-flags.h | 12 ------------ > 1 file changed, 12 deletions(-) Acked-by: Zi Yan <ziy@nvidia.com> Best Regards, Yan, Zi
diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h index 691506bdf2c5..330929b6e062 100644 --- a/include/linux/page-flags.h +++ b/include/linux/page-flags.h @@ -894,21 +894,9 @@ static inline int PageTransCompound(const struct page *page) { return PageCompound(page); } - -/* - * PageTransTail returns true for both transparent huge pages - * and hugetlbfs pages, so it should only be called when it's known - * that hugetlbfs pages aren't involved. - */ -static inline int PageTransTail(const struct page *page) -{ - return PageTail(page); -} #else TESTPAGEFLAG_FALSE(TransHuge, transhuge) TESTPAGEFLAG_FALSE(TransCompound, transcompound) -TESTPAGEFLAG_FALSE(TransCompoundMap, transcompoundmap) -TESTPAGEFLAG_FALSE(TransTail, transtail) #endif #if defined(CONFIG_MEMORY_FAILURE) && defined(CONFIG_TRANSPARENT_HUGEPAGE)
The last caller was removed in October. Also remove the FALSE definition of PageTransCompoundMap(); the normal definition was removed a few years ago. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> --- include/linux/page-flags.h | 12 ------------ 1 file changed, 12 deletions(-)