From patchwork Thu Jan 9 17:51:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13933070 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 904A9E77197 for ; Thu, 9 Jan 2025 17:51:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F2356B0098; Thu, 9 Jan 2025 12:51:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1609B6B00B4; Thu, 9 Jan 2025 12:51:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFECC6B00B3; Thu, 9 Jan 2025 12:51:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 149A66B0098 for ; Thu, 9 Jan 2025 12:51:41 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CF7DE42EFF for ; Thu, 9 Jan 2025 17:51:40 +0000 (UTC) X-FDA: 82988655960.04.85379F4 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf08.hostedemail.com (Postfix) with ESMTP id 37027160016 for ; Thu, 9 Jan 2025 17:51:39 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GtXAjCKQ; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736445099; a=rsa-sha256; cv=none; b=fRTAPstExvi09eG694BCN1Ov8wuNCLmu4h6XHOagdFvxtfixnGjGkNlpMzawTb3IlCa2wD j4uD3wwMZkeULspw/bBQl5cLT1Fhjam8V5Ue5pBE1JuLfzQ56cEPF0eFrtyiSpxprKoG+3 x2dH7Pcb6lfsXYL+u7hw0D9VWjOJqic= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GtXAjCKQ; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736445099; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d5J1AIHTYlUmXrjLKn82T8Uz9hRFE/DgF4ayh9KaOgg=; b=Uw3AM1tT/g7I6bTdkP3LaXOyLUbFRVQ/xvJleZy+f3o0uH6JLrxSRkNgwrh1Ox7NOOjPu4 xa0QKtQI9jhVAyzo1QsVJ9co2E/cvyWDxRx+2kp5U0BRMHjVt3ulIDfRjhxWkcuebL83v3 oA5w5Mha4l+I0FxxNd+RxI8rAEP/EL8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 621205C5CB2; Thu, 9 Jan 2025 17:50:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA5C4C4CED2; Thu, 9 Jan 2025 17:51:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736445098; bh=97I76lDfvaM6L2LOAAduyShBBxqQhcZ1zQRaRPWTvuU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GtXAjCKQhCXp6XoAzncBThz0kaOtImaAYZIh+2dMqtJca447B2ZLB0/KZW9C6EKwS tYgd4e8PzXMPQGuimjfE7awNMh+Ue58ZeG57xpCMyQgj9Kh6gXR0BDVBNTM+LDjBFS OJ35/YSQ2AYXSlV3kWJR6NeKTsjBABupqrMIQsf/CwT6x18zy1VHzoGdBwsgROPym0 2R9PoraJyf6PAvJ/fNbTJZWwcPTNCvN5Fjwgjd9xtJqZEuWf+ZvW+2KraUaTUJ64Jq 9gPoaPMLqUjH8wQRWwXOkbxtVjv2PVIlw/VdcOMaAiAePHI8bcvYQANhWKCjBlHa20 xnlIkeVQIiekg== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH v2 01/10] mm/damon: fixup damos_filter kernel-doc Date: Thu, 9 Jan 2025 09:51:17 -0800 Message-Id: <20250109175126.57878-2-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250109175126.57878-1-sj@kernel.org> References: <20250109175126.57878-1-sj@kernel.org> MIME-Version: 1.0 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 37027160016 X-Stat-Signature: mtkqz6nh7smorp4759wgt5er1g5n89xb X-Rspam-User: X-HE-Tag: 1736445099-208428 X-HE-Meta: U2FsdGVkX18EXYVsj5zzWUk2TPKJ7GdXCfRkejwc7z3XsZt22UlLRAFIUiUvMee5fez0zFNsg4/5/aIHVLAe/9NRNqSRfw57PcIMxiY3NLQ02+pPfHUhH4gSLggcKUoqUe+04Yc3ek6ooZfCr+2u38F2x+ArBgCHS3tRZhxfvl4OpuD89/VVfQ2rp2wjGaRKHFP/5xU9/7Nw/Y99nJpzKw8fhYx88wquBmXUjT1qiT2MM2gGGOb2j0Ks9SqC0hlgmgIjsKYwYXICPKTyjLXPf3NxSGsReNgqI+21974btvjtz2wWbsMqRrPisxydEJGpea+8+8XqLda3qpzw3OjUDu9M1uR7yLzSIaRqTaxZdEe1yrsKZn2AqLlOcqQmPt1PTAejurF4WUWcPKm4kR4XJq5utGTYWXPw1/5IpRK24z745i4e8InDjgl8Q83LJfbKnjoR+DjpekgCgfvSl3VJo50vdK2ORDAyqfgY5s5s9X+jM4jM79wniglJp7n6U9KGD7ZwWeq1GwIQWWKKIo+GpDnQqs/N3WByPN+NFEGwh5hd5x/A57aNiVjryXGKhc3PeALeVbpfgyr+AAuWtXpGDnW3wYXHxVAJ+FjsevsnJHb63PzQg3hrLYElvgIxVKR0W2ODy9LnpE1LHqvNGf+ukIIYiXnoX+vkgObzxJOSU8ATIzvuC5BccKQ4zwel9jVhrFZc8QnXUDf4BfI1vTskYnbL7hICpuvvNkW2dRFS6dzR5NF/P/6iruDsK7EpZ6n1NxiRJQXVGhoylQne58B8ae3zvRaxbSR5CYbW0pT+7vvbW66Sg618Rf0T1TVcQ6BVxeSVoh3tUMngr42VJmvuGl+WrPEIvHF3ZfAwrGtoqT16PJy2kUNfr9VloEViEQH2xt+4qID+FtUeb+mLBHyIXm87wpQP9ZjeQbpB7JtQ+2tgNYluA2d/YwVpVl4vmzjRqLzCdaVW8fishepSMx4 8Imxx3nK cm2mWmKkqQrmH2D6fQ3w2l5q0w8TZtNijUkFpAnl8fiI3g30cOsQilHZb/f3SowwjP/sNoWxmJXDJVaYSV7KYccHrVxFySFJ+lSpDjtu96/B3XL4Kr0qQkJWkdKzp1L25s2nBsdo7loTaBLwRBI65bpLHXs4kLwshpOV7nQzwo4GmUFKDk2MCM8EgfhMrSTcSs3LHKIavo3njhnaJ+hKMpYLuSzFalTR1t+wuHneU6a8jGwR7M2Wy6XnRfmmKtt0C9d85xG4hzrj3Z/MBLGMz6BSPgD7SnzJswMLVPHqPv8d/99NhtK8p8fGhmOs84XgsHcg+6UsBC3tdZVf/WNquNrH+4XY+XMthDIl6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The comment is slightly wrong. DAMOS filters are not only for pages, but general bytes of memory. Also the description of 'matching' is bit confusing, since DAMOS filters do only filtering out. Update the comments to be less confusing. Signed-off-by: SeongJae Park --- include/linux/damon.h | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/include/linux/damon.h b/include/linux/damon.h index 298b1a831e62..72afba74ac6d 100644 --- a/include/linux/damon.h +++ b/include/linux/damon.h @@ -347,8 +347,8 @@ enum damos_filter_type { /** * struct damos_filter - DAMOS action target memory filter. - * @type: Type of the page. - * @matching: If the matching page should filtered out or in. + * @type: Type of the target memory. + * @matching: If the @type-matching memory should be filtered out. * @memcg_id: Memcg id of the question if @type is DAMOS_FILTER_MEMCG. * @addr_range: Address range if @type is DAMOS_FILTER_TYPE_ADDR. * @target_idx: Index of the &struct damon_target of @@ -357,9 +357,10 @@ enum damos_filter_type { * @list: List head for siblings. * * Before applying the &damos->action to a memory region, DAMOS checks if each - * page of the region matches to this and avoid applying the action if so. - * Support of each filter type depends on the running &struct damon_operations - * and the type. Refer to &enum damos_filter_type for more detai. + * byte of the region matches to this given condition and avoid applying the + * action if so. Support of each filter type depends on the running &struct + * damon_operations and the type. Refer to &enum damos_filter_type for more + * details. */ struct damos_filter { enum damos_filter_type type;