From patchwork Sun Jan 12 15:53:55 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rik van Riel X-Patchwork-Id: 13936450 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43922E77188 for ; Sun, 12 Jan 2025 16:05:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C503E6B0099; Sun, 12 Jan 2025 11:05:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C00256B009A; Sun, 12 Jan 2025 11:05:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA0B46B009B; Sun, 12 Jan 2025 11:05:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 89B146B0099 for ; Sun, 12 Jan 2025 11:05:42 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 32A67B0EC6 for ; Sun, 12 Jan 2025 16:05:42 +0000 (UTC) X-FDA: 82999275324.06.41B64A7 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf15.hostedemail.com (Postfix) with ESMTP id 8C4DBA000C for ; Sun, 12 Jan 2025 16:05:40 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736697940; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pkfbYrAe1vz8YHgUn3vDEpzc3y+8dp64aUueUjHQLls=; b=UeBmttY2XfLRv+BXWB5TRFf8no6QTs8+TWnWHcCZzOzD2RfPyNV++P7pb8M8HiaLi7HKny 3AxtrKLEg/lSs6OLPOmyOwjehqG+bpftNk7PeObRQ9FDy6WFlzB+OZC/6E75HEsvtH5DNx nAwDcQccIuxI6PmnMxUozYdDn5LafTI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736697940; a=rsa-sha256; cv=none; b=UBWvGtGrClUJPcqWfZNMsMVGWSiCradjW9e90exCNn+JqQ2++yTuYHJh4FfyxmLaTIoXoX JIM9FKuFWL7A0sSW7V7h+PmXkFd9wQg9nUB7pryKM1qyXLiLOY/Gw/jNUdou3RhWFH+yB0 kkqF6vhOEbkWyeu2aUCN2imcO0BPHsk= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tX0Ii-0000000010W-3Zr1; Sun, 12 Jan 2025 10:54:56 -0500 From: Rik van Riel To: x86@kernel.org Cc: linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jannh@google.com, Rik van Riel Subject: [PATCH v4 11/12] x86/mm: enable AMD translation cache extensions Date: Sun, 12 Jan 2025 10:53:55 -0500 Message-ID: <20250112155453.1104139-12-riel@surriel.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250112155453.1104139-1-riel@surriel.com> References: <20250112155453.1104139-1-riel@surriel.com> MIME-Version: 1.0 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8C4DBA000C X-Stat-Signature: 4x69sj989rx4ku6d3amkjjntf49uqewq X-Rspam-User: X-HE-Tag: 1736697940-290629 X-HE-Meta: U2FsdGVkX187vFX/0dYOmI3LQHM6+zPbCIo+Ym8TUEHgcQwvbsCc3W+1g7d7ExoCKV9dCz/p2NaqyZNVCWjZTjEOeqU6ZVbJKFFfckZrtlPnxTFYiRPKJ/AscEtEg8dZLRgTP07hQM1x/Yl6fLbrqb6ilyv0SPDA1R0v1kkDFdU2dsJu3qTEHDiNBcTwYU3y+P3B2Vhp2Txar4eSqWSbGA1GfoNLOqpiovGZe0CR8dYPCf+MSxgySsUkSlJG6ph3pn/ZlOOFvy63mBfgAO2RuZAA6MrmpCBJTmte0EIMVBDEEBCXki9BTJhxUHjZh8a7bPHI8i6aP/jTFtO9kJyLzo+R2oLCGWZ+8/dMOOOEWvHhdS4/OpQZKafg7fwsuuPIZRJPgVySJDaCp9TqoVI39xCa6JP4SX+lP+sjXm77spJ6WeRY0XObdg5KSdK97hg6Swt/s9nJ10qD0fG/7RVJ/aU0tgq2l3mfqsiRE6NwjS65nTs20vUFjUb9mswXsAePKKACnPoidPNSFU2Lr3NmJXct1/Cacyj7ldJrlxfBs/dBUwyyuPJxnrFPwQWNEI+d6lnaP7NM5SWbGRwuF2f2CkDWTwkNtPWZML42KnUfPAY36jKaVj+3vfJJXVF7IWMiX1guvnsh9xx8zkWXH+mXK+U+mrtTQZzfScThINM6ghLrLb6BzeKapYrBYYUgko7db7vKykNqF30ZZHlKR0fNGDzxg2nXOZg6iYHkNfBYyGgI9ItLMvypRKe/JCwJuyd9VmSlRs8uevxtn7mP7zaAezOBmVW7SXv7hVzB/d1h1bmhW1zkWwkeQdKMDaEcqIo7Bn1+ycdsQ7cS7puqJ+2EQv8CYZVsbqpZFrxHM65Qw2mib846/UI24sMFy/33m8rwM1sWZFNVJeoqS/htKm8bj3pNzzhsIlEN6GKyciYkNpT9x00HXPDAY+H/eerlBZRp1Lugpsime/m9Z4asGPj U6zwmboW iO/T5tDXdWUekYHw7GKGqjTPTMX9eZaXxLsaDyQkHU6qVmiOmHCgJBKcvF4+0Lff8Q6+vNBnOHJJ1q1jcu0WgeeiXT5NM9rBjx9U30Z7ObGfk9gwLEP+aI57DTWdz+dTufBKB8AzK1+R8kia7TctHQN4SoGWYrHo8TXM5b1HBCSwlQa3Nr42SetW/DhCMtx5Ztp7rqE+3YdfAMwt8t9gtWWoPOOc2YcCXy2wq2fMmp2wASwpfqk/yFGklTnINTE52PI8D5L+heedO+djBgLolXaiHCJmPwNAcxu91lJ1O5GgyH359uEF+r8HeDt6YWu/VSZ3Y+UhSEcS3waFTkJ7lG4bcsh/dChE9tMsDCKuk7Rw52jgAXJ3GfY1G938borunV9kF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: With AMD TCE (translation cache extensions) only the intermediate mappings that cover the address range zapped by INVLPG / INVLPGB get invalidated, rather than all intermediate mappings getting zapped at every TLB invalidation. This can help reduce the TLB miss rate, by keeping more intermediate mappings in the cache. From the AMD manual: Translation Cache Extension (TCE) Bit. Bit 15, read/write. Setting this bit to 1 changes how the INVLPG, INVLPGB, and INVPCID instructions operate on TLB entries. When this bit is 0, these instructions remove the target PTE from the TLB as well as all upper-level table entries that are cached in the TLB, whether or not they are associated with the target PTE. When this bit is set, these instructions will remove the target PTE and only those upper-level entries that lead to the target PTE in the page table hierarchy, leaving unrelated upper-level entries intact. Signed-off-by: Rik van Riel --- arch/x86/include/asm/msr-index.h | 2 ++ arch/x86/kernel/cpu/amd.c | 3 +++ tools/arch/x86/include/asm/msr-index.h | 2 ++ 3 files changed, 7 insertions(+) diff --git a/arch/x86/include/asm/msr-index.h b/arch/x86/include/asm/msr-index.h index 3ae84c3b8e6d..dc1c1057f26e 100644 --- a/arch/x86/include/asm/msr-index.h +++ b/arch/x86/include/asm/msr-index.h @@ -25,6 +25,7 @@ #define _EFER_SVME 12 /* Enable virtualization */ #define _EFER_LMSLE 13 /* Long Mode Segment Limit Enable */ #define _EFER_FFXSR 14 /* Enable Fast FXSAVE/FXRSTOR */ +#define _EFER_TCE 15 /* Enable Translation Cache Extensions */ #define _EFER_AUTOIBRS 21 /* Enable Automatic IBRS */ #define EFER_SCE (1<<_EFER_SCE) @@ -34,6 +35,7 @@ #define EFER_SVME (1<<_EFER_SVME) #define EFER_LMSLE (1<<_EFER_LMSLE) #define EFER_FFXSR (1<<_EFER_FFXSR) +#define EFER_TCE (1<<_EFER_TCE) #define EFER_AUTOIBRS (1<<_EFER_AUTOIBRS) /* diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c index bcf73775b4f8..b7e84d43a22d 100644 --- a/arch/x86/kernel/cpu/amd.c +++ b/arch/x86/kernel/cpu/amd.c @@ -1071,6 +1071,9 @@ static void init_amd(struct cpuinfo_x86 *c) /* AMD CPUs don't need fencing after x2APIC/TSC_DEADLINE MSR writes. */ clear_cpu_cap(c, X86_FEATURE_APIC_MSRS_FENCE); + + if (cpu_feature_enabled(X86_FEATURE_INVLPGB)) + msr_set_bit(MSR_EFER, _EFER_TCE); } #ifdef CONFIG_X86_32 diff --git a/tools/arch/x86/include/asm/msr-index.h b/tools/arch/x86/include/asm/msr-index.h index 3ae84c3b8e6d..dc1c1057f26e 100644 --- a/tools/arch/x86/include/asm/msr-index.h +++ b/tools/arch/x86/include/asm/msr-index.h @@ -25,6 +25,7 @@ #define _EFER_SVME 12 /* Enable virtualization */ #define _EFER_LMSLE 13 /* Long Mode Segment Limit Enable */ #define _EFER_FFXSR 14 /* Enable Fast FXSAVE/FXRSTOR */ +#define _EFER_TCE 15 /* Enable Translation Cache Extensions */ #define _EFER_AUTOIBRS 21 /* Enable Automatic IBRS */ #define EFER_SCE (1<<_EFER_SCE) @@ -34,6 +35,7 @@ #define EFER_SVME (1<<_EFER_SVME) #define EFER_LMSLE (1<<_EFER_LMSLE) #define EFER_FFXSR (1<<_EFER_FFXSR) +#define EFER_TCE (1<<_EFER_TCE) #define EFER_AUTOIBRS (1<<_EFER_AUTOIBRS) /*