From patchwork Sat Feb 8 01:18:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yang X-Patchwork-Id: 13966203 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35675C02199 for ; Sat, 8 Feb 2025 01:26:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B8CD6B009A; Fri, 7 Feb 2025 20:26:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 69BA76B009B; Fri, 7 Feb 2025 20:26:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 531A66B009C; Fri, 7 Feb 2025 20:26:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 327BB6B009A for ; Fri, 7 Feb 2025 20:26:12 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D4F9FB3C01 for ; Sat, 8 Feb 2025 01:26:11 +0000 (UTC) X-FDA: 83095036542.14.3727C87 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by imf13.hostedemail.com (Postfix) with ESMTP id 09F4820004 for ; Sat, 8 Feb 2025 01:26:09 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Cqes1CYZ; spf=pass (imf13.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738977970; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references:dkim-signature; bh=9cKJO6WYgPVk5ONMRMSzy9wocLnlinzHwQGz+VTI6b4=; b=nqX6QOGmAKY9j88ggV8dG6Ibquy2pMqe5fexFsQQMr0gXrIEfD+dav/IwICvXiNypP2SZJ A7F5UasrahlrN+Xpwki6FDcvbNYwvu40+NL/muiV+5duH2z4W1tf1zQXcALEiBA9uLsnz4 NAboxPxU6/cSLSdbHA/58wRJRzddiO0= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Cqes1CYZ; spf=pass (imf13.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738977970; a=rsa-sha256; cv=none; b=hJLeL0nF6fWcU6nzZHpj2xAMDs2vQLmzpFhB0v64ZZjVMJdCEMuWFiO4axxPr3jl9Uz0N7 dUicHiIrlY7Cc+BaO4SwN55ZW6PrtQqHdvA9pJla4D3ctyzLtl9AYgiFTnJnQ3JVCvsvKV 4dOhuCdr1O475y+wKLit9gGFShmeIrI= Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-ab78e6edb48so162480366b.2 for ; Fri, 07 Feb 2025 17:26:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738977968; x=1739582768; darn=kvack.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=9cKJO6WYgPVk5ONMRMSzy9wocLnlinzHwQGz+VTI6b4=; b=Cqes1CYZFyx2ltKPabb+IwRWbmN5LFkDHgbnXQa3RyUlZ4i4S3r5je/GJ2j9vhs9rM nCqd3EA5H98RyxBPpExXSBk03JLvT6BgukOXSx2lvvcUFUa2zVELyzKGlBN0EkONDqF8 z3o0/xDS8Emid9UKUVP9sQs1NDnpv+uW+LGtWq69eTDTsL6WoWTcHm+icT6jHt41fAtz tIkcOnCGqdV9q4FK7ld1VfwuPCWOw4NjiKfm4MlIzMu5NsQxI7TRmJNAqH5eabcWGzF7 YvwdRxjg9hVG7Y+vZBzPv2B9MhOsL2JfuUq6wIfigRDmzEdnW5pNNX4CoSjHOX0CRiew 0XtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738977968; x=1739582768; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9cKJO6WYgPVk5ONMRMSzy9wocLnlinzHwQGz+VTI6b4=; b=BpX6MYaEMQWF3umPN8hQdwovv/figshu1OSjVv+ZEjkJEfQmUvDsrs/Crqko/VzhM5 b03KPTjisPqRPhWs/mhXjgms+ssHXmfKjKrTX3hlXWRfJdc4cmYGPLObgEFjdQOAK7VI iUyi8cbTLfD92xddQze3vA5TJT8nGnBn5wL5ZaNU3c5v/imAucjyFzhjiUXHqnkrLitb 34lkrN03UY+TzL9zttlycH4KYga3wAzOUujpgfUDrstcJS3MoW8ywYLLBUi4i/mVBJMK QlWOozZPP4L2CkpA6wC76xb0uid38Pj4k6m6Whfos8Iksy8osQgd/o2dV64UgCRYceqA WnEg== X-Forwarded-Encrypted: i=1; AJvYcCU+fsEJhK+9rZZOkDdSm0BkswcATjLHYGGhX9EJ2nHUIrnTg4B34A9lQ+nrJQb/OqZE7RDHkEkVdQ==@kvack.org X-Gm-Message-State: AOJu0YxC1hRyL0/ULAY97FjiFjSn3LbOeI9aPScadpvNgLu5fs7UjGVr 7vKnQQo1Yr0Esyhx8vAlM/fVQYVMCStnnAF8XGO10mVg1oXHxNmXWbqqLCBq X-Gm-Gg: ASbGncsXdHqsHoOSdyCLARxP+pX3pQkXpU0cMYk73Hcn1KPygACQL4qjduc/nBSqoCn Y3TTQRaKnZD2cvUzYbW0x9FkJCO3maZ/PqKZ5Z4kBH+ycz9DPyJaCl7VgbNli/0XJGpSbU02xeb wwnXzB+RkUDwWt9O0HbGVmiBbp2UAM4MaWTN534nHF/sxkD4iOpnmTtQEHdKByDNJ4m09u3SAzT bC9JB4iXVXBzA1xM5GDIuJo3pW4JWyykAU2Ht8qbAw03zqhQmikQGIUlkEInbYqwfdcZ5CCjbm8 mrkzBg6J/REoCk8= X-Google-Smtp-Source: AGHT+IEDgn4hvyftKWjVS8XUEhfL86vSVA62BU8ZxiNLHbEB44tzNbV0vYMEQ0HdKrU5qqxcj3/bjA== X-Received: by 2002:a05:6402:320b:b0:5de:3f09:e059 with SMTP id 4fb4d7f45d1cf-5de4500216emr15297006a12.12.1738977968371; Fri, 07 Feb 2025 17:26:08 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab772f83e30sm367107066b.38.2025.02.07.17.26.06 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 07 Feb 2025 17:26:07 -0800 (PST) From: Wei Yang To: akpm@linux-foundation.org, Liam.Howlett@oracle.com Cc: maple-tree@lists.infradead.org, linux-mm@kvack.org, Wei Yang , "Liam R . Howlett" Subject: [PATCH 3/3] maple_tree: assert retrieving new value on a tree with only root node Date: Sat, 8 Feb 2025 01:18:52 +0000 Message-Id: <20250208011852.31434-4-richard.weiyang@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20250208011852.31434-1-richard.weiyang@gmail.com> References: <20250208011852.31434-1-richard.weiyang@gmail.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 09F4820004 X-Stat-Signature: 5nd67nkeewppqt1agdhrnhno5khknmce X-Rspam-User: X-HE-Tag: 1738977969-660303 X-HE-Meta: U2FsdGVkX18uWleHmy+xORxPG4FFAlHVCghaXRXn7OW0hY5K/IYcFI0Ok7vsRrb55GgNIcUhvNnSs3JXF3T6RNlXtMm2CiNri3dBx6w3/qlT1KcYA2x5FppiX/1U6oOp/WZhE7eGVMr9BaxsGyfJF/0JbbYteRaf8ORUFgWTKXHchKQaeQXRtpvnjB42XCdvtdzIPxKCyllXIMWIDtLBlPKq5AFwalRptDufVm3u2gYNIqXBnyuGUtURkQ9atSKNnX5rO099q7IAHmkHiB0WvtSLmzXubU4xNq1BAkSdKzgC10H7HP1vfweZQZo/CLQjYzj0b0Q2E2iUv6gglf0C0kSWRT5KZaIUb4LhuQGwo3JJNre3MQt4J2kd4hYsPKgMWbdGFLhO66JNNm6fDwyWdyKB2aMKGi1RWeRx8KkQBLJr5CR0Ht/LWCzaxUp2fD7jijQyXzs7JLvNx/e4wyvGbpxNI2f9hmwxaGLcMWUCBXXJK8eXQuz/MwP3KVOguVVJPVAqRBOyhGP3fWySVcfn7j7fG7sd8hRtOWk1IUxMZ5v6WzpzT69qb7UEJzXS9oQnqhnFT0gTAFFtZpLHiiDhMHmiILtugbXB/yHdOrkThVNSwe9EeXoF6CNj6MUAdGBnrmS0xvaJdz0ogjcJO6lmirqQb/PQUykDGCexx3lTcNMvBKmu8M0bSc9Rhp03Ttm57tbOV6Ja3/W04Y2FrGDR6NEm2FsAgFtQhhWgzkwoIWgoQ2kjfwJtznFoV2DqFSWVr5FkaeazZ9QFQ0FsjFj66uC/FI9I+W4eC//Wjqwe2PiNhxuM4yJ6w2xZYtTY0C3n95E8kfJ8kelKwxdPyJoV8WUDPEzKx/sbAia04JNcHy9vvS1a3j3EdqKFLKtvRPFiomz2jOpLfxBXCNE4a+KiCByVBaEhFMfPY4x3tNALGQKpD65fPgYmEeV4CEzpZrD23ek1IMPaVBtYW2PDnPy 2i6azAqM 1JwlqR1soU7lsA6KCWZbgkp5GYAkSoKsrIU1scADiPhGnb1r0VwY2tbrvG4mJMdIZ04zrirmFVeBm8xeG4pB2p0dUIq7SMF889LJxop/qbRZLKlOzddPclk3OlyTaEG85MUgeKV56pKlWPVN7/gAYMGF+n0/Wp51571EthPj/V0mmwY2HF4WsS6G7dgD5tYpQilH7PWJ56JUd3yPSB7lQ5MoQ0BMPm8tjaDarXfsX7J/g8RoPwLsuLgWvTpERquBkaWqySETIQ0PW4PrDmPLr6YrjeqvSJgH9wNNfLWwwBU9rbolb32Ld6rEx5bRkUhL8kM6t1dkg0Kp/bCZ8N7wmb9MNW042ON309zeDouiHMZTU5rLDpApp5XIYpYon2Uf46Za7nAQkGawHBfAkzt5/a7adgGaF03kx5b68rOVTwlqKpIbK7prwwMfxDxHImQq1cPMQHnp9Ccf/OOgVq+0tidLreUO0BB0/mpMxFmer7ZPp8BgEaBjNpbYfHTWB3drX7iGqZbKDjQ/Ni7l6p/33eKhmBi8NXUbdRTqtH7jg6oDkFNGeet2R1jmW0A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Original code may get a stall value when overwriting the whole range on a maple tree with only root node. The reason is we didn't set the only root node dead during destroy. Add a test case to verify this is not recreated. Signed-off-by: Wei Yang CC: Liam R. Howlett --- tools/testing/radix-tree/maple.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/tools/testing/radix-tree/maple.c b/tools/testing/radix-tree/maple.c index bc30050227fd..1e293e4d856d 100644 --- a/tools/testing/radix-tree/maple.c +++ b/tools/testing/radix-tree/maple.c @@ -35256,6 +35256,30 @@ static noinline void __init check_rcu_simulated(struct maple_tree *mt) MT_BUG_ON(mt, mas_prev(&mas_reader, 0) != xa_mk_value(val)); rcu_read_unlock(); + /* Clear out tree & create one with only root node */ + mas_lock(&mas_writer); + mas_set_range(&mas_writer, 0, ULONG_MAX); + mas_store_gfp(&mas_writer, NULL, GFP_KERNEL); + mas_set_range(&mas_writer, 0, 0); + for (i = 0; i <= 5; i++) { + mas_writer.index = i * 10; + mas_writer.last = i * 10 + 5; + mas_store_gfp(&mas_writer, xa_mk_value(i), GFP_KERNEL); + } + mas_unlock(&mas_writer); + target = 10; + mas_set_range(&mas_reader, target, target); + rcu_read_lock(); + MT_BUG_ON(mt, mas_walk(&mas_reader) != xa_mk_value(target/10)); + + /* Overwrite the whole range */ + mas_lock(&mas_writer); + mas_set_range(&mas_writer, 0, ULONG_MAX); + mas_store_gfp(&mas_writer, xa_mk_value(val), GFP_KERNEL); + mas_unlock(&mas_writer); + MT_BUG_ON(mt, mas_walk(&mas_reader) != xa_mk_value(val)); + rcu_read_unlock(); + rcu_unregister_thread(); }