From patchwork Mon Feb 10 10:09:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: I Hsin Cheng X-Patchwork-Id: 13967576 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD126C02198 for ; Mon, 10 Feb 2025 10:09:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B7DA6B0085; Mon, 10 Feb 2025 05:09:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 167926B0088; Mon, 10 Feb 2025 05:09:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02EF3280001; Mon, 10 Feb 2025 05:09:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D439F6B0085 for ; Mon, 10 Feb 2025 05:09:58 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5195A1A098F for ; Mon, 10 Feb 2025 10:09:58 +0000 (UTC) X-FDA: 83103614076.11.607B1CA Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf27.hostedemail.com (Postfix) with ESMTP id 7257D4000C for ; Mon, 10 Feb 2025 10:09:56 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VjM29dKV; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of richard120310@gmail.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=richard120310@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739182196; a=rsa-sha256; cv=none; b=zrWyRFzpzrBQMExdetvMfDq/F13f/0YWrxkEfUZFhslVht+ZlhRcd3KSuFhrTSfT3lGkDl z8ms8yPnfN7Vs0VKE4gnIRgFr8q9rWmp3wt6UFx7Ciaw63yuDlI/Sqom39BljBXB9ZiEYT 69T7jPU4N+sC4V92XZtYi+YQ6KYYV6Y= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VjM29dKV; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of richard120310@gmail.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=richard120310@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739182196; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=BRIZPtgDP2C8BHY1VNSmDt2ecW2TOJuFsw7UT614zPc=; b=SqkgEv1GIkDtCm6X9sfWbbycSaQeKBPUjf4HKaCCP40CVyvOAd6V+6NnwddYNCWAELXNxS mfddhV8jR7kiA44qFimJLvturoQspEoVnhN09TbRc3jEwsJdZwPhjDtrzk76Dj0NO2CnXL vlnpRLH2PEqe+NSWnuZeSSpBhdRXFGc= Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-21f6d2642faso41079365ad.1 for ; Mon, 10 Feb 2025 02:09:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739182195; x=1739786995; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=BRIZPtgDP2C8BHY1VNSmDt2ecW2TOJuFsw7UT614zPc=; b=VjM29dKVVZaw6tBL+6OHXBaNVwNpQ8XViwtfnAk6jyj350bCHJlKMButyhyE+jY1Gi 4pfvjvVD9qKL3CN+HfbkKlaF9LwRtEjyKrL83HgdiCGVP51XLXbFk8HEtFzdQ+LtTCA+ Y7BmEihxuTpw2WfgBJSn8ariL+tLiHz1XtZ1c2d9Lpk+P/swsjpZ80KxxtegeWiIj28w r8VEmvVgFopvXRvrIRa5cSqkFj8Ar15oIqP3RTMvuI9ne6karIWF95DVVrEBWtD6ilX6 iZ8SiNm5KqGbn4oXzXeML3WmeFlqSaik8EalgkfhuPEmuVu7yJFL8AWEeMJDTuyjiC3/ 7pwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739182195; x=1739786995; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BRIZPtgDP2C8BHY1VNSmDt2ecW2TOJuFsw7UT614zPc=; b=wRf4FmuSh4dINenMbaUtwwNoX31OBVt2ayMbDQVuiLL/nnh2/YWedvBDvpHYNbOx0D BPmm8dyX7gebUUKgRvqga0+apmVn0m3bHRo3dRIgUY5s+e0Bi1/KmZO43VC15T+32AyN K9hqqi6Z02GR9K6DgsdbiwRGE3Jvf6bGkEVQpwFZuWeM1sY3NP2gL+MgxRPgeK3OYZ8v b8MB/8dt+/J+rNYI8QMadBSLYwhWF5lErEJ3xwgQ14WeW1E/YVmpjLRVFnASgan3WOfo gEC7xlft+HT3hsRAHNrkugysGwtKDO1A/7tjoTsd/qF8VkJqfIWq1yTu+vZGxwwWPYXd r1/Q== X-Forwarded-Encrypted: i=1; AJvYcCU6n69JoSoBymkS7dmbDXh0iIhOvM5DLaNUhcUlcESOuoqg3HQoWx/64Nhe0MKGcREVKUqdbtGbTg==@kvack.org X-Gm-Message-State: AOJu0YxRrTDZlubmMtPKCjYHCYtsKHr58i83qMNBMiPJy8pFTZzAlu5L OsiIdggq3mgFVdGgu9UUdg3svKgSbCLzejoMwzRbo5d2ZbFzPd0t X-Gm-Gg: ASbGnctKnWcd9lr8ujXgjiw0bCLSPZYiXTu26Ii62Qfpgjo7aUt6q+AbmH7GSwPehV6 dsvxQ2kCQFo/rcd+iPLVNrgJ89Y2VExwjh65eRc0/Ot/Km8qfNpQH6evYqH45VwUUgyidJN+KDh 4hDPQUxdGNGRyxrCLVogw/dZNMnejCqQ0NB/8vBExD7IIPf3foqDlGj1VGiHvmkANhcPVc6ghel iSMFd3zMTInU8LZnsrjpQcfBokXUbJ/lURQddofHsxuEh/gkZrYS7UEEkAH42p8lHaOcdXY5ouT CWCmfzljl8UXiJ77rNi73yMxCV3ohxHBohhXc/DBE6ZA X-Google-Smtp-Source: AGHT+IGvmuwhM8mylIYC4mbU6oGvR0C2pi9xpQjfCFLm41Vg7sGKMUgoorCoRDGPRO1eMmYJYvaS0A== X-Received: by 2002:a05:6a20:394c:b0:1e0:cadd:f670 with SMTP id adf61e73a8af0-1ee03a2432amr20684351637.5.1739182195260; Mon, 10 Feb 2025 02:09:55 -0800 (PST) Received: from vaxr-ASUSPRO-D840MB-M840MB.. ([2001:288:7001:2703:a0f4:120:366c:bbc8]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ad550abefadsm1849117a12.34.2025.02.10.02.09.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 02:09:54 -0800 (PST) From: I Hsin Cheng To: akpm@linux-foundation.org Cc: zhengqi.arch@bytedance.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, jserv@ccns.ncku.edu.tw, I Hsin Cheng Subject: [PATCH] mm: pgtable: Unlock pml without branches when !start_pte Date: Mon, 10 Feb 2025 18:09:48 +0800 Message-ID: <20250210100948.312130-1-richard120310@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: 7257D4000C X-Rspamd-Server: rspam12 X-Stat-Signature: qoz6q158bstc8my5bwbemz7mrctiuqab X-HE-Tag: 1739182196-633055 X-HE-Meta: U2FsdGVkX1+6JRVt4OMFaUgV0m9LiRG1V9sAqGWufn58EaPORYzgZ1MmOEYVb7RQbj2WnTCS3k6L1TIV3IcKZ0oWvuCbsV8R5JryQqqyA0y5TYU1i8dOGTB4F4E9PH2xN6gC+VOV6qOJF9TDQLVRymkCXyjxcwwUpn3esNtkFjhwQCy5kRA+EDLqs3nRccpGYUmwrJ6RVFzB/h4bokUWagaZRsV/bf/PYTLCtI+bVssqGUTTU3dS0Uq9+0FclG/ZW5YeLm3wmvFnafBQozQxQOTHCApSPVTQ7qw3NHSjNM+6e6ZUFo/1JHvQhVUXql5UJH+TWzlEwrQvA87IRwYEnFjreB+nhK+2YebxtuDJ0L7lnn/gS7LtTXt34CAEgvgtlZBzRGmOKwyb1PzijmbE4lugPb1jlNTFh6AyoiUj6nWuWLe9YcpL6Y/8JUZm3/QiBjCzyRmb2yAliDKoFw6uV7jn3V4UuQ3rKel9hpQ7htRZk67muGnFoTGLj9WQ3VgtRrcczYAxj+1qPY90I8/ycQJmVnV+i0f/z7L4XyzCUT6KRkiaLXm9nI+AxooRWT2NO/DibwdSrQc3d64jo/MLKbT3x065NfOBvxpScBkUUC6gs1BuxKgUimTCIOZ5+LAhcUghXCaJa0lIJouG2izwPBlYmCEHfgVdRZqLT1vjj0nrzuksUJRD7apcr8SFEmZf9DGP1i/oxa4t1yGueMUSiShExlFMW+oG4vb7QQjzorwlzam2h39o2UyaTq3qQWO0lWptbjNnyE+5YZ9xiidwSjW6M40omBji2F/1PwE41ECwKd+HTgqYRWWLKOiLu6pWQU+KP7w/MfzcP8Zs/UA+j+LSv+t9Zlgf6C1F0BlvqnfpXA1W8G/npotzLDnN8G9AVjyLi5KkzNF7iySkRKqQTMWrkNYT5MCAP89o9NRL8kjQKpGlGxWkCP06y0sQ182hWAOJUHktD48DDpfbahP +V4OlIJG fMGv64+QvvnFz1IQK03zQTWHmVW6ojApHfLLXMGqSXxJQ4EFBpQolccHIk8n8k+C1UZ9Kg4l/L6T8b7YqXPtb6Cr2FUj2CclrITvYIY7LipEtI7zD5L3UqGeLMMBvX0mhgkVlo72VkzwRU+XWiFlKdHL8EGLaCA/vLEUv8sXIn+uxaj9BkMnSgmHFl5yBGeHP+PzAA3uhqVLBjCnHYTJBVp5X6TU/3AuUNS8wG16ZUzdynhFkXg7fSuaNNWngMghYOartcIsnP9gUzo58t8znlMF71Y0Vd/gP+tJ2FNCvc90FAMBELbqRWz+5t/EtzRXm0juEf3ayXvCEfF9XPhzFiu2F2JrjSf4z3hhnMppzpfe8Y2QtWVrceYKG/uVg7Zvu2dgdJkD9y5oDiMPNa8LiFbd/k3sTxrePFFK8iQmshyEQAqC/zgfA513Zd7VVYdgODf3VvUMHXydpIQkVtN+VSkiEDw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.063023, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: When !start_pte is true, the branch for "start_pte" in "out_ptl" label section is surely false, and "ptl != pml" must be true since "ptl" is NULL in this case. It means both branches in "out_ptl" are redundant, only one thing to be done is to unlock "pml", make it directly unlock "pml" and return in this case. Signed-off-by: I Hsin Cheng --- mm/pt_reclaim.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/mm/pt_reclaim.c b/mm/pt_reclaim.c index 7e9455a18aae..f5d5c42a4679 100644 --- a/mm/pt_reclaim.c +++ b/mm/pt_reclaim.c @@ -42,8 +42,10 @@ void try_to_free_pte(struct mm_struct *mm, pmd_t *pmd, unsigned long addr, pml = pmd_lock(mm, pmd); start_pte = pte_offset_map_rw_nolock(mm, pmd, addr, &pmdval, &ptl); - if (!start_pte) - goto out_ptl; + if (!start_pte) { + spin_unlock(pml); + return; + } if (ptl != pml) spin_lock_nested(ptl, SINGLE_DEPTH_NESTING);