From patchwork Tue Feb 11 21:08:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rik van Riel X-Patchwork-Id: 13970701 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4919C021A1 for ; Tue, 11 Feb 2025 21:09:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 09392280001; Tue, 11 Feb 2025 16:09:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F1017280005; Tue, 11 Feb 2025 16:09:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D3747280001; Tue, 11 Feb 2025 16:09:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 897926B0096 for ; Tue, 11 Feb 2025 16:09:08 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 457F44A53D for ; Tue, 11 Feb 2025 21:09:08 +0000 (UTC) X-FDA: 83108903976.30.B18BF5B Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf25.hostedemail.com (Postfix) with ESMTP id BC66EA000F for ; Tue, 11 Feb 2025 21:09:06 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf25.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739308146; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6qz9gCbUXEYLUIUcJSjSc2JYCHkXZ37KXS7QGRocORI=; b=TRMCyrD4X5HWlL4SQKMv/3zWZRGAavV5k5UnRPdBE/mIgY/fc52NTvH64wbtYDdBv7ID2D zhAZP3YiYXML+PeL0ehCQRnkrBYSV/ekn3zaI+WyDEpYyfZm4Q0Avq2BF7b6muyoYPcFnp ldhBfDd0vXWzVDDVwv6S7VPaIJ08CGA= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf25.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739308146; a=rsa-sha256; cv=none; b=tqG28DRW6gOuHn9gZizOEGCNTe/BPanUuI2vjtr1MBrQLBV6gNT9AORFo9tj8aHD3lOU7v lkKEdaTxbMQ4JqBbDAaS2b2OMItESkDkbbPcY5A+NkoLoPl5Zx7Zoec0WrSFO7FWhxB5ul HvPUudeHqiGIb/hHMbrIXaFXdDV+V9w= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1thxUX-000000008HU-2xFb; Tue, 11 Feb 2025 16:08:25 -0500 From: Rik van Riel To: x86@kernel.org Cc: linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Rik van Riel , Manali Shukla Subject: [PATCH v10 05/12] x86/mm: add INVLPGB support code Date: Tue, 11 Feb 2025 16:08:00 -0500 Message-ID: <20250211210823.242681-6-riel@surriel.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250211210823.242681-1-riel@surriel.com> References: <20250211210823.242681-1-riel@surriel.com> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: BC66EA000F X-Stat-Signature: mmo3y389cmuqcuzazxifjfubpzbce6tp X-HE-Tag: 1739308146-826126 X-HE-Meta: U2FsdGVkX189Xv7uKHi3NjnGufDtZ+sdG6tcqPUSsrn4UYJaL4rx7bhFv2Bsw349U+U5DbYNlhBz5AFXmfByQ7xtviW2vDLkJhdxlnLQk7L9ao7T0935wcCLrIisdsRKvwdao4cNngGXtzDRob/SRKuysSQZGNA3sTjYIVutmiYeFePfIgL7ovljotaLLB0yugI3hb4gFB6ViM5OJkUYu21PM3piCwxxu4+ie5UeUJ+nS1yRoLCOOdC+J9njJK2TMQ+7t56Z43LQkYmJExWoWjRED0ZXGph11vefpJrQdCh/SU40zA1TdpdkvO+pzP96ogmrYJF78/yaqxaGTWp0/jFx+SBpI5QR28LwtmWMLJ16oGKSrQO5Db4wqQSlZO6bHpp/uxU0PKLtr7P2mbU3q65IPcQj4Kuz7tScxfxKqjgEP5LdbQ5XIzcWP/99oagnZz3L/l37XUpLgfeVcx3GVl/IcrO6kOVRBcdZeBw5kMZ/YplbPrlZzvhLyoNQyN9u/KfTvbkLnYW2T1z+GOMjQP/bdLl5v2Sd33vNg6ll/BKY8oRVcM1FLMZR0nR3fC3XYM38AQm7tr1LPTmQeuOfggNQmJmVY2RJkJHeMXnEb+Xxu8v6PYlMSfXUfYRO1/CJmrmZlOXQnz2/fzk6Aaksb7b3lkHl7tbVrOFX/8C8gWqevFLo2mdMckZW+EMyFCY23LyhLEQAVzIHGFpqWCAgLGooanZeXc6ifrKHZp7OwLoatx5oryLYSqRieEPGPUj6TMnv1tnAcPfXUh+SdiOWwuAbEPk25xSLcKIi4OWhCt3iJQA7GWYNFveQhigu6sKZ3+UmDPaV677/aGTE3Pzu1zLom9B2nbVwPy7NCQH08MkcVVs5yvKY1kUHoGF5GLF+ecDtRbmitZRPG2NYbvnHpTLpm5y5p8Xg+16otbUuttwYCJPMmd6XKh+38WJrBMkNNAi8yC+JnnqFpr/0Ylc AEX87Els OC8yMk+VUB5PyCOZitCP2KkONsyatb5juf3iG8fUcJSbeV//bkILTpMhEXFefUqdlfG20tQbAtNhh8m7O8gBXUnUyx4NSRtQv5Sa+7ZhNYGBMvLTEbjoKHuxNXBtv1MTmKtj/DJQnlZ24iUZvCz88N2esSJqmOXZXr1M4Z7iEYliUtBh8CKFMEmgtY51i4cNTo5Ut7GbcKHekNie8cqpMII9BTL0KBx1t/bim0S9dBhcht9iiaGq6Hcl0YTTQoQkSo+cbCMpDRq9+UJ1lvm700DQo6dpJubbzS2roUyMadYuFTX3RkoTAtpmOGCskdw+Ny0dewbX8pX49UY3wjJ78eLvwnxA2ehXDs+eNiFZkiCoqHGb1Dzzo1odZ1XpAVhceeYN5hqaFzfohG5Fbh7RtsNQP+GiUOVL5Kc4TYpGz/vmxYPZKt9ERTc4fQb19fcMIr7ZGzdbCRsQBJc0yY/X+0FxqNJKDr73rLr55ZXO044f8z6PtsOZW8Uwloy404Jdha3ftnNo1z90n7NU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Add invlpgb.h with the helper functions and definitions needed to use broadcast TLB invalidation on AMD EPYC 3 and newer CPUs. Signed-off-by: Rik van Riel Tested-by: Manali Shukla Tested-by: Brendan Jackman --- arch/x86/include/asm/disabled-features.h | 8 +- arch/x86/include/asm/invlpgb.h | 101 +++++++++++++++++++++++ arch/x86/include/asm/tlbflush.h | 1 + 3 files changed, 109 insertions(+), 1 deletion(-) create mode 100644 arch/x86/include/asm/invlpgb.h diff --git a/arch/x86/include/asm/disabled-features.h b/arch/x86/include/asm/disabled-features.h index c492bdc97b05..625a89259968 100644 --- a/arch/x86/include/asm/disabled-features.h +++ b/arch/x86/include/asm/disabled-features.h @@ -129,6 +129,12 @@ #define DISABLE_SEV_SNP (1 << (X86_FEATURE_SEV_SNP & 31)) #endif +#ifdef CONFIG_X86_BROADCAST_TLB_FLUSH +#define DISABLE_INVLPGB 0 +#else +#define DISABLE_INVLPGB (1 << (X86_FEATURE_INVLPGB & 31)) +#endif + /* * Make sure to add features to the correct mask */ @@ -146,7 +152,7 @@ #define DISABLED_MASK11 (DISABLE_RETPOLINE|DISABLE_RETHUNK|DISABLE_UNRET| \ DISABLE_CALL_DEPTH_TRACKING|DISABLE_USER_SHSTK) #define DISABLED_MASK12 (DISABLE_FRED|DISABLE_LAM) -#define DISABLED_MASK13 0 +#define DISABLED_MASK13 (DISABLE_INVLPGB) #define DISABLED_MASK14 0 #define DISABLED_MASK15 0 #define DISABLED_MASK16 (DISABLE_PKU|DISABLE_OSPKE|DISABLE_LA57|DISABLE_UMIP| \ diff --git a/arch/x86/include/asm/invlpgb.h b/arch/x86/include/asm/invlpgb.h new file mode 100644 index 000000000000..a1d5dedd5217 --- /dev/null +++ b/arch/x86/include/asm/invlpgb.h @@ -0,0 +1,101 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _ASM_X86_INVLPGB +#define _ASM_X86_INVLPGB + +#include +#include +#include + +/* + * INVLPGB does broadcast TLB invalidation across all the CPUs in the system. + * + * The INVLPGB instruction is weakly ordered, and a batch of invalidations can + * be done in a parallel fashion. + * + * TLBSYNC is used to ensure that pending INVLPGB invalidations initiated from + * this CPU have completed. + */ +static inline void __invlpgb(unsigned long asid, unsigned long pcid, + unsigned long addr, u16 extra_count, + bool pmd_stride, u8 flags) +{ + u32 edx = (pcid << 16) | asid; + u32 ecx = (pmd_stride << 31) | extra_count; + u64 rax = addr | flags; + + /* The low bits in rax are for flags. Verify addr is clean. */ + VM_WARN_ON_ONCE(addr & ~PAGE_MASK); + + /* INVLPGB; supported in binutils >= 2.36. */ + asm volatile(".byte 0x0f, 0x01, 0xfe" : : "a" (rax), "c" (ecx), "d" (edx)); +} + +/* Wait for INVLPGB originated by this CPU to complete. */ +static inline void tlbsync(void) +{ + cant_migrate(); + /* TLBSYNC: supported in binutils >= 0.36. */ + asm volatile(".byte 0x0f, 0x01, 0xff" ::: "memory"); +} + +/* + * INVLPGB can be targeted by virtual address, PCID, ASID, or any combination + * of the three. For example: + * - INVLPGB_VA | INVLPGB_INCLUDE_GLOBAL: invalidate all TLB entries at the address + * - INVLPGB_PCID: invalidate all TLB entries matching the PCID + * + * The first can be used to invalidate (kernel) mappings at a particular + * address across all processes. + * + * The latter invalidates all TLB entries matching a PCID. + */ +#define INVLPGB_VA BIT(0) +#define INVLPGB_PCID BIT(1) +#define INVLPGB_ASID BIT(2) +#define INVLPGB_INCLUDE_GLOBAL BIT(3) +#define INVLPGB_FINAL_ONLY BIT(4) +#define INVLPGB_INCLUDE_NESTED BIT(5) + +/* Flush all mappings for a given pcid and addr, not including globals. */ +static inline void invlpgb_flush_user(unsigned long pcid, + unsigned long addr) +{ + __invlpgb(0, pcid, addr, 0, 0, INVLPGB_PCID | INVLPGB_VA); + tlbsync(); +} + +static inline void invlpgb_flush_user_nr_nosync(unsigned long pcid, + unsigned long addr, + u16 nr, + bool pmd_stride) +{ + __invlpgb(0, pcid, addr, nr - 1, pmd_stride, INVLPGB_PCID | INVLPGB_VA); +} + +/* Flush all mappings for a given PCID, not including globals. */ +static inline void invlpgb_flush_single_pcid_nosync(unsigned long pcid) +{ + __invlpgb(0, pcid, 0, 0, 0, INVLPGB_PCID); +} + +/* Flush all mappings, including globals, for all PCIDs. */ +static inline void invlpgb_flush_all(void) +{ + __invlpgb(0, 0, 0, 0, 0, INVLPGB_INCLUDE_GLOBAL); + tlbsync(); +} + +/* Flush addr, including globals, for all PCIDs. */ +static inline void invlpgb_flush_addr_nosync(unsigned long addr, u16 nr) +{ + __invlpgb(0, 0, addr, nr - 1, 0, INVLPGB_INCLUDE_GLOBAL); +} + +/* Flush all mappings for all PCIDs except globals. */ +static inline void invlpgb_flush_all_nonglobals(void) +{ + __invlpgb(0, 0, 0, 0, 0, 0); + tlbsync(); +} + +#endif /* _ASM_X86_INVLPGB */ diff --git a/arch/x86/include/asm/tlbflush.h b/arch/x86/include/asm/tlbflush.h index 8fe3b2dda507..dba5caa4a9f4 100644 --- a/arch/x86/include/asm/tlbflush.h +++ b/arch/x86/include/asm/tlbflush.h @@ -10,6 +10,7 @@ #include #include #include +#include #include #include #include