From patchwork Wed Feb 12 16:21:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Waiman Long X-Patchwork-Id: 13972062 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 474D0C02198 for ; Wed, 12 Feb 2025 16:22:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D197D6B0089; Wed, 12 Feb 2025 11:22:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CA2AB6B008A; Wed, 12 Feb 2025 11:22:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1D886B008C; Wed, 12 Feb 2025 11:22:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 93C6A6B0089 for ; Wed, 12 Feb 2025 11:22:14 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E5C734C771 for ; Wed, 12 Feb 2025 16:22:13 +0000 (UTC) X-FDA: 83111809746.22.A7A7465 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 1436C1A0019 for ; Wed, 12 Feb 2025 16:22:11 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dV8WmMGm; spf=pass (imf19.hostedemail.com: domain of longman@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=longman@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739377332; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=3mkeENwhXrVCnkP0vqjiIG1p6lDK9GeK7SyVkLKRxtQ=; b=e6NOI4IZS33RmUDFOTZYMhTKFvw9URzE3BkC9PRTadMgFBiii6aylz7KFOgXhuq9hdSBhF LhN4aJObvaW3LyPmR7pbDCppsK9bVuZ5yFT06y2NXBM2cL7oUDIJ7yKld8erEUgx+xRsAL KmE/Bp09Cmo/05Inu0np6iS0lbqp8RY= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dV8WmMGm; spf=pass (imf19.hostedemail.com: domain of longman@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=longman@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739377332; a=rsa-sha256; cv=none; b=7sR7cArBZdC4SdyTCp9UN3v7oCjXUcQIPwLU8OX+hdzcrhhgaKdnhA6ZyBdjXt2tFGk2z9 bshjYgdi5o/H1Kc3G64UIUZ4RLVZ0YjadXPM6v/oujSGB2RexVPowz2u36RE8jsMt38xob rOg+SPMVatuZWbC3Jn9x/zNvGMESaR8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739377331; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=3mkeENwhXrVCnkP0vqjiIG1p6lDK9GeK7SyVkLKRxtQ=; b=dV8WmMGmMwZ9gtQjXCo395Gm/wz8dTbOykSamV2XtZmPHXpjU/yp2iZieZmFI5URz5c3I9 dQDN2bgodl3AECojgyQ98Ka0UHM+qQiFdl60AqAc5GRPJ7zFkZB/E0vD1hNl6HDelzu0mV d350nJLIfcKnQzNd7+mzVYL2WvRjAWI= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-464-gENj6CbJMx6w85Nz5YcQ9Q-1; Wed, 12 Feb 2025 11:22:07 -0500 X-MC-Unique: gENj6CbJMx6w85Nz5YcQ9Q-1 X-Mimecast-MFC-AGG-ID: gENj6CbJMx6w85Nz5YcQ9Q Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 68C7D1801A3A; Wed, 12 Feb 2025 16:22:05 +0000 (UTC) Received: from llong-thinkpadp16vgen1.westford.csb (unknown [10.22.88.238]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C78DB1800359; Wed, 12 Feb 2025 16:22:01 +0000 (UTC) From: Waiman Long To: Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Andrew Morton , Sebastian Andrzej Siewior , Clark Williams , Steven Rostedt Cc: kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, Nico Pache , Waiman Long Subject: [PATCH v2] kasan: Don't call find_vm_area() in RT kernel Date: Wed, 12 Feb 2025 11:21:51 -0500 Message-ID: <20250212162151.1599059-1-longman@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 1436C1A0019 X-Stat-Signature: xjefojtji3ag7619o3m9ne6sesuwkey9 X-HE-Tag: 1739377331-238796 X-HE-Meta: U2FsdGVkX18OoqcZ+88TF8ahYUwg54KVvkqSSE3mtXiPzpB8HkQqiPbaLsEDKKjltdRFUN2x+TajsdXJFfaEopt4iyw0F9W7XZnfqmJ4wL6Pk/7n8RKR2HOUnhHE858kZg/J/1X+abb8OJwNYEjiWpAoIEQtbnw6qm4EjBVqVcQ0b70ux4+Uvnb0kAzNjNBqwZephT3jePX1QCCRATqxK/wZwNJK8+clLtahGib/SaX69F+Xtz5XyU+tj7+rZ/rm+8IPjzSTrctCZXeC12NV/pySnPkThSeFcvsEVdo0b8h9ZhuuxPWTiDY+PnBzoRmExhu6k4uBR2m4WHKXTvzs0hoWQliZUxLGp1jBSV4n0+x3SdlzTIU/fNCyihP+/3/y9rtZnjbyPKmzynbz2P5VJ/sKtG5k9DILrqOyyCSGP5n3qu9k54Pk0PXPG9bORKRU5ZHiYyKxP33u2BI/yxFebRdKthNK1xlkbchw5ITNuyBxAlGv7si3OOeiTMevbrsBjyRWwueHQEQbpLl2e0COBsSHgb6ierMSobpIeN5wbKWry8yEdgU1LdMxdG0SA7I9GgQZEsX0TUTZ/OodWcnAmzllBuqnO9c0JVneUm9LTasmpyOSBaYDu8ZkKxHkPKIBnA0KHdCHjQXmGa3tsIIdoOCWxbCNkPgP7FZ01Xwxyz/NuqLcFoRGImW5Zd0aiJFlTNiLRzgbU/uOGGN23jqLuk7AEkaf1gAfmcURMLbJBExPCsiJURSp6qYHSqrtSi+PN21rWnCTdmyGexIFsTjqUUHatVrgFVdnVNsU8jMUkUuhNoiEMnG1z1DPJlnbP3JOIR3XgrOujTM3SxXiuPXlnRhaOcTAw6k9z1cDLXieonKgqja267tV5RLosPf7d7fOwSkXsy2mRJXA2O7z2xY4+4+/HA67dsdZIleZdtjI++wDRsQNU7QGM9n23hPCZdDZMlIs6wK0FXNOs7I6zsr P/HXSrrg pZZ+T9mT2Qj/KkV3SOnctLMOhsYBWSWVRzNHw0QvPunItP2pVY4idgbqqluD5PIR0u++KuCuPokdoPEAZ/QlZNb0vLzpLM9PjYTOwnpTg2SQHPmGh49QMc8AVXUk74UYT22VDi6HQnjCY5qOgpT2R4ML3RQLTYrcCMlWZvl44SSJgY2JintRNRTkcDV0Kokd60rLyGzEP9BWiFh2nPNckCXF6zStY8HSlMHMFvUCQBfduPCPA5AO9WIdCWWUE6W0FjCfKO4iTgAO8IZ3FsJpyU3h74JiIyNIc5i/FDM0Ids6yTVkF+O5N1pKml6pNfje+fmDFbgj13wPEHUxsDKgmNmywK23gE3OS2u4z17ueD16VEFPBg9KRyAUGR3JwJY9sYnigDHRsDrWF4y5vM3xdyFDJg5sn/002Pcsa+Pg2pmMnOLFOMQSUoQ0M/SX+2dw/SZj8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The following bug report appeared with a test run in a RT debug kernel. [ 3359.353842] BUG: sleeping function called from invalid context at kernel/locking/spinlock_rt.c:48 [ 3359.353848] in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 140605, name: kunit_try_catch [ 3359.353853] preempt_count: 1, expected: 0 : [ 3359.353933] Call trace: : [ 3359.353955] rt_spin_lock+0x70/0x140 [ 3359.353959] find_vmap_area+0x84/0x168 [ 3359.353963] find_vm_area+0x1c/0x50 [ 3359.353966] print_address_description.constprop.0+0x2a0/0x320 [ 3359.353972] print_report+0x108/0x1f8 [ 3359.353976] kasan_report+0x90/0xc8 [ 3359.353980] __asan_load1+0x60/0x70 Commit e30a0361b851 ("kasan: make report_lock a raw spinlock") changes report_lock to a raw_spinlock_t to avoid a similar RT problem. The print_address_description() function is called with report_lock acquired and interrupt disabled. However, the find_vm_area() function still needs to acquire a spinlock_t which becomes a sleeping lock in the RT kernel. IOW, we can't call find_vm_area() in a RT kernel and changing report_lock to a raw_spinlock_t is not enough to completely solve this RT kernel problem. Fix this bug report by skipping the find_vm_area() call in this case and just print out the address as is. For !RT kernel, follow the example set in commit 0cce06ba859a ("debugobjects,locking: Annotate debug_object_fill_pool() wait type violation") and use DEFINE_WAIT_OVERRIDE_MAP() to avoid a spinlock_t inside raw_spinlock_t warning. Fixes: e30a0361b851 ("kasan: make report_lock a raw spinlock") Signed-off-by: Waiman Long Acked-by: Andrey Ryabinin --- mm/kasan/report.c | 47 ++++++++++++++++++++++++++++++++++------------- 1 file changed, 34 insertions(+), 13 deletions(-) [v2] Encapsulate the change into a new kasan_print_vmalloc_info_ret_page() helper diff --git a/mm/kasan/report.c b/mm/kasan/report.c index 3fe77a360f1c..9580ac3f3203 100644 --- a/mm/kasan/report.c +++ b/mm/kasan/report.c @@ -370,6 +370,38 @@ static inline bool init_task_stack_addr(const void *addr) sizeof(init_thread_union.stack)); } +/* + * RT kernel cannot call find_vm_area() in atomic context. For !RT kernel, + * prevent spinlock_t inside raw_spinlock_t warning by raising wait-type + * to WAIT_SLEEP. + * + * Return: page pointer or NULL + */ +static inline struct page *kasan_print_vmalloc_info_ret_page(void *addr) +{ + if (!IS_ENABLED(CONFIG_PREEMPT_RT)) { + static DEFINE_WAIT_OVERRIDE_MAP(vmalloc_map, LD_WAIT_SLEEP); + struct page *page = NULL; + struct vm_struct *va; + + lock_map_acquire_try(&vmalloc_map); + va = find_vm_area(addr); + if (va) { + pr_err("The buggy address belongs to the virtual mapping at\n" + " [%px, %px) created by:\n" + " %pS\n", + va->addr, va->addr + va->size, va->caller); + pr_err("\n"); + + page = vmalloc_to_page(addr); + } + lock_map_release(&vmalloc_map); + return page; + } + pr_err("The buggy address %px belongs to a vmalloc virtual mapping\n", addr); + return NULL; +} + static void print_address_description(void *addr, u8 tag, struct kasan_report_info *info) { @@ -398,19 +430,8 @@ static void print_address_description(void *addr, u8 tag, pr_err("\n"); } - if (is_vmalloc_addr(addr)) { - struct vm_struct *va = find_vm_area(addr); - - if (va) { - pr_err("The buggy address belongs to the virtual mapping at\n" - " [%px, %px) created by:\n" - " %pS\n", - va->addr, va->addr + va->size, va->caller); - pr_err("\n"); - - page = vmalloc_to_page(addr); - } - } + if (is_vmalloc_addr(addr)) + page = kasan_print_vmalloc_info_ret_page(addr); if (page) { pr_err("The buggy address belongs to the physical page:\n");