From patchwork Mon Feb 17 06:33:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shuai Xue X-Patchwork-Id: 13977133 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F776C021A0 for ; Mon, 17 Feb 2025 06:33:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0140D280035; Mon, 17 Feb 2025 01:33:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F09DF280032; Mon, 17 Feb 2025 01:33:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D808E280035; Mon, 17 Feb 2025 01:33:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B4151280032 for ; Mon, 17 Feb 2025 01:33:50 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0BB334C4D0 for ; Mon, 17 Feb 2025 06:33:50 +0000 (UTC) X-FDA: 83128471020.27.5EEC76B Received: from out30-110.freemail.mail.aliyun.com (out30-110.freemail.mail.aliyun.com [115.124.30.110]) by imf11.hostedemail.com (Postfix) with ESMTP id 0F7CB4000C for ; Mon, 17 Feb 2025 06:33:47 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=WSjrr6uD; spf=pass (imf11.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.110 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739774028; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2HAfRf79L/SPv5Q+bga3YvpNIcG3LqJbC8lB0lpSzQc=; b=N18rgF5FzPQnd+IIE2oELivBOqesl8ZcXo0dKfdT7Fd+U6StOpF+Dyhgjj2sWpZbK/f4Gb oDhsWdARiDQrfbygBgzOJZMxA0vI/IV2MBPzz/YuSUT3+B1RyBw4w2EHG+LS4n26M6kyyH y8szwvCCm+ERuymEsu261aO+4dfs/6U= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=WSjrr6uD; spf=pass (imf11.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.110 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739774028; a=rsa-sha256; cv=none; b=7O5KsxpqK5uLcjkTlfQYREsinVg6p9mtoL4ownlr0gZb9DDl98f0RBhTe2CM+VRt635t0L tKcwn5sh+G7dvFKXrxIoJpiTgJ2MXc4vJKI2uwVxzqetzCUQzD9FDFUy4V5qvCiecXN9/z GS0q0fNoGc6+VhQSv9x8wsEZj2YTw8Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1739774024; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=2HAfRf79L/SPv5Q+bga3YvpNIcG3LqJbC8lB0lpSzQc=; b=WSjrr6uDIeBpDzPLGd+hZDrC1F6HOTHsOniX4O9MlXYAHQK0NukIXxdeHPEFi15ZVZMVxvfwIqA/zOvie7RzO3K4qSAm4oPCfZyfkO/bjsYgeaDMY0Oj9c0aJ3OpV8w/ui6gJVVxzMgcbfQSwQL/2kDCnKPB8lFmzuMBGsozaWg= Received: from localhost.localdomain(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0WPb1mQt_1739774022 cluster:ay36) by smtp.aliyun-inc.com; Mon, 17 Feb 2025 14:33:43 +0800 From: Shuai Xue To: tony.luck@intel.com, bp@alien8.de, nao.horiguchi@gmail.com Cc: tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, linmiaohe@huawei.com, akpm@linux-foundation.org, peterz@infradead.org, jpoimboe@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, baolin.wang@linux.alibaba.com, tianruidong@linux.alibaba.com Subject: [PATCH v2 5/5] mm: memory-failure: move return value documentation to function declaration Date: Mon, 17 Feb 2025 14:33:35 +0800 Message-ID: <20250217063335.22257-6-xueshuai@linux.alibaba.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20250217063335.22257-1-xueshuai@linux.alibaba.com> References: <20250217063335.22257-1-xueshuai@linux.alibaba.com> MIME-Version: 1.0 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 0F7CB4000C X-Stat-Signature: d75wzyfrydx7uhfoqpcrnp574sfdkmwh X-Rspam-User: X-HE-Tag: 1739774027-790101 X-HE-Meta: U2FsdGVkX1/R9pxYC/kmU5qqkfdQ+mjvNutsP0/oroBe+8sIz3EnTQxInCeu54U4rTyczX3ei2e6BoD6blYaJ4F7uk6J872PjcyD8Y4/X8MiSzCbum1thGKTNHTjzJyc9pvgU32iOJvoozZlCViboZcQU8IzbRIxvDlsZnXbAACMiuemUYRHtIBKFRIiEYRzUGb9ZXkN/XY+8AgXnT5ImAWyRAGKCkHtpZY3lUQfqScrQkp4eb0oxIU1nH2hzu9kwUd32A9umDzSKWdcz8RJqEvbSn2HAgYrE78NRPO+G8E6mmS5oqgOmgnhOfeLZO2kozLNgOH5jA7qEE4He7SgtYhW7P4/fVp1rO+OYWzFI8G5FyJ4vOVVxj7v4w8NHo8CmPLE8Mb5/0HUiNKQJ8p8v8jCbBO4hmxYfzEZK8W7rfZqQcUdspWW6pwaenVTiWhaxiiZ1VKkSM/rVZ3BY0ibGa5lwZT+7BQH9vZ0ASYusogmUWuUsngCCxD57CqfpXQk9WZGbju6Q2nBF704voC1Tl4qrHjmZ0luPAVb3NtluBBX4n/ysJT3XzYolsE5HDl33kJ0OpxJWsVeYpy/mnXDtJOamplwcpyvw7hRo8wW+6P8cjfkXRAPGCcVdrojv+6PeHWDT7vq6c326D1Cc5hLGRKtWrcpnVy5gwj0i3oTYUhd0fNUe3KGnIYEXWk5lA447YNH2McqlrKrTT9CLDM4lT9lBK6GWCv4arn5XFsOpqV7dSKzZY+8zAEbmVeKT6C4UxxWlFjsocicXBhqAzq5voNPL4o4CRQ2eeoE0oMjVBecy4g0Eyblw+egr06FK46NOCR3LSjm53UEzOuZSVdJ0FHEJC+PeNsk2gf3004mPZnCFjO+FlkyChPtPWelEdw36wCnfXHkedUbkWCiP+4KaAowO9vMPd5E2uA8CjKR8fUR37UNUSwBYrbJEnbmoMx15yBWDzmAubijLVjEHcw HWs32i5P IluRFaez/wIBfigNCn6qBYLftp1NbxsnoH6du9JCB7d0RVA4cFY1xVv5cDaljevDbC/s3jOvfTI6xZWFY1+POLH6rzxSmOalkWh4LsRrRRRuZ2YPvWSvAUbERGgnrgtySFflnRtS0Jv/r/IZgxrUuj0pE17zRk9LX1KDcFzxUhZwmcyDne6C4KkH+qTRLecJt0cyOOIO5ltwI82ht5YL3SR/eOfG+xOmMOtki9yC+xfLRWdSsOQH+69JNagmXoj6MNhlF0gTsMNEqwdVoNkkXYbyUJMvefp92AK0PR6UWRbNGWdpCvT76G6OD0eYdB/Q31KhFbgvTUGypcxNw20ubkOGQpsEt87FGgoe6nnES6a67kdFJhdiyb7/jQfhnbU5tZQ3HWEJ0VX8eJuA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Part of return value comments for memory_failure() were originally documented at the call site. Move those comments to the function declaration to improve code readability and to provide developers with immediate access to function usage and return information. Signed-off-by: Shuai Xue Reviewed-by: Jarkko Sakkinen Reviewed-by: Jonathan Cameron Reviewed-by: Yazen Ghannam Reviewed-by: Jane Chu Acked-by: Miaohe Lin --- arch/x86/kernel/cpu/mce/core.c | 7 ------- mm/memory-failure.c | 10 +++++++--- 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c index c1b945dbccdf..c81695f320bc 100644 --- a/arch/x86/kernel/cpu/mce/core.c +++ b/arch/x86/kernel/cpu/mce/core.c @@ -1403,13 +1403,6 @@ static void kill_me_maybe(struct callback_head *cb) return; } - /* - * -EHWPOISON from memory_failure() means that it already sent SIGBUS - * to the current process with the proper error info, - * -EOPNOTSUPP means hwpoison_filter() filtered the error event, - * - * In both cases, no further processing is required. - */ if (ret == -EHWPOISON || ret == -EOPNOTSUPP) return; diff --git a/mm/memory-failure.c b/mm/memory-failure.c index b037952565be..8649849bcdb4 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -2216,9 +2216,13 @@ static void kill_procs_now(struct page *p, unsigned long pfn, int flags, * Must run in process context (e.g. a work queue) with interrupts * enabled and no spinlocks held. * - * Return: 0 for successfully handled the memory error, - * -EOPNOTSUPP for hwpoison_filter() filtered the error event, - * < 0(except -EOPNOTSUPP) on failure. + * Return: + * 0 - success, + * -ENXIO - memory not managed by the kernel + * -EOPNOTSUPP - hwpoison_filter() filtered the error event, + * -EHWPOISON - the page was already poisoned, potentially + * kill process, + * other negative values - failure. */ int memory_failure(unsigned long pfn, int flags) {