From patchwork Mon Feb 17 19:08:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Matthew Wilcox (Oracle)" X-Patchwork-Id: 13978497 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CDCFC021A9 for ; Mon, 17 Feb 2025 19:08:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B169428008B; Mon, 17 Feb 2025 14:08:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A5177280085; Mon, 17 Feb 2025 14:08:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7905428008B; Mon, 17 Feb 2025 14:08:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 57E50280085 for ; Mon, 17 Feb 2025 14:08:51 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D2FA31C826B for ; Mon, 17 Feb 2025 19:08:50 +0000 (UTC) X-FDA: 83130373620.23.B911D09 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf12.hostedemail.com (Postfix) with ESMTP id 171E740012 for ; Mon, 17 Feb 2025 19:08:48 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=VviXey2+; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739819329; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DQ8pEjsubtBd0+r7ArW3+Pwnui7gFm3cbKmo8d222fI=; b=YFGEsqLJWoIFYXVMQ8Mfm9NwdTOCnnexlqwdQHqj6QLWSSxxE+kBRE/2CW+WBNStWtdIEg cP16AhSrtcfRYAW/j2OfiDjIH/cdqPOO8UbTp5oEwSaJdMPXwLSZWg2FxE3ZpL5ZdMtx5e 0Ac0bq4b12sWvFzMZtKHaorVd1IEv1A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739819329; a=rsa-sha256; cv=none; b=ypLVm/XFRyfXdk/rgfTWZ47KPr8t8kOMoQEgCkRnTNbspckW4oEeCgtj0gBWZID/VBASSR mGbiY8royT6e+DEtsQVbKAWCJ0Iq7KeB9+rPs/x3C88OXuBdV8OfBGZ9ybj9y66XZhuBGj aJtOTuIxblx3+/gK485yy4FL9dJNeu0= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=VviXey2+; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=DQ8pEjsubtBd0+r7ArW3+Pwnui7gFm3cbKmo8d222fI=; b=VviXey2+gk7RQlHla7fyP62RbI TWt5oMDGkBP4sH/ZbqUgWk8bfKkMHOigOck3TrdZiCNDAVRbOYFTGqv5DDvX6UgttQFSlvwPw9TsP NLCPz9fidRWT/lWflrucyZKu1lXBP23nJGb0UafoScOJ+2xcIjlAcbGJMsM2zrZXqcmVXIjmeSe70 VL1w0cEd8G7h/4R9o4P/G74QbYHA+UQJmatysUlnLAXoPic8p1UTx+k06XYAUa5hXp5ikTZ/C8t5t ckJWGnG7IdVoN3DVdUN95CMcdnIYHnW+v4WLn46jowGmawC3q3v17uKqvUt3MTrWYlS4Vm4MxDull HBNOJXwg==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tk6Tu-00000001pBD-2cvi; Mon, 17 Feb 2025 19:08:38 +0000 From: "Matthew Wilcox (Oracle)" To: linux-mm@kvack.org Cc: "Matthew Wilcox (Oracle)" , linux-arch@vger.kernel.org, x86@kernel.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org Subject: [PATCH 1/7] mm: Set the pte dirty if the folio is already dirty Date: Mon, 17 Feb 2025 19:08:28 +0000 Message-ID: <20250217190836.435039-2-willy@infradead.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250217190836.435039-1-willy@infradead.org> References: <20250217190836.435039-1-willy@infradead.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: 171E740012 X-Rspamd-Server: rspam07 X-Stat-Signature: zdqmgqbky3mwpmxd8fp84qa1g8xsgfem X-HE-Tag: 1739819328-561523 X-HE-Meta: U2FsdGVkX18SPkSkGFOgifKGZ5FULFQ8csQTVb5imJDnmS+/Ukwiasl+O73rsLdHCeKrC9w9wfCm4n5wQkYM7SMbVqYAK4myqti0nPFt8Damo3+WUTckoG4XiMY6ALCYiz+bWkRQvmDZ7xJ+nQiMizuihenhHKOcolKG/x365m2OjFdByLqtCpBZt24O6yyDmG1WOsttaZIYNsfbigNIYEghMxAiY06dQg5CIUv8VePEl07St8cnyoglVJp3GMtdLlOmcBONZNM8zBXpOzmk4CB8WLPQi9YaMPS2wuz3bt5LQN9O5TGV7pJqbirTBE3ZGVdwew1Fm2pyE6b++Zj1e/LfRVKrPimYV4+CQBNuRicDXm4Dk1FHth8UJ+AjuuK0ARTv0uXH1BXgD4OJ6aLxlh+KMg6LJXSEXehUDEe9lJnsRS3TlL7rEhhf6UzoI68whR6cXzWxFCwHbkSeTxlValtKmjejNfaUOYzjYF3e3fZ843HEAxzXuTF4G9+zVSj7ufnNFPrw0Axv6ra6HmTdPd4b3orQTsOBGJ7mJyk+rZf7azfVgQb8IgPAR6+TWsw31dxvzNXFP/xYI2C7HmsGgsPgbOt21bvND81s2jSbwZqoQGapgUl3paoDjg2SAPrqd9r5s+HGa6AK/IouOlfJuTowjq1cAP3NX51ZYR/N1/NODqtqB1u/K+OA3RYoj0Q9CIZjD7yF/k5NEfbmzzINcul0nu3tfo7NmaLwPhnWEmKZ+99v83dKto0f7D/x7oRMct78sW0grqWxNCubEDs9bo3kk8RVDS3I6r81Nm05o1p/hL1YSQBelztEwRUZ0f7iw6XtR+mxcV0RkOKAipt8lOT2GrhI4uidj+kjSuYt3kP3bk5d0LwohuM9rj+NDsEbwLQesLwID8+kQbv1ofkwWzldYbxH+/yA2Eq3TI8bjSRW9+b38YaqeXeqqDGfmBA/kEPr15JLwVkedKhdlM4 jMQuxKE8 zdkWbvfHVy6NnT1uqKEEGI+3PBFaD0HjSZ9q/DIP7a7yIr+UJNj+FpHJei1NIvu9FykJs2SRA1k25pHECaj/34mkgI/rr2spi9djp83NvdzDzSlN/ChyIdf4YRKuCOyXTakLXsT0zDqcKL+llgSgSPi/OcdytW47Xe+3QPHxxc3l3wY5ITmdFFKwhFHR5XBwsabX3KkD1aVCowRE/uw06TVmLgSQXBubsKUSs6yiKb5RQ9lg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: If the first access to a folio is a read that is then followed by a write, we can save a page fault. s390 implemented this in their mk_pte() in commit abf09bed3cce ("s390/mm: implement software dirty bits"), but other architectures can also benefit from this. Signed-off-by: Matthew Wilcox (Oracle) Acked-by: David Hildenbrand Reviewed-by: Alexander Gordeev --- arch/s390/include/asm/pgtable.h | 7 +------ mm/memory.c | 2 ++ 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/arch/s390/include/asm/pgtable.h b/arch/s390/include/asm/pgtable.h index 3ca5af4cfe43..3ee495b5171e 100644 --- a/arch/s390/include/asm/pgtable.h +++ b/arch/s390/include/asm/pgtable.h @@ -1451,12 +1451,7 @@ static inline pte_t mk_pte_phys(unsigned long physpage, pgprot_t pgprot) static inline pte_t mk_pte(struct page *page, pgprot_t pgprot) { - unsigned long physpage = page_to_phys(page); - pte_t __pte = mk_pte_phys(physpage, pgprot); - - if (pte_write(__pte) && PageDirty(page)) - __pte = pte_mkdirty(__pte); - return __pte; + return mk_pte_phys(page_to_phys(page), pgprot); } #define pgd_index(address) (((address) >> PGDIR_SHIFT) & (PTRS_PER_PGD-1)) diff --git a/mm/memory.c b/mm/memory.c index 539c0f7c6d54..4330560eee55 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -5124,6 +5124,8 @@ void set_pte_range(struct vm_fault *vmf, struct folio *folio, if (write) entry = maybe_mkwrite(pte_mkdirty(entry), vma); + else if (pte_write(entry) && folio_test_dirty(folio)) + entry = pte_mkdirty(entry); if (unlikely(vmf_orig_pte_uffd_wp(vmf))) entry = pte_mkuffd_wp(entry); /* copy-on-write page */