From patchwork Tue Feb 18 17:25:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fuad Tabba X-Patchwork-Id: 13980320 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB5DEC021AD for ; Tue, 18 Feb 2025 17:25:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AEF5128016C; Tue, 18 Feb 2025 12:25:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A73C6280169; Tue, 18 Feb 2025 12:25:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A0DA28016C; Tue, 18 Feb 2025 12:25:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 65AB8280169 for ; Tue, 18 Feb 2025 12:25:27 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 214D41601BD for ; Tue, 18 Feb 2025 17:25:27 +0000 (UTC) X-FDA: 83133741894.27.5D3C760 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) by imf21.hostedemail.com (Postfix) with ESMTP id 430191C000C for ; Tue, 18 Feb 2025 17:25:25 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=KpGEm8AJ; spf=pass (imf21.hostedemail.com: domain of 3g8K0ZwUKCCAP6776CKKCHA.8KIHEJQT-IIGR68G.KNC@flex--tabba.bounces.google.com designates 209.85.128.73 as permitted sender) smtp.mailfrom=3g8K0ZwUKCCAP6776CKKCHA.8KIHEJQT-IIGR68G.KNC@flex--tabba.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739899525; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9GhkdiTtGRQx7HkZyWp1aLkTAfBUArmMth/ZSf0dJkM=; b=Gik45tvY6DA8RtHi682sqBKbehsi3lvfpPe3LnmHzeNR7mB1dA9kVF55dy6TPvedMNbu2K 9zdFLzLO1546jRPOHLEY/FXBqLI4kRAbqLsivyONSRGYW1442lBaiLb3KuUbhUF94Yh/fi ABcNsXReUYsfIPLneA4nU/97UTXpy00= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=KpGEm8AJ; spf=pass (imf21.hostedemail.com: domain of 3g8K0ZwUKCCAP6776CKKCHA.8KIHEJQT-IIGR68G.KNC@flex--tabba.bounces.google.com designates 209.85.128.73 as permitted sender) smtp.mailfrom=3g8K0ZwUKCCAP6776CKKCHA.8KIHEJQT-IIGR68G.KNC@flex--tabba.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739899525; a=rsa-sha256; cv=none; b=pTf61i08HccuOa0Irz2tRDAGc3FDRmNWMK/19FaETd+J4MudI5bzK46Jc6MW2SoJarXUP4 aNUVEKCxlXNlNqGKcPH6aKLn51wQFhOh41IbPID7xqPcFyYaXrR/tiicYHWDqzXPznU/qS 5t7jQBbCQVlOQNVI+FG5PcCRXIzZ/Rg= Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-4394c489babso30553775e9.1 for ; Tue, 18 Feb 2025 09:25:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1739899524; x=1740504324; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=9GhkdiTtGRQx7HkZyWp1aLkTAfBUArmMth/ZSf0dJkM=; b=KpGEm8AJ8lIEo4Ls/UReJmslWxw3kJWM26SwxleVhXK1V2gOWjL1OjCbUMS1at9kb3 joZUBnCbVoghI6vsRHqyRsY5PAYo4UUn8KLWsCbTsnBmoGbUH4KWjhfiVT5jeCV7yDuz GrHkN3M6s7CttZ2qG+EJ7oL78zOtA4Q1Qex2ZFqsX0cdmCAfNam/g6PjwzSktTniflAz LvXCmME02Bp9s2FfQkjjTCgBYR25stvrrGaFa1W/3BgMTPndEwpp4F6lIpmtmyPYiPvd vviUXtEwCfj4hoDosirOzrEm4wscycpBp/p+I+QkRIeocODc95tK3nwzFEFd8iV8lxn2 l0Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739899524; x=1740504324; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9GhkdiTtGRQx7HkZyWp1aLkTAfBUArmMth/ZSf0dJkM=; b=Q8ahKOC1kUXZTtc4rrTCAkLWucnWTZ0Qwb1Zk1ZDuY7v5iBq0PWQjWy3d+Fh06Zm7R qdcdO+EwlJJOYx6ExYzfnvQH6cSCdDRHAEzhnZ4Tm6z7dgVLSeeYcX9XEfcDol6C6vvL jXocIplZ+BHmgJ/EIu7bb2M/LzFDcfdUyqFiy8AGIyq+osPhdIshV0z3wOo6VvNK0n+R L3HIucTXxHng6R1y4Sa3Wi1HrRy2hPoZc5WJW6iWzUoYymTo3wXfCDAt1J8dwwYEynDC Zmq0lMLxi5ACljuol2J3TwFpx46YAVw767PrSypmjIX4eBXHE42d9n4YmgEy9bLbNP39 miAw== X-Forwarded-Encrypted: i=1; AJvYcCUBgnhuw3VEhkcsK4gdhv8OaVX/lgpOx0PDhQ34C/HEJZGekyaIDN7MnveK6uyrvlKw0KSsdgwMcg==@kvack.org X-Gm-Message-State: AOJu0YyhFcp9MtEx6cCRFQuXgmCjjLbu5CSm8J6DFI6ZBhy/c/YNEVM4 owwuMbBekoRh2AlREbX62oOOpWXalb1j2h6FD/fiuT/uShPUWL2s6dAdij7p5tnEYQDoK4eDeA= = X-Google-Smtp-Source: AGHT+IEV4feF4d+8DAbHzGAlutoYlJf9k+yhRtIv1D+yKbeY7XS93jwvPa8IZZ9GBcPiztNTCq3yl8l6ig== X-Received: from wmbec10.prod.google.com ([2002:a05:600c:610a:b0:439:9379:38c7]) (user=tabba job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:1c83:b0:439:9828:c44b with SMTP id 5b1f17b1804b1-4399828c601mr19285985e9.14.1739899523888; Tue, 18 Feb 2025 09:25:23 -0800 (PST) Date: Tue, 18 Feb 2025 17:25:00 +0000 In-Reply-To: <20250218172500.807733-1-tabba@google.com> Mime-Version: 1.0 References: <20250218172500.807733-1-tabba@google.com> X-Mailer: git-send-email 2.48.1.601.g30ceb7b040-goog Message-ID: <20250218172500.807733-11-tabba@google.com> Subject: [PATCH v4 10/10] KVM: guest_memfd: selftests: guest_memfd mmap() test when mapping is allowed From: Fuad Tabba To: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org Cc: pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, tabba@google.com X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 430191C000C X-Stat-Signature: mham3yxgazcndahprzfbiwonfqyu3hgd X-HE-Tag: 1739899525-428370 X-HE-Meta: U2FsdGVkX18ZnW6wiS8IOzeAY2HxJ//wHNCTCuIs4tXd0gLAypb8QCasKYgSrCxghSMfNkJj9djn7X3PGqf2XsxLtmF2cmldVHUHkTiwJubxRIDS1VfKFc0q1SKuYkW8YPfbqPbYazGXgvwKxin963tTicxKk24ErEBVeLDUmrGy7FBFwhFJdWujT6LMfS3NSZIJGJ48HZV8lfgkOmiDrn4UY7n7t+YhqTuaE4mg6JihzEj5tBVp82COWP/HWSxSe9k4QeUHjmqX4kDl7uRm70P2gsbC4FmuzS1jjh3I7AYR6NTbyKlanxejUtgkuIi7N7AJmNHTgU69wAUuEbtEb8OQiyYaMeG6pvZWGTO3c/sHVxACszAfLebsWwqkcpO4ZkD9d4RAY2IhTCsL29M+1iKAinhtk6U1EI6uRjyXOPI3/aX3+PqrOyvJ68oW0CHlgd+GQLB6l7yyt5bRmrMN4n575NQwDzJs1rVoIY/M3N4X4wAAEVzyfMJ5SSvRa+kg8yYXmqYATERv9qVX2hpNJmQdqn53wFhJo9hfDqvxgCrtIMlJkijui3uz3EbEGdNRbdBr3QibPSIpow3AYDxuv0K587Clsxs4nCPux1RnXvPnC30aKMdW2Iz7bZeVBzDCSxjSdoaj2XlE6pxmQdICNklSuFZk9/L6mbHAxYma4EAtATkgeYl8nWwLfvLVzIRoqxWKVZmxuV7WhrUTdBVoEj87DR1eBBg3NFJN/wo4zTZeRHhQ8CSfHtG0yXxxxnSiTjYk6JsceobJjhhav1RE8vyIfL3RChJJzgRBTUoPX1mBbCeX9YmvKoXeUAupAjhxGmdIFM6IPMOEQP1sUUIdjAZSFPQqiJsImcJv5Jliky8HCKcPPOoOmmTrD/Jz5ayV1uOUL0ItusOhEfxdPW6DLaiv4gMmz9+6dOfecsg9fBub5mw24geV0nuJDYgtat1wuDPhePd1NtOr6kDVheU 0AfjGumv IFDYXTLqHySfAhjb8wiMM8MMmCfJZeP5UPCtyLtkwBmEH6dnqujZc2vfT0crgTqNPixPcsBaA62w+8wW6Stq1BH3BgepIPnx/pwM8xD9s3phTWfJw7XgVGXd0IDbzj4Exma2zm3ZzL6+PqSJz866SMMHjXIXQPZWk4BVMcYjZ8os6boolZYLTx1omAu3Op3OoC+0KcuRgoS+vSqZQ8slwuyWhgLXdIrhYP0Srhutu2FHWFU01TdVjY82ayWjg0zHEjQeDgmJlFuNfdDok8yHufmyiMoBG+ZT16XuswLlg7E+gTkiq7ws6od94xk3N8vxcKaxgf9M11tzG9jqKzuhlBejQgHXC3HoTlIYAYw2sHpG3YTrmMYrur1hL6jBkk77QIcsaXYufEN0UxklROTN5RDriRUYspxXpgL1Lc9Mfh0mHE1lUrwbodLyHNG+8EQaDU3iH7JV0uNk9z7onLiRUa+AN+R+csPRPwlX36y29xU3lXSWy27g482KCJZ14EzPB8frxPwUC901beLVI+kD5kCFNfUP2A3c6oOwZcsIaPPgIE9QFdTvyR4PHlZGRnI059QmSXKf98QHATzedUPz7m9A/W74BDpBjQohbmuHChL2ZR6HNoI3XbZOLnkZWmTbaCstU75aiOGAeI0b32mMsyHpqXh87IiYTz3LmL02WMA44u0SAAe3Et+Iy25edwAjy7LMw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Expand the guest_memfd selftests to include testing mapping guest memory for VM types that support it. Also, build the guest_memfd selftest for aarch64. Signed-off-by: Fuad Tabba --- tools/testing/selftests/kvm/Makefile.kvm | 1 + .../testing/selftests/kvm/guest_memfd_test.c | 75 +++++++++++++++++-- 2 files changed, 70 insertions(+), 6 deletions(-) diff --git a/tools/testing/selftests/kvm/Makefile.kvm b/tools/testing/selftests/kvm/Makefile.kvm index 4277b983cace..c9a3f30e28dd 100644 --- a/tools/testing/selftests/kvm/Makefile.kvm +++ b/tools/testing/selftests/kvm/Makefile.kvm @@ -160,6 +160,7 @@ TEST_GEN_PROGS_arm64 += coalesced_io_test TEST_GEN_PROGS_arm64 += demand_paging_test TEST_GEN_PROGS_arm64 += dirty_log_test TEST_GEN_PROGS_arm64 += dirty_log_perf_test +TEST_GEN_PROGS_arm64 += guest_memfd_test TEST_GEN_PROGS_arm64 += guest_print_test TEST_GEN_PROGS_arm64 += get-reg-list TEST_GEN_PROGS_arm64 += kvm_create_max_vcpus diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testing/selftests/kvm/guest_memfd_test.c index ce687f8d248f..38c501e49e0e 100644 --- a/tools/testing/selftests/kvm/guest_memfd_test.c +++ b/tools/testing/selftests/kvm/guest_memfd_test.c @@ -34,12 +34,48 @@ static void test_file_read_write(int fd) "pwrite on a guest_mem fd should fail"); } -static void test_mmap(int fd, size_t page_size) +static void test_mmap_allowed(int fd, size_t total_size) { + size_t page_size = getpagesize(); + const char val = 0xaa; + char *mem; + int ret; + int i; + + mem = mmap(NULL, total_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); + TEST_ASSERT(mem != MAP_FAILED, "mmaping() guest memory should pass."); + + memset(mem, val, total_size); + for (i = 0; i < total_size; i++) + TEST_ASSERT_EQ(mem[i], val); + + ret = fallocate(fd, FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE, 0, + page_size); + TEST_ASSERT(!ret, "fallocate the first page should succeed"); + + for (i = 0; i < page_size; i++) + TEST_ASSERT_EQ(mem[i], 0x00); + for (; i < total_size; i++) + TEST_ASSERT_EQ(mem[i], val); + + memset(mem, val, total_size); + for (i = 0; i < total_size; i++) + TEST_ASSERT_EQ(mem[i], val); + + ret = munmap(mem, total_size); + TEST_ASSERT(!ret, "munmap should succeed"); +} + +static void test_mmap_denied(int fd, size_t total_size) +{ + size_t page_size = getpagesize(); char *mem; mem = mmap(NULL, page_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); TEST_ASSERT_EQ(mem, MAP_FAILED); + + mem = mmap(NULL, total_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); + TEST_ASSERT_EQ(mem, MAP_FAILED); } static void test_file_size(int fd, size_t page_size, size_t total_size) @@ -170,19 +206,27 @@ static void test_create_guest_memfd_multiple(struct kvm_vm *vm) close(fd1); } -int main(int argc, char *argv[]) +unsigned long get_shared_type(void) { - size_t page_size; +#ifdef __x86_64__ + return KVM_X86_SW_PROTECTED_VM; +#endif + return 0; +} + +void test_vm_type(unsigned long type, bool is_shared) +{ + struct kvm_vm *vm; size_t total_size; + size_t page_size; int fd; - struct kvm_vm *vm; TEST_REQUIRE(kvm_has_cap(KVM_CAP_GUEST_MEMFD)); page_size = getpagesize(); total_size = page_size * 4; - vm = vm_create_barebones(); + vm = vm_create_barebones_type(type); test_create_guest_memfd_invalid(vm); test_create_guest_memfd_multiple(vm); @@ -190,10 +234,29 @@ int main(int argc, char *argv[]) fd = vm_create_guest_memfd(vm, total_size, 0); test_file_read_write(fd); - test_mmap(fd, page_size); + + if (is_shared) + test_mmap_allowed(fd, total_size); + else + test_mmap_denied(fd, total_size); + test_file_size(fd, page_size, total_size); test_fallocate(fd, page_size, total_size); test_invalid_punch_hole(fd, page_size, total_size); close(fd); + kvm_vm_release(vm); +} + +int main(int argc, char *argv[]) +{ +#ifndef __aarch64__ + /* For now, arm64 only supports shared guest memory. */ + test_vm_type(VM_TYPE_DEFAULT, false); +#endif + + if (kvm_has_cap(KVM_CAP_GMEM_SHARED_MEM)) + test_vm_type(get_shared_type(), true); + + return 0; }