From patchwork Thu Feb 20 15:03:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 13984126 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80449C021B2 for ; Thu, 20 Feb 2025 15:09:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 149A62802F0; Thu, 20 Feb 2025 10:09:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0FA6D2802ED; Thu, 20 Feb 2025 10:09:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EDC502802F0; Thu, 20 Feb 2025 10:09:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D00D42802ED for ; Thu, 20 Feb 2025 10:09:28 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 47E1E1CC431 for ; Thu, 20 Feb 2025 15:09:28 +0000 (UTC) X-FDA: 83140656816.08.1CB6B3B Received: from mail-lf1-f74.google.com (mail-lf1-f74.google.com [209.85.167.74]) by imf27.hostedemail.com (Postfix) with ESMTP id 3AE5540017 for ; Thu, 20 Feb 2025 15:09:25 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=H3BRI9uf; spf=pass (imf27.hostedemail.com: domain of 3TES3ZwgKCPUgXZhjXkYdlldib.Zljifkru-jjhsXZh.lod@flex--jackmanb.bounces.google.com designates 209.85.167.74 as permitted sender) smtp.mailfrom=3TES3ZwgKCPUgXZhjXkYdlldib.Zljifkru-jjhsXZh.lod@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740064166; a=rsa-sha256; cv=none; b=52nLgmAn1NG143FT79Xzd/k+CmurnxERnixLwopRezr46hxjyuOHEUH84IzWXrYUh7b2Ai X+nWvgn+NMXlnU0IJYfq39duVithPW/9so02+FdaMfIpCkRKxEiJz6CN+lm0lYHl6+4HEF QjnYzIrhD0qdwJKu9ZtOn0pec9NXvhs= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=H3BRI9uf; spf=pass (imf27.hostedemail.com: domain of 3TES3ZwgKCPUgXZhjXkYdlldib.Zljifkru-jjhsXZh.lod@flex--jackmanb.bounces.google.com designates 209.85.167.74 as permitted sender) smtp.mailfrom=3TES3ZwgKCPUgXZhjXkYdlldib.Zljifkru-jjhsXZh.lod@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740064166; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/GEg9bTAKZaokpu/RBxFBw77BnqyC2KwAVRaZb3wfC8=; b=aROtFKothclMkprPFjFsyQKn4s7EECLt+q0ulcYRm8X847nogfvFj8nGw00magseQVQloN eXGjwk7mxFhTT/Iqkxf3+MstgvsQp6Jc3HkLM4DGdhu7WtGLicWHeSq0SRKreluhMho13+ TXbOZp+9ytKc3FO7iwCwtS6eUBSXhgc= Received: by mail-lf1-f74.google.com with SMTP id 2adb3069b0e04-5461901d470so1112450e87.1 for ; Thu, 20 Feb 2025 07:09:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740064164; x=1740668964; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=/GEg9bTAKZaokpu/RBxFBw77BnqyC2KwAVRaZb3wfC8=; b=H3BRI9ufo+GTkf2ORZLB92JWSkvJqqH4ccLGFI8GtbJqT+x2f0IeCT8+H4C/xCWfOV T3nEX4s0nrIGiI5qEUCBj8Odl6gxgCnGPzhD1UYvexw9D5o3/F0CCSgxuekuLWm9w5D2 cUewar6Xp9EHHv4FGsIU16a6/XktE6ECNE7TyW8RgySiHQk+CwNBzSBLUjQRStL3hVP3 8z5mcQaykPCJAwDt83wOGKKXQ4ocewoggk61bFLKIfnclFZS5vDo0cPUKBBIO0jieac+ Jz/1IJf4VvO73AzZqEiE5A+XtSimpTVVjVWDPhwh7ETf+PUooNNhf4/Hc0rumEYN0QTR /tJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740064164; x=1740668964; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/GEg9bTAKZaokpu/RBxFBw77BnqyC2KwAVRaZb3wfC8=; b=N4V3u1klESiQPBKVKBuItIx87quFJ9BfiQvnTJVL4D4O+e2DE0bJmjjpY7nGizub5O Eweauk2d5N0n5/R1NNHEfNDgHSyJWsnTNGTFxKEzA2+24zkXwundBFC2vi0ZNStVBCJa nuBktuVcMVTjzfwouvSFLm1EQ5NU0T43KdmVomodqxRX9uV3KYKBxL1mNhK88CJgRDY5 EJOP3ItvBcdsYyeHIwSTyhvPTZtxGbBBk7tcM5XuikvkVyeaXFwGrN9oyAyzafJvuz2Z FBr2B3utR0bRbrIx1dF1frp9xlluX1uR+PloNlf+0zkkSmw+/YU4b5poa3/tRIgy0BNU db2Q== X-Forwarded-Encrypted: i=1; AJvYcCWBcuMQa1nOrOHyGvGXqCE480MrD5fUO/isDTXXf9tRtR1WkXNcfRZEitehF5J6p4Z6gjPL3VQybA==@kvack.org X-Gm-Message-State: AOJu0YxNIsB9l7iK83wW2Cb4DI7PeU0AIfjRskyNl14t6xrHNLVCpYUK SxTXLvvGeWDPVwk5lsJrz0+OmZO7f5gpFYtOPUB/AwpaCcUNGcSaKgWijjXtMr35p8W7sRHP9NB dbiTXoY+QVg== X-Google-Smtp-Source: AGHT+IFOliTpraR15CWTkacKeBSUqf8FbRBDdkQpsEi0GIcWjSpwR0EViFfPxP8qN/+qIjSryFofPr/PtV4xXg== X-Received: from wmbhc12.prod.google.com ([2002:a05:600c:870c:b0:439:98ca:e39d]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:3b26:b0:439:31e0:d9a5 with SMTP id 5b1f17b1804b1-43999dd1e1cmr69699445e9.22.1740063820541; Thu, 20 Feb 2025 07:03:40 -0800 (PST) Date: Thu, 20 Feb 2025 15:03:13 +0000 In-Reply-To: <20250220-mm-selftests-v1-0-9bbf57d64463@google.com> Mime-Version: 1.0 References: <20250220-mm-selftests-v1-0-9bbf57d64463@google.com> X-Mailer: b4 0.15-dev Message-ID: <20250220-mm-selftests-v1-1-9bbf57d64463@google.com> Subject: [PATCH 1/6] selftests/mm: Report errno when things fail From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Mateusz Guzik , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman X-Rspamd-Queue-Id: 3AE5540017 X-Stat-Signature: uj9yordz6kyrueujdxyrakighsky56nc X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1740064165-923922 X-HE-Meta: U2FsdGVkX19f/AMseJrOmPsp+2sAbjC1ZsKjoNLoxtXaAzDGJQ8sjsp0Izbo9BjcDw0lZm+SNkr0SizraQf67noiFegDzwzkXCGQZpub9oQNNH6zZYqV8maH34J2jUKs9BIfeKWj41mLiuYqwFF/XlKqzpGEOCFajVdE2Zg2jfsz0qi60587cTnXglg+9ywZRaWjotURLlTVIFItQqRcOsuf7YFJG4YiDgNo07RwN6OgAF946fVGxhqrj5iSqA9xkj7U7czfGrHwunppEJY1XwJfi0+XxM5+yvhkWQ1xoBIXi8+mSSzrKKppcikLe8GFB5sBJC7RB2bVBmgrM+NIfVICxrbKUjZGNRon2U3PUuMlmXkafSltKXKYEiL2mFaY9Wav4pkJOL3lwt/qIyJxERRIFKOEjj/6iazO7uoCgD7+sAsiHUEONs0xNMtxH8YCvAIR16qaSMxX40146zLV2sIz0ojTR5iWOCV1ckJYJHkqYadopoWOP2pKczVwj+YOdSFpglAYhoOqWLwwJHWIs07Yd69qaxF2sq9RegH4eksgFnQF+tqBjeDUOLgbkcAguWw25PZANCN39Fz0I//WVxq71UmtbkA/sa5TMf3ulP97dFJtP5RVdYaDfN46GTIycwK4Lb3UX1o2Wwp+VDrxflrDPOiwiNyem6lDqRQKrNgTvn+w4CwyaN+cSq6eACNvnXUhAjXoL8Y/eG2Pv2tY2IMdR55wOP7wOpu6KAHOgah3Y1kMVaNPNBODXJ70Ko1qwsHu1YWWwmEYd7MfLKvaXaSuXHtVeI6by7uADnUhjBXrqAc2IhPBArTPTx0LxVwleYMfLiYkK7u267aRhB1zL91Nwbeept0/BiRY6/GAERUxzLz3CZh+iMvD6JbyD6L+KGlMP4QfJ/CkAqv1kLiAVkJPYNgW3HAsq7iGkYp3PH8fH94lnAyqFkVrRNdIp24zjMZNf6eTNYsPEDrGJmz S3Q2Ulmz bYDQM2z2+fJcOsGPud3iVYpd82hNeh6hUhIKFY+520Ok1x0MoylujjWJayB3L1K5xNV0Cb22u3JCUWlJxApdPDbdWLoP5ZPufHWOa4P/Spr0X8WWmPSwNWnls/3AFREIsV+/VFyFrQ+2NiyxpKFcLW/8ySHDP5znC5dc7ZBgujHCNsiAWGlxUYrgKKu3eISAA1BMj2iIR6hhRMnPtPZZa2z1Ln0Wc7H84rfx/U6fN1Dxqvm9V/eeD12Ha91ZBiGE2Ihvv88IGI5l8mwK2kXqMYV9T7BaBvEFjTuJqL8JB5ST7bPOhPyAGHP6UBNbZgCDDE64VEqR4P2eyYQpOoEyNzlmJdtA0+PrWYiegFwFdjO0PrOEBjLIedlcOKu3Zh6+ceRiXx6wiNA31lWz/Qr6Jb9m2UMwRF3zoKjGcx85qauFdLNtgIXoFfkmuv4zzAHKosTxvk14d4e8bIk43SZ8bGxiB+BdDoQppaGdB3OZEP5wCAV+3K3p3KttMKSyne0KRRHk8goTiXCbqgFcERnHlz6Qm6TxMI50suvNXC99ZjghzWUbaa9STPzV58g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001403, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Just reporting failure doesn't tell you what went wrong. This can fail in different ways so report errno to help the reader get started debugging. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/gup_longterm.c | 32 +++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/tools/testing/selftests/mm/gup_longterm.c b/tools/testing/selftests/mm/gup_longterm.c index 9423ad439a6140163bdef2974615bb86406a8c14..46a2139b3a646f6c050eb031a770f615be76c433 100644 --- a/tools/testing/selftests/mm/gup_longterm.c +++ b/tools/testing/selftests/mm/gup_longterm.c @@ -96,13 +96,13 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) int ret; if (ftruncate(fd, size)) { - ksft_test_result_fail("ftruncate() failed\n"); + ksft_test_result_fail("ftruncate() failed (%d)\n", errno); return; } if (fallocate(fd, 0, 0, size)) { if (size == pagesize) - ksft_test_result_fail("fallocate() failed\n"); + ksft_test_result_fail("fallocate() failed (%d)\n", errno); else ksft_test_result_skip("need more free huge pages\n"); return; @@ -112,7 +112,7 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) shared ? MAP_SHARED : MAP_PRIVATE, fd, 0); if (mem == MAP_FAILED) { if (size == pagesize || shared) - ksft_test_result_fail("mmap() failed\n"); + ksft_test_result_fail("mmap() failed (%d)\n", errno); else ksft_test_result_skip("need more free huge pages\n"); return; @@ -130,7 +130,7 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) */ ret = mprotect(mem, size, PROT_READ); if (ret) { - ksft_test_result_fail("mprotect() failed\n"); + ksft_test_result_fail("mprotect() failed (%d)\n", errno); goto munmap; } /* FALLTHROUGH */ @@ -165,18 +165,18 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) args.flags |= rw ? PIN_LONGTERM_TEST_FLAG_USE_WRITE : 0; ret = ioctl(gup_fd, PIN_LONGTERM_TEST_START, &args); if (ret && errno == EINVAL) { - ksft_test_result_skip("PIN_LONGTERM_TEST_START failed\n"); + ksft_test_result_skip("PIN_LONGTERM_TEST_START failed (EINVAL)n"); break; } else if (ret && errno == EFAULT) { ksft_test_result(!should_work, "Should have failed\n"); break; } else if (ret) { - ksft_test_result_fail("PIN_LONGTERM_TEST_START failed\n"); + ksft_test_result_fail("PIN_LONGTERM_TEST_START failed (%d)\n", errno); break; } if (ioctl(gup_fd, PIN_LONGTERM_TEST_STOP)) - ksft_print_msg("[INFO] PIN_LONGTERM_TEST_STOP failed\n"); + ksft_print_msg("[INFO] PIN_LONGTERM_TEST_STOP failed (%d)\n", errno); /* * TODO: if the kernel ever supports long-term R/W pinning on @@ -202,7 +202,7 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) /* Skip on errors, as we might just lack kernel support. */ ret = io_uring_queue_init(1, &ring, 0); if (ret < 0) { - ksft_test_result_skip("io_uring_queue_init() failed\n"); + ksft_test_result_skip("io_uring_queue_init() failed (%d)\n", errno); break; } /* @@ -215,13 +215,13 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) /* Only new kernels return EFAULT. */ if (ret && (errno == ENOSPC || errno == EOPNOTSUPP || errno == EFAULT)) { - ksft_test_result(!should_work, "Should have failed\n"); + ksft_test_result(!should_work, "Should have failed (%d)\n", errno); } else if (ret) { /* * We might just lack support or have insufficient * MEMLOCK limits. */ - ksft_test_result_skip("io_uring_register_buffers() failed\n"); + ksft_test_result_skip("io_uring_register_buffers() failed (%d)\n", errno); } else { ksft_test_result(should_work, "Should have worked\n"); io_uring_unregister_buffers(&ring); @@ -249,7 +249,7 @@ static void run_with_memfd(test_fn fn, const char *desc) fd = memfd_create("test", 0); if (fd < 0) { - ksft_test_result_fail("memfd_create() failed\n"); + ksft_test_result_fail("memfd_create() failed (%d)\n", errno); return; } @@ -266,13 +266,13 @@ static void run_with_tmpfile(test_fn fn, const char *desc) file = tmpfile(); if (!file) { - ksft_test_result_fail("tmpfile() failed\n"); + ksft_test_result_fail("tmpfile() failed (%d)\n", errno); return; } fd = fileno(file); if (fd < 0) { - ksft_test_result_fail("fileno() failed\n"); + ksft_test_result_fail("fileno() failed (%d)\n", errno); goto close; } @@ -290,12 +290,12 @@ static void run_with_local_tmpfile(test_fn fn, const char *desc) fd = mkstemp(filename); if (fd < 0) { - ksft_test_result_fail("mkstemp() failed\n"); + ksft_test_result_fail("mkstemp() failed (%d)\n", errno); return; } if (unlink(filename)) { - ksft_test_result_fail("unlink() failed\n"); + ksft_test_result_fail("unlink() failed (%d)\n", errno); goto close; } @@ -317,7 +317,7 @@ static void run_with_memfd_hugetlb(test_fn fn, const char *desc, fd = memfd_create("test", flags); if (fd < 0) { - ksft_test_result_skip("memfd_create() failed\n"); + ksft_test_result_skip("memfd_create() failed (%d)\n", errno); return; }