From patchwork Thu Feb 20 05:20:15 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Byungchul Park X-Patchwork-Id: 13983331 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 839F3C021AD for ; Thu, 20 Feb 2025 05:21:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 68AE92802A3; Thu, 20 Feb 2025 00:20:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E8742802A1; Thu, 20 Feb 2025 00:20:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4647E28029E; Thu, 20 Feb 2025 00:20:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1078A2802A2 for ; Thu, 20 Feb 2025 00:20:48 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A31ED4BBE7 for ; Thu, 20 Feb 2025 05:20:47 +0000 (UTC) X-FDA: 83139173334.25.F425614 Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf19.hostedemail.com (Postfix) with ESMTP id 9668F1A0009 for ; Thu, 20 Feb 2025 05:20:45 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf19.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740028846; a=rsa-sha256; cv=none; b=2YB6Z/IvopK8uN4QR+Jypi8TUrtrEQG4CdjH6mpsQUropo/lG66pQdBoFNwMnqjs62mzxp xC2vFlTUmoGGN5rZ9YnrJ1Z3YxrsxqaizzYcp5zYRWGTjENvj52BJm1JOKnfQfPmigcw3A HrcpOthUviECbeL7CDoXN8XU+wVSyy8= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf19.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740028846; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=mXsBLddH25iJJSPexx1TGsWZenYlkNcZaNynnasNZoo=; b=PrSXtBQ0AhD1gBu1NPS4/jfYJFY72ea1q6+8L5YzYY7/hcAAulms4TZd6s+30k10T3Z0jG JLnkkk6OCrtS56nRBD3ZFvBHGCg8/6SC/vUjmifnCNV2OM/HVpRR0DX0PGMG46b5vFN30q 580pTL4kW3jIFjVQxTpBljr0siwDaeo= X-AuditID: a67dfc5b-3c9ff7000001d7ae-f4-67b6bba6ccf4 From: Byungchul Park To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: kernel_team@skhynix.com, akpm@linux-foundation.org, ying.huang@intel.com, vernhao@tencent.com, mgorman@techsingularity.net, hughd@google.com, willy@infradead.org, david@redhat.com, peterz@infradead.org, luto@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, rjgolo@gmail.com Subject: [RFC PATCH v12 14/26] mm/rmap: recognize read-only tlb entries during batched tlb flush Date: Thu, 20 Feb 2025 14:20:15 +0900 Message-Id: <20250220052027.58847-15-byungchul@sk.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250220052027.58847-1-byungchul@sk.com> References: <20250220052027.58847-1-byungchul@sk.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrMLMWRmVeSWpSXmKPExsXC9ZZnoe6y3dvSDU5cMLeYs34Nm8XnDf/Y LF5saGe0+Lr+F7PF0099LBaXd81hs7i35j+rxflda1ktdizdx2Rx6cACJovjvQeYLObf+8xm sXnTVGaL41OmMlr8/gFUfHLWZBYHAY/vrX0sHjtn3WX3WLCp1GPzCi2PxXteMnlsWtXJ5rHp 0yR2j3fnzrF7nJjxm8Vj3slAj/f7rrJ5bP1l59E49Rqbx+dNcgF8UVw2Kak5mWWpRfp2CVwZ P/ZsZC04KVbxpHUrWwPjC6EuRk4OCQETiTWT2lm6GDnA7Edz+UHCbALqEjdu/GQGsUUEzCQO tv5hB7GZBe4ySRzoZwOxhQUSJNY2P2ABsVkEVCVmNhxlAhnDC1Tf2F0OMV1eYvWGA2BjOIHC P2b0grUKCZhKvFtwiQmi5jObxLsd6hC2pMTBFTdYJjDyLmBkWMUolJlXlpuYmWOil1GZl1mh l5yfu4kRGPTLav9E72D8dCH4EKMAB6MSD++M1m3pQqyJZcWVuYcYJTiYlUR42+q3pAvxpiRW VqUW5ccXleakFh9ilOZgURLnNfpWniIkkJ5YkpqdmlqQWgSTZeLglGpgzPlhdov7meX1hzlX j7eIndjz/NQBa59mlz2uVx+zeyfJPbG9bXpQ8VRw2ZXGgvtii24+77AN+bCo4f5XlfMW2Qpd sTHCd12Xl3qedX6+9tHaANZ3J3P2b9kfq9y7fnF27vt/YicuWS++OH+fDue9uBARCfZn2Xyt Z5PY32m5H6j7d9y4sdP7oBJLcUaioRZzUXEiAFB+uU92AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrNLMWRmVeSWpSXmKPExsXC5WfdrLts97Z0g5U3dS3mrF/DZvF5wz82 ixcb2hktvq7/xWzx9FMfi8XhuSdZLS7vmsNmcW/Nf1aL87vWslrsWLqPyeLSgQVMFsd7DzBZ zL/3mc1i86apzBbHp0xltPj9A6j45KzJLA6CHt9b+1g8ds66y+6xYFOpx+YVWh6L97xk8ti0 qpPNY9OnSewe786dY/c4MeM3i8e8k4Ee7/ddZfNY/OIDk8fWX3YejVOvsXl83iQXwB/FZZOS mpNZllqkb5fAlfFjz0bWgpNiFU9at7I1ML4Q6mLk4JAQMJF4NJe/i5GTg01AXeLGjZ/MILaI gJnEwdY/7CA2s8BdJokD/WwgtrBAgsTa5gcsIDaLgKrEzIajTCBjeIHqG7vLQcISAvISqzcc ABvDCRT+MaMXrFVIwFTi3YJLTBMYuRYwMqxiFMnMK8tNzMwx1SvOzqjMy6zQS87P3cQIDOJl tX8m7mD8ctn9EKMAB6MSD++Dx1vThVgTy4orcw8xSnAwK4nwttVvSRfiTUmsrEotyo8vKs1J LT7EKM3BoiTO6xWemiAkkJ5YkpqdmlqQWgSTZeLglGpg1LkjXdLXPGX5tN8CbH3Hpggxr9z6 XeOBpoS47P71YiuMjF//X65ldlPM2+rrMxEra3+WyZtTLmvcXpXWtGzPutn/fPUZ9mw8oMv1 3IG35IPY3ir749UaZ8NX8e1y0L7XekdBTFT7wWFOkcctobuPzZqjGW33yzFLR69jhVfiQvXp y7YJHNrkpsRSnJFoqMVcVJwIALEjBHJeAgAA X-CFilter-Loop: Reflected X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 9668F1A0009 X-Stat-Signature: dzmutxxfog4df1t91fjbrhx83f93md7o X-Rspam-User: X-HE-Tag: 1740028845-225210 X-HE-Meta: U2FsdGVkX1/SQdcnOc9XOMCDkaJLzrHHR4IJgHrGikcjjE4X+RgtHGZpqbU7oZ0J2xURaV54hHmHyAPqUP5c4QdcuAqAsiWZP2ApBLiVcqAidKB2FcP2+ImQa5EER3JPq+igHtR8KWD02K7Y3XE669fZG2B4UPY82sC595BuvloNNL7yKe0rMHwxADbmr1vWyVqBWZ2RaVIXdrlWnKn7TkanPGogmcz1KW6r77tR09NHFsYagq829EIKgTofN15ZocXFLzAzpxe1SsBF9YthoHilPT3KHlrc8a8qDUXX4l1yY2P+SoceueQ4omumDwv7jB42QOuguogKFts9NKzv/TeTb/uDyE1GHrjUzI3LbsLgOa8jBkCrnXgqlD6F8aodyNWvkh9DCsRGlvBe/ut5WtZWVHIR8AJA5q1yTbXluXLOeyfnzCqQi9AeJWf8RCDy5BIpLDp/2cOwe9ntsAZ7/j0+czVexU/TrVvt/mptVmdCUvBFIkVjWCbc0EXw/BU1o+wpuUdhQQdZjAEM3y882AEvtC1WyJsb5mYjzLE3MCfTfNiZsFnrcJP3tjfmErmt6yl0WZfqfdXP1DbwNjghDxwkALo9lX3HgpO76O/WW+x32qj6KTcqyE/YWV4DMN94exx/6E4tNSOobbuOdItOQP6kk4tOn8QTkwAXQId4kazR3rka7aJfjbycw5FBJV2ZrG0UysskPPGbv876BpYHw1A3gvEbRlLCQ6Ew2bO3urca9hz/6VsxrJykijeMIgXQEFQHRKCUEgcPVdvjH3ITv26tTPo4ao3zf4l+MpzB0+GyPmUMCjsZQ1U+oLJCaB1bgSpF/dRj5fYxW0C9zPBPlNerhTEjGsYSrZKEviI9B5v4zen9YMOMOHDoNOsef0gCU1C2IxC2ksSzAJRUpENmI9u4mMhBnxVYBL6zjYiS5ReV7bm1Uzd0xqVZae13r4Ox5oplpCzRfjIqotn4QjR xGg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Functionally, no change. This is a preparation for luf mechanism that requires to recognize read-only tlb entries and handle them in a different way. The newly introduced API in this patch, fold_ubc(), will be used by luf mechanism. Signed-off-by: Byungchul Park --- include/linux/sched.h | 1 + mm/rmap.c | 16 ++++++++++++++-- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/include/linux/sched.h b/include/linux/sched.h index c4ff83e1d5953..a217d6011fdfe 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -1381,6 +1381,7 @@ struct task_struct { struct tlbflush_unmap_batch tlb_ubc; struct tlbflush_unmap_batch tlb_ubc_takeoff; + struct tlbflush_unmap_batch tlb_ubc_ro; /* Cache last used pipe for splice(): */ struct pipe_inode_info *splice_pipe; diff --git a/mm/rmap.c b/mm/rmap.c index 1581b1a00f974..3ed6234dd777e 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -775,6 +775,7 @@ void fold_luf_batch(struct luf_batch *dst, struct luf_batch *src) void try_to_unmap_flush_takeoff(void) { struct tlbflush_unmap_batch *tlb_ubc = ¤t->tlb_ubc; + struct tlbflush_unmap_batch *tlb_ubc_ro = ¤t->tlb_ubc_ro; struct tlbflush_unmap_batch *tlb_ubc_takeoff = ¤t->tlb_ubc_takeoff; if (!tlb_ubc_takeoff->flush_required) @@ -789,6 +790,9 @@ void try_to_unmap_flush_takeoff(void) if (arch_tlbbatch_done(&tlb_ubc->arch, &tlb_ubc_takeoff->arch)) reset_batch(tlb_ubc); + if (arch_tlbbatch_done(&tlb_ubc_ro->arch, &tlb_ubc_takeoff->arch)) + reset_batch(tlb_ubc_ro); + reset_batch(tlb_ubc_takeoff); } @@ -801,7 +805,9 @@ void try_to_unmap_flush_takeoff(void) void try_to_unmap_flush(void) { struct tlbflush_unmap_batch *tlb_ubc = ¤t->tlb_ubc; + struct tlbflush_unmap_batch *tlb_ubc_ro = ¤t->tlb_ubc_ro; + fold_batch(tlb_ubc, tlb_ubc_ro, true); if (!tlb_ubc->flush_required) return; @@ -813,8 +819,9 @@ void try_to_unmap_flush(void) void try_to_unmap_flush_dirty(void) { struct tlbflush_unmap_batch *tlb_ubc = ¤t->tlb_ubc; + struct tlbflush_unmap_batch *tlb_ubc_ro = ¤t->tlb_ubc_ro; - if (tlb_ubc->writable) + if (tlb_ubc->writable || tlb_ubc_ro->writable) try_to_unmap_flush(); } @@ -831,13 +838,18 @@ void try_to_unmap_flush_dirty(void) static void set_tlb_ubc_flush_pending(struct mm_struct *mm, pte_t pteval, unsigned long uaddr) { - struct tlbflush_unmap_batch *tlb_ubc = ¤t->tlb_ubc; + struct tlbflush_unmap_batch *tlb_ubc; int batch; bool writable = pte_dirty(pteval); if (!pte_accessible(mm, pteval)) return; + if (pte_write(pteval)) + tlb_ubc = ¤t->tlb_ubc; + else + tlb_ubc = ¤t->tlb_ubc_ro; + arch_tlbbatch_add_pending(&tlb_ubc->arch, mm, uaddr); tlb_ubc->flush_required = true;