From patchwork Thu Feb 20 19:35:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13984436 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1845BC021B3 for ; Thu, 20 Feb 2025 19:35:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CABBC2802FE; Thu, 20 Feb 2025 14:35:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C5C8E2802F3; Thu, 20 Feb 2025 14:35:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A60232802FE; Thu, 20 Feb 2025 14:35:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 80C2C2802F3 for ; Thu, 20 Feb 2025 14:35:20 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 047C882C2F for ; Thu, 20 Feb 2025 19:35:19 +0000 (UTC) X-FDA: 83141326800.22.1313704 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf02.hostedemail.com (Postfix) with ESMTP id 67DDA80005 for ; Thu, 20 Feb 2025 19:35:18 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=G9946da1; spf=pass (imf02.hostedemail.com: domain of sj@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740080118; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sIctDYQyrFSM2cXYGJVAtURLP1q/MdRjqYByEXer1vw=; b=0VxQ9NutwdLx46TdJzQoo/54s2jsSWdXiRJaUyAwu7C6d+LbDglK0iL+KVXAlBFuTiPoN7 OcudcCo0m2tPk8Xk7mBDwIZoWDRlUVjykox1Ovz8+wvpusehUxshwiThGw0I+UxiV+Z8JY N+7PiITqEef8wsz2MVJ/tiaelhELmzo= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=G9946da1; spf=pass (imf02.hostedemail.com: domain of sj@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740080118; a=rsa-sha256; cv=none; b=LuXvzGnCXIHlEJFv48nm8PhQYYbUrtNTHCnvonCi6faVW5IF4M5EYdwEVWx0C+yBgMC+TU 2fnXxtjh0yKD1coc3C/Y4HH8Vt4neidB0ibOUwhDJqkTBk2PytH14hKu8dM5qs7bDpMTpX L5HDUMyw6/6dIFx/tYXbmUxR36/8Mgg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 5AFB06132A; Thu, 20 Feb 2025 19:35:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B1BEC4CEE4; Thu, 20 Feb 2025 19:35:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740080117; bh=2GbFALk/c9BNCc25jRYoGVkk+3jSEEjMYTr49dqSrPM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=G9946da1cnNgfEsUSUknhKQ7sBC0WcrZgLi2EGaWpPPeZQl7zaAsOY7m9rrzO9r3R 2rL/pyrK9jJc/Vrw8TBPEBETY5IPECmuJ6TIZ3KyyAp1qMx7Z4IBoMR2tXmv6hhsOV 2UEsVohJNOsUYe03IrDOBI7o0Y0qGAyewwoZCNlru/RobSC8bDnJTcZNZWSiEoeUUQ hkmGRAfGNh/Mjkh2g1+GGRPJn7cN7vZ8m7uRXvL+BjX1p1abgtAnknhAyY37zHJuvv REImn0dECTmcI7Y7TIoUQaV67vTnq8ZO6VSQKpVb7Di5mdZuVjx7zjuWgAF50PdHqm m+BMGnnF7R6BQ== From: SeongJae Park To: Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 3/9] mm/damon/core: support committing ops_filters Date: Thu, 20 Feb 2025 11:35:03 -0800 Message-Id: <20250220193509.36379-4-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250220193509.36379-1-sj@kernel.org> References: <20250220193509.36379-1-sj@kernel.org> MIME-Version: 1.0 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 67DDA80005 X-Stat-Signature: facyun6mqw5i4rk3cxde5n57m1j88x47 X-Rspam-User: X-HE-Tag: 1740080118-253415 X-HE-Meta: U2FsdGVkX1+t7JJJj1CQTHwNn/6826smKSHVqrzsE6+7kBmWnxdxM8pxvEpL60drmwF8Tki0K70IfjVxD09k9eqBtKLDrCLQ2vlnNcEnWi+a0SF3nB274Vry3tW9pozyRNWwTc7iVEj7N2MAeABN4FH5YRK5/Biu41rfQJQgQCiDIK5+GI/r1C6zKdbnr3N3zfPdRg5Un/ANGtjE4Hq5UKO5eE9DDZ4rTc1sSzjL12Wn2Ls6i3vSX3iDx3bJ3epxx2in7oZmJRVBXsIXE9Y/pRlm461Ps+khzWk/raw1282+XfmMrZP7pdqAwq9mR837ya0RN5LIR5VD7d+WuX5VepS7SKaTbESmJHt9Nr1J/4ypMncZwS9KG3ROwa4H2IBcm0tdwaGn0hmBoDLKjXhtjeRAtEdU2cY4GxZ/prsarDGS5/4VtfOc/BTRG4SwncHy1bSlu3auvdPUCihau+vPirH/DnsFz8E5TGJ1BkNcB578WEuxfFARY8nwHVGs5hx8Tcq6XXpL09+YlELYfs0ttiljV/3Rx37ogw8h+2NXFuXLXHQPqkMilX04jGySpiwpjxV/PgxKmasoG49ZyvMZ8vhF+C5hPTPcFwJH9+PmeFq6gvbOq4qpbabhEgQEaUwOzk2kfngDTmXsxFuQX5JCV72JfaeUqwISKGaXiszNdojxPRK9Op1KGqrtvHtMIG1qBDerrmiKriijbksA2ICwb5r485PKFDx6B5+UfopDFQOP3iJjp/s0oAbOCv0dSFjlEFZiAKqQW2FKGc9bzjJfY6gWNo2pVFsDB8SkbPUu5TDB3VuwWRguihyEQrm9qUJFmXwW+okYJmla+072jeZU4F9TwZd6+Q4SetWDFTwCtT9N2tIKKVLMol846HYqI062Ri3hnt04Dg/9TwrSxaioSqBdJoapcJAtVQYkigSPW4B/FF0nG5VtaDbk3ECHJI/l1RKTuvcfgdJe+j5SO9o J7bKrgvC HWNziC9zw82jg5uZsVuNIdpIUeu9kS3FEcEGlFBox+R3XmohvM16mE5+d8r+6VUoUtKFTRqaTHSPeFQUZhg4RJzh6dwlGCU3+CIUpr/o/lYQHgfv0OyS8qpcko1smyo0n81yoH71p9mHPp1pA+fH8SA6WiZirB83jQ4nCtQET/WOWOqbWey/99xb7NWYqPxSnwJsQo1nTQ8ekhWfZiACGPVIiqM44pX8eda5G5if6GPlk9i2F23S5kl15eorqOI/1hvTJNie9BfUCsoGaH8ww/RQmng== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: DAMON kernel API callers should use damon_commit_ctx() to install DAMON parameters including DAMOS filters. But damos_commit_ops_filters(), which is called by damon_commit_ctx() for filters installing, is not supporting committing damos->ops_filters. Do the parameters committing so that DAMON kernel API callers can use damos->ops_filters. Signed-off-by: SeongJae Park --- mm/damon/core.c | 40 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/mm/damon/core.c b/mm/damon/core.c index bcb7e42098dc..ffdd84ff6fa5 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -793,7 +793,7 @@ static void damos_commit_filter( damos_commit_filter_arg(dst, src); } -static int damos_commit_filters(struct damos *dst, struct damos *src) +static int damos_commit_core_filters(struct damos *dst, struct damos *src) { struct damos_filter *dst_filter, *next, *src_filter, *new_filter; int i = 0, j = 0; @@ -821,6 +821,44 @@ static int damos_commit_filters(struct damos *dst, struct damos *src) return 0; } +static int damos_commit_ops_filters(struct damos *dst, struct damos *src) +{ + struct damos_filter *dst_filter, *next, *src_filter, *new_filter; + int i = 0, j = 0; + + damos_for_each_ops_filter_safe(dst_filter, next, dst) { + src_filter = damos_nth_filter(i++, src); + if (src_filter) + damos_commit_filter(dst_filter, src_filter); + else + damos_destroy_filter(dst_filter); + } + + damos_for_each_ops_filter_safe(src_filter, next, src) { + if (j++ < i) + continue; + + new_filter = damos_new_filter( + src_filter->type, src_filter->matching, + src_filter->allow); + if (!new_filter) + return -ENOMEM; + damos_commit_filter_arg(new_filter, src_filter); + damos_add_filter(dst, new_filter); + } + return 0; +} + +static int damos_commit_filters(struct damos *dst, struct damos *src) +{ + int err; + + err = damos_commit_core_filters(dst, src); + if (err) + return err; + return damos_commit_ops_filters(dst, src); +} + static struct damos *damon_nth_scheme(int n, struct damon_ctx *ctx) { struct damos *s;