From patchwork Fri Feb 21 18:25:42 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 13986158 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8744EC021B5 for ; Fri, 21 Feb 2025 18:25:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F558280019; Fri, 21 Feb 2025 13:25:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 087AF28000C; Fri, 21 Feb 2025 13:25:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E3C5B280019; Fri, 21 Feb 2025 13:25:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B775628000C for ; Fri, 21 Feb 2025 13:25:56 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5B893C1B9D for ; Fri, 21 Feb 2025 18:25:56 +0000 (UTC) X-FDA: 83144780712.07.3CBD8C8 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) by imf29.hostedemail.com (Postfix) with ESMTP id 74359120007 for ; Fri, 21 Feb 2025 18:25:54 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=tVMBNaMz; spf=pass (imf29.hostedemail.com: domain of 3McW4ZwgKCOINEGOQERFKSSKPI.GSQPMRYb-QQOZEGO.SVK@flex--jackmanb.bounces.google.com designates 209.85.128.73 as permitted sender) smtp.mailfrom=3McW4ZwgKCOINEGOQERFKSSKPI.GSQPMRYb-QQOZEGO.SVK@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740162354; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cTcycxfD9DCcL+mqAzEBCNl+Z24hIPU7/F5XNHmMRAA=; b=lvFZPm3R+Srf7/D5nWm2HCw/f66IJCGg1e6Rud1mMJt2dU1kzODS2fppjH9cVQ6F+670La o/lAkSfm9+vzxDquo5uWcGG1pG1q7KHolrMBGp4jtl4O/8pE9xngkncph8dEd3zq72kFlP gVgTke84vDhhXLdnu8pGgHowpRRaaiI= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=tVMBNaMz; spf=pass (imf29.hostedemail.com: domain of 3McW4ZwgKCOINEGOQERFKSSKPI.GSQPMRYb-QQOZEGO.SVK@flex--jackmanb.bounces.google.com designates 209.85.128.73 as permitted sender) smtp.mailfrom=3McW4ZwgKCOINEGOQERFKSSKPI.GSQPMRYb-QQOZEGO.SVK@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740162354; a=rsa-sha256; cv=none; b=r23UNtJfqhINmaLtw2ptb5oK3Yd88NUvkYN9yDYIgQRSyD65jgMtjv9UZJ/BbkLZ9sx8eH 5erpNAickFlqct2AFLBADFFTqrAhClCPcCZCcFpUVgxNbMrvw/dG11dIXzz0VtOsDVTR3l xkYQ7rMaKNFHzgAumERsmjPMK8TKlHw= Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-4393ed818ccso16380935e9.3 for ; Fri, 21 Feb 2025 10:25:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740162353; x=1740767153; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=cTcycxfD9DCcL+mqAzEBCNl+Z24hIPU7/F5XNHmMRAA=; b=tVMBNaMzce1Qws9ll6ZKi5ELXKShyZWMkWHa+rCY7XWYvi+H/cPJtndgf/gI370xoq FOZf/MVFuqC03AhGLGOJosEuJUDs8Ok9LTqkI6wfsMO+ZQomHvqRvDPsIxY5zAPcE8hJ 4MjzZfe5XY1HWkoe/oktVmJEt+InwQD7DJ29S+DALmD3QEJvDPbzoHTHJOoeP6udbkVH Vf1DBCmPG7S7OOiwe99tLXWWcFhdKo3gy8zXoERQ0KkD5fLzM7O38OYu5LdQXZlWVpm+ 4uB7qyNUek7oZHEtpX/A7YGiE38vMZrfOyINgS/cNlA12kSMbwXI8R3vXEEw3uLL/ai8 WO2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740162353; x=1740767153; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cTcycxfD9DCcL+mqAzEBCNl+Z24hIPU7/F5XNHmMRAA=; b=iIiilg/3X0YDEcBEuwvR5y1NVf3tuFJvLGdolbeJnpToGXiwF9/ZeRduFDPahg+zKL 1aYiRbeIUWRVO8TUhSF8yY5afVU4IUWWhq8JihPUYrNbIERGoK9U8BG3ZpAkP7ao+bT2 hYGhJiDmdUmDRzIbrA5TwQq/aKPyTis7uQmUxHiFuycyqJJMfkWhyxD+r7/eKnA1q0S7 hUSj3ch3Lbohet4CHjyT1feNYXlDwbbrcX05BlY+p3mXr5c2pSCTseju1fyjOrjMPNn4 v/Oo1P8X2U2zKkPmSy8FXECAEDUhMa0CWXUpQ6VbGKd1CHc1TWa6zewYb047jNB2VqRV MJXA== X-Forwarded-Encrypted: i=1; AJvYcCWEKdYREqyEi1I2CmeIK2cvPvN6Agow5H2JIb+5/TX88dIdhW+mArWTHZu+Y7Eqox4Z3pu73YD/8w==@kvack.org X-Gm-Message-State: AOJu0YzxFQhuYpggbgXE8sxBmeJfxfVMIk6ixkGTCp+kFW4cD1HeGBsx UDUCyVh55m8VodNk4+ylGgCICAqXComPxWM2AnOGZF1dgliIf1o2qw13vIrXR+elfI6wDTJ6H5l baFzxbVc7dg== X-Google-Smtp-Source: AGHT+IEszNIJhkJzwGv9AsQzVYAac3pftoItIw5cS1KOScI8cPLKnS0ZHcBEzvcUimaonjHx8RHsIBeFDU35jw== X-Received: from wmsp4.prod.google.com ([2002:a05:600c:1d84:b0:439:942c:b180]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:4f86:b0:439:59cf:8e16 with SMTP id 5b1f17b1804b1-439ae21644cmr37029575e9.23.1740162353265; Fri, 21 Feb 2025 10:25:53 -0800 (PST) Date: Fri, 21 Feb 2025 18:25:42 +0000 In-Reply-To: <20250221-mm-selftests-v2-0-28c4d66383c5@google.com> Mime-Version: 1.0 References: <20250221-mm-selftests-v2-0-28c4d66383c5@google.com> X-Mailer: b4 0.15-dev Message-ID: <20250221-mm-selftests-v2-3-28c4d66383c5@google.com> Subject: [PATCH v2 3/9] selftests/mm: Skip uffd-stress if userfaultfd not available From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 74359120007 X-Stat-Signature: 38ksd7xgxt8wyy9hbjbk681ahnz6pkfw X-Rspam-User: X-HE-Tag: 1740162354-160820 X-HE-Meta: U2FsdGVkX1/1fTh+JCV3ds4H01NTLSWq7XeMIlArqjgdTzPTcKogtLusrt+xDBHz8PD5RLcnVUVFwNxpCxPns0wN1tZ4T73m/NWbxnXzB3N99NFbdmRLE5rB8JFYNkM9as+Du7EMLvhx5x2LpB/WMlm8RT/o63Fwfu+Dt81DqDGvC6/w6mDFWxL71QJUlxq2goFhCmIG9lYW60cwqYXxBpHK8JnElWlVBdb4Dv09XalR9O/dhBouvxzL6tA0U9+M9szW5YAt208dPgM+uUq2ooFHsebN8fQRKsCaKPbpzFhLkHsFhKl0eWskukcoBHCJWgzeZZ479X6lAtZGOeIbJquW5yBAlPWLLz40V3X+TlxQWJYK9TGX/GKhJiaYDrpT6h727qwB7LQdZrt7xUdT+4rao2ZumH0ilmFEk/EueOH8XtTP7YLagBbsNRgwntM2j2UUXAnxEY7GCHHo+YebwZkLe/01LJhSV187HQGLHDJSQmzG7X4wFl3tyd8/neRP3jd43bJPzxil79aooIn8kx3/lczvVBC1T2SnMmu9ff/p22HTVw0tlyMoAU7Ins8IoiEpJ7HCEs6kVVbhX8yQmodB9odwLU3+fK5NLUd4kR8QRFdnJ5Ipe1zdUO457+xxhXyO3yLYxlQpcJYXpl8ko8GnizD1oAx0STzxen53L1ni6BxPm1dMkj6Sav5vyag/RddlkGQ88opla/OFvsSTJdtFfcE9zk6WwScPz7ypfIFStEWmI/bjrPUwelp37jNxwumfp5q/SxW5L0PxlXE70rS2EmA828+zIHf4fKn6swuG1KyWR7cI8sFXdJVPjQTMpcC7BVNCSHUZbEMt2yrI3sjuE9fFSyxlgfembAp9YW4jA3exis6/23wFDU7O+fiZF1YVSHqNAZ/7I9xy3mdx+aXq+lBm0PZv0u17ehyxEyuPVYHaEWcR0chvBM+L+b/OZEolA0o9/3tLPfiHcmY yo30ksTi YtqB4W07kFRZuANf2TuCSvyk+Zg4Sh5apRYuzwo2o14pM0n9WkapclbBU2XEZSJJPky6JpDqMb5jggh7iUej1QDHxiE9rJQHBYdRYWpvOqnxxH2chPCbXCdC7xL/SWHFe9DAAdYOtRI7DWLHS5/Zg/6vcTc4Vdm98f6oX4VxeX2zGYR5AqQDnxpDRXmuvsUDzuLKlIvQn3lz2LgjLCs05YnnQS7BYxzVtOdhhJUNHJeNHTTVY7mtpCpU3pThbR9CweoUsdJ1JDqA25YnH1h7lxf8zxwDQAGGgd/tYWX3Jy/B33KMndRl0Cdxy59Z17hiIGSs0/1aEcQzlnNqo1+lHdTnQqI1P4J/yjHvjRcu2immJlpZdJc9jCX1N7NNLVoHVO0fFA20AGbSj6H0U168T3gbBbKZYvxMv95h3MI8wC+SY3vyda+U4jn7db0x9cfs3rpryyNSOvqFHr1GfCsNb71QapIWTQ4mN4JuBT7cgXwWLjAxwZay+AkX9wxGD5qXFnt3+ASQk5Gk4a4t0iYz7ynMKgcvuVX/oTgkcBDYGQi0MGJ+ynVbtQQUeeQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.270505, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: It's pretty obvious that the test wouldn't work if you don't have the feature enabled. But, it's still useful to SKIP instead of failing so the reader can immediately tell that this is the reason why. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/uffd-stress.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selftests/mm/uffd-stress.c index a4b83280998ab7ce8d31e91d8f9fbb47ef11d742..ed68436fac62c76e2ca7060c661487f2f8a6ab45 100644 --- a/tools/testing/selftests/mm/uffd-stress.c +++ b/tools/testing/selftests/mm/uffd-stress.c @@ -411,8 +411,8 @@ static void parse_test_type_arg(const char *raw_type) * feature. */ - if (uffd_get_features(&features)) - err("failed to get available features"); + if (uffd_get_features(&features) && errno == ENOENT) + ksft_exit_skip("failed to get available features (%d)\n", errno); test_uffdio_wp = test_uffdio_wp && (features & UFFD_FEATURE_PAGEFAULT_FLAG_WP);