From patchwork Fri Feb 21 00:53:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rik van Riel X-Patchwork-Id: 13984678 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22D51C021B2 for ; Fri, 21 Feb 2025 00:55:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D7726B008A; Thu, 20 Feb 2025 19:55:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D76F3280009; Thu, 20 Feb 2025 19:55:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE1EA28000C; Thu, 20 Feb 2025 19:55:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4542B280005 for ; Thu, 20 Feb 2025 19:55:09 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BA40A801F4 for ; Fri, 21 Feb 2025 00:55:08 +0000 (UTC) X-FDA: 83142132696.10.BFC063F Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf27.hostedemail.com (Postfix) with ESMTP id 1177340003 for ; Fri, 21 Feb 2025 00:55:06 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740099307; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lx8kkE5bATflrMu8IGtIlQjO2P3voRfd0uK9epWuJlI=; b=lM1uV8iJjkAqKzpx1ofEMxPk05ckN9BXqiuQwdG1Is+5b4y2PjDQ8NE1xopWxSB8QBAkS5 rMK+cyZBEkL24bhHhmwz7favjEMyj/eYUsu8E/s8POJ+Xkic9TCcPOj4xp/zyO8Pi3Gy7p AAE4h/cMNOMnW4nCtoL4zV8mB7wnhCY= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740099307; a=rsa-sha256; cv=none; b=ubGUYS6TUmNvPtqzYxuDBPKXra9N8kSDWAbKlfLu7fmlzoMmZoFXIP/0bkOe0lBrk5JjyG h/CHwS2on9uHElychsu3+dvxgpex8xVTxclhT3bW/8IMtEzp6AOIy+az6MjgIpg2dLuuWh CRL6HwDbb4cdZ3e8E3CEJMNRF6m5Cl8= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tlHIZ-000000003Qf-1z6G; Thu, 20 Feb 2025 19:53:47 -0500 From: Rik van Riel To: x86@kernel.org Cc: linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali.Shukla@amd.com, Rik van Riel Subject: [PATCH v12 14/16] x86/mm: enable AMD translation cache extensions Date: Thu, 20 Feb 2025 19:53:13 -0500 Message-ID: <20250221005345.2156760-15-riel@surriel.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250221005345.2156760-1-riel@surriel.com> References: <20250221005345.2156760-1-riel@surriel.com> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 1177340003 X-Stat-Signature: kaspe3pm3ijagmz9khcaedwocrfswjg9 X-HE-Tag: 1740099306-422701 X-HE-Meta: U2FsdGVkX1/Ak403kLUv54GbVqSSk5uJ9cLVRi4ii46BEWknvneL75Q8kExpjPtHZRGXBJj0HYzzHQeAHja1NguZWzzole92zNWiNTZ1xS4n+LUIBwI+/I27dROfi9hlIbk6AVYhj4SJiF+azYnPjdbDbpaYaZtcMGRWntcGVaWFo+7vEvnNzJSg2s+2Bu5Hp9AykF3MOGl7InEz6G5GOAwfNjWPlNhiFmy/wH95o++c3IFXpcbBQGFr/r3nNqIGIIGXn8vNkW0RGiI379U3ys7K61XXqedkHl37yDFhlBJ4tiBLPScHBMZ0nXDFB48cgSNE7+qE0sUpvV/fg33oX069KVg7bFXW5RgWU3wRCuvFU+qkFu5BtzbFjTZqGq4BFy3N97tWU15NM15n63y8bfniAKPrD6Rp5D3OTaiWkagfXzcJwoe0MSrBDutAb1BRWA8ePOp/vD8oqooLwZ5ZvBUEH4DWBn1BB5Q354LCpcVfKLVBdrzONuowW6hTg5w/w4D1wSlbqJ2JGmMCJSh03ZzTC6kd7lgoWAVK2NLaIRyJ9dCzzBUj5KBuz6yb/pTb5Q5o06OEcf1SQpsfDX4TLQV/CnlsdDPaWJ4zNgQXpfKb2Jk5vCow3sArOwOIPkkbUoXR+vG3KkB18+a+OL7uMEb72GvQzUYixzoGX3RC03acaDJI5RfVV/k0JIFWGnDtoukFXSELlXW/0SHoSHqh8PVLvIhK7/FNkky1fPRp3GU9LqA8qqNrQCrQlpv9zjR4XBAy/Z3mJJeNMazjtA3iLQLP1wHE/s2XZH72MRFfgckj9bAA+VTAzIjEkk40fHrV3j9lMBau0gy8HArM8h5xv1pCK+UjPQzCvGHXkp0S6ZNJ9KHk2eFTkbryDapMCe/cU2V8gzUTW+q9bTbUMOU3vrdorq5+rjF/V4AxugTBagFRUwDTgdvuzo8SWoZ3uld78+9KOvynyxNNuTU2NNg x0CMlft2 +lKlEcU8bx/0ymv9TieBwzNlYpsR/PCv3LCYMbaqe+IJVMm1pP8XwOApOiSkpAjRlflm1cNReC+j9wh8Y+pms5RkqflNtwzuI356CKyg4Zk4Q0oiQ3stwoZVNpvjYb42V3CyR6Tq90h4ixGcl6sv3F7fK08/Nr7yezSE9iKvD5Y4ho1YmDfYPWGhSJkPHN8xpUo+lqJZ6hgHT+pJ9OF8SF//mBL56jTACeZoVm8iuEfxzy45jSHv2ENJVx1K+NLtsyV3ZlBqbIj5n0GGidtJ6PX9NKJ0UijTcXLZeRuyaF5LaCuEnFXYthQIeyQww7iwZ3zYgmZ3HuficIRgRfyDeCtePOU0fSxfpQKQxh2xC8iBVl3WLF+5j/NabPPPqO+yw3P3DOQzXyE1HPdVH+RVfqh3PQFv4xkbWo6Y2B4wsMPKEYdA+9RqjyISdjBWJSu3TgwfJR8ZKCUyha58= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: With AMD TCE (translation cache extensions) only the intermediate mappings that cover the address range zapped by INVLPG / INVLPGB get invalidated, rather than all intermediate mappings getting zapped at every TLB invalidation. This can help reduce the TLB miss rate, by keeping more intermediate mappings in the cache. From the AMD manual: Translation Cache Extension (TCE) Bit. Bit 15, read/write. Setting this bit to 1 changes how the INVLPG, INVLPGB, and INVPCID instructions operate on TLB entries. When this bit is 0, these instructions remove the target PTE from the TLB as well as all upper-level table entries that are cached in the TLB, whether or not they are associated with the target PTE. When this bit is set, these instructions will remove the target PTE and only those upper-level entries that lead to the target PTE in the page table hierarchy, leaving unrelated upper-level entries intact. Signed-off-by: Rik van Riel Tested-by: Manali Shukla Tested-by: Brendan Jackman Tested-by: Michael Kelley --- arch/x86/include/asm/msr-index.h | 2 ++ arch/x86/kernel/cpu/amd.c | 4 ++++ tools/arch/x86/include/asm/msr-index.h | 2 ++ 3 files changed, 8 insertions(+) diff --git a/arch/x86/include/asm/msr-index.h b/arch/x86/include/asm/msr-index.h index 9a71880eec07..a7ea9720ba3c 100644 --- a/arch/x86/include/asm/msr-index.h +++ b/arch/x86/include/asm/msr-index.h @@ -25,6 +25,7 @@ #define _EFER_SVME 12 /* Enable virtualization */ #define _EFER_LMSLE 13 /* Long Mode Segment Limit Enable */ #define _EFER_FFXSR 14 /* Enable Fast FXSAVE/FXRSTOR */ +#define _EFER_TCE 15 /* Enable Translation Cache Extensions */ #define _EFER_AUTOIBRS 21 /* Enable Automatic IBRS */ #define EFER_SCE (1<<_EFER_SCE) @@ -34,6 +35,7 @@ #define EFER_SVME (1<<_EFER_SVME) #define EFER_LMSLE (1<<_EFER_LMSLE) #define EFER_FFXSR (1<<_EFER_FFXSR) +#define EFER_TCE (1<<_EFER_TCE) #define EFER_AUTOIBRS (1<<_EFER_AUTOIBRS) /* diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c index 54194f5995de..b9b67d44c279 100644 --- a/arch/x86/kernel/cpu/amd.c +++ b/arch/x86/kernel/cpu/amd.c @@ -1073,6 +1073,10 @@ static void init_amd(struct cpuinfo_x86 *c) /* AMD CPUs don't need fencing after x2APIC/TSC_DEADLINE MSR writes. */ clear_cpu_cap(c, X86_FEATURE_APIC_MSRS_FENCE); + + /* Enable Translation Cache Extension */ + if (cpu_feature_enabled(X86_FEATURE_TCE)) + msr_set_bit(MSR_EFER, _EFER_TCE); } #ifdef CONFIG_X86_32 diff --git a/tools/arch/x86/include/asm/msr-index.h b/tools/arch/x86/include/asm/msr-index.h index 3ae84c3b8e6d..dc1c1057f26e 100644 --- a/tools/arch/x86/include/asm/msr-index.h +++ b/tools/arch/x86/include/asm/msr-index.h @@ -25,6 +25,7 @@ #define _EFER_SVME 12 /* Enable virtualization */ #define _EFER_LMSLE 13 /* Long Mode Segment Limit Enable */ #define _EFER_FFXSR 14 /* Enable Fast FXSAVE/FXRSTOR */ +#define _EFER_TCE 15 /* Enable Translation Cache Extensions */ #define _EFER_AUTOIBRS 21 /* Enable Automatic IBRS */ #define EFER_SCE (1<<_EFER_SCE) @@ -34,6 +35,7 @@ #define EFER_SVME (1<<_EFER_SVME) #define EFER_LMSLE (1<<_EFER_LMSLE) #define EFER_FFXSR (1<<_EFER_FFXSR) +#define EFER_TCE (1<<_EFER_TCE) #define EFER_AUTOIBRS (1<<_EFER_AUTOIBRS) /*