From patchwork Fri Feb 21 00:53:07 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rik van Riel X-Patchwork-Id: 13984676 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46C49C021B4 for ; Fri, 21 Feb 2025 00:55:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B3397280005; Thu, 20 Feb 2025 19:55:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CE4D28000D; Thu, 20 Feb 2025 19:55:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 783AC28000C; Thu, 20 Feb 2025 19:55:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 38A456B00AD for ; Thu, 20 Feb 2025 19:55:09 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DEBA08021E for ; Fri, 21 Feb 2025 00:55:08 +0000 (UTC) X-FDA: 83142132696.22.E131089 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf08.hostedemail.com (Postfix) with ESMTP id 5D592160003 for ; Fri, 21 Feb 2025 00:55:07 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740099307; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HJW3QmIpSlqNaI883v50yEcBcnAci6RjnvBZXp2DQnU=; b=HvmST8y/0s/uuSf0JmtgHhZ63WcehM8n5B0o3GqLv0wYwT7T4e4ena2BIJEaBefJJuoVPF eVokX4TKJhjYELVdVXJR8uy63lpaoz8WJ4GHHNQsze6VudUSQ/PQAfj9fhjjgOwHbsJsst ysmk2R3GUN6yHlHlOstK+ZR0E/SYzOg= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740099307; a=rsa-sha256; cv=none; b=aCy8nBMT1rhj/f8D3tHJdGKBm0k1aGaLH2ANVXsqqCBJGgvr7xhYyV0gaHb7/yYoG7l+Sn qWeu/CkwGKIc2tA6xb6wgYH53gafH339M0xbcre3RKem/z3cQ1wQBgWAjiK2Hs2WPs6lzO yZi2RmZDl8qREEkU7k6TrJn5O7X654E= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tlHIZ-000000003Qf-1ILt; Thu, 20 Feb 2025 19:53:47 -0500 From: Rik van Riel To: x86@kernel.org Cc: linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali.Shukla@amd.com, Rik van Riel Subject: [PATCH v12 08/16] x86/mm: use broadcast TLB flushing for page reclaim TLB flushing Date: Thu, 20 Feb 2025 19:53:07 -0500 Message-ID: <20250221005345.2156760-9-riel@surriel.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250221005345.2156760-1-riel@surriel.com> References: <20250221005345.2156760-1-riel@surriel.com> MIME-Version: 1.0 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 5D592160003 X-Stat-Signature: 15t1fo8suud165y6ocboqhjwts56rxwy X-Rspam-User: X-HE-Tag: 1740099307-871212 X-HE-Meta: U2FsdGVkX1/hPERC3D8KZU74Sfzb6nolKSRUDR/WmvGO84WzE1qyG2MnXI8JjsDfNTbDTiUf+x06hLre2wsc09uEZJGIqNY9q3+9XHz5TsExkk/fORB8gzZiYUvPS2bujBFKYI/qgmq11X6GbHgc9ENmKUa8kZbgZ75kxJC8duo2l8x56OFTt3hECZrI9TYDZIGCsSXL9PVsIasfGE7LM5NF7eO5W7cKVolxnD8efhajKEy1spkCA+lqsUlqvhBHouRSdXhvlVt1MRubG7ZDu7QsGRGHoAMdlWCIlWrCIF9z0zh2Sq1JwKv2YxA9IdlDu1TawaloG7YL18iE+EkIzk90Cf9BYYvV9lV1WocCXUg4x4OMdhcvkXpHH3Kiiy7zOfKffYNP5nVZGbSduknAat4GA7x9ko1V8A8V0qXAGYTE5IfYclpqdx0EF5x6fu1Kuj5xkh3WH4XiehN7xGMn5hZikb4UNNirFupRFyN6vb+KFSgExLMVBWKazb5/1OYNYCKJ+FyWYfky8KfbVOZ2zsUq6kSQOI5pc3+lQenSnqf+dX3Ln/9hH6R3yvseoptqtZyyxe4AB56KUkxBme7n+os5HmE4Lc1WFc+JuOXnLRUTvuNRPS6vnjZ9DACsMUSXHgvRsM9kGRTpadQWyjsG7EJ5fex7gS8dS6Fzj8AqVc9sglqhp31wjMcBitHMxugfMbUCxV0pHmMLUogv1swEwf6Q41At/R8ek5gtWToY6B8vNQHxH8nQrSEYNQiB6ABp5iOiWG8sB8eujL0YA6b+VU7j4qvaxWauJlnGF+4zAtkmpJ4mIOGKBNQaseZrodmYduMm/jyVuJZsugGSzwz/H1DdDR0ez9nMYpTVo6f6r1jHGfvVql4nEFwqI0Le86NOPQnt7JdX10DEDbglF60BhSxKXhSEoZz9Orzwk9a9tVJOrGi4mgtpY4AEXRjLl3UtX8kygDxmaQFCu+qzTVC ilWSgX5J 0qn2ZxKBUCJlVzVDM88t3vv1EznWBsIaxV/36ghx63wOQCaCJBj5egF81pNiJIKPFn/QznL981vtHwLn9qJ9DEhIIai4yf1TQjUeFYORtQ7smzabyUuL2g1FUHsHl+zxNIamk+4Wmesm1bVZmbA1XqeUQs41wj3H1MtL1FOg+a9kSHSXKfenX5HleauwM3+Mm3KAkQTwtJ7syqAgzuLYIFJAcsK/9oL3kRhLgIU/pKwL+K5Wspl1MdGF0zMWLS7UXrCNJ/DSKm7FHEAd8HP99ap9BIRAiaEWf+q8Au3U2qsQizsbcEW0y+LMVMyl17fDkTzinEYYWHOcb7KXG79p/06RrA0zpCGNfREDMaOGCr7PbfwXLVH/K9+mLOLa7w63JxRDu25cXwV9kY5A7Ae1K7o9+lLwuDjr7+XbyrjeGIbck/GZgBmd1VYYtRW7CsomsLcpDc5q2X64vNJE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: In the page reclaim code, we only track the CPU(s) where the TLB needs to be flushed, rather than all the individual mappings that may be getting invalidated. Use broadcast TLB flushing when that is available. This is a temporary hack to ensure that the PCID context for tasks in the next patch gets properly flushed from the page reclaim code, because the IPI based flushing in arch_tlbbatch_flush only flushes the currently loaded TLB context on each CPU. Patch 10 replaces this with the actual mechanism used to do broadcast TLB flushing from the page reclaim code. Signed-off-by: Rik van Riel Tested-by: Manali Shukla Tested-by: Brendan Jackman Tested-by: Michael Kelley --- arch/x86/mm/tlb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c index 2d7ed0fda61f..16839651f67f 100644 --- a/arch/x86/mm/tlb.c +++ b/arch/x86/mm/tlb.c @@ -1326,7 +1326,9 @@ void arch_tlbbatch_flush(struct arch_tlbflush_unmap_batch *batch) * a local TLB flush is needed. Optimize this use-case by calling * flush_tlb_func_local() directly in this case. */ - if (cpumask_any_but(&batch->cpumask, cpu) < nr_cpu_ids) { + if (cpu_feature_enabled(X86_FEATURE_INVLPGB)) { + invlpgb_flush_all_nonglobals(); + } else if (cpumask_any_but(&batch->cpumask, cpu) < nr_cpu_ids) { flush_tlb_multi(&batch->cpumask, info); } else if (cpumask_test_cpu(cpu, &batch->cpumask)) { lockdep_assert_irqs_enabled();