Message ID | 20250222160850.505274-2-shikemeng@huaweicloud.com (mailing list archive) |
---|---|
State | New |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D31C9C021B2 for <linux-mm@archiver.kernel.org>; Sat, 22 Feb 2025 07:12:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E1D186B0083; Sat, 22 Feb 2025 02:12:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C81056B0089; Sat, 22 Feb 2025 02:12:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BD296B008A; Sat, 22 Feb 2025 02:12:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6813D6B0085 for <linux-mm@kvack.org>; Sat, 22 Feb 2025 02:12:38 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id EE2A81C8250 for <linux-mm@kvack.org>; Sat, 22 Feb 2025 07:12:37 +0000 (UTC) X-FDA: 83146712754.28.2EA0735 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by imf04.hostedemail.com (Postfix) with ESMTP id DE9AE40006 for <linux-mm@kvack.org>; Sat, 22 Feb 2025 07:12:33 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740208356; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l40Nd+qI8Vvprc42br0mc9djnmJrS5l15N20I3XNAQM=; b=dUmVhDBdHIkWtE+1y19QNc87Sr8Wej88n+9iku2S0XTLYY9UTvSV17elw+i4EaMDFG8Czc 3Z+PiN4IPz6xk4Y2s2snmYh1miUCmBs72hyepDDcjsiOZtvoy5bSxY5KIR0UnD9e4UKSR7 MCqkNb89i7HAa3AjFT0FYwUtYvRxwnE= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740208356; a=rsa-sha256; cv=none; b=0oI3+r4wuz9FvJG0QhiV71X35PGhHVbNf7yZt0E53WeGa5jE/aC6rEgNze4pv6U1Li5viY oyzXyGK+uErdE9ykw6pDLgQSXt1od9DGa8np5bZBDPM8Y0VAf3xjTnhWz/NBiKwaweIMkk nkNxDhilmuq47JpEqijuArjAPRkMNfc= Received: from mail.maildlp.com (unknown [172.19.163.216]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4Z0J8r1s2Xz4f3jt4 for <linux-mm@kvack.org>; Sat, 22 Feb 2025 15:12:12 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.75]) by mail.maildlp.com (Postfix) with ESMTP id A295E1A0E98 for <linux-mm@kvack.org>; Sat, 22 Feb 2025 15:12:28 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.101.6]) by APP2 (Coremail) with SMTP id Syh0CgBHBWjaeLlnrTsjEg--.26688S3; Sat, 22 Feb 2025 15:12:28 +0800 (CST) From: Kemeng Shi <shikemeng@huaweicloud.com> To: akpm@linux-foundation.org, kasong@tencent.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/6] mm: swap: avoid losting cluster in swap_reclaim_full_clusters() Date: Sun, 23 Feb 2025 00:08:45 +0800 Message-Id: <20250222160850.505274-2-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20250222160850.505274-1-shikemeng@huaweicloud.com> References: <20250222160850.505274-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: Syh0CgBHBWjaeLlnrTsjEg--.26688S3 X-Coremail-Antispam: 1UD129KBjvdXoW7GFy5Kr4fXF43Aw1fJF4xWFg_yoW3CFc_Aa 4vy348GrZ5Jw1kGr12y3yrXrZ7Krs7ZFyjgry3tFWxA34fXFs7tan7Gay2gw1rJa1DCa4r J3Z8trn3X39FkjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbf8YFVCjjxCrM7AC8VAFwI0_Gr0_Xr1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l87I20VAvwVAaII0Ic2I_JFv_Gryl82 xGYIkIc2x26280x7IE14v26r18M28IrcIa0xkI8VCY1x0267AKxVWUXVWUCwA2ocxC64kI II0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM28EF7 xvwVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2 z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4 xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v2 6r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCF04k20xvY0x0EwI xGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480 Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7 IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k2 6cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxV AFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU0a0PDUUUUU== X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: DE9AE40006 X-Stat-Signature: jzs43usf9duagh53me6p7exhj6zbmw3h X-HE-Tag: 1740208353-298267 X-HE-Meta: U2FsdGVkX18Om++g+uwhkH7ggm6h4DzN3s8aIiTytgyjBgZILGqw345nUbfmmC8g+vJn5EJaJyYMP+Cq+rDbIQopd9eCYhCczHAS3FJW8BNn4KgBG26MEgnG5KJ6VevDe4RRvMLqIUN+g6PC39AJ5niB+APB2/VRL8VCrXOxuZ+8zqWdaarFPg9MFWwGQvOPoV1S/EdJDYyKTQBpqWWGo5gOF4ePz6OOPaWoojIMh3JSpGC6khuqkKseJKdiPmmYws72H9EJNERgg9ruhRlM6+iKWHm0XuFoflEP4zQ70IhW4zqfCiQskBcsuBmOQ1zyR4trpVi095ExDiWlEZDWLaHTSkA5N/yqosOo8CL/Mx7s3ZsuXWPd0VD5esQZgQRno3W+4FywPpO5X93jzLxgh9MFCZBXm5QJ7/JFgpSrGoEdbS+/9QUQxOvEoR6N2sTQmVOKX4FpwOCrBRwZswbYwcYGEqHYIqbuj6U2uB/pIeq773sr7qKVkSmXJ4AxfVHlcEEdS3uAUWH2G4UhmIFB0mH4LW/VRMhDv5xCS4IL8wJgsBZzkZ5M79VcR7qP7Ziy950U6ErUewCkR6l2w0AlSNxcRQtPNCvcov5foOtTucPMV5bDuG059EU/znAKD5K3jow36JhqkInjrknmPwwdB0wcsi3FyUJe7KdtbzecbKn3vNzcsiLOGocp1/XDv0H+8cMBB1Ao9ddWQl53EERX+38XGy4yJQa8dUpxrcF5EkgRaNQZjqM9pS4TeybO/rbPBgVcDKlQ8jZJeta/O6AcSkd/oOFCz8H0XU2Mi1dNLKgcAMAc3f9nJKqNOZH4umBOL9OQn1nNi1jz7B+9kyVWudv/NdzUSmTiSdEEQ+8C91ojnvFJ+Hf7rlWEHgDUpGmWbxLeFPzWmdTgQlFEiKRYyjOiz/E0FQrX7Pt7rmThRxnDn2p4+DOtrnLqu8Ih+fwFAXvbW0xu/noWEZGUMcy oWzgNDBo Ui3JXZUfnEDoOiNn6BjSLfdxdHmGuu6eY8aylNacksp1diqhzGTl1F/d+WA6FEc1FkgwCFC+d6y3AnObvVF1+szCatW/t+S4RAy7jA3leo/gWdIo+Hr0Dr9BKRQMCUyAMN3B3PX40cNOiYyyura5iWfHj0rxtTnXPMtTWgTWR6HXNMCSurRbzuYX5tO0hVCCeklwkJX8gH17lynCEz/xUeS6tjQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> List-Subscribe: <mailto:majordomo@kvack.org> List-Unsubscribe: <mailto:majordomo@kvack.org> |
Series |
Some random fixes and cleanups to mm/swapfile.c
|
expand
|
diff --git a/mm/swapfile.c b/mm/swapfile.c index 34baefb000b5..e5f58ab86329 100644 --- a/mm/swapfile.c +++ b/mm/swapfile.c @@ -861,6 +861,10 @@ static void swap_reclaim_full_clusters(struct swap_info_struct *si, bool force) offset++; } + /* in case no swap cache is reclaimed */ + if (ci->flags == CLUSTER_FLAG_NONE) + relocate_cluster(si, ci); + unlock_cluster(ci); if (to_scan <= 0) break;
If no swap cache is reclaimed, cluster taken off from full_clusters list will not be put in any list and may not be reused. Do relocate_cluster for such cluster to fix the issue. Fixes: 3b644773eefda ("mm, swap: reduce contention on device lock") Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> --- mm/swapfile.c | 4 ++++ 1 file changed, 4 insertions(+)