From patchwork Sun Feb 23 19:48:54 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rik van Riel X-Patchwork-Id: 13987223 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0F18C021B2 for ; Sun, 23 Feb 2025 19:51:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1EDCF6B0088; Sun, 23 Feb 2025 14:51:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D7D26B008A; Sun, 23 Feb 2025 14:51:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE8046B0092; Sun, 23 Feb 2025 14:51:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7C1066B0088 for ; Sun, 23 Feb 2025 14:51:15 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3919312029D for ; Sun, 23 Feb 2025 19:51:15 +0000 (UTC) X-FDA: 83152253310.07.9C491E4 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf22.hostedemail.com (Postfix) with ESMTP id A35EBC0002 for ; Sun, 23 Feb 2025 19:51:13 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf22.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740340273; a=rsa-sha256; cv=none; b=SRM3REqxkUmHgRCjQPaTnMkXKkP0x8vSQyak2vw2W5dqJBY5kpnJ2pJ0KElbO5GTfxpEb0 2AGYEk2tqBkbTuXgThVD5RcpuAQaV8otqLMWmV0bDCJRMKkuqiTFGq6Tcz3v82w/hA56dR p2c4qG9nYqiqg1JKdZhhtVMx2Z3Wogk= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf22.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740340273; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hF8xMwU6gtFHerZ+8FO0Ift86ipYBUao4K8kpXc1fTk=; b=UnhvxbNexmKI9ZBtQkLt0lT3cx1E5ndjyyiPePm2eZJAz3NFlyohYDTdZ8mgaxslqE6OWc R1cEkGSmC/Lil8CSfHUXe2YPHN+H+jSP3J94EC7+C98m+m92xEYtWAc8ugTWrCIqknqhbn mQUlnbH2o4e+WD5t7a7iwERhnvvyBB0= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tmHyy-000000001hX-3o7T; Sun, 23 Feb 2025 14:49:44 -0500 From: Rik van Riel To: x86@kernel.org Cc: linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali.Shukla@amd.com, mingo@kernel.org, Rik van Riel Subject: [PATCH v13 04/14] x86/mm: use INVLPGB for kernel TLB flushes Date: Sun, 23 Feb 2025 14:48:54 -0500 Message-ID: <20250223194943.3518952-5-riel@surriel.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250223194943.3518952-1-riel@surriel.com> References: <20250223194943.3518952-1-riel@surriel.com> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: A35EBC0002 X-Rspamd-Server: rspam12 X-Stat-Signature: 671y5n354det66s4e1naycyxu1ubeyju X-HE-Tag: 1740340273-840112 X-HE-Meta: U2FsdGVkX18sFPyytIyb3bddT7lGtN0A9BnXMGPNuTmxix5US/xcrDdFp6783/7QNsX1nkLXxwCaH7FdiBYxYqW5TLf87uejne46Ika1m1ovWcm6IFHluvfG71T9CY2hbU6VF+rDEbAJMntxVJvl5KkoCfWHLdMAMmUmjlGpWbMOEqxl3h2wNnnC60uOreUZMtcyDhToDwr8OysotnLiRbssSy2JTFjm/qOsIIsCeygBoB3HWBGQhKkgK/vE9vJKGQ6+Rnk63FDVD6cjiuGT6oR2Hfwfo+3YTObFXxRnHNdThz4iub+WNXGnm4TmFt6oYmTwYEjK3QI64tUv6pDDUQdRMze8iNmDaK8QvWs7/rehpJQjz5+bnAMLPyCbpw0s9hS5J2uA5837moQ99W8a9kBJVeBGFttG2kJIzcWmQX8sV4CkfWYeb8loJPCmG+vmXI7QODBE21KFQv0+hs1OIJclUMJpo4oSaqC2gVUgk8mLD3rwxMHcTBFQDUF605Ux84dIhw0ZEpRsfCjt5HI6Jr6XGlDmNDUL55x6x1YbuflX1hEl0KhjrN/me108jT7eZhjdxcg7NZ0YZiKD/mt6XoyfEuY1TFSDxyv3U8UM/tfgO2HKjtT0JM3moYDQaHx1em90MXi5jYsDumNb7/atARaRL26pqG/00eMG6KGu87bFmZZPqm4Akj12oqeUZCPC5qUtWSFLfV4NOmOM6pAGiAKW+MVnqAOr2SjWtfeYtNA9+AumqglKVT5TfJGyBJVv5Uu0J/IL4Vq6AV7xJsg9v2+WeIswkQYsraj3cFYBHoe7SCSgOu7ZMq7war5zXLuAOdBqYeVCRocUt6C1sj5Ti00YR9ukpOtaS4ATjDxRubJPPCTDIqNaJZgsd301B0S5gGUccDQltRKUOsLXluVJTxcE4W0qbXX8I1P5iFPFrsQ/RG2kl3dVhCFmhIZ7McyNe260c8K4XfzLLniUO6A eBgO8PRZ X7fyQQ/M2RgZc9gPlwOX8sZckQ61AUizHqR3yYd/RNLvVnJHUBHmHdqborFV52uDDHVa8xxinrZNXLynDCM9BUavhx9/fzwtidtztAePiJADsjXmt0Kz2hCHW0C2QmjIdIaYBkOXDFRoFhzGu0GfEBwqVko9qP3e0MHV6bX3OQPMm+gii4NPqD9fbssX7B8oU9x4w9QnYhOOY5UdMdo3dAVBQ2r61XAVRi03NPodqX70ud++/sWwXdfDbvWn8w9c15/Ss3DF9KVwLNBo/Rt0Y3wyx8l2brEtm+ikzPlCIM4WeeDZlJ3liYPFsHxbBIp2F8aV6e1I5mZmLyL8zdGCWhrVxIvoGZIyzoFHGgZAwhhU96phb6/LhK9fHO6v2IDYM9+uQXpjgJm3RczieibRlWZsex7Axc/4e10YGF3me7y3LE9GU3xJDcRaaSM+0Tr9jDutYoGpeqlj3cNuV35d5M0Xn9miWPgCa1xw9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Use broadcast TLB invalidation for kernel addresses when available. Remove the need to send IPIs for kernel TLB flushes. Signed-off-by: Rik van Riel Reviewed-by: Nadav Amit Tested-by: Manali Shukla Tested-by: Brendan Jackman Tested-by: Michael Kelley --- arch/x86/mm/tlb.c | 34 ++++++++++++++++++++++++++++++++-- 1 file changed, 32 insertions(+), 2 deletions(-) diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c index dbcb5c968ff9..59396a3c6e9c 100644 --- a/arch/x86/mm/tlb.c +++ b/arch/x86/mm/tlb.c @@ -1077,6 +1077,20 @@ void flush_tlb_all(void) on_each_cpu(do_flush_tlb_all, NULL, 1); } +static bool invlpgb_kernel_range_flush(struct flush_tlb_info *info) +{ + unsigned long addr; + unsigned long nr; + + for (addr = info->start; addr < info->end; addr += nr << PAGE_SHIFT) { + nr = (info->end - addr) >> PAGE_SHIFT; + nr = clamp_val(nr, 1, invlpgb_count_max); + invlpgb_flush_addr_nosync(addr, nr); + } + __tlbsync(); + return true; +} + static void do_kernel_range_flush(void *info) { struct flush_tlb_info *f = info; @@ -1087,6 +1101,22 @@ static void do_kernel_range_flush(void *info) flush_tlb_one_kernel(addr); } +static void kernel_tlb_flush_all(struct flush_tlb_info *info) +{ + if (cpu_feature_enabled(X86_FEATURE_INVLPGB)) + invlpgb_flush_all(); + else + on_each_cpu(do_flush_tlb_all, NULL, 1); +} + +static void kernel_tlb_flush_range(struct flush_tlb_info *info) +{ + if (cpu_feature_enabled(X86_FEATURE_INVLPGB)) + invlpgb_kernel_range_flush(info); + else + on_each_cpu(do_kernel_range_flush, info, 1); +} + void flush_tlb_kernel_range(unsigned long start, unsigned long end) { struct flush_tlb_info *info; @@ -1097,9 +1127,9 @@ void flush_tlb_kernel_range(unsigned long start, unsigned long end) TLB_GENERATION_INVALID); if (info->end == TLB_FLUSH_ALL) - on_each_cpu(do_flush_tlb_all, NULL, 1); + kernel_tlb_flush_all(info); else - on_each_cpu(do_kernel_range_flush, info, 1); + kernel_tlb_flush_range(info); put_flush_tlb_info(); }