From patchwork Mon Feb 24 03:11:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tong Tiangen X-Patchwork-Id: 13987373 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59EF8C021B2 for ; Mon, 24 Feb 2025 03:12:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF9B36B007B; Sun, 23 Feb 2025 22:12:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B85306B0083; Sun, 23 Feb 2025 22:12:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A49F16B0085; Sun, 23 Feb 2025 22:12:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 87A726B007B for ; Sun, 23 Feb 2025 22:12:07 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2BF291206C4 for ; Mon, 24 Feb 2025 03:12:07 +0000 (UTC) X-FDA: 83153364294.21.B7AED43 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf23.hostedemail.com (Postfix) with ESMTP id F2E98140005 for ; Mon, 24 Feb 2025 03:12:03 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf23.hostedemail.com: domain of tongtiangen@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=tongtiangen@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740366725; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=PLy2eIvXw1inUIoqCZgqz0jqtL9ptFO7hJQTH8lfqfM=; b=jfZTm9L8065xj4OSDrIK/dhj6NPeR+iDMaFxueMNxXl5thbj7ZIWXKNaauRAYyUtmD83hM L6f+iJfQ3b+ocpkGcPw+fczqjSed0pP+cnPHQidHtPdMmrg2sWDX0ZbCRct4xI0mN4q30h rRoyS6J1dTF17fPHiTgna0xKf99u888= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740366725; a=rsa-sha256; cv=none; b=Zo2QWAA5M0T6qaBwAr9jpNU7V+btyWu0z/WAUV1g2mdO2D0x9ezLQq29NgVU+v0/jOwf09 cJmCabLOurpwBja8JmnPpGKdWWK+AvWtKVRF+0a1jO6TeQslnh/BZ4k8ZlnCSCFn5UjAkD 3AkUk/3RM6+7t7OknRVI0g+i9vgXsJo= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf23.hostedemail.com: domain of tongtiangen@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=tongtiangen@huawei.com Received: from mail.maildlp.com (unknown [172.19.88.105]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Z1Qfn4TKxzCs7B; Mon, 24 Feb 2025 11:08:33 +0800 (CST) Received: from kwepemk500005.china.huawei.com (unknown [7.202.194.90]) by mail.maildlp.com (Postfix) with ESMTPS id 426EE1402E2; Mon, 24 Feb 2025 11:11:59 +0800 (CST) Received: from localhost.localdomain (10.175.112.125) by kwepemk500005.china.huawei.com (7.202.194.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 24 Feb 2025 11:11:57 +0800 From: Tong Tiangen To: David Hildenbrand , Oleg Nesterov , Andrew Morton , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Peter Xu , Ian Rogers , Adrian Hunter , "Liang, Kan" , Masami Hiramatsu CC: , , , , , Tong Tiangen , , Guohanjun Subject: [PATCH -next v3] uprobes: reject the share zeropage in uprobe_write_opcode() Date: Mon, 24 Feb 2025 11:11:49 +0800 Message-ID: <20250224031149.1598949-1-tongtiangen@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.175.112.125] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemk500005.china.huawei.com (7.202.194.90) X-Rspam-User: X-Rspamd-Queue-Id: F2E98140005 X-Rspamd-Server: rspam07 X-Stat-Signature: 7joh1moz49ahc6krp1w8ekqprbbm1m5o X-HE-Tag: 1740366723-963138 X-HE-Meta: U2FsdGVkX1+OpUrl6zoGQ1oyfrc7lNVy3UrScj/G18iLihFTbsCMYHSTKW7F+ycRcNnWnrMFpjpv8FEYRRLo1pVjpmXO8jmR1VAXWeaPyPhSdiXGa/S8iT7riwJHDBxxfJUp2smk0pTtHN1jRVEaiKI7+tzunb+cDMFIEFKylMKXQ76hyj3rlXwq6wBRM5dLeBv8+6RkfN6vZAK4Ug9cFYnXCKF3rtUga4ZzyF28Tzlnaxa8/UkGiYde58CpUmDi5xRZZY1Hlt+8C2HYu22OrRx/7573BGUI2597vhFaIcTjqf9ZdA0JjExQCUvwmHknwtjmh2yPqrFfg+1JvzYHlgq0jITH4RKkthGxXlb2yiSBS1lrGIkxp44Bjf9jctEejlY48NpcfNpNAtdeWcq9Ow+oVRLFRjbFFCoXfL75nsxQFADLv5VC5Fdus541Z5KCwVNJQTPr1mbj1S1fn210IH6VwZcdz64TjKwXKUTeIroh3IH4qSzSobSX1KpwAQYpb+3NTQqXBPzkRYp5UprQCt2ueEDt0dKrzlaaxo+EHWYMb4a1bc3xEAJFZRd1ANDEljIvH24TrSaH/ntvx2KVRu6XaRtkedY9E5iVz8OvRhfgDKlaytxoND2tagjUh5HO62sfv+MmsvQTmZzg5O7eSlbky+aI4LM9k35+mGKHQ35aVU8sjcNyDjuIcxxI9nrjdF1k5EczYrA6cyerQjzRhls/UB4p9zOsdhDc6lI+LMtpOUcf7UjIDoOIVwYekTJ1/SpouuYk8uJO6uTlFByzmwmEE8fA04Np/K4NoO0qFsOWwgGV9yLyZ/hZLsOymY8uqs7x8aG7dlofca+pu4HD5qLYpZUe6U17ePdRI01CmntasjnNCm5vUGHliEhyvQCwU/hJT1ZmUwt97YjZt0Dz8G9YMI/kgBjpICBbUiyMoXHKnMMvfLodJnVbAjkqsutUMAICuXDpooKwY8rwyRL khQKJ0rc xEZZu2RYbpLclLRJ0JZN4LlPcj5WIgjc2wZGCfl3c0aSXTPIZIlPo89lqYzpkHrbsSMLnCvRAX1KEr4dxT3eapiIBpAODWfbAMVXSeIFO7ycAhrplS9HishYlpcUPHQwE/GrNw7TxzFqtd/faUx3Gl9CUiY3yrfdWExOTntAKkThcgQEkf5ZcZET+A6YKmrXgVtHdNyp7mm+2DCeEbBhIlQuTrA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: We triggered the following error logs in syzkaller test: BUG: Bad page state in process syz.7.38 pfn:1eff3 page: refcount:0 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x1eff3 flags: 0x3fffff00004004(referenced|reserved|node=0|zone=1|lastcpupid=0x1fffff) raw: 003fffff00004004 ffffe6c6c07bfcc8 ffffe6c6c07bfcc8 0000000000000000 raw: 0000000000000000 0000000000000000 00000000fffffffe 0000000000000000 page dumped because: PAGE_FLAGS_CHECK_AT_FREE flag(s) set Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.13.0-1ubuntu1.1 04/01/2014 Call Trace: dump_stack_lvl+0x32/0x50 bad_page+0x69/0xf0 free_unref_page_prepare+0x401/0x500 free_unref_page+0x6d/0x1b0 uprobe_write_opcode+0x460/0x8e0 install_breakpoint.part.0+0x51/0x80 register_for_each_vma+0x1d9/0x2b0 __uprobe_register+0x245/0x300 bpf_uprobe_multi_link_attach+0x29b/0x4f0 link_create+0x1e2/0x280 __sys_bpf+0x75f/0xac0 __x64_sys_bpf+0x1a/0x30 do_syscall_64+0x56/0x100 entry_SYSCALL_64_after_hwframe+0x78/0xe2 BUG: Bad rss-counter state mm:00000000452453e0 type:MM_FILEPAGES val:-1 The following syzkaller test case can be used to reproduce: r2 = creat(&(0x7f0000000000)='./file0\x00', 0x8) write$nbd(r2, &(0x7f0000000580)=ANY=[], 0x10) r4 = openat(0xffffffffffffff9c, &(0x7f0000000040)='./file0\x00', 0x42, 0x0) mmap$IORING_OFF_SQ_RING(&(0x7f0000ffd000/0x3000)=nil, 0x3000, 0x0, 0x12, r4, 0x0) r5 = userfaultfd(0x80801) ioctl$UFFDIO_API(r5, 0xc018aa3f, &(0x7f0000000040)={0xaa, 0x20}) r6 = userfaultfd(0x80801) ioctl$UFFDIO_API(r6, 0xc018aa3f, &(0x7f0000000140)) ioctl$UFFDIO_REGISTER(r6, 0xc020aa00, &(0x7f0000000100)={{&(0x7f0000ffc000/0x4000)=nil, 0x4000}, 0x2}) ioctl$UFFDIO_ZEROPAGE(r5, 0xc020aa04, &(0x7f0000000000)={{&(0x7f0000ffd000/0x1000)=nil, 0x1000}}) r7 = bpf$PROG_LOAD(0x5, &(0x7f0000000140)={0x2, 0x3, &(0x7f0000000200)=ANY=[@ANYBLOB="1800000000120000000000000000000095"], &(0x7f0000000000)='GPL\x00', 0x7, 0x0, 0x0, 0x0, 0x0, '\x00', 0x0, @fallback=0x30, 0xffffffffffffffff, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x10, 0x0, @void, @value}, 0x94) bpf$BPF_LINK_CREATE_XDP(0x1c, &(0x7f0000000040)={r7, 0x0, 0x30, 0x1e, @val=@uprobe_multi={&(0x7f0000000080)='./file0\x00', &(0x7f0000000100)=[0x2], 0x0, 0x0, 0x1}}, 0x40) The cause is that zero pfn is set to the pte without increasing the rss count in mfill_atomic_pte_zeropage() and the refcount of zero folio does not increase accordingly. Then, the operation on the same pfn is performed in uprobe_write_opcode()->__replace_page() to unconditional decrease the rss count and old_folio's refcount. Therefore, two bugs are introduced: 1. The rss count is incorrect, when process exit, the check_mm() report error "Bad rss-count". 2. The reserved folio (zero folio) is freed when folio->refcount is zero, then free_pages_prepare->free_page_is_bad() report error "Bad page state". There is more, the following warn could also theoretically be triggered: __replace_page() -> ... -> folio_remove_rmap_pte() -> VM_WARN_ON_FOLIO(is_zero_folio(folio), folio) Considering that uprobe hit the zero folio is a very rare scene, just reject zero old folio immediately after get_user_page_vma_remote(). Fixes: 7396fa818d62 ("uprobes/core: Make background page replacement logic account for rss_stat counters") Fixes: 2b1444983508 ("uprobes, mm, x86: Add the ability to install and remove uprobes breakpoints") Signed-off-by: Tong Tiangen Reviewed-by: David Hildenbrand Reviewed-by: Oleg Nesterov --- v3: update the subject/changelog as David suggests. v2: Modified according to the comments of David and Oleg. --- kernel/events/uprobes.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c index 9372bfd0e8fc..ca1879c74158 100644 --- a/kernel/events/uprobes.c +++ b/kernel/events/uprobes.c @@ -506,6 +506,11 @@ int uprobe_write_opcode(struct arch_uprobe *auprobe, struct mm_struct *mm, if (ret <= 0) goto put_old; + if (is_zero_page(old_page)) { + ret = -EINVAL; + goto put_old; + } + if (WARN(!is_register && PageCompound(old_page), "uprobe unregister should never work on compound page\n")) { ret = -EINVAL;