From patchwork Mon Feb 24 16:55:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Hildenbrand X-Patchwork-Id: 13988503 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA503C021BB for ; Mon, 24 Feb 2025 16:56:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D8396B009E; Mon, 24 Feb 2025 11:56:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 088DB6B009F; Mon, 24 Feb 2025 11:56:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0C626B00A0; Mon, 24 Feb 2025 11:56:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7DE9F6B009E for ; Mon, 24 Feb 2025 11:56:34 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DB55BA3D01 for ; Mon, 24 Feb 2025 16:56:33 +0000 (UTC) X-FDA: 83155441866.09.E0C8ABB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 84B5D180015 for ; Mon, 24 Feb 2025 16:56:31 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SagYhZ08; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740416191; a=rsa-sha256; cv=none; b=hcMbKCxphWAQXck+KXOYP1wUaPOl/3pAPOblPY+Swv255Ap8umJEzOUklAhS6dhh3h64mh QnocCl/t4+/jsee8IX55nq6yKly4nw3fMbowOzh9btzGJYgEKOPvzIHynu8IeQPDxMeHkk Gd5HlP6+22NfqVM9dpxcV4mM45YfhAQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SagYhZ08; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740416191; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VusPlBbKEOGpL4wS1BqoWY6CYb2f4HQ+/wIDh8p+vAo=; b=S0/WeYAKr0MGK5oXzpgRtwtrv75eYjr1eJdb0orogu27W196AFxPLDlGe4D2RdtzxRa3Hz Y9UL4Bg6dWRjOwbZf+BjoXXIN88L4ThuwDXOovCitCsW1R5V5mTfw/7hUbt6Ir43B7a4qa CX/HY3pPBqlqUTS8Jj0YrcqRUEQNmJk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740416190; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VusPlBbKEOGpL4wS1BqoWY6CYb2f4HQ+/wIDh8p+vAo=; b=SagYhZ08ddx6wZoexyDBawUCryJLb4mDtmuzhxkHb8FWShggtBTks8JsUeTak2aqsJgU/M l0+lTQLoZQ0F2YHObpEmsN2YkTJFWyLOD3utDqnElzM0UviJYfn+FMZvNR7MLf8sb16fUX G+oa7cO90ubtiNVd881jvDHbwp0JNR8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-407-eug87DjtMBGweG6JxBsf-A-1; Mon, 24 Feb 2025 11:56:27 -0500 X-MC-Unique: eug87DjtMBGweG6JxBsf-A-1 X-Mimecast-MFC-AGG-ID: eug87DjtMBGweG6JxBsf-A_1740416186 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43998ec3733so23637215e9.2 for ; Mon, 24 Feb 2025 08:56:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740416186; x=1741020986; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VusPlBbKEOGpL4wS1BqoWY6CYb2f4HQ+/wIDh8p+vAo=; b=DV162+LLNAxgjNZ/r/XDLvJ0P/0zdtfcsI1H1zI4H2NcINHrW9OLjgXC79nCDYyNmp X/WqAYL9TjA+TVOQQ+EGHnbl5HFI1HVyVcc8qXS4a98aBXxSULt5G7JVk1NMHPaWPvGU jLoqqJc8PduVc/1Wtf4bQv5kbnO4CjUEf8vFxXxxZdhz2NnAy5Y6/EZ3Jn7DI4Q3mCtM J1WrXFeG/2wjbxNm8AZLEMIRYCWhvmKTcAxDNACIwwhllP8brphgzAbCWpgkjNdb4Jer wHr1YKNe66B6sZp9ZqImMyvh/ucMkfrICdGpRiDATaBxkTgCaQIwsHr0nTjuHeNAerOC 92Rw== X-Forwarded-Encrypted: i=1; AJvYcCWOeEtUPl3HImAN0XGoTl3OXVWxpmZA4NwWhMbyz1Y/aW+8piDJURDg4DnB5wzkGaBUJdp9lt6ZTw==@kvack.org X-Gm-Message-State: AOJu0YwfoXAp5y6Rxv/clxnOrKjj/AzodIarGiwiP964L6ZOL4NEJPMT kEdxKiubVYaQirnuFV9K892M7MrlsJEgQNYvgrbJEJzXm1qP7TMPsx5hq2YPSw0hUeaDbM9h3Vq +IgWPfwLCeLkKUMH92spgxWvycWYXUz7FBzU+Pp/ZAbbm+5HR X-Gm-Gg: ASbGncsBnY8NMXSD/YZm3FyCx566IvXsU7QOEYDS/jk7VY480nwOkS8MRuRY9qj20aF GISinHLXYKJShVSe1awTMgJ/1OdFiMEA3cGpwKXyj0ynGZPHeANmWf28VhYg0RNmjhbN80kCCAV iC+r4C7fym1bV/TAudW0DUFB7y7T22H7EQZ60sZ60NQAYLLY9iZR4xKk10Bze7wzv+3l65TVYt6 Lbwu5FZ5IS3TiZCLMaZ81yRKhiwAr9d9S71YwckJ2jbyd7/ked4TZCqKpQFBYewxsK1gflS2Mwg 2bQ817CGHJtqn/wtCd9Q6A4UEYwDfe1yfGGwz+F+8Q== X-Received: by 2002:a05:600c:4f43:b0:439:9828:c425 with SMTP id 5b1f17b1804b1-43ab0f2db61mr336635e9.7.1740416186361; Mon, 24 Feb 2025 08:56:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IHWfaIC9jLsYbcLXi3Fdeg1qCi0/sJNUC8bLA+3qaJ5mWtkIjQvv3YtNjkQQj/btQBGxQxPlw== X-Received: by 2002:a05:600c:4f43:b0:439:9828:c425 with SMTP id 5b1f17b1804b1-43ab0f2db61mr336445e9.7.1740416185910; Mon, 24 Feb 2025 08:56:25 -0800 (PST) Received: from localhost (p4ff234b6.dip0.t-ipconnect.de. [79.242.52.182]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-439b030b347sm111391345e9.26.2025.02.24.08.56.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Feb 2025 08:56:25 -0800 (PST) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-doc@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, David Hildenbrand , Andrew Morton , "Matthew Wilcox (Oracle)" , Tejun Heo , Zefan Li , Johannes Weiner , =?utf-8?q?Michal_Koutn=C3=BD?= , Jonathan Corbet , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Muchun Song , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn Subject: [PATCH v2 10/20] bit_spinlock: __always_inline (un)lock functions Date: Mon, 24 Feb 2025 17:55:52 +0100 Message-ID: <20250224165603.1434404-11-david@redhat.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250224165603.1434404-1-david@redhat.com> References: <20250224165603.1434404-1-david@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: MHEXvPYY4LhHN7bbbnYdzlT0FsRdsjtqzta8EH-eMOo_1740416186 X-Mimecast-Originator: redhat.com content-type: text/plain; charset="US-ASCII"; x-default=true X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 84B5D180015 X-Stat-Signature: i9n8ddp81ww66uy5dyqpjxtwjsj7e554 X-Rspam-User: X-HE-Tag: 1740416191-86869 X-HE-Meta: U2FsdGVkX185GY/Ks6+e6f6KlZ6g57Mc1gZ3HVyjYjTncE/QsA1V9CPooHrvQBbtYrd7pn6svgbT4GlsvUppwZzIFEg5TwrlEAZT7GiE+HH49oexCnUhxKEg9LkXI7Xrcz6l92ybrD6HEH8XVmAf8HoRxW48jMH6i2GF6YdjSKQpDO5t71VQA5IPtRkGzdtRJQM2/goU9R6S3RnTToSd9UtcftHjrb5S9K56jXpYaJ7GWs0bBBj28rQf6oH8zsmppDa5h8hoXdkTb+3Totr/F3kFqHVXHhFQp9mOCNHtrR+VyY/+TPBAyneeiwOe/dIk3ETcXIgINdzNnUnRLXp3lW6l6Sh27SPrCiU1KREMzRYiiP26R4bGjSzfHRb8Iwae77TzR2j/EBB5CPF/oKlDIzUq+DcrykpMz29yYo8ZG9Euq1wtjQCAos1zbG4g5a09elTvmaYUtN/JzMzS75wo8TJ71vXVyBUrUqZ4gfLbwPu84zrSmEGDj3J6Ojaas2IwxMs9M+MPgIBOpX3XT17hDLEebY9ms4bZz7hqjF53ddb2QMzyWwR5aol3kDKYOfjoZ5eNjZMEnC22B2whs4ifosfiQ9jvKkfd1ujd0OJs5dBXtaw6B9U0kHysXVkTnm7FFFTgEy2XwK6eglRWfpG9h3lAYTgOccC2mL+E2CRZ80S6b9ezt+kym2CFGXGiLe7gifFc0GGvz9UB8tfYsIS0QlS9H0Szx1l9uDWAkWMUTtziWQyZWKqSL6T1EGHXOSDFKO4EUr4KyIiZUZ9Z1dnbHb0S/6ANNwRZuwIjKKxBBPe52XOtDaQYXXopbWe/hwikhk5LC1xvTeDvfyDyN/hqViP3/HSOJKIPTPf3lNoX1MepPah9709Ut7ofq/4heHvOkXLPlHPRgCGKDhvK77lVkyfxChv5SwG5t4LWAAAq+cxrb8029tZMzTFndEPU5273v/zilvSeEqd3I6nvnBG VGmICPFz ehZdK/+IEcowke7UnTdnANH20yyxQkVweWungs2RcPYhgn9nYIn3L5BOCjZnL7MmOlCC/DwFGRRyD5ILCby9w5CznJj9OsHgwYucsgOvMKRMic5s7+unsHk3A45HUytGWWG6o/Ueo6y1tlTXhrY5ud41fD6RKFd8EFUmkyecjfkHVqekQNuc681Do11IQjw2rIFxyy0ec3grBFAZbRF34ZsFlJHom6wRWj3fbzKZFMONuo6IqqqwQieBZRHm0kSeHiwCj9b0/jpTgvVjuQ6yHe5CCS9zZl1BqrOdMruu5W7bRE4RXgHia/ruIZsiQ1iK9p7pq7F5DZPsbpNZ3SoetixTkwdfWFssJ6F7tHYOO8fUiIvWxRW0T2B+DJlhcMbPPZ+dvv6E2MTfmIjSikHrcOajF/rTDTaWS3GrB8oCbfulJSbp1RB1M1D11KDAU926VCD80c6JEYlJGVfIsMusGaA0WmyTzb9n7IpIEMx6dmql9u0buebn5GaKvvO83l7l+12njgSJYInkaEXRgdu6kAV6wZ6fDlumYdpLdZ+7GuV6m1LM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The compiler might decide that it is a smart idea to not inline bit_spin_lock(), primarily when a couple of functions in the same file end up calling it. Especially when used in RMAP map/unmap code next, the compiler sometimes decides to not inline, which is then observable in some micro-benchmarks. Let's simply flag all lock/unlock functions as __always_inline; arch_test_and_set_bit_lock() and friends are already tagged like that (but not test_and_set_bit_lock() for some reason). If ever a problem, we could split it into a fast and a slow path, and only force the fast path to be inlined. But there is nothing particularly "big" here. Signed-off-by: David Hildenbrand --- include/linux/bit_spinlock.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux/bit_spinlock.h b/include/linux/bit_spinlock.h index bbc4730a6505c..c0989b5b0407f 100644 --- a/include/linux/bit_spinlock.h +++ b/include/linux/bit_spinlock.h @@ -13,7 +13,7 @@ * Don't use this unless you really need to: spin_lock() and spin_unlock() * are significantly faster. */ -static inline void bit_spin_lock(int bitnum, unsigned long *addr) +static __always_inline void bit_spin_lock(int bitnum, unsigned long *addr) { /* * Assuming the lock is uncontended, this never enters @@ -38,7 +38,7 @@ static inline void bit_spin_lock(int bitnum, unsigned long *addr) /* * Return true if it was acquired */ -static inline int bit_spin_trylock(int bitnum, unsigned long *addr) +static __always_inline int bit_spin_trylock(int bitnum, unsigned long *addr) { preempt_disable(); #if defined(CONFIG_SMP) || defined(CONFIG_DEBUG_SPINLOCK) @@ -54,7 +54,7 @@ static inline int bit_spin_trylock(int bitnum, unsigned long *addr) /* * bit-based spin_unlock() */ -static inline void bit_spin_unlock(int bitnum, unsigned long *addr) +static __always_inline void bit_spin_unlock(int bitnum, unsigned long *addr) { #ifdef CONFIG_DEBUG_SPINLOCK BUG_ON(!test_bit(bitnum, addr)); @@ -71,7 +71,7 @@ static inline void bit_spin_unlock(int bitnum, unsigned long *addr) * non-atomic version, which can be used eg. if the bit lock itself is * protecting the rest of the flags in the word. */ -static inline void __bit_spin_unlock(int bitnum, unsigned long *addr) +static __always_inline void __bit_spin_unlock(int bitnum, unsigned long *addr) { #ifdef CONFIG_DEBUG_SPINLOCK BUG_ON(!test_bit(bitnum, addr));