From patchwork Mon Feb 24 16:55:55 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Hildenbrand X-Patchwork-Id: 13988505 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5683DC021BE for ; Mon, 24 Feb 2025 16:56:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7DE86280001; Mon, 24 Feb 2025 11:56:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 78B66280002; Mon, 24 Feb 2025 11:56:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E34B280001; Mon, 24 Feb 2025 11:56:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3B43F6B00A2 for ; Mon, 24 Feb 2025 11:56:38 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id ED63A1A18AB for ; Mon, 24 Feb 2025 16:56:37 +0000 (UTC) X-FDA: 83155442034.24.A922845 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 908261C001E for ; Mon, 24 Feb 2025 16:56:35 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TOSoDHGv; spf=pass (imf18.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740416195; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pg2vY9vqWz7IHDYregwabj5LRZT1HxPxFKsGucVLMU4=; b=UDBarfazrK9ezY3iKJPKQlDQMOsUoxCiGRiRRg9Lh6bfmA2reuKZ4VORgvVoeYZE91X1CQ 2v1EA967Y3GMaZZ/GOwDjrBdNLwarQIwtTrq0K5PnAoF6yhJym4l6wk/r7dDabApxfp1b+ 5igQFbX0LxgY9KnbbNO1P8DfedWdvwE= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TOSoDHGv; spf=pass (imf18.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740416195; a=rsa-sha256; cv=none; b=6G3D8JyeOfNcbyRAAQ2oRTYqxbSXvKgzbqamW9050Mnh6kQHd3Vq7eEqFdJjjoEvrgkNg/ eZ6UrYQGkPPoAu+oB65Ka3mepvrU+nAcrslyeLdX1rD2zteEVsgEU6YQyZkRqHV2JjucSs Cui3TWP4TKsWVsJjkKY7lX8X2vOuv70= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740416194; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pg2vY9vqWz7IHDYregwabj5LRZT1HxPxFKsGucVLMU4=; b=TOSoDHGvtqDqGdAik58FKFsJa+3q6/FSRF/QyyxZNw5yZxWAMhXVoznESuMZTwDYhzp+Mg sx/wpBIloP3o42Ad3pJPv4gFKcCc8AVWL8ik1rocHJrzd2wU31FdGnbtOSW6nrMBli3v6P dtl8icNlqQU/lEWZ/SY/VC3fNDyvl74= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-686-6vr8IsOpMFGPOEfGNsPLYg-1; Mon, 24 Feb 2025 11:56:33 -0500 X-MC-Unique: 6vr8IsOpMFGPOEfGNsPLYg-1 X-Mimecast-MFC-AGG-ID: 6vr8IsOpMFGPOEfGNsPLYg_1740416192 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-38f4cce15c8so2207823f8f.2 for ; Mon, 24 Feb 2025 08:56:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740416192; x=1741020992; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pg2vY9vqWz7IHDYregwabj5LRZT1HxPxFKsGucVLMU4=; b=EJb5Safj/3jxMJDXzk1k4giZ3eetAZnglQgT9dr/PavIK+hrI0B8mupYsc4K1SFkP7 nN/f4Rmvnnm/17QPNjWcgynqesFjgSYp8VKlKJ3C6Mi01f9rfMVc4pAppur/OtiWIDmV gy6GO65MsB+IlKU5pg2om2WJgdJZ1ZkcVRsnWmmMW1NCv5X8RM4LVsZ/nvlux1s+kP2B PUoUitPetl8ju85uxAX21Zqk0VI6oQSR7ZfFdpiQWLIibeTHhrV7MbzYLhFJpp4SI4gY 5oDBIMM2F77dyWLsc8S+wAPTH+D1lBqf1QYltyLdm88LERWT4WKlzbWLtuz+LJ1uexaV 1/fg== X-Forwarded-Encrypted: i=1; AJvYcCXMsjkgtGafhdz0pelkz2YxVdkb3XLOuPI78n1kQBP3wM2ppxbA+DxipG3N4ZwVo+ljfiZ1nILwEg==@kvack.org X-Gm-Message-State: AOJu0YwM99esIJrrXAdi6vLBFS0pF4zcnXPY911Qikdr+h/MLdKGuDDy 0AEREkcn6cswAQqhQ9x7VksgNfoCNrElyg1K5nwL35ixynUblpYCWyBn0HmQFfT4zVbCThyQlch l/M1wy7IKcEm5xDpFwxx6uCEokGc1j7gghUVrkqyzDWZlzMKp X-Gm-Gg: ASbGncuqti4PTJ9YB3mJvPqiieOQ/9XZkZ76xg31q/NU33hn8kfDG9hdO+paOuI2vWt lD6v0c41K/SfViXZbOM0To7EOBftoXifKIuANZTaqAqNNXQRN55JRkoN2XGhGeRNY7no49bzfYq 0ZpPIwT6Zw89LqqJsIMv3kIW4V+dnZh0ny1+ApjFX1nGSviQD/2mwoXASg9BI+iECUhlOeTxG5X xUTi8PsOXIwCbnZwfioXJqYSGZ/hB4jZHJUtshbulhKyg3NMgb/TQDe3TsSFw6Gj2mnsJOQjOr3 8PVac/4K7/oyAFcuJH6GIJgF4t9AmnENZeUDTDWF3Q== X-Received: by 2002:a5d:648a:0:b0:38d:db7b:5d90 with SMTP id ffacd0b85a97d-38f6f0951bbmr11757103f8f.41.1740416192491; Mon, 24 Feb 2025 08:56:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IHaIBsZiKHsVYYcLtCIPoeZB3FHIPU3YJhCLPdlvukEQ+/K5hEIgCDRy8AjGPWVYvGgArScYA== X-Received: by 2002:a5d:648a:0:b0:38d:db7b:5d90 with SMTP id ffacd0b85a97d-38f6f0951bbmr11757061f8f.41.1740416192060; Mon, 24 Feb 2025 08:56:32 -0800 (PST) Received: from localhost (p4ff234b6.dip0.t-ipconnect.de. [79.242.52.182]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-38f258b4163sm32531566f8f.19.2025.02.24.08.56.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Feb 2025 08:56:31 -0800 (PST) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-doc@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, David Hildenbrand , Andrew Morton , "Matthew Wilcox (Oracle)" , Tejun Heo , Zefan Li , Johannes Weiner , =?utf-8?q?Michal_Koutn=C3=BD?= , Jonathan Corbet , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Muchun Song , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn Subject: [PATCH v2 13/20] mm: Copy-on-Write (COW) reuse support for PTE-mapped THP Date: Mon, 24 Feb 2025 17:55:55 +0100 Message-ID: <20250224165603.1434404-14-david@redhat.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250224165603.1434404-1-david@redhat.com> References: <20250224165603.1434404-1-david@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: yhunryq_A2e_j3NNtvf3JXUAK3jik3ndJDTDt69DLO8_1740416192 X-Mimecast-Originator: redhat.com content-type: text/plain; charset="US-ASCII"; x-default=true X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 908261C001E X-Stat-Signature: f4w3oqpyonb9a8jew4yxm7xumirhjq78 X-HE-Tag: 1740416195-905444 X-HE-Meta: U2FsdGVkX18COP5vmDZOBBaPZysbK4zHgec9swPzTrNO1uRwmO1u1pKTIpcjRspt77L9EK30xBxReJhgynX8syq2ysrzrLN/idyMpZuVZ2uz2+WBHU1qzdhHcNHiwM/Ntr11qKCkLJ43rifAYmxUnrGoPAPWf1PjgaJav32eHKfq+DlvTQYxwtPwhrj+Hiw2zA19/DKU4FIT3U4ZwphSCO5+P9XjqppYPC1vWqRtLo7skmhiO8BZRI94xOx2zsbEcUZeYPWu5oD3OIoBUaap5UxfgSsmMHTZZteem+o/serVUf3gkXUNneNvc8F03nO6Ta2TWKNC5GgprbSv7FYnfacfsULiDzk1kGHGCXZ+0CiCnCxoHR6VItg7DA/Z65mjvp2IiqVUwComy/M01ViTRMuppJqsh0XuKLedFSsHpUTw4vXdcfHyFhiVAnheZHXgUjzKVbN/H7ACX5Q1bkjBpxEGT13spwh+BcbhBv499wLnFvE75VnWtQVE4qsBFXi+JffqXeMp383ebZE7hcK5KrcQHnT6Y6QRafF6XB9FBxewrTO0ibf06zektqJwmCDvYDvX5DtWkJrI+8Poi8tXVr8TIk0Klhxm2w9Gah5GNpFQI6ENZRSXjl4ic0nklKDLr1MbA7zzR8uumVBJTi67IIVgiv3clHvotyJEV5dNl7Eg32vjBJpwsFDXQQGxJiIfrxHbUgrcvlLqpxSDN1Dzb1vDNMJsR3ojUeo7NM2tqTxel2yQeRg6bj/n9f8JF6WaNxOeqJRQhMDfAbeISiMAut4IOIIjWRkk8jmo7Oh9swxjkWlB82t4AAwnH/vis02EHDEriFN9VVX7GvNJev/YYLIXQRZC9VviqIGZriM2TSWjfwVEQ7RpgXe/BZe+BIDZjMxECawS/cNWXLAd0W7mr8UkNY3M9DyJnCepnw9EjRqt20RB4YQBbzCdrJuPirOtusc9cpYQWA4X7M31n7z qrL2YF3o aeuX86z6pHiimiE+jEic91KCQ+c7Nrd01/BBO/E6lPzdqpT731pLX9YTamLcd9ONPSumj2H8S3eDvuY1NNucmnsCdvnmMdZ+o8rWPpC9/xFRfbj/tNZlXbW99L2AC5kCEKWXT86ldWOdIGAUkeW2wEmXmMfn8iwFkgpGSZoeS4hN/7uaguwVjRnrHnnlJJLv7WUM/PU6yogMseAQESxMT8KVVPMCOexxnigNNDBwP8Pn70/+JJgnfgEunN29mdzmVUbzXEq5+fg/T2I8psdvKwtlOCF8CkfWE1T8ZQK6JL548ItigJpy8IZnBl59qsSZ95Jj3H4e0YD8dUfbRlhu0YNvmHwFLQSsBVI71tZXjsFeotbcmuQBQfnZOwwVYwu9RAR+i1oZpCCy1ZSQTgsyLbw9aHsGYwb9mxdtYl+1BhNCTi3bqZ3QyE8yipZzimBsEVUyaPUjyz8ZTk/ZNdwKI04mCs/AHyAlqVpdtmAMCFW++6DzGpTnLZpvT8g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Currently, we never end up reusing PTE-mapped THPs after fork. This wasn't really a problem with PMD-sized THPs, because they would have to be PTE-mapped first, but it's getting a problem with smaller THP sizes that are effectively always PTE-mapped. With our new "mapped exclusively" vs "maybe mapped shared" logic for large folios, implementing CoW reuse for PTE-mapped THPs is straight forward: if exclusively mapped, make sure that all references are from these (our) mappings. Add some helpful comments to explain the details. CONFIG_TRANSPARENT_HUGEPAGE selects CONFIG_MM_ID. If we spot an anon large folio without CONFIG_TRANSPARENT_HUGEPAGE in that code, something is seriously messed up. There are plenty of things we can optimize in the future: For example, we could remember that the folio is fully exclusive so we could speedup the next fault further. Also, we could try "faulting around", turning surrounding PTEs that map the same folio writable. But especially the latter might increase COW latency, so it would need further investigation. Signed-off-by: David Hildenbrand --- mm/memory.c | 84 ++++++++++++++++++++++++++++++++++++++++++++++++----- 1 file changed, 76 insertions(+), 8 deletions(-) diff --git a/mm/memory.c b/mm/memory.c index ef74c4f009f84..8dc241961b684 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -3706,19 +3706,87 @@ static vm_fault_t wp_page_shared(struct vm_fault *vmf, struct folio *folio) return ret; } -static bool wp_can_reuse_anon_folio(struct folio *folio, - struct vm_area_struct *vma) +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +static bool __wp_can_reuse_large_anon_folio(struct folio *folio, + struct vm_area_struct *vma) { + bool exclusive = false; + + /* Let's just free up a large folio if only a single page is mapped. */ + if (folio_large_mapcount(folio) <= 1) + return false; + /* - * We could currently only reuse a subpage of a large folio if no - * other subpages of the large folios are still mapped. However, - * let's just consistently not reuse subpages even if we could - * reuse in that scenario, and give back a large folio a bit - * sooner. + * The assumption for anonymous folios is that each page can only get + * mapped once into each MM. The only exception are KSM folios, which + * are always small. + * + * Each taken mapcount must be paired with exactly one taken reference, + * whereby the refcount must be incremented before the mapcount when + * mapping a page, and the refcount must be decremented after the + * mapcount when unmapping a page. + * + * If all folio references are from mappings, and all mappings are in + * the page tables of this MM, then this folio is exclusive to this MM. */ - if (folio_test_large(folio)) + if (folio_test_large_maybe_mapped_shared(folio)) + return false; + + VM_WARN_ON_ONCE(folio_test_ksm(folio)); + VM_WARN_ON_ONCE(folio_mapcount(folio) > folio_nr_pages(folio)); + VM_WARN_ON_ONCE(folio_entire_mapcount(folio)); + + if (unlikely(folio_test_swapcache(folio))) { + /* + * Note: freeing up the swapcache will fail if some PTEs are + * still swap entries. + */ + if (!folio_trylock(folio)) + return false; + folio_free_swap(folio); + folio_unlock(folio); + } + + if (folio_large_mapcount(folio) != folio_ref_count(folio)) return false; + /* Stabilize the mapcount vs. refcount and recheck. */ + folio_lock_large_mapcount(folio); + VM_WARN_ON_ONCE(folio_large_mapcount(folio) < folio_ref_count(folio)); + + if (folio_test_large_maybe_mapped_shared(folio)) + goto unlock; + if (folio_large_mapcount(folio) != folio_ref_count(folio)) + goto unlock; + + VM_WARN_ON_ONCE(folio_mm_id(folio, 0) != vma->vm_mm->mm_id && + folio_mm_id(folio, 1) != vma->vm_mm->mm_id); + + /* + * Do we need the folio lock? Likely not. If there would have been + * references from page migration/swapout, we would have detected + * an additional folio reference and never ended up here. + */ + exclusive = true; +unlock: + folio_unlock_large_mapcount(folio); + return exclusive; +} +#else /* !CONFIG_TRANSPARENT_HUGEPAGE */ +static bool __wp_can_reuse_large_anon_folio(struct folio *folio, + struct vm_area_struct *vma) +{ + BUILD_BUG(); +} +#endif /* CONFIG_TRANSPARENT_HUGEPAGE */ + +static bool wp_can_reuse_anon_folio(struct folio *folio, + struct vm_area_struct *vma) +{ + if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE) && folio_test_large(folio)) + return __wp_can_reuse_large_anon_folio(folio, vma); + VM_WARN_ON_ONCE(folio_test_large(folio)); + /* * We have to verify under folio lock: these early checks are * just an optimization to avoid locking the folio and freeing