From patchwork Mon Feb 24 22:52:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Xu X-Patchwork-Id: 13989023 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA0FFC021A4 for ; Mon, 24 Feb 2025 22:52:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0A622280007; Mon, 24 Feb 2025 17:52:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 05464280001; Mon, 24 Feb 2025 17:52:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE9EC280007; Mon, 24 Feb 2025 17:52:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C4292280001 for ; Mon, 24 Feb 2025 17:52:52 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6F4C8802F3 for ; Mon, 24 Feb 2025 22:52:52 +0000 (UTC) X-FDA: 83156339784.25.7B456CB Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf01.hostedemail.com (Postfix) with ESMTP id 7ECC04000C for ; Mon, 24 Feb 2025 22:52:50 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=XU1AA155; spf=pass (imf01.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.214.180 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740437570; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uLPC0aGcYNb1lvLik1r4PuSirlrOiN9ljuV/brKB6K4=; b=Czqa7UAEY5wddSHwqfYKiZu07PML+TP+6rneqN/80gEhN9gbAfGRV1shpsWJrRyjPTy3tB Qc+Krqi/yj16c9jelA9Arhxyvs2nF25oQdsHjGIEp+rEDIzzE0PMG2vbyEmUZMTnNfvkKw /7KqsmmDQ0fNCxAkYMH4P0CxRpOb1CY= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=XU1AA155; spf=pass (imf01.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.214.180 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740437570; a=rsa-sha256; cv=none; b=pp4H3yGr0np9ed0Ny0hzYsR00n4pzIaz+h6GwaDZvhaxTRtAGzxp/j+GTWxLbhgPk4QIrK tMD1sYuRafQAUnaLPjnBDbZei/ovt8s4qfLZWsLD2zrPrWZQPYJsHWFEeAD/FoFiz3d/y1 mK8GGOKuS/NIHtIGSiTovrqaVPCXMFs= Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-22134a64d8cso12090965ad.3 for ; Mon, 24 Feb 2025 14:52:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1740437569; x=1741042369; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uLPC0aGcYNb1lvLik1r4PuSirlrOiN9ljuV/brKB6K4=; b=XU1AA155YoD3ndaDCnF9vftLJmsGLzwmp497qOYrU8JbsBxXWyOiTVo2TmzcJYrQH+ +9XwLPSPnzF3WWq1lEzHcek4axKonrIsva25UwyE24RYarq+juNykAAEMfwwHAZlHXC6 DzuyXD3vgpg5sNwhxgB4Yuebhsoq3fvxcrVHE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740437569; x=1741042369; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uLPC0aGcYNb1lvLik1r4PuSirlrOiN9ljuV/brKB6K4=; b=dFHg8ll/r7ugRaHSBQOShmFXB4GIu2RTqGeNa9j2anLY9EP0xSaHbAW+l9UN+Z/3wQ DibmQQxIYgozb9sXcaoi6CnrlJrFDx9qwtY0dXONQXO9rGQccYb3Y9BjpJ4WW+dtH32l 2djQ2FzhXUl7GyPhriGYmQWpIbSmPs4VZA2ekI5iA1pfW2ds7XpJx5/WcVifm2nw/Lu6 2PTBwOSSfSVF8kBfe7HyOWnKCcc/4I8DmqozhZuEOkNPLm1W8WjbcGy0bi+GHSsZ1fDV dRTtRvAGHzm2ND9KRsf3ouphmbLpdGZDMgFToV+MoGpAZuvfL7sauMDGuiCGwnO4xDfH IbXQ== X-Forwarded-Encrypted: i=1; AJvYcCXf6my670hFhW7usX5QTpB3cJ11rSlZvrHPXYFQSp0iXh6wSzFR9yYwmKiuF/KCplkwr9F4XaTvZA==@kvack.org X-Gm-Message-State: AOJu0YxVS/dLbETH8seBcIYnQLBQTCQn9O/bdGdK4vWaewVnJ78Hvr7O Cmlm97ASvd1u6MWaEJl4DlQru8pi7WPXqZztNdPVZz887fD8pmXczm9uiTbp1w== X-Gm-Gg: ASbGncvxEttV7SdDZzhuAqsfwNI/MbMK+Var+6jsbZcpbaGg550l+HNMzRK9gWAOb6r 2IsXW+6h5NLDJQ5JLbE03CJ/roXZAzfYDUU3s4PEcaQwSleIHB0UrRTtBIXT2tq7c/pQ2WXvFFG f9HjOuJaqpd1rTS45DYHDDj5Nwznxs3ibFkDMD+cSwcwRKTA9IJVx8T9bnceQWygC9LRs8CUVvq NFIKcp7pWUUk1VcTXzqQVjz9Nw78xh2c4OfgP+mcxUqmq67BPuw3OMxltjkQ11KnsvUDEZ+uasW 4cWTRbLzbiliD5WBlNZY9oXCtJQW9r32QTj7D5lRdnFBcBDJD6NLWH7iF2iu X-Google-Smtp-Source: AGHT+IHCp48/6UHF/fa/HDiAGSPZBXV+VJjrvt3aHCsldayQ5uHsZNAe0/b2WwYSN5ozi8oGHlQeSA== X-Received: by 2002:a17:902:fc8d:b0:220:f708:b7a2 with SMTP id d9443c01a7336-2219ffdfe62mr95535885ad.11.1740437569437; Mon, 24 Feb 2025 14:52:49 -0800 (PST) Received: from localhost (201.59.83.34.bc.googleusercontent.com. [34.83.59.201]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-2230a092fe4sm1292045ad.147.2025.02.24.14.52.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Feb 2025 14:52:48 -0800 (PST) From: jeffxu@chromium.org To: akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com, torvalds@linux-foundation.org, vbabka@suse.cz, lorenzo.stoakes@oracle.com, Liam.Howlett@Oracle.com, adhemerval.zanella@linaro.org, oleg@redhat.com, avagin@gmail.com, benjamin@sipsolutions.net Cc: linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, jorgelo@chromium.org, sroettger@google.com, hch@lst.de, ojeda@kernel.org, thomas.weissschuh@linutronix.de, adobriyan@gmail.com, johannes@sipsolutions.net, pedro.falcato@gmail.com, hca@linux.ibm.com, willy@infradead.org, anna-maria@linutronix.de, mark.rutland@arm.com, linus.walleij@linaro.org, Jason@zx2c4.com, deller@gmx.de, rdunlap@infradead.org, davem@davemloft.net, peterx@redhat.com, f.fainelli@gmail.com, gerg@kernel.org, dave.hansen@linux.intel.com, mingo@kernel.org, ardb@kernel.org, mhocko@suse.com, 42.hyeyoo@gmail.com, peterz@infradead.org, ardb@google.com, enh@google.com, rientjes@google.com, groeck@chromium.org, mpe@ellerman.id.au, aleksandr.mikhalitsyn@canonical.com, mike.rapoport@gmail.com, Jeff Xu , Kees Cook Subject: [PATCH v7 2/7] selftests: x86: test_mremap_vdso: skip if vdso is msealed Date: Mon, 24 Feb 2025 22:52:41 +0000 Message-ID: <20250224225246.3712295-3-jeffxu@google.com> X-Mailer: git-send-email 2.48.1.658.g4767266eb4-goog In-Reply-To: <20250224225246.3712295-1-jeffxu@google.com> References: <20250224225246.3712295-1-jeffxu@google.com> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 7ECC04000C X-Stat-Signature: xeobig6kq3jgw86u7fehzcczynrxmeoi X-HE-Tag: 1740437570-481469 X-HE-Meta: U2FsdGVkX187AN8lXlzPgDxnCKHm9vEi4vM9aELGQpFNRJvqHHhhqwA50f9NNKpXBV2kAOOGVqQ9SHu6tiIEqCCACgf7Gi+b3xyVYI0MTchVvWy8Z8gYWy2Pl6N5pmJZ9PVyw7Efxv5rl0/W5KeV6RgDvK/rcPyziWNHrMO75cw2VhnBem75LEkugXk8Xst6tKG06OGD/XtHXe7GlPQeoZaEqRpX2M+JRW5jhbYR41iXMx1WmwowWnXaXsTFlBtZiKNqVB0nJOTjJzhu11cM5yL1sFJ5JbV9RYiWnuWJffKB9RvyPswuPHKlTEu0HUsf1KgrlUuVZU36dNp3dHvkdaSYOcpLErG5T5fWYE6Bz1poPWvN9znkuQsvsjvzedmPY0J38ixFHuOVlUYNxyC9Ie/E3ECLjGQ+a/w67Gan2JYSODy8rewbZDAvAklchp5Yhm9010uldUPdSp2a/QBkIi5iNKL6H07tbF8NuggCJs8kU2R2G2vBFQAhlWgqXQXvX3QihwZ7KOmdYOw2QZm3rG7j55ofIYR6UMq3KnVNcvHUSXNZHkNBboubAk7Gy4Ss90kfft182ijcnnrhNCJvsDxMI0ckXAVc1yWQBrgh+996jhCP+EFTkiuTybOUfrKGwB5x5zcwsakevuoZXsfOT9AP+I93LWqJF+zgjYItcPE/4lvejrU6cPkyRX32QRV65Obgb5+PFHunn0elHDAMjCinD64SxrzX08F1LsiF/7kItZMasMAS8v+0Ib94VK7l6wkh4cXzCsnyID7N51xovuqg91UdIUv51bPbe4P+xYzCihuP9GZrAbzn4UJml4IkRC6Ejj/iJROUzye/b2OtNc65SBFZgZwCYSMdKJuV/FE+boqhbSOJcUVB2ULiBAalwJf6wfDr5V1SH9Q1iaJghF5jQQN8LdNGKbmdvsclo4GcoMcEKrLu69hvCGA9RUuv15JrsrvFfJbQr6kFwpz ZRdp2I3d R8gYU8m/twe670JhPepShFLdl6HrN9GcJBQfKthqnarKRBxt1/PyTc3rEnwHDqEde/Wd+6sxpPu8EPj13FQFU79bc1EsDwvjTSWDyi0SDoPkLRuSXfUkbUEaFx0HxOLK2bZ6qm4+ZNymzOuDq2SzXD6DtyxAn+Z6SIQdydEk8in/TKEl8a/xgXeqQQP/S7UBO0a37cyw1QUJhm8u7sGJawc/Sh5mVMOWY7qds/aiFOmaJphITNd/f+jfh57nbJNw+aui/9haikKap4XJ/herOJYmLXZ7drylODfAWAVuWhjrQLLig3t9C4e4VWvZQzxE5275lXNxbmIQEGtiM9W9ae4edm4Q3ZlZtszY5gkhEki/OqjPd/13N6TREaq3lpCF/gwgbG+GXqClRNKWgfzRP7mc04GYbWvHQAJE3/JuOh0DvB9gxUduwA0HOEMJ+FccQRA/R X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Jeff Xu Add code to detect if the vdso is memory sealed, skip the test if it is. Signed-off-by: Jeff Xu Reviewed-by: Kees Cook --- .../testing/selftests/x86/test_mremap_vdso.c | 43 +++++++++++++++++++ 1 file changed, 43 insertions(+) diff --git a/tools/testing/selftests/x86/test_mremap_vdso.c b/tools/testing/selftests/x86/test_mremap_vdso.c index d53959e03593..94bee6e0c813 100644 --- a/tools/testing/selftests/x86/test_mremap_vdso.c +++ b/tools/testing/selftests/x86/test_mremap_vdso.c @@ -14,6 +14,7 @@ #include #include #include +#include #include #include @@ -55,13 +56,55 @@ static int try_to_remap(void *vdso_addr, unsigned long size) } +#define VDSO_NAME "[vdso]" +#define VMFLAGS "VmFlags:" +#define MSEAL_FLAGS "sl" +#define MAX_LINE_LEN 512 + +bool vdso_sealed(FILE *maps) +{ + char line[MAX_LINE_LEN]; + bool has_vdso = false; + + while (fgets(line, sizeof(line), maps)) { + if (strstr(line, VDSO_NAME)) + has_vdso = true; + + if (has_vdso && !strncmp(line, VMFLAGS, strlen(VMFLAGS))) { + if (strstr(line, MSEAL_FLAGS)) + return true; + + return false; + } + } + + return false; +} + int main(int argc, char **argv, char **envp) { pid_t child; + FILE *maps; ksft_print_header(); ksft_set_plan(1); + maps = fopen("/proc/self/smaps", "r"); + if (!maps) { + ksft_test_result_skip( + "Could not open /proc/self/smaps, errno=%d\n", + errno); + + return 0; + } + + if (vdso_sealed(maps)) { + ksft_test_result_skip("vdso is sealed\n"); + return 0; + } + + fclose(maps); + child = fork(); if (child == -1) ksft_exit_fail_msg("failed to fork (%d): %m\n", errno);