From patchwork Tue Feb 25 22:23:31 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13991046 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AE21C021BC for ; Tue, 25 Feb 2025 22:23:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA24728000C; Tue, 25 Feb 2025 17:23:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CB37128000B; Tue, 25 Feb 2025 17:23:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8E6428000A; Tue, 25 Feb 2025 17:23:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8E9BF280002 for ; Tue, 25 Feb 2025 17:23:42 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F3F2580408 for ; Tue, 25 Feb 2025 22:23:41 +0000 (UTC) X-FDA: 83159895084.10.6F40D9E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id 53A771A0008 for ; Tue, 25 Feb 2025 22:23:40 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jWWcxIsF; spf=pass (imf19.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740522220; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JXYNONO7ZJuLowcmp87Nn1WzrESZovUp30JKngKMgKk=; b=yeCU0dicKRCkd95fPt2kWRXmS7NpjKgfamnRFdaA+QLOSQ5BDwcmprJSvQH/dkZekc4WQ/ 4mcGzbFO6L6+hi8IiAAiLgzy0/1xFAX38rCT4qybsCLDC1d/caxFhwTi18TH/bH/DTTFH8 Lc065SYmFWws2nNqnpsguYsjAqe0HRo= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jWWcxIsF; spf=pass (imf19.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740522220; a=rsa-sha256; cv=none; b=vX3dSLGhpDXueaC6/rt/fFjoQVbr8Lp7ydXUSuTGSKRbwgwy/Eri27mZ9ZcmTN37KB+e5p ypUNer1K/NrG3yiMGraQs2Hy0QNUZLheRLvuCurtmULS+T5I38mgITO3IzISMAs6V4HbHY k8ytSXa4rdlwNUpajUw2qJ8K4Naep4g= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9C1D55C5E23; Tue, 25 Feb 2025 22:23:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91F85C4CEE7; Tue, 25 Feb 2025 22:23:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740522218; bh=tpWLGxlVf/4BpHaXx5/fixUy6zdm68z/SbHuewfrcEc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jWWcxIsF2IncuVjeXyx7WphGUorWp+m13Tbpub2EWCXKeluqggOAnnP4/G/4qV8EC cSFf2COGUWDTC6nph6vuVsMX/H8iTJ1It5s3Lqu/ukZlT7kVVYwd9705nw820lnO+t z6Jo7AFBT4fC8gKWvN2fY4vcyclMN5FPA+5AwkuXlANEIDbfmLPPiBhBJqwxkWU7hC QASROGmWrkVlnE0GdwQIWKT0H5wiVIcgsJklhO3/HrBS9fJNxZNe+lbD99z7+teVpU vYPHteMXN3kRkKwv1DoyVvlBvAyp2jTpxkN/gHoUHxJQDlO0+XbU6uqoyBu+KQUp7W KXwA1caOlkhMw== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , Shuah Khan , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org Subject: [PATCH 1/3] selftests/damon/damos_quota: make real expectation of quota exceeds Date: Tue, 25 Feb 2025 14:23:31 -0800 Message-Id: <20250225222333.505646-2-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250225222333.505646-1-sj@kernel.org> References: <20250225222333.505646-1-sj@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: 53A771A0008 X-Stat-Signature: u7wh6h1timcu4e33xioii5so6nwkdzfh X-Rspamd-Server: rspam03 X-HE-Tag: 1740522220-650556 X-HE-Meta: U2FsdGVkX18H1zMxRGbQGg5Yo4RfVjf8nR1Xg6Ke86g5atwTAw0whcMMwb5LTJxtKsMNrfBlquvkRzaLvzqlW/eBMJ8S5ReRZBLC/F+R8LPXES203MOSPZsDD7pp0lJiF8IRdxIuY4F/G82Imp4jeYj9QzdS6GZWQlg5s9ObQdn8Q6iHLcmBCc1pzP+ZLv/R2UbZCRyWHInRRayYx/h+2lx2piTMQcPCi2r0KOfMdSfPcl9JSFs4W6xn1XhLdpDy9TXsH3NjZx6HW+8Xp0DVsHBf//heO19KH16b2EvHXg8o/oqIGiAp0KSxPjDT5SJxWoKwx6P0xUwkZcnzR7ps0vAZ4PtQUk72jAkBQEPFFumhii0WeVaEM3QbLfGXw+qOMhz3A3Fu6PAEnsDJ17TgtARFOLPVx1x8TCdBWI+Vdh7vuu1i/kWLHJhA5A2oWlaeeen01i7Aa4GI3JQH2VEFxSgpvjMKqMw0fHngZmnJV5k6vipGOv4Cl7RHGqmZtXFG1sLuMo3AUANb1oAlkK5wq/FbSr/9sZ2x5e8OH9kgJvl+Xb+FXc/qERlCw8Ic7I8TIvsdDExCGnvdNNePHGNIOuE2eUC7CrW+fxkZdgGcC7h7bz8CpaWaQohDvlM3mKN/MKoufqFNK3QUBlbMZ56JIzglALHZNj3jMyXc0/jgc2HpfWOQfdU0RUWhO5Sj+niKm2hLKJYEIJ5nujy9q2yh2D573LXgO6gnR5rP/xvNC0K6Bx2AOYfdeo+doMLoVeGwfJIXtq1KFaoaCvd/f8QZ6DYopEgZIXwldscLtC/XurECFslaqlz+AZ27TPHPmJryA5sFEjBavxSnmWyEudLvNu6rAXzpEPUcISxC0bTg975hwgbqX3oJ1lct87JeWXGQWxVe1RcjgezQQCfolIdGteZPZamJTvkA0aKDyuKrde/Fzls0+SjHsXMsSCaLYMsuF6UTLBwhauzSWLdGTH1 Ve1OA8EX pwdwv5NpvDwxkrS/czy83FY7ZwpmpTrVFShFjqsUeNIAhfQ0J5MNKx5jWBRJVJRVWJmzeW8ZAE1cC+gL5dBOWgtkVHsfGA93KtWqFgvXkPHK/WCzUxECwiEgHo+YEKOIn+yJyLRekbHmCI2O0mQunvX/De/Yux8OWEphVkrfeFEqXkOqa9OzvriC0XKI+aW/86ZDnE9qAVFofnCcHvjmkIiTJw0Q6QAXu32TNb+0/WuezoSBtzgQ0xhkSwz4GmeO6AZrfyZd0/54PTIxRaIL77g8htQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: damos_quota.py assumes the quota will always exceeded. But whether quota will be exceeded or not depend on the monitoring results. Actually the monitored workload has chaning access pattern and hence sometimes the quota may not really be exceeded. As a result, false positive test failures happen. Expect how much time the quota will be exceeded by checking the monitoring results, and use it instead of the naive assumption. Fixes: 51f58c9da14b ("selftests/damon: add a test for DAMOS quota") Cc: Signed-off-by: SeongJae Park --- tools/testing/selftests/damon/damos_quota.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/damon/damos_quota.py b/tools/testing/selftests/damon/damos_quota.py index 7d4c6bb2e3cd..57c4937aaed2 100755 --- a/tools/testing/selftests/damon/damos_quota.py +++ b/tools/testing/selftests/damon/damos_quota.py @@ -51,16 +51,19 @@ def main(): nr_quota_exceeds = scheme.stats.qt_exceeds wss_collected.sort() + nr_expected_quota_exceeds = 0 for wss in wss_collected: if wss > sz_quota: print('quota is not kept: %s > %s' % (wss, sz_quota)) print('collected samples are as below') print('\n'.join(['%d' % wss for wss in wss_collected])) exit(1) + if wss == sz_quota: + nr_expected_quota_exceeds += 1 - if nr_quota_exceeds < len(wss_collected): - print('quota is not always exceeded: %d > %d' % - (len(wss_collected), nr_quota_exceeds)) + if nr_quota_exceeds < nr_expected_quota_exceeds: + print('quota is exceeded less than expected: %d < %d' % + (nr_quota_exceeds, nr_expected_quota_exceeds)) exit(1) if __name__ == '__main__':