From patchwork Tue Feb 25 22:23:33 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13991048 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CB7BC021B2 for ; Tue, 25 Feb 2025 22:23:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D2C228000B; Tue, 25 Feb 2025 17:23:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 73629280002; Tue, 25 Feb 2025 17:23:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 537ED28000B; Tue, 25 Feb 2025 17:23:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 34CC5280002 for ; Tue, 25 Feb 2025 17:23:44 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D64CB140440 for ; Tue, 25 Feb 2025 22:23:43 +0000 (UTC) X-FDA: 83159895126.24.45F5445 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id 47B84140006 for ; Tue, 25 Feb 2025 22:23:42 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=S66W9kHZ; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740522222; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bZmnFTV+fbaqufZW0dsL4rr2NFFk+aSh1t9ONt/W3R8=; b=CiwTPLJRK1t7mCfEUaPjlBFp/4ZpfDoc9w85E2XqebnVa4A3EpHY80AvZyLFzi6vpnwIBZ uELF3TGM7o8QCneDR/kOElJD37hpGhd80+PPjJoapoam0yITiGWRxQ55lFkkFsVKBMvYk9 xhiHmpXTZVPzkJ6ca9L7fEFw/ks01XQ= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=S66W9kHZ; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740522222; a=rsa-sha256; cv=none; b=sMkUuITgAmljtplUeovkkA/1X0pKH3DJPxHT8tEQcaTd928su1pNQpPRJpENVfItfS+Opg 2+VjzWd3zRquWmEMjh/eK95Kb8uFRk9KDObfcQE+JwwzgXh9rzdQwlLFF4ZBJTcxbCKtmd E4gzZxaZLLr9+OlOr00qANP27drV1Lw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 966B15C5E98; Tue, 25 Feb 2025 22:23:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C15F3C4CEE7; Tue, 25 Feb 2025 22:23:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740522220; bh=JZwrDWNwK0HGwgbbnUAETnfdZFPS3H25nSzCsf8e/C4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=S66W9kHZZShg8xZlcQ533Ohn8T+1do/8o72DrPZ2fNwWyRvPGR7e3p1nLBNM6lOYD 3toGrsMjMc//M4hGKTPTB3s78O9hrdbCHlo+AD0EqnU2zAVSwfqqZfv4BakSmdyJCV m7lNZ48We5IKAq3puevP6JLpbJcdJEtMRLYQX+eOPhaEPR1iaYhMtErRQvmhWuMpGl zNsMZF3FvtkOuAyxphChsIcljZbXj7ErHf1l3iQjzAcS3zFNj2a1uL0MnZgQyi6Y0a KnFR2rqlwbq4oYUlj4hleJXVioXQkHhOisYWyziPULl1L2jll3EAtWzB1nq/SK9edi gsbniAPsLXUFQ== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , Shuah Khan , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org Subject: [PATCH 3/3] selftests/damon/damon_nr_regions: sort collected regiosn before checking with min/max boundaries Date: Tue, 25 Feb 2025 14:23:33 -0800 Message-Id: <20250225222333.505646-4-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250225222333.505646-1-sj@kernel.org> References: <20250225222333.505646-1-sj@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 47B84140006 X-Stat-Signature: 9uadhdwwga4kx4zch3pse7jupqh6ag3p X-HE-Tag: 1740522222-553942 X-HE-Meta: U2FsdGVkX18iUmEPun+jE+n0DQ03u1aa7NhYDTrI2h0lz9Gob9lQobVRwgF86ts/VxpD+izt2TodbuBF2mRNesHa8S/nSOD/zFUgZEXa/LvDa1w/89cmcbVUof4TkL7WiPN15rfQcm9N9FhMAQuzdaberaxJA+ROeUIuIAm9gg5MBn9dCXJpcQNAUfwLNFhaIBVYy1xwLSaiXBhva8pZ7jbyYy4oHUaXvTKc4Uk7ihhqC1wxPE8aTyqfVlOxKRjYj142sO79y3Urq8sC2vxTgEGuB3nK+PdUnw1BW8szgoGHB61bA1kznXMRRI3CBD5Nk9cmqRXOYynaZRf7KiPckWXq4FUE4SNWSPCJ+C/DPyiZaO7LdYWGE6sCXHIXK2xc4GqrIrenyF3/toGcq4IXfHFHKp7FjlwdAp5kH/+6ETOSu192UbywaSTKWK7OXvwjWX1Sjr9UM/Ry44Xgf2TUUkO7qBaR5rjqePJdrMwx/H6u8RprD6P5IGnE1jvmWMwzhkibwil/jBlJfs8/6JUG2n7M6cdtQL/iyYUU2DGX6OC8imf83oo042JZW70xgH/btZBI7urh0OnBJfrFE2ytaxz8W2uz4pw7WfZpKgRl6gIpH/v5K5Oe1fOZBOM2ArWHIF5ZoU3JK5M6RQhXdddLHC+9ZO0GBgg9Ykc/ETlNoLNaB8Sa0Mqi0Nwyg5C+i5AkttkiOlXIWvyO1tP6p2AMW0dcbcLBwGjiwrN5HHZicLf4ySamrOO2oFuxjnH3BaoRGN92cij6nh8JWjyXSLBVT4xcCjIdxquUxhGnVgc1fNdLw6Y33uIVUialV0su9uTLUY1n1J3LuEt7vYTKWTwbBPkNQdKNOKAm8MlLx69hS9gcyvvN/rCdHLVCWFe9ktKyMKJGE3FgxvKGlnGIh50MRXJjCIdfl+75APr0nLoZ5GbcP3IipAG074VZzInHKE8uDlZvtE9F+0tb3L+7oyb we9Nmwlg HWWYJDGByUPVCDCJ9VKhBMITk5QUe2dhTGQuPDToiuF0jWEc7xHEgLOg0sTwo1gz8/s9xuSBedW6xoijy1jeJ4T+oZ9jG+DU9vIGKn+D6zQMJkLCBvBSfMUCY19Abpjv21YdSndVyJ+oS5bOovyqZexXQkXtSfiMlHNpU8M+aabFSMNsse4Ovxia+CGNaqmB+GHkS8ELAkTHRfD37fmqyTzYN1l4XiveQ9TVfghdgvFovGN4ngyqczekp/PdBn1jHY9yZsVdpoBreIwUEwvRa9qoAPJEpUw2+sS6/e5xN/IWD5/5iNEww4KIgHQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: damon_nr_regions.py starts DAMON, periodically collect number of regions in snapshots, and see if it is in the requested range. The check code assumes the numbers are sorted on the collection list, but there is no such guarantee. Hence this can result in false positive test success. Sort the list before doing the check. Fixes: 781497347d1b ("selftests/damon: implement test for min/max_nr_regions") Cc: Signed-off-by: SeongJae Park --- tools/testing/selftests/damon/damon_nr_regions.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/damon/damon_nr_regions.py b/tools/testing/selftests/damon/damon_nr_regions.py index 6f1c1d88e309..58f3291fed12 100755 --- a/tools/testing/selftests/damon/damon_nr_regions.py +++ b/tools/testing/selftests/damon/damon_nr_regions.py @@ -65,6 +65,7 @@ def test_nr_regions(real_nr_regions, min_nr_regions, max_nr_regions): test_name = 'nr_regions test with %d/%d/%d real/min/max nr_regions' % ( real_nr_regions, min_nr_regions, max_nr_regions) + collected_nr_regions.sort() if (collected_nr_regions[0] < min_nr_regions or collected_nr_regions[-1] > max_nr_regions): print('fail %s' % test_name)