From patchwork Wed Feb 26 12:26:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ricardo_Ca=C3=B1uelo_Navarro?= X-Patchwork-Id: 13992263 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62B9DC021BF for ; Wed, 26 Feb 2025 12:27:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE013280046; Wed, 26 Feb 2025 07:27:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E8EF4280021; Wed, 26 Feb 2025 07:27:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D3000280046; Wed, 26 Feb 2025 07:27:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AEF8C280021 for ; Wed, 26 Feb 2025 07:27:17 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4D37F1614CD for ; Wed, 26 Feb 2025 12:27:12 +0000 (UTC) X-FDA: 83162020704.18.C9D65EB Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by imf14.hostedemail.com (Postfix) with ESMTP id 327F410000E for ; Wed, 26 Feb 2025 12:27:09 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=PV2I+fJB; dmarc=pass (policy=none) header.from=igalia.com; spf=pass (imf14.hostedemail.com: domain of rcn@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=rcn@igalia.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740572830; a=rsa-sha256; cv=none; b=1RcoCn7oRfo1rwt9vVYCs6c+qAgRV+sMuiKR2JpBNzQ8z20QK1q/DkDpfK2StNrodi02n7 EN883J2vwq6yEzHKTvGuUdYoF8TCiDM98pi7Exqt+FL9Bk14MIAKt7sbdtpAsDXsAwXlZN SLBwv4TEKXqEo1+cvFvD6+a/bl+ZFxY= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=PV2I+fJB; dmarc=pass (policy=none) header.from=igalia.com; spf=pass (imf14.hostedemail.com: domain of rcn@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=rcn@igalia.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740572830; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=bWGS9xmVUTg5M3b34VrZ8WzlTWbZpIBbMUV45ofQZbk=; b=WuwYcpryDEoqQyEljJs7jFd37mp5ixXJWfqrY0r146A31xk603L5kZNnNTpU1QHz7Zov47 Um7z7yCKS0yK3O+d24d6mTwDt911PhwtiJp+Z5QclCT2a2EsAszVBb0CIpywbv+uqKn8K3 6cSktJzyKxMcvKB2GiQrcXhZpNyL+E4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Cc:To:Message-Id:Content-Transfer-Encoding:Content-Type: MIME-Version:Subject:Date:From:Sender:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=bWGS9xmVUTg5M3b34VrZ8WzlTWbZpIBbMUV45ofQZbk=; b=PV2I+fJB1az6C6vZEm/cmETrto uZ0sUN8rr6od0oiQqJCNkRakjsZMmDLhcgOXldW5nWaIZwISKaNS8lm3n4XQE/HXZ5XPiEiXrRqdJ EZbiq//LSlBKALKb5CbaLPezrDN0GdpWk7l/6v76IW2mC+IhH7jNagbpLIC4UVa9/O0EkAnZKV0wP QwehIpb28hOs01x6rBw4s+gzlWmrJ+xtmqFt9P+uuFvbHnRd+xyWT7voUJIFMQV/HIQgpMqvTKMwx ltSxYHxsnXno8V1FUuuR8CtPLzohW+0wlgSi9JmISVUzHf74Yb0DqhGdsCYpumhGU6nCCrjNlEMpb sWWHpEXQ==; Received: from 253.red-79-144-234.dynamicip.rima-tde.net ([79.144.234.253] helo=localhost.localdomain) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1tnGV0-000xB8-5F; Wed, 26 Feb 2025 13:26:56 +0100 From: =?utf-8?q?Ricardo_Ca=C3=B1uelo_Navarro?= Date: Wed, 26 Feb 2025 13:26:27 +0100 Subject: [PATCH] mm: shmem: remove unnecessary warning in shmem_writepage() MIME-Version: 1.0 Message-Id: <20250226-20250221-warning-in-shmem_writepage-v1-1-5ad19420e17e@igalia.com> X-B4-Tracking: v=1; b=H4sIAHIIv2cC/y2NQQqDQAxFryJZN+BEdKRXKUUGm9EsTCVTHEG8u 0Nx997i/X9AYhNO8KwOMN4kyVeLuEcF4xx0YpRPcaCa2pqowxsc5mAqOqEopnnhZcgmP15DSdj HPpJvGudHKEurcZT9//J6n+cFUDlKlXUAAAA= X-Change-ID: 20250226-20250221-warning-in-shmem_writepage-e7f8f273317c To: Hugh Dickins , Andrew Morton , David Hildenbrand , Yosry Ahmed , Luis Chamberlain , Davidlohr Bueso Cc: Christian Brauner , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Florent Revest , kernel-dev@igalia.com, Pengfei Xu X-Mailer: b4 0.14.2 X-Rspam-User: X-Rspamd-Queue-Id: 327F410000E X-Rspamd-Server: rspam12 X-Stat-Signature: yqw5ny7djf65tjkji497ou61hq8xt9p8 X-HE-Tag: 1740572829-215531 X-HE-Meta: U2FsdGVkX18Q29f/4V5XOfwyLh73BDX7CTOOfReFhDikhuK6OJqIW56AbgELkmxuU1Va5j+Pj7YJzmrDCm+dKOvNjnCZacqBeNARzHp0EHik+hGFyVji1081FDMYxMRmcOIwhsEyA3npYq8YtXgWYfSIXXiarEgSUrkCa+A5ADhZxpdXc+XWc0lAUnnAvevt2gSevqMgJIWt+QN+vE1d6GshoDEk69eUTf97SK14WIzMoRBVWiJz6JKDaNUCXSe3QUcQ/oSexhepV8PgvFycHSHDwYDOgNuLq8lf7OujOxyh9pcdmN5dJdP+cf2AlNy/rR6z9hvkD+/iiZ1QW2z3sfp1ipGm875pdH6Vdo2EfyVVtyy9wK7hvo1XWxuwtDdGGnALQqOcQXNSfh30ArMTSOdIiXMWFjh2bXP36LYSeIQxzvF9D1PaNEtMCbMFkNV+bRudeZnPhNtNV+8iEMks6A5vReUweWSDv7DmM4xALDY5V9Vp4sjQu9A5nMNe0sMjZpDWStA2ZhLk53gZciDwOsV9X++e4h0/MOfuK72aqk5VlPoCYeJO8DQLKIsnhBY44uydzSkCgjZ4m0PM1s5Q7ysIMf7NW2xo7OvAcS1iChtsjUG/IH4sk+li/aGM1rwXhN86KG6F/NJYuxDQJj6yy5+oOCrOfgRkQrsIHgCj67Me+uooEo1Y0oJyQYdhDqfpfS7fyuVx889CwI82b+4K2Vv0ut0FAK6RXz7IxlcCsmVRjbt5k75sFj235n3YIsy59n71nejnWkMhdwbg2FX2A1qZpU7FPpjGACdqFDcBskjtRjm8VZfkW4ze2DFtNIVYeleghqkGgLQEoy8ruoLuudyD/Khp9f93bU7CuHfCrFJLBaaFOhoKvWqcYDpPKKo1GudAsoNJEfrn1F6Xbg8/xPyl4W2B84UpGVsVYFml4oLDGBy83qkJbW4Fq2g1QQAr5+VSymte4bARmVWZSnK J/8JzWm6 O0bck/vaO+RFcnq3iYrmk1PVjQDEQwlScDSfeu//lp7T9iynnUmwGYLsDmyah/YNn6Lx7CVoDkZW+97hs0VA/91vWUt9YnPnCtF7zIBTijPpZntZ4ELtLmy3Q7qq7PpcudVamh+O/Vywi9evmFwXEqnnsJYrpEXOX4GQSBlG8av7beD3a2jTpFz0y0k9EFEQdF/S6RcG3fuWe8+7QryoMD+zwb/iNKVqstXVW+bJvl8WTSaQvn4piglfDQuRVr+79TRA6uGpyx487m9Ax4TaImustN/VpGq3tKA5NKd3VmFSnh0Js3jjPQ9rN9n1+8xGXjvCLS+pG3kazHYRgUOLugXxAWj+z6zeI732FpnBXafr0fkYayxc2f6FDFMDYxCBDZWbHtmBIsLjbHvDoAQXZGf1n+7dzAWHeR5RSYIeCrBoC6vdPBRKu3uTiy2va0ifNH4glrIuRC1cMBha8sbPtRosbEGedGqWmFZr+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Although the scenario where shmem_writepage() is called with info->flags & VM_LOCKED is unlikely to happen, it's still possible, as evidenced by syzbot [1]. However, the warning in this case isn't necessary because the situation is already handled correctly [2]. [2] https://lore.kernel.org/lkml/8afe1f7f-31a2-4fc0-1fbd-f9ba8a116fe3@google.com/ Reported-by: Pengfei Xu Closes: https://lore.kernel.org/lkml/ZZ9PShXjKJkVelNm@xpf.sh.intel.com/ [1] Suggested-by: Hugh Dickins Cc: Florent Revest Signed-off-by: Ricardo Cañuelo Navarro Fixes: 9a976f0c847b ("shmem: skip page split if we're not reclaiming") Reviewed-by: Baolin Wang --- mm/shmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: ac9c34d1e45a4c25174ced4fc0cfc33ff3ed08c7 change-id: 20250226-20250221-warning-in-shmem_writepage-e7f8f273317c Cheers, Ricardo diff --git a/mm/shmem.c b/mm/shmem.c index 4ea6109a80431e5eeae15278064d5c86412f9fc9..a5eaad03038e8ca56a54d096159892e01c7a5bfe 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -1548,7 +1548,7 @@ static int shmem_writepage(struct page *page, struct writeback_control *wbc) if (WARN_ON_ONCE(!wbc->for_reclaim)) goto redirty; - if (WARN_ON_ONCE((info->flags & VM_LOCKED) || sbinfo->noswap)) + if ((info->flags & VM_LOCKED) || sbinfo->noswap) goto redirty; if (!total_swap_pages)