From patchwork Wed Feb 26 03:00:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rik van Riel X-Patchwork-Id: 13991459 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E31EC021BE for ; Wed, 26 Feb 2025 03:02:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 62B6A280013; Tue, 25 Feb 2025 22:02:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B5E628000F; Tue, 25 Feb 2025 22:02:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E235280013; Tue, 25 Feb 2025 22:02:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1373E28000F for ; Tue, 25 Feb 2025 22:02:43 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CE46612066E for ; Wed, 26 Feb 2025 03:02:42 +0000 (UTC) X-FDA: 83160598164.23.6AAEEAA Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf19.hostedemail.com (Postfix) with ESMTP id 58E681A0010 for ; Wed, 26 Feb 2025 03:02:41 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf19.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740538961; a=rsa-sha256; cv=none; b=QkBCEx7mSMj/2FBRdse1fQYDITU8tUf+gi0BwKpjkBLx8+IX6mlQaQdw9TszjSdnDWU0Nu kYiyALWpivmdMG24kv979zBd0x4MjfwVXtWzWcg4xZ5s37CIsJwzpxlfurDT6eeBqAa9l5 9HL9WC8XCz89qxLz82WBDckO1aVghbk= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf19.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740538961; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CZXldwNfoBeSPHhHtkjfRWchenbUlW05eL04gXlbatk=; b=Ny9Gr0xKNbbtmWK7d/85v2gJzjuDIkLalE9FasVHhs4/wpooegYIW6+SW6BUTK4QBb2hXV AyqDRZXNC/yaPKjYAvo/MRvkC/DqJNN4muWUDMgLTqlzt6aCKcKHScoChOb6LZV1TOhc6n DMHAViNTvBYFv1A/cJhwwDvtFYx2zFQ= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tn7fw-000000001Y5-0hvS; Tue, 25 Feb 2025 22:01:32 -0500 From: Rik van Riel To: x86@kernel.org Cc: linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali.Shukla@amd.com, mingo@kernel.org, Rik van Riel Subject: [PATCH v14 04/13] x86/mm: use INVLPGB for kernel TLB flushes Date: Tue, 25 Feb 2025 22:00:39 -0500 Message-ID: <20250226030129.530345-5-riel@surriel.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250226030129.530345-1-riel@surriel.com> References: <20250226030129.530345-1-riel@surriel.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 58E681A0010 X-Stat-Signature: 43c8e5brcusk48xh7k6pwnozirqubnep X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1740538961-879825 X-HE-Meta: U2FsdGVkX187qEFSslZXvH/NjZBLpasxoZRJX2uM1FwpHW0I94YAr7sY8APgS19UM2YgjeP0pfq5zAS1cF5AnYxbKxsz43UUhYTtReMETBjBsPocdS5s5Q/jIvp4iO9YLfjS2xrG51aLgmaJIqEFY3W16oJU+kDhq5YSUuoQoJW1pLa5pjNtGlErqbgOtMlTqKnVHbQQtcWmMiShAaIdF6e9SZP6DPchFuNOLmKIPVkCVO7TKpe9GQxCo2WWcdop5FPJEoNQrKcdg+utYQl+AZiBETexGhMinvyL3/Rrsbfrwj7Z3T/CVcX/xO+mYuAo1m3TWgBmeurUx6lwuVbHkAj2QBMGVgeW3l/u6GV3e9hRIhhqV2adz2ar9AgxRaz9BAxwIjjfemz77d6w/s9RxeWJRGhkwSvJfI2Wzf6+wKW9lG2d1WZxrJMQ4y/JxPlsBtXliUxpPzenHASi389o8z6ddzaVf9dqKl5FUDsoUxuLXiIQhmp1wRW9HnHkS9t+utuvvbGPuh+slEjH8aDc5bKdyuB3sKFmfsfEpXJsAj25hP/YMkGzhwWhw4xzH6ZQuRDrAc+KaNfwwSwKEWULwAtivYhI9RvdCtRN8whiLA1QgJcwDmhGyTyVsad1gMbncVK1cxLuj/Sn4xBHWTABIfSzUUwMwuGMOxjRwsroYFPTUzjulzbVVshwuCluJI28f83/SSMekdgMplVNmkNtiRIP+vUcAJN/QJjE+p35iQe9/1uaPBOF+fTDNKMM3jVDgThgWs/R4wwqs472c+gfN2BMA6J8jrdEdsssNQYkSLEqf6gCnK2v+yOscX7EEI3B5yoXmKDLORYAEzQQCfzRg1nIq8ToNyL7bMZcgZ1gfqwfCjDSVpdv5JHwCzMYNiH7ZLFYmITnE9PdqjTiZ5C2g0xVKrYcN4QIJdJAWHt6nsYNcMMABu0TsO5ha0JhANF33RlPoqNabRQnQK9sjGr e+D1xZoQ AUhuQAmo/sDa3WiEfybmAviFGRUI7DAvbi3yPBLZ07FIReWINMH3A6KIgC5OznO9FXVNRnnaNdAgFPGNAJUhbmcaKH2j2HU5PE8VqZWeNkxboR7VAnuJP6U7x5Y/HGOaRWFyPrt+foqRCm5peGRoIZj4Mzwdm03YPy2TFqrP7wzSeAeR5RNrkxi4G3AGfUAUiFJrU8dLllvMvGHmVFsDjr4276bgaVlTawcRggpPcl/JKsu8cQtlD9FiK/O1Bc0wm9YWRPkIFIkIhTy7hTmWMqJtT1akb2HeU0amieu/kw0bfLU6kH8z+GcmkDWE4dfIbYAjGxnLzfDXfHySffYre5QmMWikCa0ByBGkf6LREYwsKWfH1TD+T6y1x1A/ZZMq4xpTUMhxlQys6+oB7e9vn1/Uxebzla3o1u7K6mzyoq8EO/moqo17StMk1znKds7ZopQvFRtw29Im00tY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Use broadcast TLB invalidation for kernel addresses when available. Remove the need to send IPIs for kernel TLB flushes. Signed-off-by: Rik van Riel Tested-by: Manali Shukla Tested-by: Brendan Jackman Tested-by: Michael Kelley --- arch/x86/mm/tlb.c | 32 ++++++++++++++++++++++++++++++-- 1 file changed, 30 insertions(+), 2 deletions(-) diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c index dbcb5c968ff9..f44a03bca41c 100644 --- a/arch/x86/mm/tlb.c +++ b/arch/x86/mm/tlb.c @@ -1077,6 +1077,18 @@ void flush_tlb_all(void) on_each_cpu(do_flush_tlb_all, NULL, 1); } +static void invlpgb_kernel_range_flush(struct flush_tlb_info *info) +{ + unsigned long addr, nr; + + for (addr = info->start; addr < info->end; addr += nr << PAGE_SHIFT) { + nr = (info->end - addr) >> PAGE_SHIFT; + nr = clamp_val(nr, 1, invlpgb_count_max); + invlpgb_flush_addr_nosync(addr, nr); + } + __tlbsync(); +} + static void do_kernel_range_flush(void *info) { struct flush_tlb_info *f = info; @@ -1087,6 +1099,22 @@ static void do_kernel_range_flush(void *info) flush_tlb_one_kernel(addr); } +static void kernel_tlb_flush_all(struct flush_tlb_info *info) +{ + if (cpu_feature_enabled(X86_FEATURE_INVLPGB)) + invlpgb_flush_all(); + else + on_each_cpu(do_flush_tlb_all, NULL, 1); +} + +static void kernel_tlb_flush_range(struct flush_tlb_info *info) +{ + if (cpu_feature_enabled(X86_FEATURE_INVLPGB)) + invlpgb_kernel_range_flush(info); + else + on_each_cpu(do_kernel_range_flush, info, 1); +} + void flush_tlb_kernel_range(unsigned long start, unsigned long end) { struct flush_tlb_info *info; @@ -1097,9 +1125,9 @@ void flush_tlb_kernel_range(unsigned long start, unsigned long end) TLB_GENERATION_INVALID); if (info->end == TLB_FLUSH_ALL) - on_each_cpu(do_flush_tlb_all, NULL, 1); + kernel_tlb_flush_all(info); else - on_each_cpu(do_kernel_range_flush, info, 1); + kernel_tlb_flush_range(info); put_flush_tlb_info(); }