From patchwork Wed Feb 26 06:36:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13991598 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EF3FC021BC for ; Wed, 26 Feb 2025 06:37:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC6B2280011; Wed, 26 Feb 2025 01:37:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A7635280007; Wed, 26 Feb 2025 01:37:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F058280011; Wed, 26 Feb 2025 01:37:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6F878280007 for ; Wed, 26 Feb 2025 01:37:07 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2085D80C6D for ; Wed, 26 Feb 2025 06:37:07 +0000 (UTC) X-FDA: 83161138494.06.B904306 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id 818E5140003 for ; Wed, 26 Feb 2025 06:37:05 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MK4TDoVk; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740551825; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3MYYDuM8DCriaMbr/dnBYT1lKgXzNSRV7iUhv0lX8Nk=; b=GxokRChkpE3YQbnp7/n26bK2n3PxJsfdstpfl4hc0Na/4TZHZCS3bEkgPU5XlWjXMqQ7RF eex51S8+p6CCpSuhO0hEGxv9TedMhH/GGfuk56++9axx0nf54CLjQpIKZxG4ihDl1GFlGe Q5krN4qFT/HkEEpceqrsKTsh0VYsZvA= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MK4TDoVk; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740551825; a=rsa-sha256; cv=none; b=JQMC610LUAx4vP1zOmaZEOawWqlvIlDNk7Y5C6DrOrnUWC5pcgceb9qFaSp9hTyGX3aCnk VKoxedaGhDu3JL4T1nYCXbctk1O0qOysc/xgB8DdUOrwes0jecsRhEiA/sN0fz9azi+tyh VYV6amEhLeSxmHvQN1zxR4qS8NTBAsQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 58CF15C5E92; Wed, 26 Feb 2025 06:36:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD050C4CEEF; Wed, 26 Feb 2025 06:37:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740551825; bh=7J5ghi8H2WMjQQb1EvkfdSEY5M+51vnK26msM4ePujs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MK4TDoVkFXgj08qkJ+EcQXH+mw3NjLfnViyo0n3e55anSepeTY5jXsyN7Yt5mkqxV Lulnr/k/dX1l+iDioETho9Vd/iKLfxVPHn2tQEzbbbwJrdKMR6gNJs8nBLXVw8xSUz YPbvl7K0LN+3bPsbgZjXPdB5R0g+QcqPj5cxEPJteD/+HCZDOha6Wm+W5Ob7gXHQvZ LoZbADvdbvVZ0Rx1FwPCGaQsb0JC3ykTliyJA3LCvbxDHkF6R3/ctpcvkmzPLTQ/tK WHARxzqIRfK2FN06WamKGPZYWdgzffwMQ0MFOfdZDm6KjryghaYUT4LtsfGA1Y2aGO OI7eQC+5MP2rw== From: SeongJae Park To: Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 09/13] mm/damon: remove damon_callback->private Date: Tue, 25 Feb 2025 22:36:47 -0800 Message-Id: <20250226063651.513178-10-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250226063651.513178-1-sj@kernel.org> References: <20250226063651.513178-1-sj@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 818E5140003 X-Stat-Signature: mabb9jmmr6pttpg6wph57t5bqfbakfhb X-HE-Tag: 1740551825-423787 X-HE-Meta: U2FsdGVkX18uGyDj0ZpdL4iZ7M//1CzQtExzYvG6KSK4Lf4wJOO+Yja9Gq7R3mpGBglCxzM6n0VUR6VhsepY3N+L4TMcoQTHHbfq2+5snz+ZOW+DtDBlbhgzIyB+Ei5hIuwIkp97lJHEUD5lMu4DgfT7wmXllknSqqbFrP1H4IjOQKHuM01iV08CS7qgwvmiXTYGEEqmmheS2NASB/getZs91ojBUUaqtMKsSvuf2R2U/eZuja2qQuPwOBDZhAGa1VweaTIZ1VLWnfO7ANJ941tsgmiifkJvfvqCijvEpaMf9rsxQrsQIecxiOsl+oW/4JiH1Orf1n73i2EzKdzYCgmO+o4ofwtyZ+Zl3XEOWubxjJIOknNw+zob9s8cJUMqR8dS44G4Z/9Z7ZpJqrhqXJNV5E8qZ8s/cWbFIvWx58MkmKBVC8rozfmtRNo14Q4hLv4SZxMeX8GFQgtcykjhLte8eIHNkr5AWALnaYlCXSTU1XrATt5S1GgCsWHeTLTC0gOKb0ELR7MaYdcEGBlNR3xVCiDZmH7Fh9YprOAyxgexGcAYE4dPXfxHTnVSOjG4HPQXMXO55qPAq8bAJAh7eEh0MuDMteqHdeujdV/PVJeBDZTe8t1kw2r6xs36XLMPJEa9B2w5Xu+GeWe2gUjVPUx+8QdPhQ6mPMm6Uf0u/z5wJ0J3rKKqwxVZkeAebgWxV+3xs1kFFmjKdOkhdfL1wuZI5yW+gHct314DBkJsT0dbTEB1PiMv2Xtdwa9bbMk6RtDsTDQmP5JjeJTXYf6HWMKJXmbcFdNI1mu21gowIsDc9uk94ITLnOD+orifmxWqcBkxSghfL+A0GfGImjp7RkyJggu5SyMuZlUMpxvtMFS5vQiFgY9oXvR/U6Bl2RdD9dl17RvPPLU9vR75QhJXTRbPaiO+5Bl+/U+h2NbLHu/6TYVTJ7sdgg+M2LC2dVNd1JAGwt+BhewLfmlPLI/ /dOJShlk Cv2GpjTypFJyK6bBFIrwn4JRMZ/xWXBMYCukIDpsFOUZ4/XtcpZwWvznUj2Pu3AxnujgbcuA79TtAh0sKAHIlswZfiaPtGCf0MQwKNVMpgIcu5l8qamcBPmRKludiz4xeUwVjrFKhLHrHht8h776vyLyfN5tcFIaEHD2azVNWUgREX/u17Q08UMq9gMn7Sf2SwBasaQhpUaVwCZ4f30Dv/ZKxpN6LYqmsR1EbgDPRtygt2pO945HZFCYt6ycbePHuGzhWYgVeZ/eIr8KwXCxqOqZz/g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The field was added to let users keep their personal data to use inside of the callbacks. However, no one is actively using that now. Remove it. Signed-off-by: SeongJae Park --- include/linux/damon.h | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/include/linux/damon.h b/include/linux/damon.h index 636dcdc49b22..2b783c91cbb5 100644 --- a/include/linux/damon.h +++ b/include/linux/damon.h @@ -604,12 +604,10 @@ struct damon_operations { * @after_aggregation: Called after each aggregation. * @before_damos_apply: Called before applying DAMOS action. * @before_terminate: Called before terminating the monitoring. - * @private: User private data. * * The monitoring thread (&damon_ctx.kdamond) calls @before_start and * @before_terminate just before starting and finishing the monitoring, - * respectively. Therefore, those are good places for installing and cleaning - * @private. + * respectively. * * The monitoring thread calls @after_wmarks_check after each DAMON-based * operation schemes' watermarks check. If users need to make changes to the @@ -625,8 +623,6 @@ struct damon_operations { * If any callback returns non-zero, monitoring stops. */ struct damon_callback { - void *private; - int (*before_start)(struct damon_ctx *context); int (*after_wmarks_check)(struct damon_ctx *context); int (*after_sampling)(struct damon_ctx *context);