From patchwork Wed Feb 26 06:36:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13991600 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A822BC021B8 for ; Wed, 26 Feb 2025 06:37:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C5050280013; Wed, 26 Feb 2025 01:37:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BFE0E280007; Wed, 26 Feb 2025 01:37:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B218280013; Wed, 26 Feb 2025 01:37:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 74454280007 for ; Wed, 26 Feb 2025 01:37:08 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1D23C80C6A for ; Wed, 26 Feb 2025 06:37:08 +0000 (UTC) X-FDA: 83161138536.23.ECF0242 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id 85290180008 for ; Wed, 26 Feb 2025 06:37:06 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Qo/zDMIb"; spf=pass (imf24.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740551826; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xdfcRqARcPGc084FmgCeuP1wshoSWNriGQ9mP2YertE=; b=a7P3ERggfcbOB29YQjuYiy/yXr4MIwsHl5FrV/aXOXhVawePn6UIzarbmbPYGr7MTmI08e GL5Ugtm8cs24aQG2b3wtVdl8wOMMhyMFsBQRtIiCejY1dzWU1NwiNPpOjTayiB2BcfJrpM OgU8z0O/vUM7Tj9UDrbUYZSb1M57KTY= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Qo/zDMIb"; spf=pass (imf24.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740551826; a=rsa-sha256; cv=none; b=YZSsEFua716WH/0H3XhBRTpj0ahJl+axCpMqwKvmVXxME8559iI/+bWh3nsomba4nqwFeH bu5HA4cIjGTjQR0tib2SaD1gDLSCvVAt79L3m2qsIgSFpAgQpsYu0ojzFkAZ3OCLCuO3zQ 7ArhGQpILF8ca6tz+FhGJuNrg3nY0sU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 6BBC75C5C1C; Wed, 26 Feb 2025 06:36:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F3D24C4AF0D; Wed, 26 Feb 2025 06:37:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740551826; bh=e9BbdG+2vB4mTDRNMra/h/Oi4AJ4RbVhMKgF5wEM9pw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Qo/zDMIbXIg4iDVJoez5QmSFrcvso/zTS3AF0lBT5xEKV2so/jqAzecIE/MA1ci1d 8bJb/oeaUeW3UiowG/ACpPzXs+xbCwGERjCC8K12Wb5Yjrh6aHbiosCR3ftS36DTGz ylF/G3Mc532XIVh45Jeoc1Pa5aX88EZZGRQi6YELDM+8AzhT38Pu7TOcS0V2yBZtXW MhCiqCSnls5757YCrjBjTAIWH5o944ZHS/9jHu2fPjSQPpYOaAknFb79Blcc2QtASs RE44cR4n5JTU52dRgQbINPnxtCHGXPdV7oqysRLLjtMUTUcnnHsy9DqCzeOko4MaVC npq+r7YNR8bdA== From: SeongJae Park To: Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 10/13] mm/damon: remove ->before_start of damon_callback Date: Tue, 25 Feb 2025 22:36:48 -0800 Message-Id: <20250226063651.513178-11-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250226063651.513178-1-sj@kernel.org> References: <20250226063651.513178-1-sj@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: 85290180008 X-Stat-Signature: ibfaifjz4zycwhnq5qeq89kxpek41ok3 X-Rspamd-Server: rspam03 X-HE-Tag: 1740551826-200413 X-HE-Meta: U2FsdGVkX1+nLAwb64EcB0iXGP8V/iEioT5mLQPx2Ff20T5t6mMivVqIdLSWtdlPXp6DM/M4wzxScjzu7EP/hSfw02WpMwtDH5z1EOpiFDxPrdw5w1GsrBK7Uj8cZ5zAd5hCE+HgQEWQUFUDF5R9GA1xvFrpw/EJS9Nysq5bPKQpzHjPr1sBEiOz/bWCw2Blzz+1CosaeypD/DSBPDNa5WxBOKL3ZSRAj7p1X7Udt+qQ+0xM8Xg7O8Al206dnBXH+mKRlkk9a1hfgVyj7kgBV+56TotrFN3L8M5p7FF9ctMdY6+BuTeo52FXdbLIIHzb4ik+p/eLA7KAyJl+jzpmblKErm3vev6Ut52aRVtoLEYqSV4iq34CBWRdrVA+DVgrce7SAk0xrlunKytfmJM+uCJVxl5fTEPYXCdEQRTJxLMUickhx2Zh65HLdFBY66CGzxKG42zhrg9c4ggG2dDS9ZTZRaJqGmSodjfVg/f7ZdVqgyPSCEGOfIJYfnjeG71WIQpWFaMoYregpF7HXRvsDuRkXCsFyjiGu4PURx4iJNu3+gnI5a19JQszdLiltHJjkadzV2RvDSK0Ijz5mlUf4BXJ7PaT5FK67FU/pJFX8wI40gj25ItFPhk/axz+YS4zghR6npO0tvzool4e1HcJJlMV5i4zejV7KnxiMYudNCYddgn7/3zspT0iIxd/YD7N4wupevgrrajiGOr9uirRlorX2ye4hLkyHOloQPQKtbQJXsNluFBC7lGAobnbu+2VNEQnzqQYYDFSAtkhrmuDxiUfHFfha0Be3ta2OLzdI1YQw8BmU45s7CgfEF3ORFYAWeB++6pKdg77aOKqE2QaQjWZH7+GdwYNS3OaLeVeujL/HOY8GF9o2IppLBzjcAW3o6RUKGJeBuVgr7Bdmgup/hN23tgz3woMeNooJXPYV0k9KMyDFqsMiIyjzpydLISxVRlNgQskmgEMqGdrjb5 il5q2wWn Pzi0L5aehOn29PZlvNdi5dJd8DFaZbzAz8L9tuQFheUfDXHqH61H2EooIA8LU4Rq2tOPBcFeQakcnIa8KeAHFvhJwzDz1sw+4TNTxJf8sdoozubGI7b8I2kl+RUYfbWAk83NKoX0tmdPQZoZ7pGhvNMrITs7GOWk9OyLEnQKftptg3XJdBlVoKE4aUwwX5M0g2VhMiiBVRYLsQ++Kmu3NN86ditmcZfVPQVwYBs280Mtg6oIOhMHMSuVoWBigE/F4QhECB3eGI9++VtSfW31EClA6lQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The function pointer field was added to be used as a place to do some initialization works just before DAMON starts working. However, nobody is using it now. Remove it. Signed-off-by: SeongJae Park --- include/linux/damon.h | 7 ++----- mm/damon/core.c | 2 -- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/include/linux/damon.h b/include/linux/damon.h index 2b783c91cbb5..11cd916b41fb 100644 --- a/include/linux/damon.h +++ b/include/linux/damon.h @@ -598,16 +598,14 @@ struct damon_operations { /** * struct damon_callback - Monitoring events notification callbacks. * - * @before_start: Called before starting the monitoring. * @after_wmarks_check: Called after each schemes' watermarks check. * @after_sampling: Called after each sampling. * @after_aggregation: Called after each aggregation. * @before_damos_apply: Called before applying DAMOS action. * @before_terminate: Called before terminating the monitoring. * - * The monitoring thread (&damon_ctx.kdamond) calls @before_start and - * @before_terminate just before starting and finishing the monitoring, - * respectively. + * The monitoring thread (&damon_ctx.kdamond) calls @before_terminate just + * before finishing the monitoring. * * The monitoring thread calls @after_wmarks_check after each DAMON-based * operation schemes' watermarks check. If users need to make changes to the @@ -623,7 +621,6 @@ struct damon_operations { * If any callback returns non-zero, monitoring stops. */ struct damon_callback { - int (*before_start)(struct damon_ctx *context); int (*after_wmarks_check)(struct damon_ctx *context); int (*after_sampling)(struct damon_ctx *context); int (*after_aggregation)(struct damon_ctx *context); diff --git a/mm/damon/core.c b/mm/damon/core.c index 5b807caaec95..8efb249be855 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -2399,8 +2399,6 @@ static int kdamond_fn(void *data) if (ctx->ops.init) ctx->ops.init(ctx); - if (ctx->callback.before_start && ctx->callback.before_start(ctx)) - goto done; ctx->regions_score_histogram = kmalloc_array(DAMOS_MAX_SCORE + 1, sizeof(*ctx->regions_score_histogram), GFP_KERNEL); if (!ctx->regions_score_histogram)