From patchwork Wed Feb 26 06:36:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13991601 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B808C021B8 for ; Wed, 26 Feb 2025 06:37:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9B17280014; Wed, 26 Feb 2025 01:37:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C4A4C280007; Wed, 26 Feb 2025 01:37:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A28B4280014; Wed, 26 Feb 2025 01:37:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 82559280007 for ; Wed, 26 Feb 2025 01:37:09 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 49BDA80B45 for ; Wed, 26 Feb 2025 06:37:09 +0000 (UTC) X-FDA: 83161138578.03.33010B4 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id A8A0D140007 for ; Wed, 26 Feb 2025 06:37:07 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=s+hMAQS9; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740551827; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uOReOJc+cft5+DdFrh5vbKC51yWodgGEZM2ZebuVu2k=; b=Pz2Tx7y4Jw19u4KwqhAQKpt7nv1J7ej9ovIa+ygGFFRj8vFI4kUax4AOVEoQsCoJ3/tvLG lWjBqVwwwTpYWk1DcXIyU7KGKv9PUOB7No3LzozBZNYaf8422AGhb3zSG7Rh0fwlu6LsSS b3spPj//PLUdz7Mg2wUg82muHNTQRP0= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=s+hMAQS9; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740551827; a=rsa-sha256; cv=none; b=rzt/ItpHsQ9GUFZhlZlxZlS3FDLmk+TT/c5K90tv4riV816GqmV2fbnF9SkijP0b8ZcYnd pGH1FpTT9HIM5L8hA89SZVHGbk6vKvQh+dAYvr5Ck9qh1Zw5Ca9CwbUSYOGlIfXv0hj4Gn mwt5kX9FuXEfrgz8RgjVlDJCIPr0UYI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 831A35C5AB0; Wed, 26 Feb 2025 06:36:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1517EC4CEE2; Wed, 26 Feb 2025 06:37:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740551827; bh=PfFmM0ne7oeiliHHlhMvk+NOJkvWZ9fZ49v2P+Pn3V8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=s+hMAQS9IZUUNzjcxBCFzvAu6e86w60J/OsSVl7SoXFMus4d9TQBOdA38tv76FXlk kw4INrISe/ou+9pU8qcv+As2O2REveghPG5mSAeSfhWK/XEBcT0GOfP41fI9bvGI// 0vleAx8Tzorcq/SKPmmTDV73koXV1J64xp9SscUbgZnF3SEeE8DyIPfrbe58dVmfHK tPq7bxuvwuPcFGbCp0Vx7nzHO2i/PLFG3jekRQBzPT/2ZyATYY/uwYiBhO8cULjONS vnM+w+IIDAQADnGOeVdKin+e3vO+nf8/h4sWAsmLsJblwz9RC+x0Gv3wpX8dIGQNaL rMtg4tSW/IJEQ== From: SeongJae Park To: Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 11/13] mm/damon: remove damon_callback->after_sampling Date: Tue, 25 Feb 2025 22:36:49 -0800 Message-Id: <20250226063651.513178-12-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250226063651.513178-1-sj@kernel.org> References: <20250226063651.513178-1-sj@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: A8A0D140007 X-Stat-Signature: cywmhfan7kzzbgxjezgoep8zwqx487ni X-HE-Tag: 1740551827-598726 X-HE-Meta: U2FsdGVkX199lSpS6VjiCK4Qs9q/8yBH99XuK6/930HrAg9P9t63fBNyUzKSyvnlTm5KqpjdsT1jgoELA8BEtGbpDfpcmcPxfYbxxa3EV3PV9X83BuxyZeIgJegNUxVh4N1asaQx2lXU8RmZFZjHMD/HrQjj6UP6FbFsrrSjgiGLfmkvTg27vFH9oPJqxLq7WPAzK8mPM5rBOcaO3XAbJQhOqG1LeWVVirZiI7JesqDC2G9X9YX2Qn7bdbz9l+nDnHtZlS3ngeUpxuCm/eqJkX3vjuy5bPW4byIgUH47pRsV5l3L+oB5xLXor7Vu6z6Of09c4DtbIyBhPEj4a0YGOukA+TvvAxiWYaJ48AmAAL94MAr5oBWLU08N7/rE3Ea3LQBG9XjhsZ5pDYTeHjkQUHpWMnIzizv4nk14XY/moIh69HDZzO61Bnrwe5WX5l8UY0GAeAPUrupqRVhK59rStv7TAAs5wCABauEGxKShvULk0D1qM46nhADrTRrtFRqJpQvadxkCIoA8NXChz6iQojy827oSDWeoq+T7uSzKfIipLgjKM2geR6OTIljQUkglkXzHe9ucEKF2+8MUUMzjrfL8iuylmCy/YOV3j2zThIxMYjLn1yeggiHKy8F5N5ZV/A6Un9bOuJ6JU3eODDV0OpVryaMofJUCtcixZ81LHI54UpOEoHqROdUe/BcDnndqlh439AyobvW7CRRVHs5Oxlu3bdx7HgHPo3gHXFAhjGZVNiEKQaTs7kV3+/xh9kvWj3SbVx2TOlLXBXMN+mSy0biMTL/7+OVb4w4fex2ZCqJvG8ohpg9KXafHwMK6mVRJ7ukvVE4zfmRxIfXwr1yZppOLEBAbQFYB/xomjWalQswuzVir1A8MMHMm22bsrCPS1+tDPMY874qWz6uR+QOWzIIbhJUtYTprk322l78lvzg8rjCkFznBqbvgIYXEOXuZPi6G9RO/7w144/sCRP5 wnEHLUkE Ex4V7ybX5oZ79ymQxMvlLbNCd81YTnp3v7fUUbTCsRVPQEgNMxIbFcavNsIaBnilYmkwqQN0PuWUE2bTWISAWiZc9PbK3EvMtzN9hDWVHP3fzOhf9apuBsBNxYo8YJjehffhcJvXezrOBmQ9lY/FpEGBQ/biVLKtOntaMniQdiCtN94u2d8HnfBtngS0JgjOhVEuDtvsrht3aII/nCQe4dZjvdsIMZC0BjqS8HNDUlZv6uQDRaQ4zdLifwThIRasdsZISdDmGz4dA0RbCF7FylGRHUw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The callback was used by DAMON sysfs interface for reading DAMON internal data. But it is no more being used, and damon_call() can do similar works in a better way. Remove it. Signed-off-by: SeongJae Park --- include/linux/damon.h | 11 ++++------- mm/damon/core.c | 3 --- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/include/linux/damon.h b/include/linux/damon.h index 11cd916b41fb..c9abacf16d88 100644 --- a/include/linux/damon.h +++ b/include/linux/damon.h @@ -599,7 +599,6 @@ struct damon_operations { * struct damon_callback - Monitoring events notification callbacks. * * @after_wmarks_check: Called after each schemes' watermarks check. - * @after_sampling: Called after each sampling. * @after_aggregation: Called after each aggregation. * @before_damos_apply: Called before applying DAMOS action. * @before_terminate: Called before terminating the monitoring. @@ -612,17 +611,15 @@ struct damon_operations { * attributes of the monitoring context while it's deactivated due to the * watermarks, this is the good place to do. * - * The monitoring thread calls @after_sampling and @after_aggregation for each - * of the sampling intervals and aggregation intervals, respectively. - * Therefore, users can safely access the monitoring results without additional - * protection. For the reason, users are recommended to use these callback for - * the accesses to the results. + * The monitoring thread calls @after_aggregation for each of the aggregation + * intervals. Therefore, users can safely access the monitoring results + * without additional protection. For the reason, users are recommended to use + * these callback for the accesses to the results. * * If any callback returns non-zero, monitoring stops. */ struct damon_callback { int (*after_wmarks_check)(struct damon_ctx *context); - int (*after_sampling)(struct damon_ctx *context); int (*after_aggregation)(struct damon_ctx *context); int (*before_damos_apply)(struct damon_ctx *context, struct damon_target *target, diff --git a/mm/damon/core.c b/mm/damon/core.c index 8efb249be855..14e4122464a1 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -2423,9 +2423,6 @@ static int kdamond_fn(void *data) if (ctx->ops.prepare_access_checks) ctx->ops.prepare_access_checks(ctx); - if (ctx->callback.after_sampling && - ctx->callback.after_sampling(ctx)) - break; kdamond_usleep(sample_interval); ctx->passed_sample_intervals++;