From patchwork Wed Feb 26 06:36:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13991603 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5E7DC19776 for ; Wed, 26 Feb 2025 06:37:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39C09280016; Wed, 26 Feb 2025 01:37:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 237C0280007; Wed, 26 Feb 2025 01:37:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D973280016; Wed, 26 Feb 2025 01:37:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D9986280007 for ; Wed, 26 Feb 2025 01:37:11 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9E4FC160C61 for ; Wed, 26 Feb 2025 06:37:11 +0000 (UTC) X-FDA: 83161138662.22.5361131 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id EBEC2140005 for ; Wed, 26 Feb 2025 06:37:09 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=NkC3trE4; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740551830; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zi4bLAzmPbKb/rcJNSQQvSUwrVRMYUCwWJWkJW+m6f8=; b=vXIL6RA46OtdKssduxCJDHR1WKYXImA/PDfEF0t/PHh4Qtf0xIMC25JaGfMBWCw18MrI5B jJpjCATJCEWp9h1oFhqxScy0fG0ddJCiNgFm9bSUJu+CVpEkN+5V3oalw4ol3unPve+mFa dEIIuNijKAOZ2pTbOQuGk6qklgf2ZP0= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=NkC3trE4; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740551830; a=rsa-sha256; cv=none; b=BUAddM2MRkjNfukuf43Qv/8ZLSDEZSt7Fqyhowcr0b0W3ec2F8pFYXTfga2V/TsYcPYsBS 4RIp5LqGDPMi22IkROca3fdt4XB2I2cGmA2drT1FMlB0/ZJ3qDbN1CeJj1T3bvegbUq4k1 2bzVA7ggmxiErY9uB41VjnwwEjHR7Ww= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C57E55C5A8D; Wed, 26 Feb 2025 06:36:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C407C4CEE2; Wed, 26 Feb 2025 06:37:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740551829; bh=tR7XrAvAqL9tgp0wezUMza5484QErgFfXZf5Rw+Zt88=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NkC3trE48rYxCFFDy66tykiWPjoMbZBsb/HBH52ZAkninFLJ0O7MByribphGwbMXz KLyVk3wtX2t/4Y0G1+C3lCFJJtVUbu69r17GBdwwItO1VXWf3YcRODWw7dXkn0AuAE phXZP9tRtyKsqQZ0MbG+9Qfyf7IP+CPFby3/BLT18JYgoBHCuZks1Cw+zk79o+PzpW uSl6vMNooIM3pr8B6TzmOWAUwvxvYIavDbJQouMkMxLaR7GHAXpqTFmi/H1u6KuAFm zTkjponpdS4dehkyARKICzrcYji2/gmUJN+SIFQgkB1I12AaeUXdMzH/18G3MFPeHx 9yDRcptpIKLMg== From: SeongJae Park To: Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 13/13] mm/damon: remove damon_operations->reset_aggregated Date: Tue, 25 Feb 2025 22:36:51 -0800 Message-Id: <20250226063651.513178-14-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250226063651.513178-1-sj@kernel.org> References: <20250226063651.513178-1-sj@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: EBEC2140005 X-Stat-Signature: 6wn9bdzasxh9i4upt5kt85igzwas86hi X-HE-Tag: 1740551829-577915 X-HE-Meta: U2FsdGVkX1+eKXdOvi7gBrfXLzxRMXmCrrD6AypCeXjnFOoBQVLYcIJcaszzyAzziSFHgll/MGmNT/fKoyPwZo3JRnc9ks+4wWEDHBDqIazdk6CQe7vGYUJRK5pm6a978bZPaNUnUhnPrirrWLjOdqCVZRi9jmaaQrV+YKM2Ku8cDGr4Tr4J3ReDyhXX5fo/UqgX2Xgu5hV2U0Is6tfYhgvRlieVj6Om7yc66RgPuGSB36PGwYPMXgHiXofgBK/v+k9mtl7cixBLw5lCKfXoYda2w5d5HsesiK76baZ/W1Pr3ksTdF9RcoyIa0md7GGWNZuhmKpG0lNzFHZsAujbN47Skhb012yc2ljjFUV5dAALYLfg80XgN9tulU/F0rGSZw1Pd6vWUX0UPqUmBAqP/2GH75QZPpX5r3Dlwv5/0ZvaoZyR1ITfR1L6gMkCBCUAEbIKNtUjXsmAnshUG6Fe10amqyXeemh5BJUy0LEewvQRBBDa13vwDIvSrm9NzDoUsBydCMyEO8LpoiMT3TbR1gfSXEm+U1tdmM+vocSrQBkSr/D+eu8QvsNVAPHggQd/UNt1J2ro6qb3Sec70R0LNTujwfAvccgRVkEE2pzZiTqay7ImnqHYGW4kJ+XY/CQd1uq2Zj9CWhSmZ+ab45NABr+nKoTom9EQiOgFXiRnglb18WjSKjseXNYRgtXnt8Sfq4cWl1llIfBkQquym6Th7IzUGz/B3h9geRrTm51VhwTDjnx0vyRKNdqEjr2zYIxOt/cZ8IO8LKpRdmfQ6/ySPmabYgsDgIjhNGToEh3BqIijuPSddVJrG+BAK0+GAxkLrRMURXBOmxjbJhu1DS7wZIQzanoy1xw9TQ81nC2F+Khspc76kCbEySVSH5Gdo2SgOQiQNpV+sVOz1GassTRL7oGzD4q+oHPRzK4yhUBn5CoaLjNX2R81qtlRf/P6BEf34Ndlcb8Vkpc+5bC6O3E m4ozx/tk Q6WrRFgNFa5BUB39Nj5qaUgIByMQH4LCjNbgbdsrD1IoMR5VcOl/tmaxs1YGA39j9wiDksgnQbRBTXv06mmc2de/eU1Wo+wEIt0PZVx2omAbJjA9SG7DCq7oYX1c/B+KqqJ7AR3rC68r0XqRG3UGBfvWEUL9DpqY4lbtHsSeO5PejdcfCYnKc8/f9Q5nv0K+D5hf/DVAB8rRIdBtspWj/jmMcV5KUw8+pre/tgaeqoWsyfDuIWe1pOHs56OqpktxbWXrOwtyl/nk5Yhdn989gxdOwuA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The operations layer hook was introduced to let operations set do any aggregation data reset if needed. But it is not really be used now. Remove it. Signed-off-by: SeongJae Park --- include/linux/damon.h | 7 +------ mm/damon/core.c | 2 -- mm/damon/paddr.c | 1 - mm/damon/vaddr.c | 1 - 4 files changed, 1 insertion(+), 10 deletions(-) diff --git a/include/linux/damon.h b/include/linux/damon.h index 2808ea07e1cc..957c7f3af80f 100644 --- a/include/linux/damon.h +++ b/include/linux/damon.h @@ -537,7 +537,6 @@ enum damon_ops_id { * @update: Update operations-related data structures. * @prepare_access_checks: Prepare next access check of target regions. * @check_accesses: Check the accesses to target regions. - * @reset_aggregated: Reset aggregated accesses monitoring results. * @get_scheme_score: Get the score of a region for a scheme. * @apply_scheme: Apply a DAMON-based operation scheme. * @target_valid: Determine if the target is valid. @@ -549,8 +548,7 @@ enum damon_ops_id { * (&damon_ctx.kdamond) calls @init and @prepare_access_checks before starting * the monitoring, @update after each &damon_attrs.ops_update_interval, and * @check_accesses, @target_valid and @prepare_access_checks after each - * &damon_attrs.sample_interval. Finally, @reset_aggregated is called after - * each &damon_attrs.aggr_interval. + * &damon_attrs.sample_interval. * * Each &struct damon_operations instance having valid @id can be registered * via damon_register_ops() and selected by damon_select_ops() later. @@ -565,8 +563,6 @@ enum damon_ops_id { * last preparation and update the number of observed accesses of each region. * It should also return max number of observed accesses that made as a result * of its update. The value will be used for regions adjustment threshold. - * @reset_aggregated should reset the access monitoring results that aggregated - * by @check_accesses. * @get_scheme_score should return the priority score of a region for a scheme * as an integer in [0, &DAMOS_MAX_SCORE]. * @apply_scheme is called from @kdamond when a region for user provided @@ -584,7 +580,6 @@ struct damon_operations { void (*update)(struct damon_ctx *context); void (*prepare_access_checks)(struct damon_ctx *context); unsigned int (*check_accesses)(struct damon_ctx *context); - void (*reset_aggregated)(struct damon_ctx *context); int (*get_scheme_score)(struct damon_ctx *context, struct damon_target *t, struct damon_region *r, struct damos *scheme); diff --git a/mm/damon/core.c b/mm/damon/core.c index 22f90666fe16..6f821a579257 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -2463,8 +2463,6 @@ static int kdamond_fn(void *data) kdamond_reset_aggregated(ctx); kdamond_split_regions(ctx); - if (ctx->ops.reset_aggregated) - ctx->ops.reset_aggregated(ctx); } if (ctx->passed_sample_intervals >= next_ops_update_sis) { diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c index fee66a3cc82b..e5b532340102 100644 --- a/mm/damon/paddr.c +++ b/mm/damon/paddr.c @@ -618,7 +618,6 @@ static int __init damon_pa_initcall(void) .update = NULL, .prepare_access_checks = damon_pa_prepare_access_checks, .check_accesses = damon_pa_check_accesses, - .reset_aggregated = NULL, .target_valid = NULL, .cleanup = NULL, .apply_scheme = damon_pa_apply_scheme, diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c index a6174f725bd7..e6d99106a7f9 100644 --- a/mm/damon/vaddr.c +++ b/mm/damon/vaddr.c @@ -710,7 +710,6 @@ static int __init damon_va_initcall(void) .update = damon_va_update, .prepare_access_checks = damon_va_prepare_access_checks, .check_accesses = damon_va_check_accesses, - .reset_aggregated = NULL, .target_valid = damon_va_target_valid, .cleanup = NULL, .apply_scheme = damon_va_apply_scheme,