Message ID | 20250226063651.513178-3-sj@kernel.org (mailing list archive) |
---|---|
State | New |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27B61C19776 for <linux-mm@archiver.kernel.org>; Wed, 26 Feb 2025 06:37:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 966FE28000A; Wed, 26 Feb 2025 01:37:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 91547280007; Wed, 26 Feb 2025 01:37:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DD0028000A; Wed, 26 Feb 2025 01:37:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5FE3A280007 for <linux-mm@kvack.org>; Wed, 26 Feb 2025 01:37:00 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C4EF8160C2F for <linux-mm@kvack.org>; Wed, 26 Feb 2025 06:36:59 +0000 (UTC) X-FDA: 83161138158.01.0CCFDE8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id 221B5C000A for <linux-mm@kvack.org>; Wed, 26 Feb 2025 06:36:57 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=QEaBgAC4; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740551818; a=rsa-sha256; cv=none; b=zEk1Gz6jcAKK8stIoTtuzqyulgcW1dAofkpdQwDrPvQLHAFXmPx7ou1/b68TlF/2nTsan1 mO3ZYJ9pujY7YOXoYyb2T/KGxNkMd7ClAv+7qY+a11xV/K62o1CMqECY2S05bC728OnYq+ B0ez7vkxoE9MQky+uMEx1ETuucZPkKc= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=QEaBgAC4; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740551818; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NSeKL/sNvHQoUV6jIy2gqzYh8p2nAZg3FrACSQVo9pY=; b=gs3C9nEIp3X5umRbv/PD3BwGIOF7Rtpof25IUGpP2EhvX3YqL1UTp0QEnN0WSkejn3l0K4 T6kZ7L16gTFI/zRW1ZuBMknSMjagTk/wLNSoAkfYPD1en6z/t/fvcu24qPtLkKPNQtjE0v Q0Bs9eLoUl2Hl/EGFxjbB0ZW7nGJBas= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 82B235C5C1C; Wed, 26 Feb 2025 06:36:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 167AAC4CEEF; Wed, 26 Feb 2025 06:36:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740551817; bh=9LkGnu4V55DcG0gnLZ1nxdIsaaPuWfP3P63Al4SXqQY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QEaBgAC47cbxN/RRjljj/8roAg+KCPL71T4UAk25EG2gYQZU01C8ZZm/pZhxdCMTr dnWU8VqhwLdVhdEQEP3yxWTYhNkXhzjyJrljzSasWAWf6ljh/fl564jMepEjub7hpL 9dYuHOFrQOSMxGUm+FtWJy3FnzLHIwNMdfxmGgOEK/XsK/+SK7KRL/17jiWAhJBafP iiGwutL6uv8Vd8FM+8kaYmFpuDyGAtDtHm3UOwJe98w6gR71px8mwiTAJmsbDEOsgl ntMIFzIJsMEROJQvm0jvpJ0s8G/jqL4Tesq5PXZL6jGcgAvAzr0YpCry7BWySPVx9P bNZaVK+RBMpCw== From: SeongJae Park <sj@kernel.org> To: Cc: SeongJae Park <sj@kernel.org>, Andrew Morton <akpm@linux-foundation.org>, damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 02/13] mm/damon/core: invoke kdamond_call() after merging is done if possible Date: Tue, 25 Feb 2025 22:36:40 -0800 Message-Id: <20250226063651.513178-3-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250226063651.513178-1-sj@kernel.org> References: <20250226063651.513178-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 221B5C000A X-Stat-Signature: dxo9buswx4b7kqx6kfmaoyypfd7f7ktq X-Rspam-User: X-HE-Tag: 1740551817-906559 X-HE-Meta: U2FsdGVkX18s4gIkuU6jT/KuFIYs/rxiW8OniARVcSoFYEW4lgn7Rcy7aiaWfqaOwLCNnA2S6JDRgPwyQj1QCe/tONN8MMGrcZFi0KkN+LM2OcYneIBs1johWA13ebOvh/fB73qxBk9gVAIvPY/4YdEx3mq+ukM6Kfh7dxBhr5hdlc1f/3mfsKJOww7HRgOnvX1NtSjzxxYYG6FUDICzpLyLpJ3IYEA+n7ef9hvkTsWPvJhX4Gz8xrV7m5z78ayjQ6wkx+QBYHuZsC18QiovtKtcsR/6aIyUYidMajPDksHw1iKRZ2m2i5VjdXvibtE4WYw63UFWmIcd5CmBNd1JTbHXh29mN266aALISBECdwI/9C548WBtr07GXBdvtpxho87S9Yqr42a6ZJzPBImG37TtIHRJI0L26sLJUj/IaHs258XMmIB6W/ERKG+lvl1UfKO7SQ8TORLGPrHqTEJCcZbtH18oQI4XG1qWm1Na9299xo3DWJ9W6QeR5zuh1ZMWk0dJgE+GUE4+QmfA2GkN6VEXgUMr7ZPsq8ykZtdarBeac+WUNAlwcecQRna8sDQZcutNQdIXFL+TZkNKHUj0IehPjx47bqhju8btG5cVg+bnK8VBdIqVvKZYt1Mhb+WXf6cTbzzY2UPH/tyt1DzU13yy+dKIoVQDjuZXQKFQcUaIv2LLW02VSb6NrXavfRjADg8A4uF37rFPoqeg1ktgJUip5F2Q4byXcNnpHs04Ir+avkrTqlkoWeFR+wNxtrBuZ/dBaznH4LFidlVt9L16PVKmiATM2VeQ89FC8qCMojq3nrVHO+iDR32D3HxSmXQ2VkzxDc37XSCrC5GJSFwxO1uMqkqPwcXT8V94/mJC7E2+yTvoW3cEUsz24J8znqxiTTWuUzA1dcgbnbVUfS+EiqPGYEN39B0VICpGlZQTHAuajZdUZluhsrGhkgbIUbFcXWQonx9hR2cuUKsMkqo /JtJIjVl UGOzgg3z5sfZI27dTYqxM33KB1lsd7LQTCVo/Hf6AnADNagvv34e4w6xN8b6u6kFh6hFyivI+DCJktkyLzQ1J/wIRuHXM9YdPmcTP1vYcD6AizGtXjFhZ3MLiwccAu8IMd52a3QXtYxh2KwaDDd8T+zHFIAKAYYvmbBcM/jQ4RRUhR9Z3N2q9aycvzEOseqxSaYgrJjzpUE83foU/TiEp3SmF2PbjqMXA8SWqyHph2EWMITt+YuFn35F8npDKALbxTlRYjyPuH6z5o6AjFJBBputlDA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> List-Subscribe: <mailto:majordomo@kvack.org> List-Unsubscribe: <mailto:majordomo@kvack.org> |
Series |
mm/damon/sysfs: commit parameters online via damon_call()
|
expand
|
diff --git a/mm/damon/core.c b/mm/damon/core.c index 310cdc87d5f4..0578e89dff13 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -2412,7 +2412,6 @@ static int kdamond_fn(void *data) if (ctx->callback.after_sampling && ctx->callback.after_sampling(ctx)) break; - kdamond_call(ctx, false); kdamond_usleep(sample_interval); ctx->passed_sample_intervals++; @@ -2430,9 +2429,10 @@ static int kdamond_fn(void *data) } /* - * do kdamond_apply_schemes() after kdamond_merge_regions() if - * possible, to reduce overhead + * do kdamond_call() and kdamond_apply_schemes() after + * kdamond_merge_regions() if possible, to reduce overhead */ + kdamond_call(ctx, false); if (!list_empty(&ctx->schemes)) kdamond_apply_schemes(ctx); else
kdamond_call() callers may iterate the regions, so better to call it when the number of regions is as small as possible. It is when kdamond_merge_regions() is finished. Invoke it on the point. This change is also for making future change for carrying online parameters commit with damon_call() easier. The commit work should be able to make sequence between other aggregation interval based operations including regioins merging and aggregation reset. Placing damon_call() invocation after the regions merging makes the sequence handling simpler. Signed-off-by: SeongJae Park <sj@kernel.org> --- mm/damon/core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)