From patchwork Wed Feb 26 06:36:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13991594 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E543C021B8 for ; Wed, 26 Feb 2025 06:37:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7438528000D; Wed, 26 Feb 2025 01:37:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A5EC280007; Wed, 26 Feb 2025 01:37:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51DF428000D; Wed, 26 Feb 2025 01:37:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3429A280007 for ; Wed, 26 Feb 2025 01:37:03 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E28F2C0C8D for ; Wed, 26 Feb 2025 06:37:02 +0000 (UTC) X-FDA: 83161138284.15.D262F70 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id 3FD38140004 for ; Wed, 26 Feb 2025 06:37:01 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=P+NvSuYV; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740551821; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ux9zlbR9tf1mnCG2BsHn1eoPkABz3PjjjDgQegwW7GI=; b=dVQPi4aZ8Jiw3zpEcy9QWFvPHsqeZsNFv4d73irz99dH1IEE4nvmcldZnMChCq3TQMKzBs 1tWVB6WhW2EicWYUdtGMZ/EBgjrMdhA0BqtSV27Cw4z3XPmgWA/5hXCXEwI7hy75KXgzr4 e/No2Ve6H7/hvFJatwKCFcZ2Wq6/biY= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=P+NvSuYV; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740551821; a=rsa-sha256; cv=none; b=Z6vutFWT6Jf0CPb8W/cQOXx2G4tU/V2h2PpTQM7szMODlz8kXzz1wIFkbtubGZW52VrniC F/ypEtuUK0q5KLPMQQmziwQUQOen5aeL0mg+olqib08sP7UFSS7j0w/x8tTOOqOOdiSI01 SsUerPY5Lyh+n6E/UR5m3hipp0D7TN8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E3A905C5C40; Wed, 26 Feb 2025 06:36:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72AE7C4CEE9; Wed, 26 Feb 2025 06:37:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740551820; bh=ZDADvW0oQPUgZeNcgv9P9GJF3heQ3/Xecw6OVh3xMI4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=P+NvSuYVCbP0zamxR9Q/T6/f9oqao4fhYmC9FmNd8WnmGQmavl/+yCP8sFp2JJ0x0 wsdh8ZTOVYIAhsfdq8IUCe8m4JKlWrpDNkAawiTNWgTv/DeA3X9QD6QzsQAbZXxNVe VlutXHzq9Cai0AjDj1uiQI0L+7cCB+wBaQLFWxoFlfGHWJlS1nneI197sqWE/pFpUa 1tM/iMs5d5Dc1ose5/SFQDJGVVoyMralJztkIL26RLL48jyNrfZbew7bCdkgHBaqrl OagseUL313dWU+fHsgFcJ5Lztx1xk34sj/HVXOfwOWcZcbUGzvAv+qz+3NB+F5wnmV i827EwrB5itOA== From: SeongJae Park To: Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 05/13] mm/damon/sysfs: remove damon_sysfs_cmd_request code from damon_sysfs_handle_cmd() Date: Tue, 25 Feb 2025 22:36:43 -0800 Message-Id: <20250226063651.513178-6-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250226063651.513178-1-sj@kernel.org> References: <20250226063651.513178-1-sj@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 3FD38140004 X-Stat-Signature: 94a6zibwa3g9gzatek4k83jd5hs84awe X-HE-Tag: 1740551821-19288 X-HE-Meta: U2FsdGVkX1+666kbormCZ3H7fe8WYjHDXQqc7d9JyRvfs02WDc1SwgbGjdXkza1sQLrtOBwaLoxruVg54dNDSGXGnamjdUMbmRDxWBgEiRZA7TM5PEOJQkLVMMhp3TOrrm9P48JeMk/sO86bCfH3BHAnd0in4s4HwpuCb37zbgi1Dz7xvECx9iA5lppApH0QLZo1izyMilELAFcVf6hvKmLfcdhTtC+loBAtovJUPQPvNM156WHZIlhuHlCcJZ8HdSTUmAi750zVIxrgpoqbmvrVxzqm3sBidukUUH5F71Ehx9P9X9AhCm+b1oMS5ZGxobC6TsNP4/fuqZpEMfMIlyUAbPrsQlUsHmP/FyZWv5U7APtAi2kvjApdXs3HSEZ7mRW7fEuWM0wWCOSYZBNrhuePEW9RJ2Jw+0R2LuIxJYtV50l7Ivymf/0W779IIeZ0rhXN3oQxDLBXOzFhkddAIHDUg8pM03cKIddiEH4s6qR6RcllFwH6uw0QpoX07agHJx3e4qIonQt8ubjD4Vs+OvVEMLYQuz4+iSt7XrRD9lrb05bGUmDp4izYImTYNnD9juthB1L6rpLCC9dhbSTBwb5r9PwxeqHUGUAE2nYkDfcS7tJ5P5CKY679oNNw68Ng1cosS/fAIQYTSBMUUq2zW4O6vRYOhsVZJ3C9Y8UKwRiM13ib7b2BL4OngqSJJhRt/9s1Nrlgl9ks6Bve4Xyg/eOFj41RYMpVJs5+0mjIHgw12tR17rewfjxCOu+1Dsz+9p968WHFs7IHO/zvlXOZP51OoGVZ35InMRNukuTp+QIT+rXncEigF9GFxqjkxCk9zv35sp5y0/XYzqJ9CVptO2E27t6Roa1nx/ydgmzLUxId+L2Td/My3t4/9KL+oUiBiPt96sYHMt4m9NbGEGhMpjWVeM+al0lb+2SpkiIh+Fx8QOZCkU48zdgLXpFOtz+oDhLeLcGBzH07xxFqHGv ijWNn+f2 QvjPny2OOxwlIfWPZGqsDRLcUs+TbQPLLc2YSy8W0AXdTBko8BieDGMkwBbW9OLb9suPOCdEuEYrEIJ1LZSVVojZiKK4JhERH3esqhObybwHfELNc1cgcBm/GATzIHOq4o5oM1nzodgZMpKpmPDYNtKQcVMhuti1t8Pl/tV4cyA7kcbCGblfb6zy4vgQU0E8GOvXF/H3o5FsTVhO2c4V4NWTH1FvmceFb1pfwd8aB0BCjAQJZ5H2ZYgHxgxL9u2/8ZuGsIWwwXtB1zHDKWMBxYxKlsg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: damon_sysfs_handle_cmd() handles user requests that it can directly handle on its own. For requests that need to be handled from damon_callback hooks, it uses DAMON sysfs interface's own synchronous damon_callback hooks management mechanism, namely damon_sysfs_cmd_request. Now all user requests are handled without damon_callback hooks, so damon_sysfs_cmd_request use code in damon_sysfs_andle_cmd() does nothing in real. Remove the unnecessary code. Signed-off-by: SeongJae Park --- mm/damon/sysfs.c | 32 -------------------------------- 1 file changed, 32 deletions(-) diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c index c55a2cee4b74..166161f12c26 100644 --- a/mm/damon/sysfs.c +++ b/mm/damon/sysfs.c @@ -1715,8 +1715,6 @@ static int damon_sysfs_update_schemes_tried_regions( static int damon_sysfs_handle_cmd(enum damon_sysfs_cmd cmd, struct damon_sysfs_kdamond *kdamond) { - bool need_wait = true; - switch (cmd) { case DAMON_SYSFS_CMD_ON: return damon_sysfs_turn_damon_on(kdamond); @@ -1747,38 +1745,8 @@ static int damon_sysfs_handle_cmd(enum damon_sysfs_cmd cmd, return damon_sysfs_damon_call( damon_sysfs_upd_tuned_intervals, kdamond); default: - break; - } - - /* Pass the command to DAMON callback for safe DAMON context access */ - if (damon_sysfs_cmd_request.kdamond) - return -EBUSY; - if (!damon_sysfs_kdamond_running(kdamond)) return -EINVAL; - damon_sysfs_cmd_request.cmd = cmd; - damon_sysfs_cmd_request.kdamond = kdamond; - - /* - * wait until damon_sysfs_cmd_request_callback() handles the request - * from kdamond context - */ - mutex_unlock(&damon_sysfs_lock); - while (need_wait) { - schedule_timeout_idle(msecs_to_jiffies(100)); - if (!mutex_trylock(&damon_sysfs_lock)) - continue; - if (!damon_sysfs_cmd_request.kdamond) { - /* damon_sysfs_cmd_request_callback() handled */ - need_wait = false; - } else if (!damon_sysfs_kdamond_running(kdamond)) { - /* kdamond has already finished */ - need_wait = false; - damon_sysfs_cmd_request.kdamond = NULL; - } - mutex_unlock(&damon_sysfs_lock); } - mutex_lock(&damon_sysfs_lock); - return 0; } static ssize_t state_store(struct kobject *kobj, struct kobj_attribute *attr,