From patchwork Wed Feb 26 06:36:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13991595 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62F15C19776 for ; Wed, 26 Feb 2025 06:37:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6334E28000E; Wed, 26 Feb 2025 01:37:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5947A280007; Wed, 26 Feb 2025 01:37:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3BF0828000E; Wed, 26 Feb 2025 01:37:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1DA18280007 for ; Wed, 26 Feb 2025 01:37:04 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C9706A2B3C for ; Wed, 26 Feb 2025 06:37:03 +0000 (UTC) X-FDA: 83161138326.01.99BDE2B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id 3506F180005 for ; Wed, 26 Feb 2025 06:37:02 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="ou4Jlw/h"; spf=pass (imf24.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740551822; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C1AJWfRumzmQ358us44uziJ6YdgiSOHEvhD97GuZ1Fc=; b=1iBVPU8aJ3nsNiIsbp+YWfaVN6dXOzdxFQaQ8iMFuKVeMPKadmTK4+IQw8KHyjjLdlXQGT VVw6fzOkqjnofxm6OMD9sFqnEffmmFk5suAbEs76V/1wTg2Z1y5ew8ofg/M8gSUWerCYQC go7NpXexBA805fkrOJlLs0CuF0BT0GI= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="ou4Jlw/h"; spf=pass (imf24.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740551822; a=rsa-sha256; cv=none; b=FYq2RO5x+JOSd4Mj0MZLhUSIig6OS0V7Pa+wpF0jQoEUE2fnVOS1/pLC91AmV3V3gsQ1/Q b5cNAR5U7Jqjd2Bl34RTeSWxcgk3TnF5+vMW0bgROhoILVMgcOZ36x/+uZGpoCqmU+m5Tf hNU3GuOqQx2IyIIcFY4Ze8Vksx6F4YY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 10D6D5C5B3F; Wed, 26 Feb 2025 06:36:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9491DC4CEEC; Wed, 26 Feb 2025 06:37:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740551821; bh=T05PHV/b/RY6SE79bGJVruG1lJQyvBwcsDSu/WYUE0U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ou4Jlw/h7uxzaJKHZrhqjlV2IAvmkNPu9L3ZopdDLUbEKqsSKUFC4oNZcwIN974nz NOwvefrT1a5l7zV4szTYyn7Zz8Fg9RoYksLLzP+Gjjrf5oCH5MP88bgQhyPyubwqwJ Itxtyz0qHmVmtj5hHo+bcvquT6H0jg1mOO//L6+Qz12uSC5u1ktkLRoENnpxDtLLoq WYAOzzgdsSCZkd3SLqTaNCvfSMQ2RyRWGxD+tqkDFlsFYCZ3LQptMkp34co2a/3q8F FIMek3ClqcJbhIexLUjLeW5TtbhKsNCcZuLbbItCEh6RELG9wYPT2UZ0svKOt5wDYa 2DNmGdrkiut6Q== From: SeongJae Park To: Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 06/13] mm/damon/sysfs: remove damon_sysfs_cmd_request_callback() and its callers Date: Tue, 25 Feb 2025 22:36:44 -0800 Message-Id: <20250226063651.513178-7-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250226063651.513178-1-sj@kernel.org> References: <20250226063651.513178-1-sj@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: 3506F180005 X-Stat-Signature: k18qt3rgnizq7z98b3ahu74engur7cgn X-Rspamd-Server: rspam03 X-HE-Tag: 1740551822-624865 X-HE-Meta: U2FsdGVkX1+nV9mWZbvjuy0RM9ZyNKkuFs76DcGK/5v3746P2fDxfxiIHWtHOAu2Y9EDgFH5YI7sUC5c08FwOrximAdFjap+pxb/0IDoDSk3+PM/Nut7CBkTPgZD4z0B05R/PcN+fu0VShuEk0ABRU9/SOO/7Nlb69NUt5cJF0bWyJRCkJKp7A1D97jRgmPW4g/pa9vpzp6WNmTKeCCMDniQHBI6Rwbrt61871/VNrnwHe2k4yGvyMM1dHbn0iHiB+MtdoMGFpGQZWtNhmvHMcxMnKEoyEn1D7R6//5kCzjjpvIQPAmHKNUs/EAdbRROPDGdwYEB9UlDvbKoUZFzAxRfAuhxN819YdTVuN5zV2q4xPCJXNzc2udOyhPNUTkjnAwYje4FT8/IzygRU2dWOQxnGNBjhwwojiHdZ3twpa8XsONAujFyFWfCacMy2mOmOttMFOh8sfkmJw1ps6/6jvxLgsvFsfTJF1xmuLTy/k3CKnoK81YA/GLEPrWGKPSBUcjdqkMBBj2if2/f3Ill1hmk8BG1OwpAw3okd7hMv6fWy9UU6BePjnzYFBYq930TyRc4D0kZ02xgvyOiiqyC1ahbhbqSHWItI5o2O3u/y5ldU8so8eNcf5z6Gz1YcHunMbrwl63IUMqSoGZX7ZuTkkXhyxHVtvsoG+xFbRfvkQT2uLUV5snoCxH27S2pV94NCNfjortI+h3psNub0ZEPplVPHCKwxcxyzy6lppbdHX77Y3k3vfCjc+eP56iCN37u4SLvbhxR4je218diG0dt9/HqteZKBi9NBfUOVfNKO1PDlsJ51FVf7zCGaDFAlouYqTtmas81fkR+ITmk5Dvl+VrJbhjJ3FFm3ImElRf+LTY4KqnccRa8QDOJYZZhlFc9Dfo1YFy3ifdFKY1pBVAPCkAYvGqIHaApkKlV9Qnie+A8pf3+dMW+psXQxUPGtn9+THlu13uWc/b56JQu3BC IM8JhzXP q2d/KhgAMcVUf/RWXQ9+5LPh9bl+3Lmzz/Z4aV07uD/nUpRBRFtdKC1bFpNMAJ67eI9niiY26z0+wwXs+zD8ONg46frKCDvLVamH7LrOff8lTgameNU0KfhZVkC5fp3U26A0Tl4PSbzpwVyrv7CmDrc+TQt1Ql9u4NeQu+84YyW+WWFCHCxnStgfnXKNOxZ/undFdXo7Lug1AGPsjP6MAbQk/OYufARu2k6jksgqmqmcDRMKuQbjO9vzPBnTht4F4AwWVR4ozlnI/HgJbTQly7G+Mmw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: damon_sysfs_cmd_request_callback() is the damon_callback hook functions that were used to handle user requests that need to read and/or write DAMON internal data. All the usages are now updated to use damon_call() or damos_walk(), though. Remove it and its callers. Signed-off-by: SeongJae Park --- mm/damon/sysfs.c | 62 ------------------------------------------------ 1 file changed, 62 deletions(-) diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c index 166161f12c26..e5bcf019086f 100644 --- a/mm/damon/sysfs.c +++ b/mm/damon/sysfs.c @@ -1529,65 +1529,6 @@ static int damon_sysfs_upd_tuned_intervals(void *data) return 0; } -/* - * damon_sysfs_cmd_request_callback() - DAMON callback for handling requests. - * @c: The DAMON context of the callback. - * @active: Whether @c is not deactivated due to watermarks. - * @after_aggr: Whether this is called from after_aggregation() callback. - * - * This function is periodically called back from the kdamond thread for @c. - * Then, it checks if there is a waiting DAMON sysfs request and handles it. - */ -static int damon_sysfs_cmd_request_callback(struct damon_ctx *c, bool active, - bool after_aggregation) -{ - struct damon_sysfs_kdamond *kdamond; - int err = 0; - - /* avoid deadlock due to concurrent state_store('off') */ - if (!mutex_trylock(&damon_sysfs_lock)) - return 0; - kdamond = damon_sysfs_cmd_request.kdamond; - if (!kdamond || kdamond->damon_ctx != c) - goto out; - switch (damon_sysfs_cmd_request.cmd) { - default: - break; - } - /* Mark the request as invalid now. */ - damon_sysfs_cmd_request.kdamond = NULL; -out: - mutex_unlock(&damon_sysfs_lock); - return err; -} - -static int damon_sysfs_after_wmarks_check(struct damon_ctx *c) -{ - /* - * after_wmarks_check() is called back while the context is deactivated - * by watermarks. - */ - return damon_sysfs_cmd_request_callback(c, false, false); -} - -static int damon_sysfs_after_sampling(struct damon_ctx *c) -{ - /* - * after_sampling() is called back only while the context is not - * deactivated by watermarks. - */ - return damon_sysfs_cmd_request_callback(c, true, false); -} - -static int damon_sysfs_after_aggregation(struct damon_ctx *c) -{ - /* - * after_aggregation() is called back only while the context is not - * deactivated by watermarks. - */ - return damon_sysfs_cmd_request_callback(c, true, true); -} - static struct damon_ctx *damon_sysfs_build_ctx( struct damon_sysfs_context *sys_ctx) { @@ -1603,9 +1544,6 @@ static struct damon_ctx *damon_sysfs_build_ctx( return ERR_PTR(err); } - ctx->callback.after_wmarks_check = damon_sysfs_after_wmarks_check; - ctx->callback.after_sampling = damon_sysfs_after_sampling; - ctx->callback.after_aggregation = damon_sysfs_after_aggregation; ctx->callback.before_terminate = damon_sysfs_before_terminate; return ctx; }