From patchwork Wed Feb 26 06:36:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13991596 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1B40C021B8 for ; Wed, 26 Feb 2025 06:37:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F13228000F; Wed, 26 Feb 2025 01:37:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A21F280007; Wed, 26 Feb 2025 01:37:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 71BCB28000F; Wed, 26 Feb 2025 01:37:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 549C7280007 for ; Wed, 26 Feb 2025 01:37:05 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D4B83140CAA for ; Wed, 26 Feb 2025 06:37:04 +0000 (UTC) X-FDA: 83161138368.19.55BCB4E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id 4362D140004 for ; Wed, 26 Feb 2025 06:37:03 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IY35+2jS; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740551823; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A2gyByZa1MK9nzQQN5kuYw7RObahIZPJ2xXKc0/b6MI=; b=FYVNbYeeJpuS59rkzy51zQjkERHLvz6nO+rp9fFEE7vmQ0Xo02zTXv9jOsf+6zTuKU7yU+ dR7iSSdl48QrSk7VvSgF52W7jFci42XtE9pIJrEpxDcl/WdmfdaDQSmfZlDS8f9PPwqMGQ ENeApWHEvuNCcCEEVxZYifieJ04ezbY= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IY35+2jS; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740551823; a=rsa-sha256; cv=none; b=0G1UeqUQpNIQvRInKGHUHkMPPCnYI2vet9xK4BCYkuoB32oe//qqIX7+dBdrQuJYWJ4uZ8 qTxiIyvyi/Oa92aq8bxoWWFCvroGu9YvS/DLcoH5UOMWw0zJFLMuE6U0JHJ2hxKEI2JdgS iGkAfDkHIsEFW7QiXsQAYTq9TFD02ZU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 248965C5E2E; Wed, 26 Feb 2025 06:36:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A40BBC4CEEA; Wed, 26 Feb 2025 06:37:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740551822; bh=4J5vWHiHbtHqjwMC+hRbiipl4h9liEs0+TfNTGi8OuM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IY35+2jSTR0fwPWqE0pDaF10P37LWFVbjA8i0aglA/xKkrkdRBuW0AFLyuSa9KeHM pL7QeBCioMTspDME/Oi5tgLtMj3Ww5A1LPrqqmL+8dn/I3P/H+2ATvr7HkujdVpKi+ kHsu0DgCV4rIYvS/nH7GWwA5/FyIk/sNfWnIPacPHqL0MUoFtHZ4yCGO0syynawauK o6NDT1eHtNQSJhVYcRQ8EP8uA+lKkSVaQWO6RUtD4CnGHJnBTN6fPLTNtOzqrfcU3k V9DFeIAiANVX3zwg0kvelgpgrf764O4s+SgKVbqY4L3lCILw+abR5640X7UDPvdUnp MicgMxBby5e1g== From: SeongJae Park To: Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 07/13] mm/damon/sysfs: remove damon_sysfs_cmd_request and its readers Date: Tue, 25 Feb 2025 22:36:45 -0800 Message-Id: <20250226063651.513178-8-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250226063651.513178-1-sj@kernel.org> References: <20250226063651.513178-1-sj@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 4362D140004 X-Stat-Signature: 6zyxhoyk43ry9xejwe35a3y9wi7gye4m X-HE-Tag: 1740551823-815661 X-HE-Meta: U2FsdGVkX1/IsasXUO1ggisUH6Bpy9R2W+G4SlQ6kxOO6BLCI0NSz3hnZvsRemmmJIHHIlD9Nqvwt9bvjOTBgAyoo5NjUuM0fP42p/ZzEOc/die1WmHQkmV+5pBCgE8VSGqbO9eZSJSmYuewd/+tnJZrmefvXCdcmIzC61b16JYupe9RGFXXU+0uRxjLzHHy5D2Nz0MKHJ8TYk/p087sL7rNK1B452irxWmM2HGUTMO8DDYYJorVCV9AVmP6KxkrJw2vVdM2SaN5LxKYQOtCNbuxyQxirc3ZNlsiiDM57/mCGk8mgRDt0uUx1A/JKntg+HPvFtOzifHAgpv+sVx7g1vHC+6grYY7DnL6S1aVav6qDLoEVeUdouIgz2KdNZUNdMhf7cp+75z93o9TcBxciHRMnXkxlD2G5LdYT8c05qCYlxOXPllHjvdBkbWseqGJ+MXWSintKE+2On2VbABbxHmfMBi7wylIhRBXIcmPN5vhfqKHosWXbjVIDT2pHk2CWM1pZFqfjkN0fKyxvb2BGb9zzLwss06294RxYVnzCLzNREFoq0rFSaX5EovSsImw7cjXXCzIcBaTNt9nnATjTXYXRrfaSpSy/fZ6bh95UbMjqVFdF2i9oTgP8rylcwsIxNtrqEb9w7vFtYo/eflppuDUpdkQH/SKWDpKDGJi/v7QSD0pfIMU2AAlldXRXbkYaSw0RFpdgcFqzj9MXTA9nYExw/Hx9qHj5QLGoG1mOy1sF4QJAHmR3QT5LcFf9Xc3lse6sNtgCtfz28uQAWnMijkirmBLViSQrsor4EumD6D256Bh45PHvMAobtO4wjd3hQX+iabI/u0wUnLX55j18hI9b/vkRlqCTpnbhPdLKB/mbmdQELGpEmo1Nh1VQKjhKkyqO2SHm+wWRpXjCiN/O0iF/e8X+sa6fopJpB6MEgHBWpRIXjt8MnvikIs8Hl9VrMaKqJLp5F5ZefPpcBr l2o7xZdd d+VWMxYWH032+MeVeVTNJf26U60IoOPh1+CFbGuURWAoXri56pX5XveJDzH/9Y83aDqurY9tXq/UbDeTpd/ADuW+okrLobGFMrXBuIeiNFMUeosZ9kwpqYE8Kz9BbQdF30Oa5BUre25M02udyvEvbfhAAgXFj/Eyh13U7CHk7+N6BrlOgHaRj8ypDDyl/uv8ecBTSrdjvmCXCA7suKPSYlt/haqB7rR8tHH56MdgEMMuA7y4s3aztFmyxE72cF3asVO49BKfrQAvtstb2/nukUzZwzg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: damon_sysfs_cmd_request is DAMON sysfs interface's own synchronization mechanism for accessing DAMON internal data via damon_callback hooks. All the users are now migrated to damon_call() and damos_walk(), so nobody really uses it. No one writes to the data structure but reading code is remained. Remove the reading code and the entire data structure. Signed-off-by: SeongJae Park --- mm/damon/sysfs.c | 24 +----------------------- 1 file changed, 1 insertion(+), 23 deletions(-) diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c index e5bcf019086f..1af6aff35d84 100644 --- a/mm/damon/sysfs.c +++ b/mm/damon/sysfs.c @@ -1238,25 +1238,6 @@ static const char * const damon_sysfs_cmd_strs[] = { "update_tuned_intervals", }; -/* - * struct damon_sysfs_cmd_request - A request to the DAMON callback. - * @cmd: The command that needs to be handled by the callback. - * @kdamond: The kobject wrapper that associated to the kdamond thread. - * - * This structure represents a sysfs command request that need to access some - * DAMON context-internal data. Because DAMON context-internal data can be - * safely accessed from DAMON callbacks without additional synchronization, the - * request will be handled by the DAMON callback. None-``NULL`` @kdamond means - * the request is valid. - */ -struct damon_sysfs_cmd_request { - enum damon_sysfs_cmd cmd; - struct damon_sysfs_kdamond *kdamond; -}; - -/* Current DAMON callback request. Protected by damon_sysfs_lock. */ -static struct damon_sysfs_cmd_request damon_sysfs_cmd_request; - static ssize_t state_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf) { @@ -1555,8 +1536,6 @@ static int damon_sysfs_turn_damon_on(struct damon_sysfs_kdamond *kdamond) if (damon_sysfs_kdamond_running(kdamond)) return -EBUSY; - if (damon_sysfs_cmd_request.kdamond == kdamond) - return -EBUSY; /* TODO: support multiple contexts per kdamond */ if (kdamond->contexts->nr != 1) return -EINVAL; @@ -1796,8 +1775,7 @@ static bool damon_sysfs_kdamonds_busy(struct damon_sysfs_kdamond **kdamonds, int i; for (i = 0; i < nr_kdamonds; i++) { - if (damon_sysfs_kdamond_running(kdamonds[i]) || - damon_sysfs_cmd_request.kdamond == kdamonds[i]) + if (damon_sysfs_kdamond_running(kdamonds[i])) return true; }