From patchwork Wed Feb 26 12:01:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Byungchul Park X-Patchwork-Id: 13992179 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60CEBC18E7C for ; Wed, 26 Feb 2025 12:02:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B1CE6280020; Wed, 26 Feb 2025 07:01:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AA660280023; Wed, 26 Feb 2025 07:01:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D492280020; Wed, 26 Feb 2025 07:01:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3F24C280020 for ; Wed, 26 Feb 2025 07:01:51 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9F5371A136E for ; Wed, 26 Feb 2025 12:01:50 +0000 (UTC) X-FDA: 83161956780.13.F3FAA31 Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf23.hostedemail.com (Postfix) with ESMTP id 0CE4F140028 for ; Wed, 26 Feb 2025 12:01:44 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf23.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740571305; a=rsa-sha256; cv=none; b=qIs/Q3f8vvYvj+g6rpLJDcwhM5u87FsXS3wkjExeggbJJVE+jcT1zL5E6sUS1y7kRoLZ6v 5n5siZ5lk8UFQ+xT/jyzcCu33U1KEb/KYMiStVFzbAwwg2FukXp26IRdmNjuM43hah0v0o XJUS4qUuoRQ+oeMYLZQU6IO4Rm7Gats= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf23.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740571305; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=clFjBUSA7nPR6hZWh3dLYCFnVg2VyTrdMDGjh6+piaw=; b=V+44jDC9/z2EjPy4Q85OMiEzNhguJAYPpYyzv5chvyGvHJ40MrNuqPUWu6CZEsP1OrKJ+6 PtwAOLs/+KHMPj9slA6WsazlVJOsqYvMkDN0kakJJ3iVnU+m9A87cmVVN4zoaHXhAvnQ8U oW4uL8SSv/oxno5zlk7SX1gfP44GGeA= X-AuditID: a67dfc5b-3e1ff7000001d7ae-db-67bf02a6e88f From: Byungchul Park To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: kernel_team@skhynix.com, akpm@linux-foundation.org, vernhao@tencent.com, mgorman@techsingularity.net, hughd@google.com, willy@infradead.org, david@redhat.com, peterz@infradead.org, luto@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, rjgolo@gmail.com Subject: [RFC PATCH v12 based on mm-unstable as of Feb 21, 2025 05/25] mm/buddy: make room for a new variable, luf_key, in struct page Date: Wed, 26 Feb 2025 21:01:12 +0900 Message-Id: <20250226120132.28469-5-byungchul@sk.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250226120132.28469-1-byungchul@sk.com> References: <20250226113342.GB1935@system.software.com> <20250226120132.28469-1-byungchul@sk.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrKLMWRmVeSWpSXmKPExsXC9ZZnke4ypv3pBtOeyFnMWb+GzeLzhn9s Fl/X/2K2ePqpj8Xi8q45bBb31vxntTi/ay2rxY6l+5gsLh1YwGRxvPcAk8X8e5/ZLDZvmsps cXzKVEaL3z/msDnweXxv7WPx2DnrLrvHgk2lHptXaHlsWtXJ5rHp0yR2j3fnzrF7nJjxm8Xj /b6rbB5bf9l5NE69xubxeZNcAE8Ul01Kak5mWWqRvl0CV8bGR3sZC9bIVPTtb2JtYJwr1sXI ySEhYCIx/2EbG4zdv+wqC4jNJqAucePGT2YQW0TATOJg6x/2LkYuDmaBZUwSe080sIE4wgLt jBJd77+BVbEIqEp8nfYerJtXwFTieMdzdoip8hKrNxwAq+EEmvRv92+wuJBAskTL+t8sIIMk BG6zSUx70QF1hqTEwRU3WCYw8i5gZFjFKJSZV5abmJljopdRmZdZoZecn7uJERjYy2r/RO9g /HQh+BCjAAejEg/vgzN704VYE8uKK3MPMUpwMCuJ8HJm7kkX4k1JrKxKLcqPLyrNSS0+xCjN waIkzmv0rTxFSCA9sSQ1OzW1ILUIJsvEwSnVwChcYvCwoK9EMqOuKnlNbWPGnwdzpaQrHvd+ c32xa8t3s2i/xb8M8u5WPEtVm//44fb4ueXF0Q1Ga8x6y+ZqL1E5H+yWf9a39XecvtLqVe+X qG5/fIo3obKU0+OvDadgxUuNTds2ePszuh+8elYg59q3d2zSjpOrLE/WiUU2uqt9mMK6+Zn+ WyWW4oxEQy3mouJEAFLeKnxoAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDLMWRmVeSWpSXmKPExsXC5WfdrLuMaX+6QVufqMWc9WvYLD5v+Mdm 8XX9L2aLp5/6WCwOzz3JanF51xw2i3tr/rNanN+1ltVix9J9TBaXDixgsjjee4DJYv69z2wW mzdNZbY4PmUqo8XvH3PYHPg9vrf2sXjsnHWX3WPBplKPzSu0PDat6mTz2PRpErvHu3Pn2D1O zPjN4vF+31U2j8UvPjB5bP1l59E49Rqbx+dNcgG8UVw2Kak5mWWpRfp2CVwZGx/tZSxYI1PR t7+JtYFxrlgXIyeHhICJRP+yqywgNpuAusSNGz+ZQWwRATOJg61/2LsYuTiYBZYxSew90cAG 4ggLtDNKdL3/BlbFIqAq8XXae7BuXgFTieMdz9khpspLrN5wAKyGE2jSv92/weJCAskSLet/ s0xg5FrAyLCKUSQzryw3MTPHVK84O6MyL7NCLzk/dxMjMEyX1f6ZuIPxy2X3Q4wCHIxKPLwP zuxNF2JNLCuuzD3EKMHBrCTCy5m5J12INyWxsiq1KD++qDQntfgQozQHi5I4r1d4aoKQQHpi SWp2ampBahFMlomDU6qBUS+ZieNlcOKk5LookfCjW3bvy/HjcI2dsDhB0Yen0ajvut+NbSVz vx7R/roh4/PzF7qqC/WTNt2tPD79UJ11xeLaIl2hKKVby7KT1jT+S1H8mirVcdwwI2vOP6En P07a1D3z9Hs5f9YatTfy8Ytqk4/1szQJpZT9OFAenH9KPPD3nR0imtnLlViKMxINtZiLihMB 1g+7Ok8CAAA= X-CFilter-Loop: Reflected X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 0CE4F140028 X-Stat-Signature: fucnbkc8ci1m5epa11mryud58js74mrk X-Rspam-User: X-HE-Tag: 1740571304-784399 X-HE-Meta: U2FsdGVkX18rrRNa/q7YyRkDitU+UM1y28ypfqKedpzt+woWTONbYC8dArCUgKSCPiajceBsjZS8ZNHAFEUwT29I9NC7w1WRbt6j3k1vmvN4W4tqzqLagFZbKlP5v5itAj+EAreyjlnMDymdAqNsO2ePH7Rw4yx4kNBAVVfHlJKjiivoZ+1IR1Fv2wQEyZ0Lb7/TGpWft3X2Dl0Uv3iiacM7ZnwNUoXxtBUe1/J89j96IU+14JEq1N2O4Uv6yfST7khDu1dMPuXTTTZ/pNoPg0S1IK3qXWQm138jvUbPfTdhYj9tbdPQwYnL/46ULcHyUHoxQBgXKaLOle41CA/W9t6QM7elqknp1usjG1is5G3g+eZdBFc+A4cjxS5y8/mBDWlWEvcjkoGyJSdM3I9fOm4TG+0VAUyguMuaeew88M/h18dyN+Tle1zh4jHmNOu+J+RQw42t+Nhv8oCjtRIfEbzxtwcp4U87Ee6XRSuTmCJBJaxGVgi1sZetOTybw2HCiW08U5XT0LhhlHWeXTB4Zrtyo31wqhyaCAGkCZqbXx0eTz1n5/bVyfSLLr5YCQ+cmrenO+2b5ZJgaNKRfF4fr7AL5NguJxZZy9gW+I+nn79MbeXadBhQKdFB130X242pSaB3g7A7YWHhmJFYg4WzqvzoMB5CxtSzh7qPKLAwG/fxgFM6SYi/JgkMDxdeleeLSq4+Vf09Kxn4UQQfS2Eu13aZrmoMuo8CdbfO7FduKzS65Wml9dwuUhnSC261KWkm8JCUdu2y/g9rBlZySHVJPMa/dVPTUYIADnuVXxvOmmfm5x9jswnoG71TP20F59QkUKDG9yEhxTXLBn7Q7Jm7crOl0uoKuPvP+yGuqIa2O1vCl7Pgi/QOOEIHm2q5NznqzVVRMRaRVbRYFaUDMWUZxPU17ZYZEE/HYD2TAbg450Lq8j5IFjjdfx1HyZcIvAIwN3m/mj3g17mDakKs6jL K1mkW6ap kGW3xO+YoNCOO1yT/JJBetKec0YdmDZTdATr6pqnegHu60XzwvxOPRW3P41Tp8uPIp6Mc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Functionally, no change. This is a preparation for luf mechanism that tracks need of tlb flush for each page residing in buddy. Since the private field in struct page is used only to store page order in buddy, ranging from 0 to MAX_PAGE_ORDER, that can be covered with unsigned short. So splitted it into two smaller ones, order and luf_key, so that the both can be used in buddy at the same time. Signed-off-by: Byungchul Park --- include/linux/mm_types.h | 42 +++++++++++++++++++++++++++++++++------- mm/internal.h | 4 ++-- mm/page_alloc.c | 2 +- 3 files changed, 38 insertions(+), 10 deletions(-) diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h index 689b2a7461892..7b15efbe9f529 100644 --- a/include/linux/mm_types.h +++ b/include/linux/mm_types.h @@ -107,13 +107,27 @@ struct page { pgoff_t index; /* Our offset within mapping. */ unsigned long share; /* share count for fsdax */ }; - /** - * @private: Mapping-private opaque data. - * Usually used for buffer_heads if PagePrivate. - * Used for swp_entry_t if swapcache flag set. - * Indicates order in the buddy system if PageBuddy. - */ - unsigned long private; + union { + /** + * @private: Mapping-private opaque data. + * Usually used for buffer_heads if PagePrivate. + * Used for swp_entry_t if swapcache flag set. + * Indicates order in the buddy system if PageBuddy. + */ + unsigned long private; + struct { + /* + * Indicates order in the buddy system if PageBuddy. + */ + unsigned short order; + + /* + * For tracking need of tlb flush, + * by luf(lazy unmap flush). + */ + unsigned short luf_key; + }; + }; }; struct { /* page_pool used by netstack */ /** @@ -577,6 +591,20 @@ static inline void set_page_private(struct page *page, unsigned long private) page->private = private; } +#define page_buddy_order(page) ((page)->order) + +static inline void set_page_buddy_order(struct page *page, unsigned int order) +{ + page->order = (unsigned short)order; +} + +#define page_luf_key(page) ((page)->luf_key) + +static inline void set_page_luf_key(struct page *page, unsigned short luf_key) +{ + page->luf_key = luf_key; +} + static inline void *folio_get_private(struct folio *folio) { return folio->private; diff --git a/mm/internal.h b/mm/internal.h index b07550db2bfd1..c4d2018a7cf8e 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -543,7 +543,7 @@ struct alloc_context { static inline unsigned int buddy_order(struct page *page) { /* PageBuddy() must be checked by the caller */ - return page_private(page); + return page_buddy_order(page); } /* @@ -557,7 +557,7 @@ static inline unsigned int buddy_order(struct page *page) * times, potentially observing different values in the tests and the actual * use of the result. */ -#define buddy_order_unsafe(page) READ_ONCE(page_private(page)) +#define buddy_order_unsafe(page) READ_ONCE(page_buddy_order(page)) /* * This function checks whether a page is free && is the buddy diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 16dfcf7ade74a..86c9fa45d36fe 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -576,7 +576,7 @@ void prep_compound_page(struct page *page, unsigned int order) static inline void set_buddy_order(struct page *page, unsigned int order) { - set_page_private(page, order); + set_page_buddy_order(page, order); __SetPageBuddy(page); }