diff mbox series

mm: zswap: use ATOMIC_LONG_INIT to initialize zswap_stored_pages

Message ID 20250226124141.22218-1-sunk67188@gmail.com (mailing list archive)
State New
Headers show
Series mm: zswap: use ATOMIC_LONG_INIT to initialize zswap_stored_pages | expand

Commit Message

sun k Feb. 26, 2025, 12:41 p.m. UTC
This is currently the only atomic_long_t variable initialized by
ATOMIC_INIT macro found in the kernel by using
`grep -r atomic_long_t | grep ATOMIC_INIT`

This was introduced in 6e1fa55, in which we modified
the type of zswap_stored_pages to atomic_long_t,
but didn't change the initialization.

Fixes: 6e1fa55 ("mm: zswap: modify zswap_stored_pages to be atomic_long_t")
Signed-off-by: Sun YangKai <sunk67188@gmail.com>
---
 mm/zswap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Yosry Ahmed Feb. 26, 2025, 3:15 p.m. UTC | #1
On Wed, Feb 26, 2025 at 08:41:39PM +0800, Sun YangKai wrote:
> This is currently the only atomic_long_t variable initialized by
> ATOMIC_INIT macro found in the kernel by using
> `grep -r atomic_long_t | grep ATOMIC_INIT`
> 
> This was introduced in 6e1fa55, in which we modified

We use the first 12 characters in the SHA1 to minimize collisions (same
in 'Fixes' below), so both should be 6e1fa555ec77.

> the type of zswap_stored_pages to atomic_long_t,
> but didn't change the initialization.
> 
> Fixes: 6e1fa55 ("mm: zswap: modify zswap_stored_pages to be atomic_long_t")
> Signed-off-by: Sun YangKai <sunk67188@gmail.com>

Acked-by: Yosry Ahmed <yosry.ahmed@linux.dev>

> ---
>  mm/zswap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/zswap.c b/mm/zswap.c
> index ac9d299e7d0c..23365e76a3ce 100644
> --- a/mm/zswap.c
> +++ b/mm/zswap.c
> @@ -43,7 +43,7 @@
>  * statistics
>  **********************************/
>  /* The number of compressed pages currently stored in zswap */
> -atomic_long_t zswap_stored_pages = ATOMIC_INIT(0);
> +atomic_long_t zswap_stored_pages = ATOMIC_LONG_INIT(0);
>  
>  /*
>   * The statistics below are not protected from concurrent access for
> -- 
> 2.48.1
>
diff mbox series

Patch

diff --git a/mm/zswap.c b/mm/zswap.c
index ac9d299e7d0c..23365e76a3ce 100644
--- a/mm/zswap.c
+++ b/mm/zswap.c
@@ -43,7 +43,7 @@ 
 * statistics
 **********************************/
 /* The number of compressed pages currently stored in zswap */
-atomic_long_t zswap_stored_pages = ATOMIC_INIT(0);
+atomic_long_t zswap_stored_pages = ATOMIC_LONG_INIT(0);
 
 /*
  * The statistics below are not protected from concurrent access for