From patchwork Wed Feb 26 13:22:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Hildenbrand X-Patchwork-Id: 13992388 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14707C021B8 for ; Wed, 26 Feb 2025 13:23:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8013D280001; Wed, 26 Feb 2025 08:23:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7AD1128000A; Wed, 26 Feb 2025 08:23:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6269A280001; Wed, 26 Feb 2025 08:23:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 41D5C6B008C for ; Wed, 26 Feb 2025 08:23:08 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id DA6C1C14A6 for ; Wed, 26 Feb 2025 13:23:07 +0000 (UTC) X-FDA: 83162161614.23.7FBF8B2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 09ACE140013 for ; Wed, 26 Feb 2025 13:23:03 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ecphAGIu; spf=pass (imf09.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740576184; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B6orXFeJGAvu/Rrohb/dX/LYlUkQorCUoMUzPFZb2AU=; b=XzjNE8IpyyzeExKLdf4jube43cLawJ66xW8AWQXdiiFj6yjZDvPiS/W3MtF1pkMCE2eAiv To0Iqym2BiQv0EM57OQTjG46UBi0x9f7vK3Eq7lLZ/r45ytbR67cPw4MDtc/wFPFRh7Sh6 199rnJjSd2EiO4h14YlWnXh4H8Yze7A= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ecphAGIu; spf=pass (imf09.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740576184; a=rsa-sha256; cv=none; b=fjpGnDLXiDx/D0zMTi0QUl6rA5DEIoKescR5SdBMPl1I13sI261HoKpC1oo4LFTUKVVy+Y Lp21XpkKs+WrwHEdiqbn/wxpyWyysj1TF0avb7WTS9/ucn/Ko5pk2jXSI3X3JXZur63vbo xW1in774f9VPw2h8NH/em74Bw3wdjPo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740576183; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B6orXFeJGAvu/Rrohb/dX/LYlUkQorCUoMUzPFZb2AU=; b=ecphAGIuzOxvdIvvhWzMd3i3Z/CILZPhQcdIRJj+nbjIlJ45OAmTH2SQn9JKYhyxwaqQhT 9lEXWSFyg5uBXuh//1sVHSfPwP2JOUI/bTjUfjidSkBb6+GQaOP/bhpSLtTtQT00ZQcnZ2 y39zck6kSPp4dNP6VMqIYpzOBnPunYU= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-653-df8ijXLZO4iSp_1Z3WFuLA-1; Wed, 26 Feb 2025 08:23:02 -0500 X-MC-Unique: df8ijXLZO4iSp_1Z3WFuLA-1 X-Mimecast-MFC-AGG-ID: df8ijXLZO4iSp_1Z3WFuLA_1740576181 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43945f32e2dso62329885e9.2 for ; Wed, 26 Feb 2025 05:23:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740576181; x=1741180981; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B6orXFeJGAvu/Rrohb/dX/LYlUkQorCUoMUzPFZb2AU=; b=RKSYKxKLAsHFTuscIXbaggdMKDYF4NZ2M5GSRRoQnT/2MkZJ/HkyY0Ruc8AZIBJTV2 KA3ZxiwFwSlKdTM9195oGsCeiZgMKyW7qNNZsfh/5IXoGNbySfFLtgueInST9j4xsq2J 7L7FFqn9cwHNh05f+eJqN5WZ3xz90C4O7Lql66nYm0e3pIl+sO5jrrLmBfd0QraTa9z6 HRiFzD5EP9ZsOOK5bc2lNWyAgC4zP/YJC10L54HfoA3lF5nz7ZSR3XxzgoYmNIhccBz0 IktnK7b+Uy1OYFAjtZ3jdvTCGjDL4ZIVsGFdR8fl6tfgLKVJNCnmIYcFIvUJwzLYWiy1 9JMA== X-Gm-Message-State: AOJu0YwteXX8ARiciYErCKXZRM14HMgZ9LPEG7gY22Hh5daEE3z8miqx lQDkzD/Ly6WYpEwyMXw93p7unnAbXCimpmTAjaJHmgR4FQiV6jGEteGk06r4CYkKbGGCsfVQW7s qltGkXV+OaYTGn9fPVGZLtOIetaAwiXpHz1lYiqDvSDQ79Wxb X-Gm-Gg: ASbGnctNL+bMWtIO/TAHckSU2NcUmZs9+UtonotwB/JyviQ+muKaem9MQzoG+NBfUQN ip12sHEp+HcmkxlgIIA6MUrEzq1c+vNfwd/KHL5kJDU84l/HNJ8vwHGWEWjiDyWj9deJhKRQgSy pnE9S6xLj8a5VkJT0uDwZjMcYxE8TnjCbP2fuUFlqEpw9gS93ZEBjt5DsV+0XOwULl3xZSO0M4h STbYJin+FwFmbZr7nDy9J591mC1OEaSAnmRAAPRer5fyhMPDSRRNKUh+/lcC3yqsthrK6reMQvE Z91Lr4XboIRS/ZOBnElvHf6hIFijdJ/zFLAG9SLblQXLsDXaRJr/T0h/vjTryxsvndUnun9uBm5 R X-Received: by 2002:a05:600c:468b:b0:439:9eba:93bb with SMTP id 5b1f17b1804b1-43ab0f42a24mr78452175e9.18.1740576181048; Wed, 26 Feb 2025 05:23:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IFTKTUVpjblmKPNOofPuJhCfQ+I0IhzFCw2t/VamjME4II9+wlbxcBhKnNzq4bwr4GFZqWn4g== X-Received: by 2002:a05:600c:468b:b0:439:9eba:93bb with SMTP id 5b1f17b1804b1-43ab0f42a24mr78451845e9.18.1740576180695; Wed, 26 Feb 2025 05:23:00 -0800 (PST) Received: from localhost (p200300cbc747ff009d854afba7df6c45.dip0.t-ipconnect.de. [2003:cb:c747:ff00:9d85:4afb:a7df:6c45]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-43aba543fdfsm21554525e9.31.2025.02.26.05.22.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Feb 2025 05:23:00 -0800 (PST) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, David Hildenbrand , Andrew Morton , =?utf-8?b?SsOpcsO0bWUgR2xpc3Nl?= , Simona Vetter , Alistair Popple , Jason Gunthorpe Subject: [PATCH v2 1/5] lib/test_hmm: make dmirror_atomic_map() consume a single page Date: Wed, 26 Feb 2025 14:22:53 +0100 Message-ID: <20250226132257.2826043-2-david@redhat.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250226132257.2826043-1-david@redhat.com> References: <20250226132257.2826043-1-david@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: IM-6u4drnFBlW0jnXMkGG9xBW9bxnkUnuTOM4QXh5Dc_1740576181 X-Mimecast-Originator: redhat.com content-type: text/plain; charset="US-ASCII"; x-default=true X-Rspamd-Queue-Id: 09ACE140013 X-Stat-Signature: jybag9exz7n5sykrsccsgqh3trj64e7p X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1740576183-187184 X-HE-Meta: U2FsdGVkX1/NtQqKuYuRrIfzPhXhwWzy/+Fh6yNyPjt/LclpUvFuZPiAlxICvmh/cvWmL5/GPZy4aBxUjpnYF3GMT7OCXbPjBU6TkJ27N7bqfEZTCKY6jdmAWh1NyIlLtsduvLoZtDvkfjrKJXMRThHJ2ocEJPH8QDiKaZT4mQ+S42r+R1zTwAyNkXEPYmrjLcuXzNNbkzcPn0ShaM8MN1nsXMXnZhcFjSzU6uFSKN9P4k+Dcf9TCYgJLLBgSgYWhRC7lmmMfUscWIBWb5eR2rV1iU7ap74xGGty5bGVzYdDI1XmW1xkwFBER4x3H7O7VMjnL4fEyQzzQMHNML67GJ2NGSkPR+PhnafrNwiq07kOmx3+1XrTaWhCtG3KGazUS4WUquKQU2Awy3INbPWlN4csOMEOguVqA16XGY07vUj533PVwTp5h+h55fsbrlkD58P6DZDquXh8uD7UmqDMEYfUNp32yVoGHbdslRcq1dcgY5QgkH+2Vidrt7J/+V6gxZtmcXO8cDafscm5SHv6SJRLTHecaHs9YT5XYg+XSI9qq3wemYWnZPkB3G1vldguv/5+CdNyKY7UOURX/YfEdm8j+f5MbHpvPB1fwFUHTaxydsU8NRQRrMuWcnQ5iabFNagS8VQzx484fELw/8Fr83Lzm2rvgj4yBOypDtYFm9PWV/oQ/0/wht5gfrUukrWYIS4LFFPcH5PdQ9ZL1duXwcRzrlhU9C7O11gbOjBlDOU72bdL374zJrXnMrPyPEoeO9aqO/KND7Ikj4jJqF/l1UhNdtn12r8oD0wjXK8MTAqIraTwK0/B+0rTzFYDK7HeIxuYhDMqhxX4W6WGV73OECQAp0TvbcGWfWfaJAsg799eTJt7EM+sGRuV8oZaIniYV8YBvSAP91s9RTo1caVya59916GAFam3na+Ba50+qX7JNphb9pGiSji6nV7wL07rIeHYNFi5sGpo1jQqTke nG5dlYlY p8jKzDu9Y1bIKKU73t6eO2Vj4DfOACsCIm80G3p1sHYK2YIFm7hvV4RhV3MrZ+4HvMdo9bqmn3fS4vRbIgqHVs97MwCAvCG53oH+ALGAqvt53zHxIHvLTdg5Xy+SbrEfKwBwFstV9a8igyutacqOxYqiWLfywVDTpUjGvtIpwoButCvXlPMCXbhzbShyAGpkdcpgtOWArmVmSjXFLl2OR7/8d/gGUAhooQQFUBBgA7brmTnqqACcO2wx1li/NBgCOzn18gJIWrp3jMuz4QVR1CktV/Kgx0GGmF1l6u3yeWaVCVwxAGvfjCDK6zTV7x0qqjAd2vOteup1eyJSBD1DbvRJlMvYgLLqhQ1MF0kt+DcAocbcGvn5kB7W4eL2lPencS8GMkc0OBpTiTNplOu3RPbCK6yZbz9AREJGEXhMFN6+hY3ZbuOHvupLU1xX2aTXZjlIJKc2RquEoNa5dV6VsfmBgqH0JaNeNpA7sfiuX47yjJ6DyzfUxBxglnCa6F3/DaL4CCKuv+g603NowwmdeWxJjHaswI/TvXPjK8Es8Hw8c4vw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The caller now always passes a single page; let's simplify, and return "0" on success. Reviewed-by: Alistair Popple Signed-off-by: David Hildenbrand --- lib/test_hmm.c | 32 ++++++++++---------------------- 1 file changed, 10 insertions(+), 22 deletions(-) diff --git a/lib/test_hmm.c b/lib/test_hmm.c index 155b18cd9f2af..5b144bc5c4ec7 100644 --- a/lib/test_hmm.c +++ b/lib/test_hmm.c @@ -707,34 +707,23 @@ static int dmirror_check_atomic(struct dmirror *dmirror, unsigned long start, return 0; } -static int dmirror_atomic_map(unsigned long start, unsigned long end, - struct page **pages, struct dmirror *dmirror) +static int dmirror_atomic_map(unsigned long addr, struct page *page, + struct dmirror *dmirror) { - unsigned long pfn, mapped = 0; - int i; + void *entry; /* Map the migrated pages into the device's page tables. */ mutex_lock(&dmirror->mutex); - for (i = 0, pfn = start >> PAGE_SHIFT; pfn < (end >> PAGE_SHIFT); pfn++, i++) { - void *entry; - - if (!pages[i]) - continue; - - entry = pages[i]; - entry = xa_tag_pointer(entry, DPT_XA_TAG_ATOMIC); - entry = xa_store(&dmirror->pt, pfn, entry, GFP_ATOMIC); - if (xa_is_err(entry)) { - mutex_unlock(&dmirror->mutex); - return xa_err(entry); - } - - mapped++; + entry = xa_tag_pointer(page, DPT_XA_TAG_ATOMIC); + entry = xa_store(&dmirror->pt, addr >> PAGE_SHIFT, entry, GFP_ATOMIC); + if (xa_is_err(entry)) { + mutex_unlock(&dmirror->mutex); + return xa_err(entry); } mutex_unlock(&dmirror->mutex); - return mapped; + return 0; } static int dmirror_migrate_finalize_and_map(struct migrate_vma *args, @@ -804,8 +793,7 @@ static int dmirror_exclusive(struct dmirror *dmirror, break; } - ret = dmirror_atomic_map(addr, addr + PAGE_SIZE, &page, dmirror); - ret = ret == 1 ? 0 : -EBUSY; + ret = dmirror_atomic_map(addr, page, dmirror); folio_unlock(folio); folio_put(folio); }