From patchwork Wed Feb 26 21:35:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joshua Hahn X-Patchwork-Id: 13993230 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A23CC19F2E for ; Wed, 26 Feb 2025 21:35:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 009196B0088; Wed, 26 Feb 2025 16:35:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ED4A56B008A; Wed, 26 Feb 2025 16:35:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D00766B008C; Wed, 26 Feb 2025 16:35:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A64336B0088 for ; Wed, 26 Feb 2025 16:35:24 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5C58E160C66 for ; Wed, 26 Feb 2025 21:35:24 +0000 (UTC) X-FDA: 83163402168.07.B980C85 Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) by imf14.hostedemail.com (Postfix) with ESMTP id 7DDE610000D for ; Wed, 26 Feb 2025 21:35:22 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dby6jnrC; spf=pass (imf14.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.128.175 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740605722; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XVYI9kcUdIjH4cxP98YN5mlg2UhaCwMf2rCWTMU2nGY=; b=HRHtR05yO3PK7a30RyjiSHojM8sCLEgniMHRZiLV5QPfI8a86a2Nquwe2VKLDKcAa3yhs2 vLXFg8ivUkpY6ZU6fZ7FXeqlcYgEuJIyIMYmUjYrOya1ZO3c8yNSFgKOQQitX/rQuSdhSf 5TuMNtmg9H2wHdyrFfldK04NESsaIzM= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dby6jnrC; spf=pass (imf14.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.128.175 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740605722; a=rsa-sha256; cv=none; b=sVmWs0cgR4pxOpKlX9aYGTEoV+XcXWqkhoeSNZ4Qm8GQuVc4RTZ7PHlxjoUBTUqPuGa5Ql MDp1FDEgqxHpuxHbVrKqivXlEi80iV6jamYTxegx5AVm1Jx8sbkwrZS7HgfBs8F/FBw3Zi HZx3UWfIbOgOVpvDRRLqP/XB4b/gB7c= Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-6f74b78df93so3054677b3.0 for ; Wed, 26 Feb 2025 13:35:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740605721; x=1741210521; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XVYI9kcUdIjH4cxP98YN5mlg2UhaCwMf2rCWTMU2nGY=; b=dby6jnrCzt4w5pqP7SKIduBNcwYmCFZLRV76VUevoT4915Bi2XQxo8yoFzVaYPWZcX Iw/WVqSmxDWe89/edHljzxSlSDH1mXkYByNyRdiD/ta6hOwYwILKnvyRX6KaIOA1Qy+J kmpbJDFnBTii5szBeCgXkA/NO/03JufxP6iFhqL72/0fTFCqkrohPLnryGP1j4A/CD/r aoZkO/zCZMZKW0lH5AINgUBwH7owsE+sTUAh9g6Gcab8yMlyCI0j244g0fIV8ay9UZZk Du+OrEnkIx1aNpc+K4HiDc6jXZ5NuwZha4O0P8wOHYrmnm1ExPuoAx5jBGKY3dEIf3lN kzPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740605721; x=1741210521; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XVYI9kcUdIjH4cxP98YN5mlg2UhaCwMf2rCWTMU2nGY=; b=mkHZLyiaEhWzZX6jUmvYsfhm4GpH7fM5b5fe3gncq534paG72mzWlIiNJfbEp/Im93 5oZSQqmZ22zactgBZ6z2SxOjYQ/bGGikmGjIWvDcWvE8KsKN52wk00KsZ8Xi13tIwBWE qxNEACx46D+E8SDtGW5UaNhPdWvVsCsm2XxlcsFCHllhMSy+ICRnw2E/SX4cAY5ODiY0 /X6wrb7oB+mmxuuXcLhz1XBwSahcVhIgQ77AcLzkdIg+Y8M7n2QLk9KHexfm6dVpVbje QIX+8A7zq4O6Cj5DsSj/4gRkMawSlvE+11stMnGg2XvYPRC7AyhF+8w7T/GiTHoDtxda lu2w== X-Forwarded-Encrypted: i=1; AJvYcCVlVD6Fa30/3T1bhDWx+ZEW1hXPqsZ/mAfgDwmTyr8WrWKICc13eMXO078vtJM2wBrL/Zqx0WsLTw==@kvack.org X-Gm-Message-State: AOJu0Yw8w8Q/LSPDBfJV8PfxpiAwBEDDAfrTN5JCtO9+PQ7JgGYdmg6R +goWBSkB1pPyKR328xUFxlnvVIyQpYMP/X0urTcCK6FlDrnNKCps X-Gm-Gg: ASbGnctlRQmi9SihSrjCHZIfQ/gHEiCa14Ve9z3LEs6xZpYINqS18SuhHIylku7uyBp /rTOEK8uUklZMet1YxWCoNL2MiHnnQQDAqUdrJ7nZNIUhZSbVmy2XfW3dvrzpsvTt7IDfxRVzRu V2E1PvGpSTJhyLVuAAa4D4Q20Cb3HDwOT21U2F4r0ZXb2i9PRh5aSF1ksrcQfdbMbTN4/QwRc80 XfmTWx3xvcRiLyNkRf4pTmiwpYMMLwpBzqYA2U2uzAxucR8eZusuCFBBvdpZEfgjM6cAdBZujkD qnLOcShuU3/49VvcuwiSbg34 X-Google-Smtp-Source: AGHT+IG1EvsPoz1Bd0r2fP5cpv7TzPk24gy2Kj+wLmrdUzEN3RWmK1nuptSk4y4e1hD44ksUTTWCBA== X-Received: by 2002:a05:690c:498b:b0:6f9:9891:7a7f with SMTP id 00721157ae682-6fd22084565mr44734717b3.25.1740605721598; Wed, 26 Feb 2025 13:35:21 -0800 (PST) Received: from localhost ([2a03:2880:25ff:6::]) by smtp.gmail.com with ESMTPSA id 00721157ae682-6fd1185bd13sm11805607b3.96.2025.02.26.13.35.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Feb 2025 13:35:20 -0800 (PST) From: Joshua Hahn To: gourry@gourry.net, harry.yoo@oracle.com, ying.huang@linux.alibaba.com Cc: honggyu.kim@sk.com, gregkh@linuxfoundation.org, rakie.kim@sk.com, akpm@linux-foundation.org, rafael@kernel.org, lenb@kernel.org, dan.j.williams@intel.com, Jonathan.Cameron@huawei.com, dave.jiang@intel.com, horen.chuang@linux.dev, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, kernel-team@meta.com Subject: [PATCH 2/2 v6] mm/mempolicy: Don't create weight sysfs for memoryless nodes Date: Wed, 26 Feb 2025 13:35:18 -0800 Message-ID: <20250226213518.767670-2-joshua.hahnjy@gmail.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20250226213518.767670-1-joshua.hahnjy@gmail.com> References: <20250226213518.767670-1-joshua.hahnjy@gmail.com> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 7DDE610000D X-Stat-Signature: 3fyy6r7ictqqa5wte1ra8zrmsuyzpui3 X-HE-Tag: 1740605722-638245 X-HE-Meta: U2FsdGVkX18wTqrXkZ/kfpulSNMVxAmnSVbeEDrtLy5MA69+u30PwLMrMp9fkO+MGojzIxg9c9pe3nAjpFvhnFORg9QQFD2VdqtrFdfSfw781/ZW6oxl+/nPuTDKzvtdfLYYWrAXDRK8q2ayUipebcrBWiyQxpwK3SLtJG5AHvVxeOc/8IbsIOl4a3RWbwwx2guewVxBNLDPK+dTkQ2GMv5iDg7PLMgEqelVnUL4RlPfyCml+qBwe/OetTSFjV9l6xI89NTsNGIF3ngLzSTBpczfGZZiVnXwdXMIc/DftDHJaV3+eMpC1OAPGu787XNqhZInA8aCnbit/ZzSxLDKCwHoEmOrjwc6UjIFpvWh/NLy+AFvI1sLhD6sDsGla5NVdN1YlQvrD7dYKug9n6rp58zFuOuTdIxAF6LHD7fHKMZ+WnYgIozxGPhdCCY55dPxTV1z94ovZ2rWE4TfYseICEK5nOpP+SAiAkA0lwcJ+ERwB5QPdf1PIpXF/LTgbXZfpHRz3s53OaE5Rn7FyH9P81iys9cUB/klEq3GH+dEGG4bM7MfecC8fBpXQ0tnJki4q8tN1EmbSeIjbPtVFgB74nlEnKF7YK+fbuSozn0oWtucMnYpViKeBX9W2oGZyxxdjr8+K1x4FFGENrKSMr7OfRNkUOCMgAB5U6TyHOWwa30Un3CDspaICTvE0xdOOypvgeayT6bkkEl2lSaVsxlz5SAbTJNdW9hMOTagWYCovb8jJuQuCZr2M5iWw4fYcNFdROHq225RLIBDq0BUxifEcF04GRH+foRxEvbZScwUz0GGbvnoU48ulISg4j3yTwWhmBMVTLhQUCTlfs50Q1ciYe8417nILXKpEoNj669A0ceVAcVtjXFX1s0uIomIg1LJL3myl2uQbKd2RQ5OO4HERpUQG12lGFeGfE48V3JkK3BJhKlfArNWu9vZrFGz72lsVzUp+hdKCljA/BmmxN1 m3yJ9j94 hTFoz0hEIJiP+HSWngFd/Y82BE0tVd5fafJwzc9Y8Gxub3OytDTSLGxcx7xJn0b1+Zbq7Vk0QwbO3P2vr0fcrVBCij2qA1Z5syTbSiuMmrdCLEdI8A3T6i8X3EqzGHsRagSvu87P2FdsBDTxeULPzhymItfnV0sNmWaZ8oIqt+PXrzbthfaXWGLFOoVWiwhIDevHIbDvSxlIEpLsc/RrZ76Ic0Y49NDBlYkFNWjpvfIE8qVy/r5ZNcK31Nw32REfgv2rH4mab+trdqmusbql7AV3823zDBoe6hx24qRrfS9xbiGyBnUIHIyVQH145NhseLoTxD0RoN5ckLmhXZSSnZpWxViqGLCZp6Tqmen9wpgVM12UlSoXMrvdSQGnYKLN1RnDnzUNcxsAZT7g/BcLCgyN1/gCOqGAz5EkTy0kvMCh/sjxJ88xgSyM3hjibA61uO2ckpq5latgQKwaLLuUYPw4rNg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000016, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: We should never try to allocate memory from a memoryless node. Creating a sysfs knob to control its weighted interleave weight does not make sense, and can be unsafe. Only create weighted interleave weight knobs for nodes with memory. Signed-off-by: Joshua Hahn --- mm/mempolicy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/mempolicy.c b/mm/mempolicy.c index 4cc04ff8f12c..50cbb7c047fa 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -3721,7 +3721,7 @@ static int add_weighted_interleave_group(struct kobject *root_kobj) return err; } - for_each_node_state(nid, N_POSSIBLE) { + for_each_node_state(nid, N_MEMORY) { err = add_weight_node(nid, wi_kobj); if (err) { pr_err("failed to add sysfs [node%d]\n", nid);